[GitHub] [flink] yuzelin commented on a diff in pull request #20719: [FLINK-29148][docs][sql-gateway][hive] Add SQL Gateway docs

2022-09-08 Thread GitBox
yuzelin commented on code in PR #20719: URL: https://github.com/apache/flink/pull/20719#discussion_r966597307 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -0,0 +1,226 @@ +--- +title: Overview +weight: 1 +type: docs +aliases: +- /dev/table/sql-gateway.html

[GitHub] [flink] yuzelin commented on a diff in pull request #20719: [FLINK-29148][docs][sql-gateway][hive] Add SQL Gateway docs

2022-09-08 Thread GitBox
yuzelin commented on code in PR #20719: URL: https://github.com/apache/flink/pull/20719#discussion_r966597933 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -0,0 +1,226 @@ +--- +title: Overview +weight: 1 +type: docs +aliases: +- /dev/table/sql-gateway.html

[jira] [Assigned] (FLINK-28833) [5] Support customized scheduler options as a hashmap for each scheduler.

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28833: - Assignee: bo zhao > [5] Support customized scheduler options as a hashmap for each scheduler.

[jira] [Assigned] (FLINK-29055) [3.4] Provide a way to exclude the build-in stepDecorator

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-29055: - Assignee: bo zhao > [3.4] Provide a way to exclude the build-in stepDecorator >

[jira] [Assigned] (FLINK-28831) [3] Support pluginable decorators mechanism

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28831: - Assignee: bo zhao > [3] Support pluginable decorators mechanism >

[jira] [Assigned] (FLINK-28829) [2] Need the ability of preparing K8S resource before JobManager creation

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28829: - Assignee: bo zhao > [2] Need the ability of preparing K8S resource before JobManager creation

[jira] [Assigned] (FLINK-28825) [1] Support specify K8S pod scheduler

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28825: - Assignee: bo zhao > [1] Support specify K8S pod scheduler >

[jira] [Assigned] (FLINK-29047) [3.1] Shade the Flink-Kubernetes Fabric8 Kubernetes dependency with org.apache.flink.shaded prefix

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-29047: - Assignee: bo zhao > [3.1] Shade the Flink-Kubernetes Fabric8 Kubernetes dependency with >

[jira] [Assigned] (FLINK-26559) Support Customized Kubernetes Schedulers for Flink Kubernetes

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-26559: - Assignee: bo zhao > Support Customized Kubernetes Schedulers for Flink Kubernetes >

[jira] [Assigned] (FLINK-28832) [4] Upgrade Fabric8 to the latest version

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28832: - Assignee: (was: bo zhao) > [4] Upgrade Fabric8 to the latest version >

[jira] [Closed] (FLINK-29047) [3.1] Shade the Flink-Kubernetes Fabric8 Kubernetes dependency with org.apache.flink.shaded prefix

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-29047. - Resolution: Fixed Fixed via: master(1.17): 17d7c39bb2a9fcbaac1ead42073c099a52171d7d > [3.1] Shade the

[jira] [Updated] (FLINK-29047) [3.1] Shade the Flink-Kubernetes Fabric8 Kubernetes dependency with org.apache.flink.shaded prefix

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-29047: -- Fix Version/s: 1.17.0 > [3.1] Shade the Flink-Kubernetes Fabric8 Kubernetes dependency with >

[jira] [Assigned] (FLINK-28832) [4] Upgrade Fabric8 to the latest version

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28832: - Assignee: bo zhao > [4] Upgrade Fabric8 to the latest version >

[jira] [Updated] (FLINK-26559) Support Customized Kubernetes Schedulers for Flink Kubernetes

2022-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-26559: -- Fix Version/s: 1.17.0 > Support Customized Kubernetes Schedulers for Flink Kubernetes >

[GitHub] [flink] wangyang0918 merged pull request #20642: [FLINK-29047][k8s] Shade fabric8 kubernetes with org.apache.flink.shaded prefix in flink-kubernetes

2022-09-08 Thread GitBox
wangyang0918 merged PR #20642: URL: https://github.com/apache/flink/pull/20642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-26980) PulsarUnorderedSourceReaderTest hang on azure

2022-09-08 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602103#comment-17602103 ] Yufan Sheng commented on FLINK-26980: - This bug would be fixed in 2.11.0 release. See the related

[jira] [Closed] (FLINK-27736) Pulsar sink catch watermark error

2022-09-08 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-27736. - Assignee: Yufan Sheng Resolution: Duplicate > Pulsar sink catch watermark error >

[GitHub] [flink] tisonkun merged pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

2022-09-08 Thread GitBox
tisonkun merged PR #20765: URL: https://github.com/apache/flink/pull/20765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] tisonkun commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

2022-09-08 Thread GitBox
tisonkun commented on PR #20765: URL: https://github.com/apache/flink/pull/20765#issuecomment-1241474048 Thanks for your contribution! Merging... @wenbingshen please ping me on the related backport PR. After all PRs merged, I'll close the JIRA ticket. -- This is an automated

[jira] (FLINK-27736) Pulsar sink catch watermark error

2022-09-08 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27736 ] Yufan Sheng deleted comment on FLINK-27736: - was (Author: syhily): Tks for your report. This is a known bug and gets fixed in FLINK-28083. The source shouldn't set the timestamp to zero. >

[jira] [Commented] (FLINK-27736) Pulsar sink catch watermark error

2022-09-08 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602101#comment-17602101 ] Yufan Sheng commented on FLINK-27736: - [~tison] Since this is a duplicated issue. Can you help me

[GitHub] [flink] wenbingshen commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

2022-09-08 Thread GitBox
wenbingshen commented on PR #20765: URL: https://github.com/apache/flink/pull/20765#issuecomment-1241471194 > @wenbingshen Can you backport this PR to `release-1.15` and `release-1.16` branch? Of course. I will submit other PRs later. Thanks. -- This is an automated message from

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #288: [FLINK-29226] Throw exception for streaming insert overwrite

2022-09-08 Thread GitBox
JingsongLi commented on code in PR #288: URL: https://github.com/apache/flink-table-store/pull/288#discussion_r966600291 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java: ## @@ -159,6 +163,10 @@ public void

[GitHub] [flink] syhily commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

2022-09-08 Thread GitBox
syhily commented on PR #20765: URL: https://github.com/apache/flink/pull/20765#issuecomment-1241469176 @wenbingshen Can you backport this PR to `release-1.15` and `release-1.16` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] yuzelin commented on a diff in pull request #20719: [FLINK-29148][docs][sql-gateway][hive] Add SQL Gateway docs

2022-09-08 Thread GitBox
yuzelin commented on code in PR #20719: URL: https://github.com/apache/flink/pull/20719#discussion_r966597933 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -0,0 +1,226 @@ +--- +title: Overview +weight: 1 +type: docs +aliases: +- /dev/table/sql-gateway.html

[GitHub] [flink] syhily commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

2022-09-08 Thread GitBox
syhily commented on PR #20765: URL: https://github.com/apache/flink/pull/20765#issuecomment-1241466493 @tisonkun Since this is a minor hotfix. Can you merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (FLINK-28506) Pulsar sink don't support zero timestamp which may be provided by flink

2022-09-08 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng closed FLINK-28506. --- Resolution: Duplicate > Pulsar sink don't support zero timestamp which may be provided by flink >

[GitHub] [flink] syhily commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

2022-09-08 Thread GitBox
syhily commented on PR #20765: URL: https://github.com/apache/flink/pull/20765#issuecomment-1241466240 Thanks, this PR LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] yuzelin commented on a diff in pull request #20719: [FLINK-29148][docs][sql-gateway][hive] Add SQL Gateway docs

2022-09-08 Thread GitBox
yuzelin commented on code in PR #20719: URL: https://github.com/apache/flink/pull/20719#discussion_r966597307 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -0,0 +1,226 @@ +--- +title: Overview +weight: 1 +type: docs +aliases: +- /dev/table/sql-gateway.html

[GitHub] [flink] masteryhx commented on a diff in pull request #20782: [FLINK-29195] Expose lastCheckpointId metric

2022-09-08 Thread GitBox
masteryhx commented on code in PR #20782: URL: https://github.com/apache/flink/pull/20782#discussion_r966587453 ## docs/content/docs/ops/metrics.md: ## @@ -1292,6 +1292,11 @@ Note that for failed checkpoints, metrics are updated on a best efforts basis an The

[jira] [Updated] (FLINK-29226) Throw exception for streaming insert overwrite

2022-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29226: --- Labels: pull-request-available (was: ) > Throw exception for streaming insert overwrite >

[GitHub] [flink-table-store] SteNicholas opened a new pull request, #288: [FLINK-29226] Throw exception for streaming insert overwrite

2022-09-08 Thread GitBox
SteNicholas opened a new pull request, #288: URL: https://github.com/apache/flink-table-store/pull/288 Currently, table store dose not support streaming insert overwrite, we should throw exception for this. **The brief change log** - `TableStoreSink#applyOverwrite` throws the

[jira] [Commented] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-08 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602087#comment-17602087 ] Qingsheng Ren commented on FLINK-29153: --- [~hxb] Yes I'm waiting for the CI on release-1.16. Will

[jira] [Commented] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-08 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602086#comment-17602086 ] Xingbo Huang commented on FLINK-29153: -- [~renqs] Should we need to cp this fix to release-1.16 >

[jira] [Updated] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-08 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29153: - Attachment: image-2022-09-09-11-15-42-735.png > KafkaConsumerThread should catch

[jira] [Updated] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-08 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29153: - Attachment: (was: image-2022-09-09-11-15-42-735.png) > KafkaConsumerThread should catch

[GitHub] [flink] godfreyhe commented on pull request #20705: [FLINK-29113][table-planner] throw exception when finding at least one invalid table name in join hints

2022-09-08 Thread GitBox
godfreyhe commented on PR #20705: URL: https://github.com/apache/flink/pull/20705#issuecomment-1241438437 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-28787) rename getUniqueKeys to getUpsertKeys in CommonPhysicalJoin

2022-09-08 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-28787. -- Resolution: Fixed Fixed in master: 347316ea6394b24c4471aa8616f2632e126f733d in 1.16:

[GitHub] [flink] godfreyhe closed pull request #20763: [FLINK-28787][table-planner] rename getUniqueKeys to getUpsertKeys in CommonPhysicalJoin

2022-09-08 Thread GitBox
godfreyhe closed pull request #20763: [FLINK-28787][table-planner] rename getUniqueKeys to getUpsertKeys in CommonPhysicalJoin URL: https://github.com/apache/flink/pull/20763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-29238) Wrong index information will be obtained after the downstream failover in hybrid full mode

2022-09-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29238: --- Description: Hybrid shuffle relies on the index to read the disk data. Since the spilled data may

[jira] [Created] (FLINK-29238) Wrong index information will be obtained after the downstream failover in hybrid full mode

2022-09-08 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-29238: -- Summary: Wrong index information will be obtained after the downstream failover in hybrid full mode Key: FLINK-29238 URL: https://issues.apache.org/jira/browse/FLINK-29238

[GitHub] [flink] godfreyhe closed pull request #20743: [hotfix][tests][table-planner] Add two more cases to verify the conflict of multiple LOOKUP hints

2022-09-08 Thread GitBox
godfreyhe closed pull request #20743: [hotfix][tests][table-planner] Add two more cases to verify the conflict of multiple LOOKUP hints URL: https://github.com/apache/flink/pull/20743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #20794: [BP-1.16][FLINK-29153][connector/kafka] Retry KafkaConsumer#commitAsync on WakeupException in KafkaConsumerThread

2022-09-08 Thread GitBox
flinkbot commented on PR #20794: URL: https://github.com/apache/flink/pull/20794#issuecomment-1241429203 ## CI report: * 7ba7f3ee1dd988aeef17dd71d679b8eb9d768227 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen opened a new pull request, #20794: [BP-1.16][FLINK-29153][connector/kafka] Retry KafkaConsumer#commitAsync on WakeupException in KafkaConsumerThread

2022-09-08 Thread GitBox
PatrickRen opened a new pull request, #20794: URL: https://github.com/apache/flink/pull/20794 Unchanged backport of #20764 on release-1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-09-08 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602076#comment-17602076 ] Qingsheng Ren commented on FLINK-29153: --- Fixed on master: 3e883e687d2bdb80ad2f160b08184fca11f4f554

[GitHub] [flink] PatrickRen merged pull request #20764: [FLINK-29153][connector/kafka] Retry KafkaConsumer#commitAsync on WakeupException in KafkaConsumerThread

2022-09-08 Thread GitBox
PatrickRen merged PR #20764: URL: https://github.com/apache/flink/pull/20764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.

2022-09-08 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau closed FLINK-29227. Resolution: Won't Fix > shoud package disruptor(com.lmax) to flink lib for aync logger when >

[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.

2022-09-08 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602064#comment-17602064 ] jackylau commented on FLINK-29227: -- i close this issue [~jark] [~chesnay]  > shoud package

[jira] [Commented] (FLINK-29227) shoud package disruptor(com.lmax) to flink lib for aync logger when xxconnector using it.

2022-09-08 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602061#comment-17602061 ] jackylau commented on FLINK-29227: -- [~jark]  thanks for your careful explanation > shoud package

[GitHub] [flink] bzhaoopenstack commented on pull request #20642: [FLINK-29047][k8s] Shade fabric8 kubernetes with org.apache.flink.shaded prefix in flink-kubernetes

2022-09-08 Thread GitBox
bzhaoopenstack commented on PR #20642: URL: https://github.com/apache/flink/pull/20642#issuecomment-1241408388 @wangyang0918 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-29226) Throw exception for streaming insert overwrite

2022-09-08 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-29226: Assignee: Nicholas Jiang > Throw exception for streaming insert overwrite >

[jira] [Commented] (FLINK-29226) Throw exception for streaming insert overwrite

2022-09-08 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602059#comment-17602059 ] Nicholas Jiang commented on FLINK-29226: [~lzljs3620320], could you please assign this ticket to

[GitHub] [flink] flinkbot commented on pull request #20793: [BK-1.15][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-08 Thread GitBox
flinkbot commented on PR #20793: URL: https://github.com/apache/flink/pull/20793#issuecomment-1241381224 ## CI report: * 192e1cb919e07a75b2ec3f90237f2c52b142a9be UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #20792: [BK-1.16][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-08 Thread GitBox
flinkbot commented on PR #20792: URL: https://github.com/apache/flink/pull/20792#issuecomment-1241378212 ## CI report: * e228ea02f9c01740c1268f2b7f0357b777a7401b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] syhily opened a new pull request, #20793: [BK-1.15][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-08 Thread GitBox
syhily opened a new pull request, #20793: URL: https://github.com/apache/flink/pull/20793 This is a backport PR for https://github.com/apache/flink/pull/20725. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] syhily opened a new pull request, #20792: [BK-1.16][FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-08 Thread GitBox
syhily opened a new pull request, #20792: URL: https://github.com/apache/flink/pull/20792 This is a backport PR for https://github.com/apache/flink/pull/20725. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-29203) SetOperatorsITCase#testUnionAllWithCommonType is failing after Calcite update to 1.27

2022-09-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602032#comment-17602032 ] Sergey Nuyanzin commented on FLINK-29203: - Probably was solve by

[jira] [Created] (FLINK-29237) CalcITCase.testOrWithIsNullPredicate fails after update to calcite 1.27

2022-09-08 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-29237: --- Summary: CalcITCase.testOrWithIsNullPredicate fails after update to calcite 1.27 Key: FLINK-29237 URL: https://issues.apache.org/jira/browse/FLINK-29237

[jira] [Updated] (FLINK-29236) TableFactory wildcard options are not supported

2022-09-08 Thread Krishnaiah Narukulla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishnaiah Narukulla updated FLINK-29236: - Description: SQL API: {code:java} CREATE TEMPORARY TABLE `playevents`

[jira] [Created] (FLINK-29236) TableFactory wildcard options are not supported

2022-09-08 Thread Krishnaiah Narukulla (Jira)
Krishnaiah Narukulla created FLINK-29236: Summary: TableFactory wildcard options are not supported Key: FLINK-29236 URL: https://issues.apache.org/jira/browse/FLINK-29236 Project: Flink

[GitHub] [flink] snuyanzin commented on pull request #20663: [FLINK-29067][Table SQL/API] Replace deprecated SqlParser#configBuilder with SqlParser#config

2022-09-08 Thread GitBox
snuyanzin commented on PR #20663: URL: https://github.com/apache/flink/pull/20663#issuecomment-1241305429 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-08 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r966428003 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkElementConverter.java: ## @@ -0,0 +1,73

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-08 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r965983155 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkElementConverter.java: ## @@ -0,0 +1,73

[GitHub] [flink] pnowojski commented on pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
pnowojski commented on PR #20485: URL: https://github.com/apache/flink/pull/20485#issuecomment-1241135990 > @mxm Thanks a lot also from my side for you contributions. However, @pnowojski this PR was not orphaned! (I wrote to you that I'm on vacations.) Yes, sorry for the mental

[GitHub] [flink] mxm commented on pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
mxm commented on PR #20485: URL: https://github.com/apache/flink/pull/20485#issuecomment-1241039980 Thank you @pnowojski for your thoughtful comments and guidance. And of course thanks to the original authors @AHeise @dawidwys @smattheis. Whoops @smattheis I had assumed you wouldn't

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r966251899 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderBase.java: ## @@ -179,6 +180,21 @@

[GitHub] [flink-web] zentol merged pull request #570: [FLINK-29230] Add Akka licensing change blogpost

2022-09-08 Thread GitBox
zentol merged PR #570: URL: https://github.com/apache/flink-web/pull/570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-09-08 Thread Sergio Sainz (Jira)
Sergio Sainz created FLINK-29235: Summary: CVE-2022-25857 on flink-shaded Key: FLINK-29235 URL: https://issues.apache.org/jira/browse/FLINK-29235 Project: Flink Issue Type: Bug

[GitHub] [flink] gaborgsomogyi commented on pull request #18118: [FLINK-24907] Support side out late data for interval join

2022-09-08 Thread GitBox
gaborgsomogyi commented on PR #18118: URL: https://github.com/apache/flink/pull/18118#issuecomment-1240943704 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] smattheis commented on pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
smattheis commented on PR #20485: URL: https://github.com/apache/flink/pull/20485#issuecomment-1240941359 @mxm Thanks a lot also from my side for you contributions. However, @pnowojski this PR was not orphaned! (I wrote to you that I'm on vacations.) -- This is an automated message from

[GitHub] [flink] stevenzwu commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-08 Thread GitBox
stevenzwu commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r966164935 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] zentol commented on pull request #20187: [FLINK-27473] Introduce Generic Metrics For Job States

2022-09-08 Thread GitBox
zentol commented on PR #20187: URL: https://github.com/apache/flink/pull/20187#issuecomment-1240930119 I made a pass over the PR and prepared a significant set of changes here: https://github.com/atris/flink/pull/1 I know that this isn't the ideal approach; but otherwise we would've

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-08 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r966129384 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkElementConverter.java: ## @@ -0,0 +1,73 @@

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-08 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r966129384 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkElementConverter.java: ## @@ -0,0 +1,73 @@

[jira] [Updated] (FLINK-29234) Dead lock in DefaultLeaderElectionService

2022-09-08 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-29234: Description: Jobmanager stop working because the deadlock in DefaultLeaderElectionService. The log

[jira] [Updated] (FLINK-29234) Dead lock in DefaultLeaderElectionService

2022-09-08 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-29234: Description: Jobmanager stop working because the deadlock in DefaultLeaderElectionService. Which may

[jira] [Updated] (FLINK-29234) Dead lock in DefaultLeaderElectionService

2022-09-08 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated FLINK-29234: Priority: Critical (was: Major) > Dead lock in DefaultLeaderElectionService >

[jira] [Created] (FLINK-29234) Dead lock in DefaultLeaderElectionService

2022-09-08 Thread Yu Wang (Jira)
Yu Wang created FLINK-29234: --- Summary: Dead lock in DefaultLeaderElectionService Key: FLINK-29234 URL: https://issues.apache.org/jira/browse/FLINK-29234 Project: Flink Issue Type: Bug

[GitHub] [flink] mxm commented on pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
mxm commented on PR #20485: URL: https://github.com/apache/flink/pull/20485#issuecomment-1240828114 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] syhily commented on a diff in pull request #20725: [FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-08 Thread GitBox
syhily commented on code in PR #20725: URL: https://github.com/apache/flink/pull/20725#discussion_r966051977 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarUnorderedPartitionSplitReader.java: ## @@ -147,7

[GitHub] [flink] tisonkun commented on a diff in pull request #20725: [FLINK-28934][Connector/pulsar] Fix split assignment for different Pulsar subscriptions

2022-09-08 Thread GitBox
tisonkun commented on code in PR #20725: URL: https://github.com/apache/flink/pull/20725#discussion_r965996490 ## flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/UnorderedCollectIteratorAssert.java: ## @@ -0,0 +1,140

[GitHub] [flink] flinkbot commented on pull request #20791: [FLINK-28569][table-planner] Fix SinkUpsertMaterializer that should be aware of the input upsertKey if it is not empty to prevent wrong resu

2022-09-08 Thread GitBox
flinkbot commented on PR #20791: URL: https://github.com/apache/flink/pull/20791#issuecomment-1240760497 ## CI report: * add298232cfe66ffc5129b153fbc4c929ebd40b3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Fix Version/s: 1.16.0 > SinkUpsertMaterializer should be aware of the input upsertKey if it is

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Affects Version/s: 1.15.2 1.14.5 > SinkUpsertMaterializer should be aware

[GitHub] [flink-connector-dynamodb] dannycranmer commented on pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-08 Thread GitBox
dannycranmer commented on PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#issuecomment-1240753383 Apologies for the delay, I have left some comments. As commented in the main pom I will open a PR to contribute the general repo files so we can decouple from this

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28569: --- Labels: pull-request-available (was: ) > SinkUpsertMaterializer should be aware of the

[GitHub] [flink] lincoln-lil opened a new pull request, #20791: [FLINK-28569][table-planner] Fix SinkUpsertMaterializer that should be aware of the input upsertKey if it is not empty to prevent wrong

2022-09-08 Thread GitBox
lincoln-lil opened a new pull request, #20791: URL: https://github.com/apache/flink/pull/20791 ## What is the purpose of the change Currently SinkUpsertMaterializer only update row by comparing the complete row in anycase, but this may cause wrong result if input has upsertKey and also

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-09-08 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r965965165 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/util/DynamoDbAttributeValueUtils.java: ## @@ -0,0 +1,127

[jira] [Comment Edited] (FLINK-29090) Fix the code gen for ColumnarMapData and ColumnarArrayData

2022-09-08 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601826#comment-17601826 ] dalongliu edited comment on FLINK-29090 at 9/8/22 1:48 PM: --- I didn't reproduce

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Description: Currently SinkUpsertMaterializer only update row by comparing the complete row in

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Description: Currently SinkUpsertMaterializer only update row by comparing the complete row in

[GitHub] [flink] mxm commented on pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
mxm commented on PR #20485: URL: https://github.com/apache/flink/pull/20485#issuecomment-1240740217 > I wouldn't squash all commits into one. The original commits authored by Sebastian, Dawid and Arvid I think are nicely separated. But sure, squashing your fixups to those commits and

[jira] [Commented] (FLINK-29090) Fix the code gen for ColumnarMapData and ColumnarArrayData

2022-09-08 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601826#comment-17601826 ] dalongliu commented on FLINK-29090: --- I didn't reproduce the exception through the following sql case:

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Description: Currently  {code} @Test public void

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Description: Currently  {code:java} @Test public void

[jira] [Updated] (FLINK-28569) SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty otherwise wrong result maybe produced

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Summary: SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty

[jira] [Updated] (FLINK-28569) Optimization: SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Parent: (was: FLINK-27849) Issue Type: Bug (was: Sub-task) > Optimization:

[jira] [Updated] (FLINK-28569) Optimization: SinkUpsertMaterializer should be aware of the input upsertKey if it is not empty

2022-09-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28569: Priority: Major (was: Minor) > Optimization: SinkUpsertMaterializer should be aware of the input

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-08 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r965983501 ## flink-core/src/main/java/org/apache/flink/api/common/eventtime/CombinedWatermarkStatus.java: ## @@ -95,10 +97,12 @@ public boolean updateCombinedWatermark() {

[GitHub] [flink] XComp commented on a diff in pull request #19916: [FLINK-27936][tests] Migrate flink-connector-cassandra to JUnit5

2022-09-08 Thread GitBox
XComp commented on code in PR #19916: URL: https://github.com/apache/flink/pull/19916#discussion_r965971077 ## flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java: ## @@ -46,15 +47,15 @@ import

  1   2   3   >