[GitHub] [flink] fredia commented on pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry

2022-10-24 Thread GitBox
fredia commented on PR #21053: URL: https://github.com/apache/flink/pull/21053#issuecomment-1288523183 Hi @klion26, could you please take a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] fredia commented on a diff in pull request #21050: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-24 Thread GitBox
fredia commented on code in PR #21050: URL: https://github.com/apache/flink/pull/21050#discussion_r1002943684 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -95,60 +95,78 @@ public StreamStateHandle registerReference(

[jira] [Comment Edited] (FLINK-29677) Prevent dropping the current catalog

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622637#comment-17622637 ] Shengkai Fang edited comment on FLINK-29677 at 10/24/22 7:00 AM: - Merged

[jira] [Closed] (FLINK-29677) Prevent dropping the current catalog

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-29677. - Resolution: Fixed > Prevent dropping the current catalog >

[jira] [Updated] (FLINK-29677) Prevent dropping the current catalog

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-29677: -- Affects Version/s: 1.17.0 (was: 1.15.2)

[GitHub] [flink] fsk119 merged pull request #21134: [FLINK-29677] Prevent dropping the current catalog

2022-10-24 Thread GitBox
fsk119 merged PR #21134: URL: https://github.com/apache/flink/pull/21134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21136: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-24 Thread GitBox
flinkbot commented on PR #21136: URL: https://github.com/apache/flink/pull/21136#issuecomment-1288505413 ## CI report: * 0cc2200f45faddcddeaf90eaa4aceb31b9bcab2f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
gyfora commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1002929772 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + *

[GitHub] [flink] fredia opened a new pull request, #21136: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-24 Thread GitBox
fredia opened a new pull request, #21136: URL: https://github.com/apache/flink/pull/21136 ## What is the purpose of the change Improve logging in SharedStateRegistry and make the conditional logic more clear. This PR is copied from

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29733: - Labels: pull-request-available test-stability (was: pull-request-available) > Error Flink

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29733: - Component/s: Connectors / Hive > Error Flink connector hive Test failing >

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29733: - Affects Version/s: 1.17.0 > Error Flink connector hive Test failing >

[GitHub] [flink-kubernetes-operator] rgsriram commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

2022-10-24 Thread GitBox
rgsriram commented on code in PR #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002928530 ## examples/flink-python-example/Dockerfile: ## @@ -36,7 +36,7 @@ apt-get clean && \ rm -rf /var/lib/apt/lists/* # install PyFlink -RUN pip3

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
gyfora commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1002927900 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/AbstractFlinkSpec.java: ## @@ -57,6 +57,9 @@ public abstract

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1288495452 @luoyuxia packer is made by this.packer = Packer.LITTLE_ENDIAN.newBytePacker(bitWidth); so it impossible to run the abstract parent class BytePacker'method

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

2022-10-24 Thread GitBox
gyfora commented on code in PR #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002926848 ## examples/flink-python-example/Dockerfile: ## @@ -36,7 +36,7 @@ apt-get clean && \ rm -rf /var/lib/apt/lists/* # install PyFlink -RUN pip3

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #407: [FLINK-29713] Kubernetes operator should restart failed jobs

2022-10-24 Thread GitBox
gyfora commented on code in PR #407: URL: https://github.com/apache/flink-kubernetes-operator/pull/407#discussion_r1002922589 ## docs/content/docs/custom-resource/job-management.md: ## @@ -241,6 +241,21 @@ In order this feature to work one must enable [recovery of missing job

[GitHub] [flink] flinkbot commented on pull request #21135: [FLINK-29733][hotfix/test] fix error caused due to FLINK-29478

2022-10-24 Thread GitBox
flinkbot commented on PR #21135: URL: https://github.com/apache/flink/pull/21135#issuecomment-1288493675 ## CI report: * 4230e8f92af3ef533028295688fe1a0fd68e9591 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fredia commented on a diff in pull request #21050: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-24 Thread GitBox
fredia commented on code in PR #21050: URL: https://github.com/apache/flink/pull/21050#discussion_r997761529 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -95,60 +95,78 @@ public StreamStateHandle registerReference(

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29733: --- Labels: pull-request-available (was: ) > Error Flink connector hive Test failing >

[GitHub] [flink] Samrat002 opened a new pull request, #21135: [FLINK-29733][hotfix/test] fix error caused due to FLINK-29478

2022-10-24 Thread GitBox
Samrat002 opened a new pull request, #21135: URL: https://github.com/apache/flink/pull/21135 ## What is the purpose of the change This is a quick fix missed due to FLINK-29478. *(For example: This pull request makes task deployment go through the blob server, rather than

[jira] [Created] (FLINK-29734) Support authentication in the Flink SQL Gateway

2022-10-24 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-29734: - Summary: Support authentication in the Flink SQL Gateway Key: FLINK-29734 URL: https://issues.apache.org/jira/browse/FLINK-29734 Project: Flink Issue

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-24 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-29733: --- Summary: Error Flink connector hive Test failing (was: Error Flink connector hive ) > Error Flink

[jira] [Created] (FLINK-29733) Error Flink connector hive

2022-10-24 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-29733: -- Summary: Error Flink connector hive Key: FLINK-29733 URL: https://issues.apache.org/jira/browse/FLINK-29733 Project: Flink Issue Type: Bug

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1288481471 ![image](https://user-images.githubusercontent.com/12368495/197461285-91ad97a8-7c56-4037-ae31-39383dac4fe9.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1288480519 ![image](https://user-images.githubusercontent.com/12368495/197461152-ede7d0cb-cd71-4f41-82f6-37947f350ddd.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] jiangjiguang commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
jiangjiguang commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1002916628 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[jira] [Commented] (FLINK-29478) Flink sql Connector hive to support 3.1.3

2022-10-24 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622976#comment-17622976 ] Samrat Deb commented on FLINK-29478: Looking into it [~hxb] !  > Flink sql Connector hive to

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622973#comment-17622973 ] Xingbo Huang commented on FLINK-29405: --

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622971#comment-17622971 ] Xingbo Huang commented on FLINK-24119: --

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622969#comment-17622969 ] Xingbo Huang commented on FLINK-29405: --

[jira] [Commented] (FLINK-29478) Flink sql Connector hive to support 3.1.3

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622967#comment-17622967 ] Xingbo Huang commented on FLINK-29478: --

[jira] [Commented] (FLINK-29387) IntervalJoinITCase.testIntervalJoinSideOutputRightLateData failed with AssertionError

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622965#comment-17622965 ] Xingbo Huang commented on FLINK-29387: --

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622964#comment-17622964 ] Xingbo Huang commented on FLINK-24119: --

<    1   2   3