[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #424: [FLINK-29655] Move FlinkResourceListener to api

2022-11-02 Thread GitBox
mbalassi merged PR #424: URL: https://github.com/apache/flink-kubernetes-operator/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-29858) Jdbc reading supports setting multiple queryTemplates

2022-11-02 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] waywtdcc updated FLINK-29858: - Attachment: image-2022-11-03-13-53-12-593.png > Jdbc reading supports setting multiple queryTemplates >

[jira] [Updated] (FLINK-29858) Jdbc reading supports setting multiple queryTemplates

2022-11-02 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] waywtdcc updated FLINK-29858: - Description: Jdbc reading supports setting multiple queryTemplates. Currently, jdbc reading only

[jira] [Commented] (FLINK-29095) Improve logging in SharedStateRegistry

2022-11-02 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628126#comment-17628126 ] Yanfei Lei commented on FLINK-29095: I'd like to continue this work, could you please assign it to

[jira] [Created] (FLINK-29858) Jdbc reading supports setting multiple queryTemplates

2022-11-02 Thread waywtdcc (Jira)
waywtdcc created FLINK-29858: Summary: Jdbc reading supports setting multiple queryTemplates Key: FLINK-29858 URL: https://issues.apache.org/jira/browse/FLINK-29858 Project: Flink Issue Type:

[GitHub] [flink] gaoyunhaii commented on pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-11-02 Thread GitBox
gaoyunhaii commented on PR #21077: URL: https://github.com/apache/flink/pull/21077#issuecomment-1301675992 > I assume you're talking about AsyncRetryStrategies and the reference to AsyncRetryPredicate is just a typo? I still don't think I fully understand what you're suggesting. This is

[GitHub] [flink] reswqa commented on pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-11-02 Thread GitBox
reswqa commented on PR #21137: URL: https://github.com/apache/flink/pull/21137#issuecomment-1301664533 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-19651) Support the filter push down for the Jdbc connector

2022-11-02 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-19651. -- Resolution: Duplicate [~Tomm] Thanks for your PR, it's a good work. However, this is duplicated

[GitHub] [flink] libenchao closed pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector

2022-11-02 Thread GitBox
libenchao closed pull request #20126: [FLINK-19651][Connectors/JDBC] Support the filter push down for the JDBC connector URL: https://github.com/apache/flink/pull/20126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-table-store] tsreaper opened a new pull request, #350: [FLINK-29805] Fix incorrect snapshot filter when snapshots are committing too slow

2022-11-02 Thread GitBox
tsreaper opened a new pull request, #350: URL: https://github.com/apache/flink-table-store/pull/350 Table Store sink continuously fails with "Trying to add file which is already added" when snapshot committing is slow. This is due to a bug in `FileStoreCommitImpl#filterCommitted`.

[GitHub] [flink] xintongsong commented on pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-11-02 Thread GitBox
xintongsong commented on PR #21137: URL: https://github.com/apache/flink/pull/21137#issuecomment-1301630684 Thanks @reswqa for the fix, and thanks all for the discussion. For this specific case, I think it indeed can be fixed either way, introducing a thread or making sure

[jira] [Commented] (FLINK-27995) Upgrade Janino version

2022-11-02 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628101#comment-17628101 ] lincoln lee commented on FLINK-27995: - [~fsk119] I'm investigating the problem in the thread[1], but

[jira] [Assigned] (FLINK-29818) HsResultPartitionTest.testAvailability fails

2022-11-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-29818: -- Assignee: Weijie Guo > HsResultPartitionTest.testAvailability fails >

[GitHub] [flink] flinkbot commented on pull request #21226: [Flink 29492] Return Kafka producer to the pool when the Kafka sink is not the end of the chain

2022-11-02 Thread GitBox
flinkbot commented on PR #21226: URL: https://github.com/apache/flink/pull/21226#issuecomment-1301609959 ## CI report: * b8bad940ca1c1e0a5e4913d609766085801530ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] ruanhang1993 opened a new pull request, #21226: [Flink 29492] Return Kafka producer to the pool when the Kafka sink is not the end of the chain

2022-11-02 Thread GitBox
ruanhang1993 opened a new pull request, #21226: URL: https://github.com/apache/flink/pull/21226 ## What is the purpose of the change This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment

[jira] [Updated] (FLINK-29857) Fix HiveServer2Endpoint crush when using Hive3 Beeline

2022-11-02 Thread yuzelin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29857: Description: Hive3 add a new 'TGetInfoType' value 'CLI_ODBC_KEYWORDS', but 'HiveServer2Endpoint' doesn't

[jira] [Updated] (FLINK-29857) Fix HiveServer2Endpoint crush when using Hive3 Beeline

2022-11-02 Thread yuzelin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29857: Description: Hive3 add a new 'TGetInfoType' value 'CLI_ODBC_KEYWORDS', but  HiveServer2Endpoint > Fix

[jira] [Created] (FLINK-29857) Fix HiveServer2Endpoint crush when using Hive3 Beeline

2022-11-02 Thread yuzelin (Jira)
yuzelin created FLINK-29857: --- Summary: Fix HiveServer2Endpoint crush when using Hive3 Beeline Key: FLINK-29857 URL: https://issues.apache.org/jira/browse/FLINK-29857 Project: Flink Issue Type: Bug

[GitHub] [flink-table-store] zjureel commented on pull request #349: [FLINK-29791] Redirect gc log from stdout to file

2022-11-02 Thread GitBox
zjureel commented on PR #349: URL: https://github.com/apache/flink-table-store/pull/349#issuecomment-1301593843 Hi @LadyForest I want to fix this bug, can you help to review this PR? THX -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-29856) Triggering savepoint does not trigger source operator checkpoint

2022-11-02 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-29856: --- Description: When I trigger a savepoint with the Flink K8s operator, I verified for two sources

[GitHub] [flink-table-store] tsreaper merged pull request #346: [FLINK-29842] Change commitIdentifier in Table Store snapshot to long value

2022-11-02 Thread GitBox
tsreaper merged PR #346: URL: https://github.com/apache/flink-table-store/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-29791) Print sink result mess up with GC log in E2eTestBase

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29791: --- Labels: pull-request-available (was: ) > Print sink result mess up with GC log in

[GitHub] [flink-table-store] zjureel opened a new pull request, #349: [FLINK-29791] Redirect gc log from stdout to file

2022-11-02 Thread GitBox
zjureel opened a new pull request, #349: URL: https://github.com/apache/flink-table-store/pull/349 Redirct gc log from stdout to file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-29856) Triggering savepoint does not trigger source operator checkpoint

2022-11-02 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-29856: --- Description: When I trigger a savepoint with the Flink K8s operator, I verified for two sources

[jira] [Updated] (FLINK-29856) Triggering savepoint does not trigger source operator checkpoint

2022-11-02 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-29856: --- Description: When I trigger a savepoint with the Flink K8s operator, I verified for two sources

[jira] [Created] (FLINK-29856) Triggering savepoint does not trigger source operator checkpoint

2022-11-02 Thread Mason Chen (Jira)
Mason Chen created FLINK-29856: -- Summary: Triggering savepoint does not trigger source operator checkpoint Key: FLINK-29856 URL: https://issues.apache.org/jira/browse/FLINK-29856 Project: Flink

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #160: [FLINK-29434] Add AlgoOperator for Splitter

2022-11-02 Thread GitBox
zhipeng93 commented on code in PR #160: URL: https://github.com/apache/flink-ml/pull/160#discussion_r1012438620 ## docs/content/docs/operators/feature/randomsplitter.md: ## @@ -0,0 +1,148 @@ +--- +title: "RandomSplitter" +weight: 1 +type: docs +aliases: +-

[GitHub] [flink] 1996fanrui commented on pull request #19781: Just for test : output buffer aligned to uc

2022-11-02 Thread GitBox
1996fanrui commented on PR #19781: URL: https://github.com/apache/flink/pull/19781#issuecomment-1301580063 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] 1996fanrui commented on pull request #20137: Just for CI

2022-11-02 Thread GitBox
1996fanrui commented on PR #20137: URL: https://github.com/apache/flink/pull/20137#issuecomment-1301579975 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (FLINK-29567) Revert sink output metric names from numRecordsSend back to numRecordsOut

2022-11-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620663#comment-17620663 ] Qingsheng Ren edited comment on FLINK-29567 at 11/3/22 2:24 AM: master:

[GitHub] [flink] PatrickRen merged pull request #21220: [FLINK-29567][connector/common] Change numRecordsSend / numBytesSend / numRecordsSendError back to numRecordsOut / numBytesOut / numRecordsOutEr

2022-11-02 Thread GitBox
PatrickRen merged PR #21220: URL: https://github.com/apache/flink/pull/21220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-29647) report stackoverflow when using kryo

2022-11-02 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628074#comment-17628074 ] Xintong Song commented on FLINK-29647: -- [~jackin853], As [~zhuzh] mentioned previously, you can

[jira] [Comment Edited] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628061#comment-17628061 ] dalongliu edited comment on FLINK-29855 at 11/3/22 2:05 AM: Do the results

[jira] [Commented] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628061#comment-17628061 ] dalongliu commented on FLINK-29855: --- Do the results in the print table as expected? > UDF randomly

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #166: [FLINK-29598] Add Estimator and Transformer for Imputer

2022-11-02 Thread GitBox
yunfengzhou-hub commented on code in PR #166: URL: https://github.com/apache/flink-ml/pull/166#discussion_r1012433599 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/ImputerTest.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink] flinkbot commented on pull request #21225: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule

2022-11-02 Thread GitBox
flinkbot commented on PR #21225: URL: https://github.com/apache/flink/pull/21225#issuecomment-1301559678 ## CI report: * 6ab4e11b720543cdde73a912d6a39bdfa77750f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lincoln-lil opened a new pull request, #21225: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTranspose

2022-11-02 Thread GitBox
lincoln-lil opened a new pull request, #21225: URL: https://github.com/apache/flink/pull/21225 ## What is the purpose of the change Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule, the remap logic is necessary here.

[GitHub] [flink] flink-sql closed pull request #21173: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule

2022-11-02 Thread GitBox
flink-sql closed pull request #21173: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule URL: https://github.com/apache/flink/pull/21173 -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flink-sql commented on pull request #21173: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRul

2022-11-02 Thread GitBox
flink-sql commented on PR #21173: URL: https://github.com/apache/flink/pull/21173#issuecomment-1301555055 incorrect github account here, close this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] lincoln-lil commented on pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-11-02 Thread GitBox
lincoln-lil commented on PR #21219: URL: https://github.com/apache/flink/pull/21219#issuecomment-1301554180 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #160: [FLINK-29434] Add AlgoOperator for Splitter

2022-11-02 Thread GitBox
yunfengzhou-hub commented on code in PR #160: URL: https://github.com/apache/flink-ml/pull/160#discussion_r1012423267 ## flink-ml-python/pyflink/ml/lib/feature/randomsplitter.py: ## @@ -0,0 +1,80 @@

[GitHub] [flink] luoyuxia commented on pull request #21218: [FLINK-29831][hive] fix test failure for hive3

2022-11-02 Thread GitBox
luoyuxia commented on PR #21218: URL: https://github.com/apache/flink/pull/21218#issuecomment-1301543777 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-11-02 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1012407031 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSink.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-11-02 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1012406782 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,306 @@ +/* + *

[jira] [Commented] (FLINK-29850) Flink Table Store quick start guide does not work

2022-11-02 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628030#comment-17628030 ] Shammon commented on FLINK-29850: - Hi [~knaufk] I try the steps above with flink 1.15.2 and table sotre

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-11-02 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1012406088 ## flink-connector-dynamodb/src/test/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkBuilderTest.java: ## @@ -0,0 +1,66 @@ +/* + *

[jira] [Updated] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated FLINK-29855: -- Description: Local flink cluster env:  1 task manager and 1 task slot. To reproduce the issue: #

[jira] [Updated] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated FLINK-29855: -- Description:   To reproduce the issue: # create a datagen table with a single column int type of id

[jira] [Updated] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated FLINK-29855: -- Description:   To reproduce the issue: # create a datagen table with a single column int type of id

[GitHub] [flink] snuyanzin commented on pull request #21150: [hotfix] Replace deprecated kafka-clients methods

2022-11-02 Thread GitBox
snuyanzin commented on PR #21150: URL: https://github.com/apache/flink/pull/21150#issuecomment-1301432124 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #21224: [FLINK-29827][Connectors/Base] Registering callback for AsyncWriter on restore from state

2022-11-02 Thread GitBox
flinkbot commented on PR #21224: URL: https://github.com/apache/flink/pull/21224#issuecomment-1301400580 ## CI report: * 39c4138587b44ba392e84b1b5f30065e34b71b59 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29827) [Connector][AsyncSinkWriter] Checkpointed states block writer from sending records

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29827: --- Labels: pull-request-available (was: ) > [Connector][AsyncSinkWriter] Checkpointed states

[GitHub] [flink] vahmed-hamdy opened a new pull request, #21224: [FLINK-29827][Connectors/Base] Registering callback for AsyncWriter on restore from state

2022-11-02 Thread GitBox
vahmed-hamdy opened a new pull request, #21224: URL: https://github.com/apache/flink/pull/21224 ## What is the purpose of the change This is a bug fix, where `AsyncSinkWriter` doesn't register callback on state restoration causing records to reside in buffer more than

[jira] [Updated] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated FLINK-29855: -- Description:   To reproduce the issue: # create a datagen table with a single column int type of

[jira] [Created] (FLINK-29855) UDF randomly processed input data twice

2022-11-02 Thread Xinyi Yan (Jira)
Xinyi Yan created FLINK-29855: - Summary: UDF randomly processed input data twice Key: FLINK-29855 URL: https://issues.apache.org/jira/browse/FLINK-29855 Project: Flink Issue Type: Bug

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #424: [FLINK-29655] Move FlinkResourceListener to api

2022-11-02 Thread GitBox
mbalassi commented on PR #424: URL: https://github.com/apache/flink-kubernetes-operator/pull/424#issuecomment-1301291863 Thanks @morhidi, good catch. The beauty of refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #424: [FLINK-29655] Move FlinkResourceListener to api

2022-11-02 Thread GitBox
morhidi commented on PR #424: URL: https://github.com/apache/flink-kubernetes-operator/pull/424#issuecomment-1301281774 LGTM, it seems we only needed the plugin interface from flink-core. Nit: The STATUS generic type is not used. `public > ResourceLifecycleState getLifecycleState()

[jira] [Updated] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-29854: -- Description: h3. Background Currently AsyncSinkWriter supports three mechanisms that trigger

[jira] [Assigned] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-29854: - Assignee: Ahmed Hamdy > Make Record Size Flush Strategy Optional for Async Sink >

[jira] [Commented] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627986#comment-17627986 ] Danny Cranmer commented on FLINK-29854: --- Done, thanks [~chalixar] > Make Record Size Flush

[jira] [Commented] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627981#comment-17627981 ] Ahmed Hamdy commented on FLINK-29854: - Hi [~dannycranmer], could you please assign me this issue? >

[jira] [Commented] (FLINK-29853) Older jackson-databind found in flink-kubernetes-operator-1.2.0-shaded.jar

2022-11-02 Thread James Busche (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627978#comment-17627978 ] James Busche commented on FLINK-29853: -- OK - I tried changing the pom.xml from: 2.13.4 to

[jira] [Updated] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-29854: -- Description: h3. Background Currently AsyncSinkWriter supports three mechanisms that trigger

[jira] [Updated] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-29854: -- Description: h3. Background Currently AsyncSinkWriter supports three mechanisms that trigger

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-11-02 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1012223894 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,306 @@ +/* + *

[jira] [Created] (FLINK-29854) Make Record Size Flush Strategy Optional for Async Sink

2022-11-02 Thread Danny Cranmer (Jira)
Danny Cranmer created FLINK-29854: - Summary: Make Record Size Flush Strategy Optional for Async Sink Key: FLINK-29854 URL: https://issues.apache.org/jira/browse/FLINK-29854 Project: Flink

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-11-02 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1012223894 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,306 @@ +/* + *

[jira] [Commented] (FLINK-29850) Flink Table Store quick start guide does not work

2022-11-02 Thread Konstantin Knauf (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627911#comment-17627911 ] Konstantin Knauf commented on FLINK-29850: -- I can reproduce this. > Flink Table Store quick

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #424: [FLINK-29655] Move FlinkResourceListener to api

2022-11-02 Thread GitBox
mbalassi commented on PR #424: URL: https://github.com/apache/flink-kubernetes-operator/pull/424#issuecomment-1301044792 cc @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #424: [FLINK-29655] Move FlinkResourceListener to api

2022-11-02 Thread GitBox
mbalassi opened a new pull request, #424: URL: https://github.com/apache/flink-kubernetes-operator/pull/424 I expect that this is finally the last commit for the API refactor change. This is a potentially controversial one, because for this I needed to introduce an intentionally slim

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-02 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1012083456 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/sink/writer/serializer/MongoSerializationSchema.java: ## @@ -0,0 +1,65 @@ +/*

[jira] [Created] (FLINK-29853) Older jackson-databind found in flink-kubernetes-operator-1.2.0-shaded.jar

2022-11-02 Thread James Busche (Jira)
James Busche created FLINK-29853: Summary: Older jackson-databind found in flink-kubernetes-operator-1.2.0-shaded.jar Key: FLINK-29853 URL: https://issues.apache.org/jira/browse/FLINK-29853 Project:

[jira] [Commented] (FLINK-15462) Introduce PrestoSqlDialect

2022-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-15462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627854#comment-17627854 ] João Boto commented on FLINK-15462: --- created a PR to Trino dialect (previous PrestoSql) if someone

[GitHub] [flink] eskabetxe commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

2022-11-02 Thread GitBox
eskabetxe commented on PR #21223: URL: https://github.com/apache/flink/pull/21223#issuecomment-1300995384 Im working on docs, but it would be cool some review as documentation depends on implementation. There are two test disabled on TrinoTableSinkITCase, as the Trino connector used

[GitHub] [flink] flinkbot commented on pull request #21223: [FLINK-15462][connectors] Add Trino dialect

2022-11-02 Thread GitBox
flinkbot commented on PR #21223: URL: https://github.com/apache/flink/pull/21223#issuecomment-1300993207 ## CI report: * 828280a9c4c672af0e67737da302fd095c96108f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-15462) Introduce PrestoSqlDialect

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15462: --- Labels: auto-deprioritized-major pull-request-available (was: auto-deprioritized-major) >

[GitHub] [flink] eskabetxe opened a new pull request, #21223: [FLINK-15462][connectors] Add Trino dialect

2022-11-02 Thread GitBox
eskabetxe opened a new pull request, #21223: URL: https://github.com/apache/flink/pull/21223 ## What is the purpose of the change Add the implementation of the Trino dialect for JDBC connectors ## Brief change log Added: TrinoDialect TrinoDialectFactory

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-02 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1012085964 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/MongoSourceBuilder.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-02 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1012083456 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/sink/writer/serializer/MongoSerializationSchema.java: ## @@ -0,0 +1,65 @@ +/*

[GitHub] [flink] pnowojski commented on a diff in pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoin

2022-11-02 Thread GitBox
pnowojski commented on code in PR #21131: URL: https://github.com/apache/flink/pull/21131#discussion_r1012016085 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImpl.java: ## @@ -73,11 +79,27 @@ public void

[jira] [Commented] (FLINK-29818) HsResultPartitionTest.testAvailability fails

2022-11-02 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627824#comment-17627824 ] Weijie Guo commented on FLINK-29818: I have found the reason and proposed pull request, it will

[GitHub] [flink] XComp commented on pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-11-02 Thread GitBox
XComp commented on PR #21137: URL: https://github.com/apache/flink/pull/21137#issuecomment-1300806942 > To me the issue stems more from both the runner and election service calling into each other under locks (== fundamental issue that should never happen), and locks maybe being way too

[jira] [Created] (FLINK-29852) The operator is repeatedly displayed on the Flink Web UI

2022-11-02 Thread JasonLee (Jira)
JasonLee created FLINK-29852: Summary: The operator is repeatedly displayed on the Flink Web UI Key: FLINK-29852 URL: https://issues.apache.org/jira/browse/FLINK-29852 Project: Flink Issue Type:

[jira] [Commented] (FLINK-29818) HsResultPartitionTest.testAvailability fails

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627804#comment-17627804 ] Matthias Pohl commented on FLINK-29818: ---

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627802#comment-17627802 ] Matthias Pohl commented on FLINK-24119: ---

[jira] [Commented] (FLINK-26974) Python EmbeddedThreadDependencyTests.test_add_python_file failed on azure

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627801#comment-17627801 ] Matthias Pohl commented on FLINK-26974: ---

[jira] [Commented] (FLINK-29818) HsResultPartitionTest.testAvailability fails

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627798#comment-17627798 ] Matthias Pohl commented on FLINK-29818: ---

[jira] [Updated] (FLINK-29818) HsResultPartitionTest.testAvailability fails

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29818: -- Labels: pull-request-available test-stability (was: pull-request-available) >

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627796#comment-17627796 ] Matthias Pohl commented on FLINK-24119: ---

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627795#comment-17627795 ] Matthias Pohl commented on FLINK-29427: ---

[jira] [Commented] (FLINK-26674) flink-tests module exit with code 137

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627789#comment-17627789 ] Matthias Pohl commented on FLINK-26674: --- I'm increasing the priority of this ticket again. We're

[jira] [Commented] (FLINK-26674) flink-tests module exit with code 137

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627790#comment-17627790 ] Matthias Pohl commented on FLINK-26674: --- {{flink-table}} failed with an 137 exit code:

[jira] [Updated] (FLINK-26674) flink-tests module exit with code 137

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-26674: -- Affects Version/s: 1.16.0 1.17.0 > flink-tests module exit with code

[jira] [Updated] (FLINK-26674) flink-tests module exit with code 137

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-26674: -- Priority: Major (was: Minor) > flink-tests module exit with code 137 >

[jira] [Commented] (FLINK-28424) JdbcExactlyOnceSinkE2eTest hangs on Azure

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627776#comment-17627776 ] Matthias Pohl commented on FLINK-28424: ---

[jira] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440 ] Matthias Pohl deleted comment on FLINK-28440: --- was (Author: mapohl):

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627775#comment-17627775 ] Matthias Pohl commented on FLINK-28440: ---

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627774#comment-17627774 ] Matthias Pohl commented on FLINK-28440: ---

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-11-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-28440: -- Fix Version/s: (was: 1.17.0) > EventTimeWindowCheckpointingITCase.testSlidingTimeWindow

[GitHub] [flink] flinkbot commented on pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-11-02 Thread GitBox
flinkbot commented on PR #21222: URL: https://github.com/apache/flink/pull/21222#issuecomment-1300645730 ## CI report: * 26b9b75d144315b19f62fda2ceff8fd076e91a45 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   3   >