[GitHub] [flink-table-store] GOODBOY008 closed pull request #438: [FLINK-30414] Add unit test time out when run ci.

2022-12-15 Thread GitBox
GOODBOY008 closed pull request #438: [FLINK-30414] Add unit test time out when run ci. URL: https://github.com/apache/flink-table-store/pull/438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (FLINK-23035) Add explicit method to StateChangelogWriter to write metadata

2022-12-15 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-23035. Assignee: Yanfei Lei (was: Xinbin Huang) Resolution: Resolved > Add explicit method to

[jira] [Commented] (FLINK-23035) Add explicit method to StateChangelogWriter to write metadata

2022-12-15 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648379#comment-17648379 ] Yanfei Lei commented on FLINK-23035: Merged

[GitHub] [flink] link3280 commented on pull request #21292: [FLINK-28617][SQL Gateway] Support stop job statement in SqlGatewayService

2022-12-15 Thread GitBox
link3280 commented on PR #21292: URL: https://github.com/apache/flink/pull/21292#issuecomment-1354328522 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-30345) Improve the serializer performace of state change of changelog

2022-12-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648377#comment-17648377 ] Hangxiang Yu commented on FLINK-30345: -- Actually, I think it should be tagged with "Bug". So I

[jira] [Updated] (FLINK-30345) Improve the serializer performace of state change of changelog

2022-12-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-30345: - Issue Type: Bug (was: Improvement) > Improve the serializer performace of state change of

[GitHub] [flink] flinkbot commented on pull request #21517: Update broadcast_state.md

2022-12-15 Thread GitBox
flinkbot commented on PR #21517: URL: https://github.com/apache/flink/pull/21517#issuecomment-1354296145 ## CI report: * 4afcdd820d8a1444ff3d20b6b3ea326b5c62b357 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] DatTrannn opened a new pull request, #21517: Update broadcast_state.md

2022-12-15 Thread GitBox
DatTrannn opened a new pull request, #21517: URL: https://github.com/apache/flink/pull/21517 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] curcur merged pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-12-15 Thread GitBox
curcur merged PR #21405: URL: https://github.com/apache/flink/pull/21405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-18568) Add Support for Azure Data Lake Store Gen 2 in File Sink

2022-12-15 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648354#comment-17648354 ] ramkrishna.s.vasudevan commented on FLINK-18568: [~psrinivasulu]  - can you take a look

[GitHub] [flink] Myasuka commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

2022-12-15 Thread GitBox
Myasuka commented on code in PR #21498: URL: https://github.com/apache/flink/pull/21498#discussion_r1050406399 ## docs/layouts/shortcodes/generated/cluster_configuration.html: ## @@ -70,7 +70,7 @@ cluster.thread-dump.stacktrace-max-depth -

[GitHub] [flink-table-store] zjureel commented on pull request #439: [FLINK-30410] Rename 'full' to 'latest-full' and 'compacted' to 'compacted-full' for scan.mode in Table Store

2022-12-15 Thread GitBox
zjureel commented on PR #439: URL: https://github.com/apache/flink-table-store/pull/439#issuecomment-1354234775 LGTM  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-table-store] GOODBOY008 commented on pull request #438: [FLINK-30414] Add unit test time out when run ci.

2022-12-15 Thread GitBox
GOODBOY008 commented on PR #438: URL: https://github.com/apache/flink-table-store/pull/438#issuecomment-1354219408 @JingsongLi @SteNicholas Thanks for your reply . I just think add `time out` to kill ci ,because when we develop and trigger ci run unit test , It's hang on . We must kill

[GitHub] [flink] xintongsong commented on pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-15 Thread GitBox
xintongsong commented on PR #21447: URL: https://github.com/apache/flink/pull/21447#issuecomment-1354188912 > Do you mean that we get the result of subtask level from job-vertex-cache in the first step, right? And don't trigger any thread sampling when get the result of subtask level,

[jira] [Commented] (FLINK-28863) Snapshot result of RocksDB native savepoint should have empty shared-state

2022-12-15 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648326#comment-17648326 ] Jinzhong Li commented on FLINK-28863: - [~yunta]  Yes, that is. And +1 for keeping the logic as it

[jira] [Commented] (FLINK-30412) create many checkpoint empty dir when job not enable checkpoint

2022-12-15 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648325#comment-17648325 ] Xintong Song commented on FLINK-30412: -- [~xiaodao], Thanks for the explanation. Now I get your

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-15 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1050354918 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/MinHashLSHModelData.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] flinkbot commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-15 Thread GitBox
flinkbot commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1354168517 ## CI report: * c20c1bb8a1803cc8ffd4d5f163f18f0d63cc7298 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28863) Snapshot result of RocksDB native savepoint should have empty shared-state

2022-12-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28863: --- Labels: pull-request-available (was: ) > Snapshot result of RocksDB native savepoint

[GitHub] [flink-table-store] SteNicholas commented on pull request #438: [FLINK-30414] Add unit test time out when run ci.

2022-12-15 Thread GitBox
SteNicholas commented on PR #438: URL: https://github.com/apache/flink-table-store/pull/438#issuecomment-1354164654 @GOODBOY008, as you mentioned in the above ticket, you could add the timeout of the unit tests for CI in the [[FLINK-26465] Optimize SortMergeReader: use loser tree to

[GitHub] [flink] ljz2051 opened a new pull request, #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB…

2022-12-15 Thread GitBox
ljz2051 opened a new pull request, #21516: URL: https://github.com/apache/flink/pull/21516 … native savepoint doesn't have empty shared-state ## What is the purpose of the change This pull request adds some comments about why snapshot result fo rocksdb native savepoint doesn't

[GitHub] [flink-table-store] JingsongLi commented on pull request #438: [FLINK-30414] Add unit test time out when run ci.

2022-12-15 Thread GitBox
JingsongLi commented on PR #438: URL: https://github.com/apache/flink-table-store/pull/438#issuecomment-1354164402 Hi @GOODBOY008 , thanks for the contribution. I think there may be error tests to block testing. We may not really need to add test timeout. -- This is an automated

[jira] [Closed] (FLINK-30428) SparkReadITCase.testSnapshotsTable is unstable

2022-12-15 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30428. Fix Version/s: table-store-0.3.0 Assignee: Shammon Resolution: Fixed master:

[jira] [Updated] (FLINK-30428) SparkReadITCase.testSnapshotsTable is unstable

2022-12-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30428: --- Labels: pull-request-available (was: ) > SparkReadITCase.testSnapshotsTable is unstable >

[GitHub] [flink-table-store] JingsongLi merged pull request #440: [FLINK-30428] Fix SparkReadITCase.testSnapshotsTable

2022-12-15 Thread GitBox
JingsongLi merged PR #440: URL: https://github.com/apache/flink-table-store/pull/440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-15 Thread GitBox
1996fanrui commented on code in PR #21447: URL: https://github.com/apache/flink/pull/21447#discussion_r1050345039 ## flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java: ## @@ -32,25 +36,33 @@ */ public class ThreadInfoSample implements

[GitHub] [flink] 1996fanrui commented on pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-15 Thread GitBox
1996fanrui commented on PR #21447: URL: https://github.com/apache/flink/pull/21447#issuecomment-1354154092 > In the first step, we do not touch how thread samples are captured / cached, and only provide apis for building flame graph with samples from a specific subtask. This should be good

[jira] [Updated] (FLINK-30432) HiveSoure doesn't need to maintain all splits when it's for parallelism inference

2022-12-15 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-30432: - Description: By default, Hive source will try to infer parallelism during which it'll split files to

[jira] [Commented] (FLINK-30412) create many checkpoint empty dir when job not enable checkpoint

2022-12-15 Thread xiaodao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648317#comment-17648317 ] xiaodao commented on FLINK-30412: - [~xtsong] thank you for your reply。 Supplementary Note: when we build

[jira] [Updated] (FLINK-30432) HiveSoure doesn't need to maintain all splits when it's for parallelism inference

2022-12-15 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-30432: - Description: By default, Hive source will try to do  > HiveSoure doesn't need to maintain all splits

[jira] [Created] (FLINK-30432) HiveSoure doesn't need to maintain all splits when it's for parallelism inference

2022-12-15 Thread luoyuxia (Jira)
luoyuxia created FLINK-30432: Summary: HiveSoure doesn't need to maintain all splits when it's for parallelism inference Key: FLINK-30432 URL: https://issues.apache.org/jira/browse/FLINK-30432 Project:

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-15 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1050339527 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/DataStreamUtils.java: ## @@ -133,6 +135,15 @@ public static DataStream reduce(DataStream input,

[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-12-15 Thread GitBox
fredia commented on PR #21405: URL: https://github.com/apache/flink/pull/21405#issuecomment-1354142422 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-jdbc] GOODBOY008 commented on pull request #7: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-15 Thread GitBox
GOODBOY008 commented on PR #7: URL: https://github.com/apache/flink-connector-jdbc/pull/7#issuecomment-1354111892 Hi @MartijnVisser , Please review my pr , If you are availible . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #7: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-15 Thread GitBox
boring-cyborg[bot] commented on PR #7: URL: https://github.com/apache/flink-connector-jdbc/pull/7#issuecomment-1354110597 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an

[GitHub] [flink-connector-jdbc] GOODBOY008 opened a new pull request, #7: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-15 Thread GitBox
GOODBOY008 opened a new pull request, #7: URL: https://github.com/apache/flink-connector-jdbc/pull/7 Link https://issues.apache.org/jira/browse/FLINK-30357. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] chucheng92 commented on a diff in pull request #21513: [FLINK-30424][DataStream API] Add source operator addSplits log when restore from state

2022-12-15 Thread GitBox
chucheng92 commented on code in PR #21513: URL: https://github.com/apache/flink/pull/21513#discussion_r1049417560 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java: ## @@ -333,6 +333,7 @@ public void open() throws Exception {

[GitHub] [flink] link3280 commented on a diff in pull request #21292: [FLINK-28617][SQL Gateway] Support stop job statement in SqlGatewayService

2022-12-15 Thread GitBox
link3280 commented on code in PR #21292: URL: https://github.com/apache/flink/pull/21292#discussion_r1050321324 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -405,4 +425,107 @@ private Set

[jira] [Commented] (FLINK-30431) JDBC Connector fails to reestablish the lost DB connection.

2022-12-15 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648307#comment-17648307 ] luoyuxia commented on FLINK-30431: -- Thanks for reporting. I think we should fix it. Otherwise, the

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-15 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1354074250 Hi @snuyanzin I am recently encountering issue, where I am not able to run tests. Any idea about this > [ERROR] Failed to execute goal

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-15 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1050303584 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/LSHModel.java: ## @@ -0,0 +1,422 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-15 Thread GitBox
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1354073289 Hi @snuyanzin , I have given you access to my repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] xintongsong commented on pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-15 Thread GitBox
xintongsong commented on PR #21447: URL: https://github.com/apache/flink/pull/21447#issuecomment-1354053526 > The execution-vertex cache just saves the result when requesting the flame graph for subtask level, right? Yes. > Is it typo? For the subtask flame graph, we should

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-15 Thread GitBox
zhipeng93 commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1049646990 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/MinHashLSHTest.java: ## @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Created] (FLINK-30431) JDBC Connector fails to reestablish the lost DB connection.

2022-12-15 Thread Sai Nadendla (Jira)
Sai Nadendla created FLINK-30431: Summary: JDBC Connector fails to reestablish the lost DB connection. Key: FLINK-30431 URL: https://issues.apache.org/jira/browse/FLINK-30431 Project: Flink

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #484: FLIP-271: Autoscaling

2022-12-15 Thread GitBox
morhidi commented on PR #484: URL: https://github.com/apache/flink-kubernetes-operator/pull/484#issuecomment-1353728082 Exciting work @gyfora +1 for merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-18777) Supports schema registry catalog

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-18777: --- Issue Type: New Feature (was: Bug) > Supports schema registry catalog >

[jira] [Updated] (FLINK-12256) Implement Confluent Schema Registry Catalog

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-12256: --- Priority: Major (was: Not a Priority) > Implement Confluent Schema Registry Catalog >

[jira] [Updated] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30430: --- Fix Version/s: pulsar-3.0.1 (was: pulsar-3.0.0) > Remove the useless

[jira] [Commented] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648209#comment-17648209 ] Martijn Visser commented on FLINK-30175: [~syhily] I totally understand that, but perhaps it

[jira] [Updated] (FLINK-18777) Supports schema registry catalog

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-18777: --- Priority: Major (was: Minor) > Supports schema registry catalog >

[jira] [Updated] (FLINK-18777) Supports schema registry catalog

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-18777: --- Fix Version/s: (was: 1.17.0) > Supports schema registry catalog >

[jira] [Commented] (FLINK-29796) pyflink protobuf requirement out of date

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648203#comment-17648203 ] Martijn Visser commented on FLINK-29796: It looks this was changed as part of FLINK-28786 which

[jira] [Commented] (FLINK-29796) pyflink protobuf requirement out of date

2022-12-15 Thread Nathanael England (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648177#comment-17648177 ] Nathanael England commented on FLINK-29796: --- Just wanted to bump this. Looking at

[GitHub] [flink] pvary commented on a diff in pull request #21511: Delegation token framework refactoring

2022-12-15 Thread GitBox
pvary commented on code in PR #21511: URL: https://github.com/apache/flink/pull/21511#discussion_r1049939031 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManager.java: ## @@ -45,91 +42,86 @@ import java.util.concurrent.TimeUnit;

[GitHub] [flink] pvary commented on a diff in pull request #21511: Delegation token framework refactoring

2022-12-15 Thread GitBox
pvary commented on code in PR #21511: URL: https://github.com/apache/flink/pull/21511#discussion_r1049937712 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManagerFactory.java: ## @@ -34,37 +31,21 @@ import java.io.IOException;

[GitHub] [flink] pvary commented on a diff in pull request #21511: Delegation token framework refactoring

2022-12-15 Thread GitBox
pvary commented on code in PR #21511: URL: https://github.com/apache/flink/pull/21511#discussion_r1049936886 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManagerFactory.java: ## @@ -34,37 +31,21 @@ import java.io.IOException;

[GitHub] [flink] gaborgsomogyi commented on pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
gaborgsomogyi commented on PR #21515: URL: https://github.com/apache/flink/pull/21515#issuecomment-1353417733 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] gaborgsomogyi commented on pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
gaborgsomogyi commented on PR #21515: URL: https://github.com/apache/flink/pull/21515#issuecomment-1353417077 Ci is dying again: ``` [ERROR] The project org.apache.flink:flink-connector-gcp-pubsub:1.17-SNAPSHOT

[GitHub] [flink] pvary commented on a diff in pull request #21511: Delegation token framework refactoring

2022-12-15 Thread GitBox
pvary commented on code in PR #21511: URL: https://github.com/apache/flink/pull/21511#discussion_r1049924477 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -75,6 +83,10 @@ public void install() throws SecurityInstallException {

[GitHub] [flink] mxm commented on a diff in pull request #21443: [FLINK-30213] Change ForwardPartitioner to RebalancePartitioner on parallelism changes

2022-12-15 Thread GitBox
mxm commented on code in PR #21443: URL: https://github.com/apache/flink/pull/21443#discussion_r1049868134 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1799,6 +1811,64 @@ public void testMailboxMetricsMeasurement()

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-15 Thread GitBox
1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1049851231 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-15 Thread GitBox
1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1049831635 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImpl.java: ## @@ -152,14 +200,23 @@ private void

[jira] [Comment Edited] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648144#comment-17648144 ] Yufan Sheng edited comment on FLINK-30175 at 12/15/22 3:58 PM: --- I see. But

[jira] [Commented] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648144#comment-17648144 ] Yufan Sheng commented on FLINK-30175: - I see. But I want to clarify that the {{pulsar-broker}} is

[jira] [Assigned] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30430: -- Assignee: Yufan Sheng > Remove the useless dependencies in flink-connector-pulsar's

[jira] [Commented] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648138#comment-17648138 ] Martijn Visser commented on FLINK-30175: [~syhily] {{snakeyaml}} is a transitive dependency of

[jira] [Commented] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648134#comment-17648134 ] Yufan Sheng commented on FLINK-30430: - [~martijnvisser] Tks for your information. I'll check the doc

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-15 Thread GitBox
1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1049806879 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImpl.java: ## @@ -90,33 +103,62 @@ public void

[jira] [Comment Edited] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648130#comment-17648130 ] Yufan Sheng edited comment on FLINK-30175 at 12/15/22 3:45 PM: ---

[jira] [Commented] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648130#comment-17648130 ] Yufan Sheng commented on FLINK-30175: - [~martijnvisser] Pulsar also don't need {{snakeyaml}}. But I

[jira] [Commented] (FLINK-30427) Pulsar SQL connector lists not bundled dependencies

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648128#comment-17648128 ] Martijn Visser commented on FLINK-30427: [~syhily] It was needed to resolve dependency

[jira] [Comment Edited] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648124#comment-17648124 ] Yufan Sheng edited comment on FLINK-30175 at 12/15/22 3:43 PM: --- Can we

[jira] [Commented] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648126#comment-17648126 ] Martijn Visser commented on FLINK-30175: [~syhily] None of the other connectors have needed

[jira] [Commented] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648125#comment-17648125 ] Martijn Visser commented on FLINK-30430: [~syhily] Feel free to open a PR to clean them up. I do

[jira] [Commented] (FLINK-30175) Bump snakeyaml from 1.31 to 1.33

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648124#comment-17648124 ] Yufan Sheng commented on FLINK-30175: - Can we defined all the common dependencies in the

[GitHub] [flink] gyfora commented on a diff in pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
gyfora commented on code in PR #21515: URL: https://github.com/apache/flink/pull/21515#discussion_r1049796201 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java: ## @@ -1149,6 +1150,11 @@ public int parseAndRun(String[] args) { /** Submits the

[GitHub] [flink] gyfora commented on a diff in pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
gyfora commented on code in PR #21515: URL: https://github.com/apache/flink/pull/21515#discussion_r1049796201 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java: ## @@ -1149,6 +1150,11 @@ public int parseAndRun(String[] args) { /** Submits the

[jira] [Updated] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng updated FLINK-30430: Description: I can see a lot of useless dependencies exist in the root pom.xml file of

[jira] [Created] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-15 Thread Yufan Sheng (Jira)
Yufan Sheng created FLINK-30430: --- Summary: Remove the useless dependencies in flink-connector-pulsar's dependencyManagement Key: FLINK-30430 URL: https://issues.apache.org/jira/browse/FLINK-30430

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21443: [FLINK-30213] Change ForwardPartitioner to RebalancePartitioner on parallelism changes

2022-12-15 Thread GitBox
1996fanrui commented on code in PR #21443: URL: https://github.com/apache/flink/pull/21443#discussion_r1049789012 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1799,6 +1811,64 @@ public void

[GitHub] [flink] flinkbot commented on pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
flinkbot commented on PR #21515: URL: https://github.com/apache/flink/pull/21515#issuecomment-1353279627 ## CI report: * c247028cdd1b17ddf75bc471e8a7d8dc47a357ef UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30429) Flink command stops with IllegalArgumentException

2022-12-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30429: --- Labels: pull-request-available (was: ) > Flink command stops with IllegalArgumentException

[GitHub] [flink] gaborgsomogyi commented on pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
gaborgsomogyi commented on PR #21515: URL: https://github.com/apache/flink/pull/21515#issuecomment-1353274190 cc @gyfora -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-15 Thread GitBox
gaborgsomogyi opened a new pull request, #21515: URL: https://github.com/apache/flink/pull/21515 ## What is the purpose of the change Flink now throws exception in command line tools: ``` $ flink ... java.lang.IllegalArgumentException: 1 > 0 at

[jira] [Commented] (FLINK-30427) Pulsar SQL connector lists not bundled dependencies

2022-12-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648118#comment-17648118 ] Yufan Sheng commented on FLINK-30427: - The bouncycastle dependency is introduced by

[GitHub] [flink] MartijnVisser commented on pull request #20289: [FLINK-23633][FLIP-150][connector/common] HybridSource: Support dynamic stop position in FileSource

2022-12-15 Thread GitBox
MartijnVisser commented on PR #20289: URL: https://github.com/apache/flink/pull/20289#issuecomment-1353265333 @xinbinhuang @tweise What's the status of this PR? Can we somehow bring this forward and resolve it for 1.17? -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-30340) PulsarUnorderedSourceITCase fails with IllegalStateException

2022-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648113#comment-17648113 ] Martijn Visser commented on FLINK-30340:

[jira] [Closed] (FLINK-28875) Add FlinkSessionJobControllerTest

2022-12-15 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-28875. -- Resolution: Fixed merged to main c8ed11dfde1e0fc57d8fa45b0121ecec362bd03d > Add

[jira] [Closed] (FLINK-30150) Evaluate operator error log whitelist entry: REST service in session cluster is bad now

2022-12-15 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30150. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #485: [FLINK-28875] Add FlinkSessionJobControllerTest

2022-12-15 Thread GitBox
gyfora merged PR #485: URL: https://github.com/apache/flink-kubernetes-operator/pull/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-30429) Flink command stops with IllegalArgumentException

2022-12-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-30429: - Assignee: Gabor Somogyi > Flink command stops with IllegalArgumentException >

[jira] [Updated] (FLINK-30429) Flink command stops with IllegalArgumentException

2022-12-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-30429: -- Component/s: Client / Job Submission > Flink command stops with IllegalArgumentException >

[jira] [Updated] (FLINK-30429) Flink command stops with IllegalArgumentException

2022-12-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-30429: -- Description: The issue has been introduced

[jira] [Commented] (FLINK-30198) Support AdaptiveBatchScheduler to set per-task size for reducer task

2022-12-15 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648099#comment-17648099 ] Aitozi commented on FLINK-30198: Thanks, all guys, for your input. I agree that vertex-level tuning will

[jira] [Created] (FLINK-30429) Flink command stops with IllegalArgumentException

2022-12-15 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30429: - Summary: Flink command stops with IllegalArgumentException Key: FLINK-30429 URL: https://issues.apache.org/jira/browse/FLINK-30429 Project: Flink Issue

[GitHub] [flink] mxm commented on a diff in pull request #21443: [FLINK-30213] Change ForwardPartitioner to RebalancePartitioner on parallelism changes

2022-12-15 Thread GitBox
mxm commented on code in PR #21443: URL: https://github.com/apache/flink/pull/21443#discussion_r1049729462 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -1614,6 +1617,15 @@ List>>> createRecordWriters return

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #474: [FLINK-30150] Ignore "REST service in session cluster is bad now" where we kill the JobManager manually

2022-12-15 Thread GitBox
gyfora merged PR #474: URL: https://github.com/apache/flink-kubernetes-operator/pull/474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-15 Thread GitBox
zhipeng93 commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1049588862 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/LSH.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[jira] [Updated] (FLINK-28875) Add FlinkSessionJobControllerTest

2022-12-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28875: --- Labels: pull-request-available (was: ) > Add FlinkSessionJobControllerTest >

  1   2   3   >