[GitHub] [flink] flinkbot commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread via GitHub
flinkbot commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1474732693 ## CI report: * 5d7e324b18d000d6f46e3bfde2dbd654c3dda08c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1474732352 @wuchong wu @luoyuxia luo Please take a look, thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-31499) Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31499: --- Labels: pull-request-available (was: ) > Move SqlCreateTable conversion logic to

[GitHub] [flink] xuzhiwen1255 opened a new pull request, #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread via GitHub
xuzhiwen1255 opened a new pull request, #22208: URL: https://github.com/apache/flink/pull/22208 ## What is the purpose of the change Similar to [FLINK-31368](https://issues.apache.org/jira/browse/FLINK-31368), the SqlToOperationConverter is a bit bloated. This PR moves the conversion

[GitHub] [flink] fredia commented on pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
fredia commented on PR #21822: URL: https://github.com/apache/flink/pull/21822#issuecomment-1474697817 @zoltar9264 Thanks for the review and suggestion, I updated the PR based on the comment. Currently, the `LocalChangelogRegistryImpl#prune()` is removed. -- This is an automated message

[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
fredia commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1140930335 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/LocalChangelogRegistryImpl.java: ## @@ -115,4 +116,32 @@ private void

[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
fredia commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1140928595 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,12 +52,12 @@ * Store the meta of files

[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
fredia commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1140928577 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogStorage.java: ## @@ -167,6 +167,7 @@ public FsStateChangelogWriter

[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
fredia commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1140928508 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/LocalChangelogRegistryImpl.java: ## @@ -87,8 +88,8 @@ public void discardUpToCheckpoint(long

[jira] [Comment Edited] (FLINK-29298) LocalBufferPool request buffer from NetworkBufferPool hanging

2023-03-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702051#comment-17702051 ] Weijie Guo edited comment on FLINK-29298 at 3/18/23 3:27 AM: - Hi

[jira] [Commented] (FLINK-29298) LocalBufferPool request buffer from NetworkBufferPool hanging

2023-03-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702051#comment-17702051 ] Weijie Guo commented on FLINK-29298: Hi [~lichen1109]. Unfortunately, this bug is only possible to

[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
fredia commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1140919763 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/LocalChangelogRegistryImpl.java: ## @@ -58,23 +59,23 @@ public void register(StreamStateHandle

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-17 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1474659993 because execution of operation has changed in [FLINK-31507](https://issues.apache.org/jira/browse/FLINK-31507) . I will rebase it. -- This is an automated message from the Apache

[jira] (FLINK-31380) Support enhanced show catalogs syntax

2023-03-17 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380 ] Ran Tao deleted comment on FLINK-31380: - was (Author: lemonjing): Hi, [~jark] . Currently there are three ways to support these auxiliary sql statements. 1.change every operation to support

[GitHub] [flink] flinkbot commented on pull request #22207: FLINK-31510. Use getMemorySize instead of getMemory.

2023-03-17 Thread via GitHub
flinkbot commented on PR #22207: URL: https://github.com/apache/flink/pull/22207#issuecomment-1474563109 ## CI report: * e6835649ed601e22536f0550e52c089aa4e06da9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31510) Use getMemorySize instead of getMemory

2023-03-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31510: --- Labels: pull-request-available (was: ) > Use getMemorySize instead of getMemory >

[GitHub] [flink] slfan1989 opened a new pull request, #22207: FLINK-31510. Use getMemorySize instead of getMemory.

2023-03-17 Thread via GitHub
slfan1989 opened a new pull request, #22207: URL: https://github.com/apache/flink/pull/22207 ## What is the purpose of the change JIRA: FLINK-31510. Use getMemorySize instead of getMemory In [YARN-4844](https://issues.apache.org/jira/browse/YARN-4844), use

[jira] [Created] (FLINK-31510) Use getMemorySize instead of getMemory

2023-03-17 Thread Shilun Fan (Jira)
Shilun Fan created FLINK-31510: -- Summary: Use getMemorySize instead of getMemory Key: FLINK-31510 URL: https://issues.apache.org/jira/browse/FLINK-31510 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-29298) LocalBufferPool request buffer from NetworkBufferPool hanging

2023-03-17 Thread Lee chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702031#comment-17702031 ] Lee chen commented on FLINK-29298: -- We alse faced to this problem, how to reproduce this problem with

[jira] [Commented] (FLINK-23159) Correlated sql subquery on the source created via fromValues() failed to compile

2023-03-17 Thread Deepyaman Datta (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702027#comment-17702027 ] Deepyaman Datta commented on FLINK-23159: - Hello! I believe I'm affected by this issue, as

[GitHub] [flink-kubernetes-operator] robsonpeixoto commented on pull request #93: [FLINK-26706] Introduce Ingress URL templating

2023-03-17 Thread via GitHub
robsonpeixoto commented on PR #93: URL: https://github.com/apache/flink-kubernetes-operator/pull/93#issuecomment-1474533148 This solution is amazing! Thanks a lot =D But add this feature in annotation os very useful, for example: ``` ingress: template:

[jira] [Created] (FLINK-31509) REST Service missing sessionAffinity causes job run failure with HA cluster

2023-03-17 Thread Emmanuel Leroy (Jira)
Emmanuel Leroy created FLINK-31509: -- Summary: REST Service missing sessionAffinity causes job run failure with HA cluster Key: FLINK-31509 URL: https://issues.apache.org/jira/browse/FLINK-31509

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #549: [FLINK-31502] Limit the number of scale operations to reduce cluster churn

2023-03-17 Thread via GitHub
gyfora commented on code in PR #549: URL: https://github.com/apache/flink-kubernetes-operator/pull/549#discussion_r1140649362 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -86,6 +86,12 @@ Duration Interval at which periodic

[jira] [Created] (FLINK-31508) FLIP-304: Pluggable failure handling for Apache Flink

2023-03-17 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31508: -- Summary: FLIP-304: Pluggable failure handling for Apache Flink Key: FLINK-31508 URL: https://issues.apache.org/jira/browse/FLINK-31508 Project:

[jira] [Updated] (FLINK-31502) Limit the number of concurrent scale operations to reduce cluster churn

2023-03-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31502: --- Labels: pull-request-available (was: ) > Limit the number of concurrent scale operations

[GitHub] [flink-kubernetes-operator] mxm opened a new pull request, #549: [FLINK-31502] Limit the number of scale operations to reduce cluster churn

2023-03-17 Thread via GitHub
mxm opened a new pull request, #549: URL: https://github.com/apache/flink-kubernetes-operator/pull/549 Until we move to using the upcoming Rescale API which recycles pods, we need to be mindful with how many deployments we scale at the same time because each of them is going to give up all

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

2023-03-17 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701917#comment-17701917 ] Chesnay Schepler commented on FLINK-31490: -- But FLINK-27848 was fixed in 1.17.0; if that change

[GitHub] [flink] zentol commented on pull request #22052: [FLINK-31278] Disables fork reuse and parallel execution for flink-core package

2023-03-17 Thread via GitHub
zentol commented on PR #22052: URL: https://github.com/apache/flink/pull/22052#issuecomment-1474175255 I'd suggest to instead somewhat profile the runtime tests instead. Add a special test that runs last (see https://stackoverflow.com/questions/57624495/junit-test-class-order) that

[jira] [Comment Edited] (FLINK-31380) Support enhanced show catalogs syntax

2023-03-17 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701912#comment-17701912 ] Ran Tao edited comment on FLINK-31380 at 3/17/23 5:26 PM: -- Hi, [~jark] .

[GitHub] [flink] zentol commented on pull request #22052: [FLINK-31278] Disables fork reuse and parallel execution for flink-core package

2023-03-17 Thread via GitHub
zentol commented on PR #22052: URL: https://github.com/apache/flink/pull/22052#issuecomment-1474170781 Still I don't see what this gets you. The test running into the OOM isn't necessarily who's causing it. If some test allocates 99% of memory but finishes, then some subsequent test may

[jira] [Comment Edited] (FLINK-31380) Support enhanced show catalogs syntax

2023-03-17 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701912#comment-17701912 ] Ran Tao edited comment on FLINK-31380 at 3/17/23 5:24 PM: -- Hi, [~jark] .

[jira] [Commented] (FLINK-31380) Support enhanced show catalogs syntax

2023-03-17 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701912#comment-17701912 ] Ran Tao commented on FLINK-31380: - Hi, [~jark] . Currently there are three ways to support these

[GitHub] [flink] zentol commented on pull request #22052: [FLINK-31278] Disables fork reuse and parallel execution for flink-core package

2023-03-17 Thread via GitHub
zentol commented on PR #22052: URL: https://github.com/apache/flink/pull/22052#issuecomment-1474164411 wait a minute. Why is the basic nightly run using `'ubuntu-20.04'` as the pool`? A because of FLINK-18370... -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] zentol commented on pull request #22052: [FLINK-31278] Disables fork reuse and parallel execution for flink-core package

2023-03-17 Thread via GitHub
zentol commented on PR #22052: URL: https://github.com/apache/flink/pull/22052#issuecomment-1474157633 What makes you think they are on azure-owned hosts? They are both scheduled builds in flink-ci, which do use the alibaba machines. -- This is an automated message from the Apache Git

[jira] [Assigned] (FLINK-31504) Move execution logic of CreateOperation out from TableEnvironmentImpl

2023-03-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-31504: --- Assignee: Jark Wu > Move execution logic of CreateOperation out from TableEnvironmentImpl >

[jira] [Created] (FLINK-31507) Move execution logic of ShowOperation out from TableEnvironmentImpl

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31507: --- Summary: Move execution logic of ShowOperation out from TableEnvironmentImpl Key: FLINK-31507 URL: https://issues.apache.org/jira/browse/FLINK-31507 Project: Flink

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-17 Thread via GitHub
echauchot commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1474052060 @zentol I pushed for security reasons, I have only the addSplitsBack case to deal with in lazy splits generation scenario. You can start to take a look at the other things

[jira] [Created] (FLINK-31505) Move execution logic of DropOperation out from TableEnvironmentImpl

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31505: --- Summary: Move execution logic of DropOperation out from TableEnvironmentImpl Key: FLINK-31505 URL: https://issues.apache.org/jira/browse/FLINK-31505 Project: Flink

[jira] [Created] (FLINK-31506) Move execution logic of AlterOperation out from TableEnvironmentImpl

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31506: --- Summary: Move execution logic of AlterOperation out from TableEnvironmentImpl Key: FLINK-31506 URL: https://issues.apache.org/jira/browse/FLINK-31506 Project: Flink

[jira] [Created] (FLINK-31504) Move execution logic of CreateOperation out from TableEnvironmentImpl

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31504: --- Summary: Move execution logic of CreateOperation out from TableEnvironmentImpl Key: FLINK-31504 URL: https://issues.apache.org/jira/browse/FLINK-31504 Project: Flink

[jira] [Closed] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-31494. --- Fix Version/s: 1.18.0 Resolution: Fixed Fixed in master: ba03d4db7ca01c7a2436253b9f9429a2a3fb3219 >

[jira] [Comment Edited] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701863#comment-17701863 ] Jark Wu edited comment on FLINK-31494 at 3/17/23 3:42 PM: -- Fixed in master:

[GitHub] [flink] wuchong merged pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
wuchong merged PR #22205: URL: https://github.com/apache/flink/pull/22205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wuchong commented on pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
wuchong commented on PR #22205: URL: https://github.com/apache/flink/pull/22205#issuecomment-1474031293 Thank you for the review @xuzhiwen1255 . Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] wuchong commented on a diff in pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
wuchong commented on code in PR #22205: URL: https://github.com/apache/flink/pull/22205#discussion_r1140393596 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java: ## @@ -285,11 +287,18 @@ public static

[jira] [Commented] (FLINK-31503) "org.apache.beam.sdk.options.PipelineOptionsRegistrar: Provider org.apache.beam.sdk.options.DefaultPipelineOptionsRegistrar not a subtype" is thrown when executing Pyt

2023-03-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701861#comment-17701861 ] Dian Fu commented on FLINK-31503: - If your Flink version doesn't contain this fix, you could simply work

[jira] [Assigned] (FLINK-31499) Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-31499: --- Assignee: xuzhiwen > Move SqlCreateTable conversion logic to SqlCreateTableConverter >

[jira] [Closed] (FLINK-31478) TypeError: a bytes-like object is required, not 'JavaList' is thrown when ds.execute_and_collect() is called on a KeyedStream

2023-03-17 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-31478. --- Fix Version/s: 1.16.2 1.18.0 1.17.1 Resolution: Fixed Fixed

[GitHub] [flink] dianfu closed pull request #22190: [FLINK-31478][python] Fix ds.execute_and_collect to support nested tuple

2023-03-17 Thread via GitHub
dianfu closed pull request #22190: [FLINK-31478][python] Fix ds.execute_and_collect to support nested tuple URL: https://github.com/apache/flink/pull/22190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #22206: [FLINK-31503][python] Makes sure it loads Beam classes using the same class loader as the PyFlink classes

2023-03-17 Thread via GitHub
flinkbot commented on PR #22206: URL: https://github.com/apache/flink/pull/22206#issuecomment-1473992293 ## CI report: * a0428979c1e0b2870fe6e2710e2584e0ae531420 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31503) "org.apache.beam.sdk.options.PipelineOptionsRegistrar: Provider org.apache.beam.sdk.options.DefaultPipelineOptionsRegistrar not a subtype" is thrown when executing Pytho

2023-03-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31503: --- Labels: pull-request-available (was: ) >

[GitHub] [flink] dianfu opened a new pull request, #22206: [FLINK-31503][python] Makes sure it loads Beam classes using the same class loader as the PyFlink classes

2023-03-17 Thread via GitHub
dianfu opened a new pull request, #22206: URL: https://github.com/apache/flink/pull/22206 … ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid

[GitHub] [flink] reswqa commented on pull request #22161: [FLINK-31405] Refactor tests to git rid of timeout of CompletableFuture assertions.

2023-03-17 Thread via GitHub
reswqa commented on PR #22161: URL: https://github.com/apache/flink/pull/22161#issuecomment-1473941258 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-31503) "org.apache.beam.sdk.options.PipelineOptionsRegistrar: Provider org.apache.beam.sdk.options.DefaultPipelineOptionsRegistrar not a subtype" is thrown when executing Pytho

2023-03-17 Thread Dian Fu (Jira)
Dian Fu created FLINK-31503: --- Summary: "org.apache.beam.sdk.options.PipelineOptionsRegistrar: Provider org.apache.beam.sdk.options.DefaultPipelineOptionsRegistrar not a subtype" is thrown when executing Python UDFs in SQL Client Key:

[GitHub] [flink] xuzhiwen1255 commented on pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
xuzhiwen1255 commented on PR #22205: URL: https://github.com/apache/flink/pull/22205#issuecomment-1473881727 LGTM. Thank you @wuchong for contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
xuzhiwen1255 commented on code in PR #22205: URL: https://github.com/apache/flink/pull/22205#discussion_r1140254867 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java: ## @@ -285,11 +287,18 @@ public

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-17 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1140236168 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1050,6 +1055,14 @@ public

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-17 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1140235833 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1050,6 +1055,14 @@ public

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-17 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1140223431 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1213,4 +1268,17 @@ T transitionToState(StateFactory

[jira] [Commented] (FLINK-31499) Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread xuzhiwen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701719#comment-17701719 ] xuzhiwen commented on FLINK-31499: -- [~jark] Can you assign it to me. > Move SqlCreateTable conversion

[jira] [Created] (FLINK-31502) Limit the number of concurrent scale operations to reduce cluster churn

2023-03-17 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-31502: -- Summary: Limit the number of concurrent scale operations to reduce cluster churn Key: FLINK-31502 URL: https://issues.apache.org/jira/browse/FLINK-31502

[jira] [Commented] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701683#comment-17701683 ] Jark Wu commented on FLINK-31494: - [~xzw0223], the key idea is not putting all the conversion logic in a

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-03-17 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701681#comment-17701681 ] Maximilian Michels commented on FLINK-31135: Oh, just realized this is unrelated to

[jira] [Reopened] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-03-17 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-31135: > ConfigMap DataSize went > 1 MB and cluster stopped working >

[jira] [Resolved] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-03-17 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-31135. Resolution: Duplicate Closing because this has been resolved already on the main

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-03-17 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701679#comment-17701679 ] Maximilian Michels commented on FLINK-31135: This has been addressed in FLINK-31345. >

[GitHub] [flink] luoyuxia commented on a diff in pull request #22202: [FLINK-29177][hive] Shade org.apache.commons.lang3 in flink-sql-connector-hive to avoid potential class conflict

2023-03-17 Thread via GitHub
luoyuxia commented on code in PR #22202: URL: https://github.com/apache/flink/pull/22202#discussion_r1140150472 ## flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml: ## @@ -115,6 +115,10 @@ under the License.

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-17 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1140149272 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,485 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink] luoyuxia commented on a diff in pull request #22202: [FLINK-29177][hive] Shade org.apache.commons.lang3 in flink-sql-connector-hive to avoid potential class conflict

2023-03-17 Thread via GitHub
luoyuxia commented on code in PR #22202: URL: https://github.com/apache/flink/pull/22202#discussion_r1140146575 ## flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml: ## @@ -115,6 +115,10 @@ under the License.

[GitHub] [flink] luoyuxia commented on a diff in pull request #22197: [FLINK-31487][table-planner] Add targetColumns to DynamicTableSink#Context

2023-03-17 Thread via GitHub
luoyuxia commented on code in PR #22197: URL: https://github.com/apache/flink/pull/22197#discussion_r1139990233 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java: ## @@ -167,6 +168,26 @@ interface Context { *

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-17 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1140145036 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,485 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-17 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1140138561 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,485 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-17 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1140137456 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,485 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[jira] [Created] (FLINK-31501) Move SqlCreateView conversion logic to SqlCreateViewConverter

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31501: --- Summary: Move SqlCreateView conversion logic to SqlCreateViewConverter Key: FLINK-31501 URL: https://issues.apache.org/jira/browse/FLINK-31501 Project: Flink Issue

[jira] [Created] (FLINK-31500) Move SqlAlterTableSchema conversion logic to AlterTableSchemaConverter

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31500: --- Summary: Move SqlAlterTableSchema conversion logic to AlterTableSchemaConverter Key: FLINK-31500 URL: https://issues.apache.org/jira/browse/FLINK-31500 Project: Flink

[jira] [Created] (FLINK-31499) Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-17 Thread Jark Wu (Jira)
Jark Wu created FLINK-31499: --- Summary: Move SqlCreateTable conversion logic to SqlCreateTableConverter Key: FLINK-31499 URL: https://issues.apache.org/jira/browse/FLINK-31499 Project: Flink Issue

[GitHub] [flink] flinkbot commented on pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
flinkbot commented on PR #22205: URL: https://github.com/apache/flink/pull/22205#issuecomment-1473709150 ## CI report: * c91d41a200babd67477dd8288f41cf77936ee318 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] wuchong commented on pull request #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
wuchong commented on PR #22205: URL: https://github.com/apache/flink/pull/22205#issuecomment-1473704387 @luoyuxia @xuzhiwen1255 , would be appreciated if you could help to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31494: --- Labels: pull-request-available (was: ) > Introduce SqlNodeConverter for

[GitHub] [flink] wuchong opened a new pull request, #22205: [FLINK-31494][table-planner] Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread via GitHub
wuchong opened a new pull request, #22205: URL: https://github.com/apache/flink/pull/22205 ## What is the purpose of the change Similar to [FLINK-31368](https://issues.apache.org/jira/browse/FLINK-31368), the `SqlToOperationConverter` is a bit bloated. This PR is aiming to

[jira] [Updated] (FLINK-31489) OperationManagerTest.testCloseOperation failed because it couldn't find a submitted operation

2023-03-17 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-31489: --- Fix Version/s: 1.17.1 > OperationManagerTest.testCloseOperation failed because it couldn't find a

[jira] [Resolved] (FLINK-31489) OperationManagerTest.testCloseOperation failed because it couldn't find a submitted operation

2023-03-17 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-31489. Fix Version/s: 1.18.0 (was: 1.17.0) Resolution: Fixed >

[jira] [Comment Edited] (FLINK-31489) OperationManagerTest.testCloseOperation failed because it couldn't find a submitted operation

2023-03-17 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701652#comment-17701652 ] Leonard Xu edited comment on FLINK-31489 at 3/17/23 11:35 AM: -- Fixed in :

[GitHub] [flink] leonardBang merged pull request #22200: [FLINK-31489][sql-gateway] Fix instable OperationManagerTest.testCloseOperation

2023-03-17 Thread via GitHub
leonardBang merged PR #22200: URL: https://github.com/apache/flink/pull/22200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1139825377 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,12 +52,12 @@ * Store the meta of

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-17 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1139807707 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -199,15 +200,21 @@ public SequenceNumber

[jira] [Commented] (FLINK-31489) OperationManagerTest.testCloseOperation failed because it couldn't find a submitted operation

2023-03-17 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701652#comment-17701652 ] Leonard Xu commented on FLINK-31489: Fixed in : master: ff08c7b1d7fb9334d624aa74bc5788d4d7ac1edc

[jira] [Updated] (FLINK-31489) OperationManagerTest.testCloseOperation failed because it couldn't find a submitted operation

2023-03-17 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-31489: --- Priority: Major (was: Critical) > OperationManagerTest.testCloseOperation failed because it

[GitHub] [flink] leonardBang merged pull request #22199: [FLINK-31489][sql-gateway] Fix instable OperationManagerTest.testCloseOperation

2023-03-17 Thread via GitHub
leonardBang merged PR #22199: URL: https://github.com/apache/flink/pull/22199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] Aitozi commented on a diff in pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

2023-03-17 Thread via GitHub
Aitozi commented on code in PR #22179: URL: https://github.com/apache/flink/pull/22179#discussion_r1140063123 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SupportsShowLikeOperation.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache

[GitHub] [flink] flinkbot commented on pull request #22204: [Flink 31170] [docs]The spelling error of the document word causes sq…

2023-03-17 Thread via GitHub
flinkbot commented on PR #22204: URL: https://github.com/apache/flink/pull/22204#issuecomment-1473630712 ## CI report: * c2ef221f4397634df80b1dd2372bc9c423c2627b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] BoYiZhang opened a new pull request, #22204: [Flink 31170] [docs]The spelling error of the document word causes sq…

2023-03-17 Thread via GitHub
BoYiZhang opened a new pull request, #22204: URL: https://github.com/apache/flink/pull/22204 ## What is the purpose of the change - *Fix spelling errors in the create table statement* ## Brief change log - *The create table statement provided by the document is

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #58: [FLINK-16003][Connectors/Kinesis] Log non-retriable Kinesis exceptions from getRecords

2023-03-17 Thread via GitHub
dannycranmer commented on code in PR #58: URL: https://github.com/apache/flink-connector-aws/pull/58#discussion_r1140050195 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java: ## @@ -313,6 +313,9 @@ public

[jira] [Comment Edited] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread xuzhiwen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701631#comment-17701631 ] xuzhiwen edited comment on FLINK-31494 at 3/17/23 10:14 AM: Hi [~jark] ,

[jira] [Commented] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread xuzhiwen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701631#comment-17701631 ] xuzhiwen commented on FLINK-31494: -- hi [~jark] , Will SqlNodeConverters register all SQLnodes? My

[GitHub] [flink] leonardBang commented on pull request #22201: [FLINK-30959][table][doc-zh] Improve the documentation of UNIX_TIMESTAMP function for different argument formats

2023-03-17 Thread via GitHub
leonardBang commented on PR #22201: URL: https://github.com/apache/flink/pull/22201#issuecomment-1473599179 @ruanhang1993 Could we can create a new JIRA issue to track the translation for all sql function? I found some content of these function is outdated. -- This is an automated

[jira] [Created] (FLINK-31498) DeclartiveSlotManager always request redundant task manager when resource is not enough

2023-03-17 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-31498: - Summary: DeclartiveSlotManager always request redundant task manager when resource is not enough Key: FLINK-31498 URL: https://issues.apache.org/jira/browse/FLINK-31498

[jira] [Comment Edited] (FLINK-30959) Improve the documentation of UNIX_TIMESTAMP for different argument format

2023-03-17 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700745#comment-17700745 ] Leonard Xu edited comment on FLINK-30959 at 3/17/23 10:09 AM: -- Resolved in: 

[jira] [Updated] (FLINK-31494) Introduce SqlNodeConverter for SqlToOperationConverter

2023-03-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-31494: Description: Introduce {{SqlNodeConverter}} for {{SqlToOperationConverter}}, following Timo's idea in

[GitHub] [flink] leonardBang merged pull request #22186: [FLINK-30959][table][docs] Improve the documentation of UNIX_TIMESTAMP function for different argument formats

2023-03-17 Thread via GitHub
leonardBang merged PR #22186: URL: https://github.com/apache/flink/pull/22186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >