[GitHub] [flink] flinkbot commented on pull request #22387: [FLINK-31790] Respect the PartitionCommitPolicy for batch Filesystem …

2023-04-12 Thread via GitHub
flinkbot commented on PR #22387: URL: https://github.com/apache/flink/pull/22387#issuecomment-1506365720 ## CI report: * 1eec46aa7862cd78d0bcd62b27d3b44f8c4df491 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31790) Filesystem batch sink should also respect to the PartitionCommitPolicy

2023-04-12 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711683#comment-17711683 ] Aitozi commented on FLINK-31790: CC [~luoyuxia] > Filesystem batch sink should also respect to the

[jira] [Updated] (FLINK-31790) Filesystem batch sink should also respect to the PartitionCommitPolicy

2023-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31790: --- Labels: pull-request-available (was: ) > Filesystem batch sink should also respect to the

[GitHub] [flink] liuyongvs commented on a diff in pull request #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-04-12 Thread via GitHub
liuyongvs commented on code in PR #22324: URL: https://github.com/apache/flink/pull/22324#discussion_r1165012228 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/MapFromEntriesInputTypeStrategy.java: ## @@ -0,0 +1,75 @@ +/* + *

[GitHub] [flink] Aitozi opened a new pull request, #22387: [FLINK-31790] Respect the PartitionCommitPolicy for batch Filesystem …

2023-04-12 Thread via GitHub
Aitozi opened a new pull request, #22387: URL: https://github.com/apache/flink/pull/22387 …mode ## What is the purpose of the change This PR is meant to add the partition commit policy for the filesystem batch mode. ## Brief change log *(for example:)* -

[jira] [Closed] (FLINK-31767) Improve the implementation for "analyze table" execution on partitioned table

2023-04-12 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-31767. -- Fix Version/s: 1.18.0 Resolution: Fixed Fixed in master:

[GitHub] [flink] godfreyhe closed pull request #22376: [FLINK-31767][table-planner] Improve the implementation for "analyze table" execution on partitioned table

2023-04-12 Thread via GitHub
godfreyhe closed pull request #22376: [FLINK-31767][table-planner] Improve the implementation for "analyze table" execution on partitioned table URL: https://github.com/apache/flink/pull/22376 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164941748 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -49,7 +49,11 @@ * * The size of this pool can be dynamically

[GitHub] [flink] reswqa commented on pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on PR #22381: URL: https://github.com/apache/flink/pull/22381#issuecomment-1506298316 Thanks @1996fanrui for the quick reply, I have updated this, PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164959231 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -766,13 +776,12 @@ private void returnExcessMemorySegments() {

[GitHub] [flink] Aitozi commented on a diff in pull request #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-04-12 Thread via GitHub
Aitozi commented on code in PR #22324: URL: https://github.com/apache/flink/pull/22324#discussion_r1164956399 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/MapFromEntriesInputTypeStrategy.java: ## @@ -0,0 +1,75 @@ +/* + *

[GitHub] [flink] godfreyhe commented on pull request #22376: [FLINK-31767][table-planner] Improve the implementation for "analyze table" execution on partitioned table

2023-04-12 Thread via GitHub
godfreyhe commented on PR #22376: URL: https://github.com/apache/flink/pull/22376#issuecomment-1506292921 Thanks for the review, I will merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-31655) Adaptive Channel selection for partitioner

2023-04-12 Thread tartarus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711663#comment-17711663 ] tartarus commented on FLINK-31655: -- Hi [~akalash]  thanks for your reminder! In our company, adaptive

[jira] [Updated] (FLINK-31764) Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31764: --- Description: After FLINK-31763, we don't need the specific field

[jira] [Updated] (FLINK-31764) Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31764: --- Description: After FLINK-31763, we don't need the specific field

[jira] [Assigned] (FLINK-31374) ProxyStreamPartitioner should implement ConfigurableStreamPartitioner

2023-04-12 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang reassigned FLINK-31374: - Assignee: Jiang Xin (was: jiangxin li) > ProxyStreamPartitioner should implement

[jira] [Updated] (FLINK-30888) Flink Doc(zh version) has misspelled words

2023-04-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-30888: -- Fix Version/s: 1.18.0 > Flink Doc(zh version) has misspelled words >

[jira] [Updated] (FLINK-31764) Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31764: --- Description: After FLINK-31763, we are no longer need the specific field

[jira] [Commented] (FLINK-30888) Flink Doc(zh version) has misspelled words

2023-04-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711658#comment-17711658 ] Yuxin Tan commented on FLINK-30888: --- I found the typo has been fixed.

[jira] [Closed] (FLINK-30888) Flink Doc(zh version) has misspelled words

2023-04-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-30888. - Release Note: I found the typo has been fixed.

[jira] [Updated] (FLINK-30888) Flink Doc(zh version) has misspelled words

2023-04-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-30888: -- Release Note: (was: I found the typo has been fixed.

[jira] [Updated] (FLINK-31764) Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31764: --- Description: After FLINK-31763, we are no longer need the specific  (was: After FLINK-31763) >

[jira] [Updated] (FLINK-31764) Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31764: --- Description: After FLINK-31763 (was: We can changes the definition of overdraft buffer from static

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164944912 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -671,13 +675,20 @@ public void setNumBuffers(int numBuffers) {

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Ensure that the total number of requested buffers does not exceed poolSize + maxOverdraftBuffersPerGate

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164941748 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -49,7 +49,11 @@ * * The size of this pool can be dynamically

[jira] [Commented] (FLINK-27719) Create Apache Flink slack workspace

2023-04-12 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711656#comment-17711656 ] Xintong Song commented on FLINK-27719: -- Yes. Thanks for the reminder. > Create Apache Flink slack

[jira] [Closed] (FLINK-27723) Slack: revisit how this communication channel works

2023-04-12 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-27723. Resolution: Resolved > Slack: revisit how this communication channel works >

[jira] [Closed] (FLINK-27719) Create Apache Flink slack workspace

2023-04-12 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-27719. Resolution: Resolved > Create Apache Flink slack workspace > ---

[jira] [Updated] (FLINK-31763) Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31763: --- Description: As we discussed in FLINK-31610, new buffers can be requested only when

[jira] [Updated] (FLINK-31763) Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31763: --- Summary: Convert requested buffers to overdraft buffers when pool size is decreased (was: Ensure

[jira] [Created] (FLINK-31791) FLIP-292: Enhance COMPILED PLAN to support operator-level state TTL configuration

2023-04-12 Thread Jane Chan (Jira)
Jane Chan created FLINK-31791: - Summary: FLIP-292: Enhance COMPILED PLAN to support operator-level state TTL configuration Key: FLINK-31791 URL: https://issues.apache.org/jira/browse/FLINK-31791 Project:

[jira] [Commented] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-04-12 Thread jinghaihang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711654#comment-17711654 ] jinghaihang commented on FLINK-31743: - Hi [~roman]  Previously, Tang Yun and I discussed a two-step

[jira] [Commented] (FLINK-31530) For currently commonly used databases, MySQL and Postgres have implemented catalogs. Currently, catalogs are implemented based on Oracle

2023-04-12 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711649#comment-17711649 ] xingyuan cheng commented on FLINK-31530: The use of OracleCatalog is similar to that of official

[jira] [Commented] (FLINK-27719) Create Apache Flink slack workspace

2023-04-12 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711648#comment-17711648 ] Yun Tang commented on FLINK-27719: -- I think this ticket shall be marked as resolved, right? [~xtsong]

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22381: [FLINK-31763][runtime] Ensure that the total number of requested buffers does not exceed poolSize + maxOverdraftBuffersPerGate

2023-04-12 Thread via GitHub
1996fanrui commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164914879 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -671,13 +675,20 @@ public void setNumBuffers(int numBuffers) {

[jira] [Created] (FLINK-31790) Filesystem batch sink should also respect to the PartitionCommitPolicy

2023-04-12 Thread Aitozi (Jira)
Aitozi created FLINK-31790: -- Summary: Filesystem batch sink should also respect to the PartitionCommitPolicy Key: FLINK-31790 URL: https://issues.apache.org/jira/browse/FLINK-31790 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc

2023-04-12 Thread via GitHub
flinkbot commented on PR #22386: URL: https://github.com/apache/flink/pull/22386#issuecomment-1506226134 ## CI report: * a350087241b4eee9260a12f3f91181d3bc10109b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31787) Add the explicit ROW constructor to the system function doc

2023-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31787: --- Labels: pull-request-available (was: ) > Add the explicit ROW constructor to the system

[GitHub] [flink] Aitozi opened a new pull request, #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc

2023-04-12 Thread via GitHub
Aitozi opened a new pull request, #22386: URL: https://github.com/apache/flink/pull/22386 ## What is the purpose of the change Add back the explicit ROW constructor to doc ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job

[jira] [Closed] (FLINK-28484) UniqueKey inference should respect the semantics of null as well as consider the possibility of precision loss from implicit conversions

2023-04-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-28484. --- Resolution: Not A Bug This is not a bug after revisit the code > UniqueKey inference should

[GitHub] [flink] slfan1989 commented on pull request #22374: [FLINK-31761] Fix Some Typo And Improve lambda expressions.

2023-04-12 Thread via GitHub
slfan1989 commented on PR #22374: URL: https://github.com/apache/flink/pull/22374#issuecomment-1506183387 @reswqa @1996fanrui Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-31761) Fix Some Typo And Improve lambda expressions.

2023-04-12 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711623#comment-17711623 ] Shilun Fan commented on FLINK-31761: [~martijnvisser] Thanks for your message! > Fix Some Typo And

[GitHub] [flink] FangYongs commented on a diff in pull request #22360: [FLINK-31741][jdbc-driver] Support data converter for value in statement result

2023-04-12 Thread via GitHub
FangYongs commented on code in PR #22360: URL: https://github.com/apache/flink/pull/22360#discussion_r1164814536 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/utils/StringDataConverter.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (FLINK-31787) Add the explicit ROW constructor to the system function doc

2023-04-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-31787: -- Assignee: Aitozi > Add the explicit ROW constructor to the system function doc >

[GitHub] [flink] hustonic commented on pull request #22370: [hotfix] Fix typos of comment

2023-04-12 Thread via GitHub
hustonic commented on PR #22370: URL: https://github.com/apache/flink/pull/22370#issuecomment-1506133377 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-16868) Table/SQL doesn't support custom trigger

2023-04-12 Thread Chalres Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711590#comment-17711590 ] Chalres Tan commented on FLINK-16868: - hi [~jark], I was looking around for a way to perform early

[GitHub] [flink-connector-mongodb] dannycranmer merged pull request #6: [hotfix] Fix incompatible archunit version

2023-04-12 Thread via GitHub
dannycranmer merged PR #6: URL: https://github.com/apache/flink-connector-mongodb/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22385: [hotfix] [docs] Fix documentation hyperlink to table formats (to master)

2023-04-12 Thread via GitHub
flinkbot commented on PR #22385: URL: https://github.com/apache/flink/pull/22385#issuecomment-1505873875 ## CI report: * 57b89bec3f61af58a89a2c742b71eb191671c5ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] novakov-alexey closed pull request #22231: [hotfix] [docs] Fix documentation hyperlink to table formats

2023-04-12 Thread via GitHub
novakov-alexey closed pull request #22231: [hotfix] [docs] Fix documentation hyperlink to table formats URL: https://github.com/apache/flink/pull/22231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] novakov-alexey commented on pull request #22231: [hotfix] [docs] Fix documentation hyperlink to table formats

2023-04-12 Thread via GitHub
novakov-alexey commented on PR #22231: URL: https://github.com/apache/flink/pull/22231#issuecomment-1505870495 @MartijnVisser I've create new PR. This time to master branch: https://github.com/apache/flink/pull/22385 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] novakov-alexey opened a new pull request, #22385: [hotfix] [docs] Fix documentation hyperlink to table formats (to master)

2023-04-12 Thread via GitHub
novakov-alexey opened a new pull request, #22385: URL: https://github.com/apache/flink/pull/22385 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[GitHub] [flink-kubernetes-operator] rodmeneses commented on a diff in pull request #563: [FLINK-31716] Event UID field is missing the first time that an event…

2023-04-12 Thread via GitHub
rodmeneses commented on code in PR #563: URL: https://github.com/apache/flink-kubernetes-operator/pull/563#discussion_r1164504549 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -217,9 +227,10

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #563: [FLINK-31716] Event UID field is missing the first time that an event…

2023-04-12 Thread via GitHub
morhidi commented on code in PR #563: URL: https://github.com/apache/flink-kubernetes-operator/pull/563#discussion_r1164497734 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -217,9 +227,10 @@

[jira] [Created] (FLINK-31789) Update axel to current

2023-04-12 Thread Morey Straus (Jira)
Morey Straus created FLINK-31789: Summary: Update axel to current Key: FLINK-31789 URL: https://issues.apache.org/jira/browse/FLINK-31789 Project: Flink Issue Type: Bug Affects Versions:

[GitHub] [flink] mohsenrezaeithe commented on pull request #21849: [FLINK-30596][Runtime/REST] Fix duplicate jobs when submitting with the same jobId

2023-04-12 Thread via GitHub
mohsenrezaeithe commented on PR #21849: URL: https://github.com/apache/flink/pull/21849#issuecomment-1505672063 @zentol when you get a chance, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] mohsenrezaeithe commented on pull request #22302: [hotfix] [docs] Fix `ROW()` decleration syntax

2023-04-12 Thread via GitHub
mohsenrezaeithe commented on PR #22302: URL: https://github.com/apache/flink/pull/22302#issuecomment-1505666939 @wuchong, thanks for pointing that out. Chinese docs are gtg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] XComp commented on a diff in pull request #22317: [FLINK-29334][runtime] Remove releaseAndTryRemoveAll in StateHandleStore

2023-04-12 Thread via GitHub
XComp commented on code in PR #22317: URL: https://github.com/apache/flink/pull/22317#discussion_r1164423432 ## flink-runtime/src/test/java/org/apache/flink/runtime/persistence/TestingStateHandleStore.java: ## @@ -121,11 +121,6 @@ public boolean releaseAndTryRemove(String name)

[jira] [Closed] (FLINK-31363) KafkaSink failed to commit transactions under EXACTLY_ONCE semantics

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-31363. --- Resolution: Fixed Merged via flink-connector-kafka

[jira] [Updated] (FLINK-31363) KafkaSink failed to commit transactions under EXACTLY_ONCE semantics

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31363: Priority: Blocker (was: Major) > KafkaSink failed to commit transactions under

[jira] [Updated] (FLINK-31363) KafkaSink failed to commit transactions under EXACTLY_ONCE semantics

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31363: Fix Version/s: kafka-3.0.0 > KafkaSink failed to commit transactions under

[jira] [Updated] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31305: Priority: Blocker (was: Major) > KafkaWriter doesn't wait for errors for

[jira] [Updated] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31620: Priority: Blocker (was: Critical) > ReducingUpsertWriter does not flush the

[jira] [Updated] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-04-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30765: -- Affects Version/s: 1.18.0 (was: 1.17.0) >

[jira] [Updated] (FLINK-24456) Support bounded offset in the Kafka table connector

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-24456: Fix Version/s: (was: kafka-3.0.0) > Support bounded offset in the Kafka table

[jira] [Updated] (FLINK-31319) Kafka new source partitionDiscoveryIntervalMs=0 cause bounded source can not quit

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31319: Fix Version/s: kafka-3.0.0 > Kafka new source partitionDiscoveryIntervalMs=0

[jira] [Updated] (FLINK-24456) Support bounded offset in the Kafka table connector

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-24456: Fix Version/s: kafka-3.0.0 > Support bounded offset in the Kafka table connector

[jira] [Resolved] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-04-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30765. --- Resolution: Fixed master: 3e4f653ffa0e9b86d82b1c1a00a1523e0891635b >

[jira] [Updated] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-04-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30765: -- Fix Version/s: 1.18.0 > LeaderElectionService.stop should always call revokeLeadership >

[jira] [Closed] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-31305. --- Resolution: Fixed Merged to flink-connector-kafka via: * v3.0 -

[jira] [Updated] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31620: Fix Version/s: kafka-3.0.0 > ReducingUpsertWriter does not flush the wrapped

[jira] [Closed] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-31620. --- Resolution: Fixed Merged to flink-connector-kafka via

[GitHub] [flink] XComp merged pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

2023-04-12 Thread via GitHub
XComp merged PR #21742: URL: https://github.com/apache/flink/pull/21742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31305: Fix Version/s: kafka-3.0.0 (was: 1.18.0) > KafkaWriter

[jira] [Updated] (FLINK-31599) Update Kafka dependency in flink-connector-kafka to 3.4.0

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31599: Fix Version/s: kafka-3.1.0 (was: kafka-5.0.0) > Update

[jira] [Updated] (FLINK-31740) Allow setting boundedness for upsert-kafka SQL connector

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31740: Fix Version/s: kafka-3.1.0 (was: kafka-4.1.0) > Allow

[jira] [Updated] (FLINK-30963) Switch binary downloads to archive.apache.org

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-30963: Fix Version/s: kafka-3.0.0 (was: kafka-3.0.1) > Switch

[jira] [Updated] (FLINK-30996) Sync Kafka 1.17 commits from apache/flink repo to flink-connector-kafka

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-30996: Fix Version/s: kafka-3.0.0 (was: kafka-4.0.0) > Sync Kafka

[jira] [Closed] (FLINK-25916) Using upsert-kafka with a flush buffer results in Null Pointer Exception

2023-04-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-25916. --- Resolution: Fixed > Using upsert-kafka with a flush buffer results in Null Pointer

[jira] [Commented] (FLINK-31765) Disable changelog backend for the StatefulJobSavepointMigrationITCase and StatefulJobWBroadcastStateMigrationITCase with RocksDB and checkpoints

2023-04-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711487#comment-17711487 ] Matthias Pohl commented on FLINK-31765: --- After a

[jira] [Updated] (FLINK-31765) Disable changelog backend for the StatefulJobSavepointMigrationITCase and StatefulJobWBroadcastStateMigrationITCase with RocksDB and checkpoints

2023-04-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31765: -- Affects Version/s: (was: 1.17.0) > Disable changelog backend for the

[jira] [Updated] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-12 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-31788: - Description: This feature was originally implemented in the old planner: 

[jira] [Updated] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-12 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-31788: - Description: This feature was originally implemented in the old planner: 

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711443#comment-17711443 ] Martijn Visser commented on FLINK-31788: [~twalthr] WDYT? > Add back Support

[jira] [Comment Edited] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-12 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711440#comment-17711440 ] Sergio Sainz edited comment on FLINK-31775 at 4/12/23 3:18 PM: --- Another

[jira] [Commented] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-12 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711440#comment-17711440 ] Sergio Sainz commented on FLINK-31775: -- Another confusion about how the fix for  FLINK-28171 can

[jira] [Created] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2023-04-12 Thread Feng Jin (Jira)
Feng Jin created FLINK-31788: Summary: Add back Support emitValueWithRetract for TableAggregateFunction Key: FLINK-31788 URL: https://issues.apache.org/jira/browse/FLINK-31788 Project: Flink

[GitHub] [flink] MartijnVisser merged pull request #22310: [hotfix][doc] Fix the incorrect description for TO_TIMESTAMP function

2023-04-12 Thread via GitHub
MartijnVisser merged PR #22310: URL: https://github.com/apache/flink/pull/22310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] hackergin commented on pull request #22310: [hotfix][doc] Fix the incorrect description for TO_TIMESTAMP function

2023-04-12 Thread via GitHub
hackergin commented on PR #22310: URL: https://github.com/apache/flink/pull/22310#issuecomment-1505420389 @MartijnVisser Thank you for the suggestion, I have updated the pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-31761) Fix Some Typo And Improve lambda expressions.

2023-04-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711430#comment-17711430 ] Martijn Visser commented on FLINK-31761: [~slfan1989] Next time, as outlined on

[jira] [Closed] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-04-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31757. -- Resolution: Invalid [~RocMarshal] When the ticket is updated, I can re-open it again. Right

[jira] [Commented] (FLINK-31749) The Using Hadoop OutputFormats example is not avaliable for DataStream

2023-04-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711428#comment-17711428 ] Martijn Visser commented on FLINK-31749: [~echauchot] WDYT? Did we make a mistake by including

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22377: [FLINK-31765][runtime][test] Disable changelog backend for RocksDB migration tests

2023-04-12 Thread via GitHub
rkhachatryan commented on code in PR #22377: URL: https://github.com/apache/flink/pull/22377#discussion_r1164249518 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/StatefulJobSnapshotMigrationITCase.java: ## @@ -136,6 +136,12 @@ public void testSavepoint()

[jira] [Commented] (FLINK-31787) Add the explicit ROW constructor to the system function doc

2023-04-12 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711427#comment-17711427 ] Aitozi commented on FLINK-31787: see discussion in this ticket:

[jira] [Created] (FLINK-31787) Add the explicit ROW constructor to the system function doc

2023-04-12 Thread Aitozi (Jira)
Aitozi created FLINK-31787: -- Summary: Add the explicit ROW constructor to the system function doc Key: FLINK-31787 URL: https://issues.apache.org/jira/browse/FLINK-31787 Project: Flink Issue Type:

[GitHub] [flink] MartijnVisser closed pull request #22203: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md

2023-04-12 Thread via GitHub
MartijnVisser closed pull request #22203: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md URL: https://github.com/apache/flink/pull/22203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] MartijnVisser commented on pull request #22203: [hotfix] [doc] Fix the configuration item error of docs/content.zh/docs/connectors/table/jdbc.md

2023-04-12 Thread via GitHub
MartijnVisser commented on PR #22203: URL: https://github.com/apache/flink/pull/22203#issuecomment-1505401586 @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-31780) Allow users to disable "Ensemble tracking" for ZooKeeper

2023-04-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31780: --- Issue Type: Improvement (was: Bug) > Allow users to disable "Ensemble tracking" for

[jira] [Created] (FLINK-31786) Removing unused HighAvailabilityServices implementations

2023-04-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-31786: - Summary: Removing unused HighAvailabilityServices implementations Key: FLINK-31786 URL: https://issues.apache.org/jira/browse/FLINK-31786 Project: Flink

[jira] [Assigned] (FLINK-31786) Removing unused HighAvailabilityServices implementations

2023-04-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31786: - Assignee: Matthias Pohl > Removing unused HighAvailabilityServices implementations >

[jira] [Comment Edited] (FLINK-31775) High-Availability not supported in kubernetes when istio enabled

2023-04-12 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711413#comment-17711413 ] Sergio Sainz edited comment on FLINK-31775 at 4/12/23 2:32 PM: --- Hi [~huwh]

  1   2   3   >