[GitHub] [flink] 1996fanrui commented on a diff in pull request #22808: [FLINK-32316] [SourceAlignment] Scheduling announceCombinedWatermark period task during SourceCoordinator::start not in construc

2023-06-21 Thread via GitHub
1996fanrui commented on code in PR #22808: URL: https://github.com/apache/flink/pull/22808#discussion_r1237971048 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -131,6 +136,73 @@ void

[GitHub] [flink] flinkbot commented on pull request #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

2023-06-21 Thread via GitHub
flinkbot commented on PR #22845: URL: https://github.com/apache/flink/pull/22845#issuecomment-1601970488 ## CI report: * 3e53f0587d57073a6db12b1381aaa9ed4fba644d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] 1996fanrui commented on pull request #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

2023-06-21 Thread via GitHub
1996fanrui commented on PR #22845: URL: https://github.com/apache/flink/pull/22845#issuecomment-1601969939 Hi @becketqin @pnowojski @LoveHeat , would you mind help take a look this PR in your free time? thanks~ I have described this bug in detail in FLINK-32411. -- This is an

[jira] [Updated] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32411: --- Labels: pull-request-available (was: ) > SourceCoordinator thread leaks when job recovers

[GitHub] [flink] 1996fanrui opened a new pull request, #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

2023-06-21 Thread via GitHub
1996fanrui opened a new pull request, #22845: URL: https://github.com/apache/flink/pull/22845 ## What is the purpose of the change Fix the bug about SourceCoordinator thread leaks. You can get more detailed background from FLINK-32411. ## Brief change log Closing the

[jira] [Updated] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-21 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32411: Description: SourceCoordinator thread leaks when job recovers from checkpoint, from the following

[jira] [Updated] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-21 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32411: Description: SourceCoordinator thread leaks when job recovers from checkpoint, from the following

[jira] [Updated] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-21 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32411: Attachment: (was: image-2023-06-22-11-00-25-446.png) > SourceCoordinator thread leaks when job

[jira] [Created] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-21 Thread Rui Fan (Jira)
Rui Fan created FLINK-32411: --- Summary: SourceCoordinator thread leaks when job recovers from checkpoint Key: FLINK-32411 URL: https://issues.apache.org/jira/browse/FLINK-32411 Project: Flink

[GitHub] [flink] afedulov commented on pull request #21028: [FLINK-28229][streaming-java] Introduce Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-06-21 Thread via GitHub
afedulov commented on PR #21028: URL: https://github.com/apache/flink/pull/21028#issuecomment-1601564665 @zentol One concerns regarding the idea to migrate the existing methods in `StreamExecutionEnvironment` to `DataGeneratorSource` is that adding the `flink-streaming-java` dependency on

[jira] [Commented] (FLINK-31958) Table to DataStream allow partial fields

2023-06-21 Thread padavan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735812#comment-17735812 ] padavan commented on FLINK-31958: - plz vote to this issue if you often work with models and hit this

[GitHub] [flink] flinkbot commented on pull request #22844: [WIP][FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

2023-06-21 Thread via GitHub
flinkbot commented on PR #22844: URL: https://github.com/apache/flink/pull/22844#issuecomment-1601072224 ## CI report: * 506a625457f00f4c99d8ccc6a8bef17aeb4a5749 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30141) MinioTestContainerTest failed due to IllegalStateException in container startup

2023-06-21 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735782#comment-17735782 ] Ryan Skraba commented on FLINK-30141: - I took a look at this and the related issue FLINK-26402 -- it

[jira] [Updated] (FLINK-31784) Add multiple-component support to DefaultLeaderElectionService

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31784: --- Labels: pull-request-available (was: ) > Add multiple-component support to

[GitHub] [flink] XComp opened a new pull request, #22844: [WIP][FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

2023-06-21 Thread via GitHub
XComp opened a new pull request, #22844: URL: https://github.com/apache/flink/pull/22844 * https://github.com/apache/flink/pull/21742 * https://github.com/apache/flink/pull/22379 * https://github.com/apache/flink/pull/22422 * https://github.com/apache/flink/pull/22380 *

[GitHub] [flink] flinkbot commented on pull request #22843: [FLINK-30141][s3][filesystem] Increase retries on MinIO container startup

2023-06-21 Thread via GitHub
flinkbot commented on PR #22843: URL: https://github.com/apache/flink/pull/22843#issuecomment-1601050461 ## CI report: * ab40ed309eb39c427278658d47dbc2d6dc3139b4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-06-21 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32261: Description: Description: This is an implementation of MAP_UNION  Returns a map created by

[jira] [Updated] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-06-21 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32261: Description: Description: This is an implementation of MAP_UNION  Returns a map created by

[jira] [Updated] (FLINK-30141) MinioTestContainerTest failed due to IllegalStateException in container startup

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30141: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] RyanSkraba opened a new pull request, #22843: [FLINK-30141][s3][filesystem] Increase retries on MinIO container startup

2023-06-21 Thread via GitHub
RyanSkraba opened a new pull request, #22843: URL: https://github.com/apache/flink/pull/22843 ## What is the purpose of the change We observe flaky tests using MinIO about once per month, and it appears to be due to a container responding to API requests with enough **503

[GitHub] [flink] flinkbot commented on pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-21 Thread via GitHub
flinkbot commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1601024848 ## CI report: * 4f26f9375e99db7765ce6a4bf6d161bc8ef4899e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32261: --- Labels: pull-request-available (was: ) > Add MAP_UNION support in SQL & Table API >

[GitHub] [flink] hanyuzheng7 opened a new pull request, #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-21 Thread via GitHub
hanyuzheng7 opened a new pull request, #22842: URL: https://github.com/apache/flink/pull/22842 Description: The current implementation of the map_union method in the Flink library does not provide a way to combine two dictionaries into a single dictionary. This enhancement aims to

[jira] [Closed] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32408. -- Resolution: Fixed > JobManager HA configuration update needed in Flink k8s Operator >

[GitHub] [flink] flinkbot commented on pull request #22841: [FLINK-32410] Allocate hash-based collections with sufficient capacity for expected size

2023-06-21 Thread via GitHub
flinkbot commented on PR #22841: URL: https://github.com/apache/flink/pull/22841#issuecomment-1600948809 ## CI report: * d8f3e1e99759cb5b91f7d560f5fbda643e4255a2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-21 Thread via GitHub
1996fanrui commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1236917373 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-06-21 Thread via GitHub
snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1237090987 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/table/CalcTest.xml: ## @@ -107,14 +107,14 @@

[jira] [Updated] (FLINK-32410) Allocate hash-based collections with sufficient capacity for expected size

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32410: --- Labels: pull-request-available (was: ) > Allocate hash-based collections with sufficient

[GitHub] [flink] StefanRRichter opened a new pull request, #22841: [FLINK-32410] Allocate hash-based collections with sufficient capacity for expected size

2023-06-21 Thread via GitHub
StefanRRichter opened a new pull request, #22841: URL: https://github.com/apache/flink/pull/22841 ## What is the purpose of the change The JDK API to create hash-based collections for a certain capacity is arguably misleading because it doesn't size the collections to "hold a

[jira] [Updated] (FLINK-32409) Moves componentId/contenderID handling from DefaultMultipleComponentLeaderElectionService into DefaultLeaderElectionService

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32409: -- Summary: Moves componentId/contenderID handling from

[jira] [Created] (FLINK-32410) Allocate hash-based collections with sufficient capacity for expected size

2023-06-21 Thread Stefan Richter (Jira)
Stefan Richter created FLINK-32410: -- Summary: Allocate hash-based collections with sufficient capacity for expected size Key: FLINK-32410 URL: https://issues.apache.org/jira/browse/FLINK-32410

[GitHub] [flink] afedulov closed pull request #17314: [WIP][FLINK-22790] HybridSource E2E tests

2023-06-21 Thread via GitHub
afedulov closed pull request #17314: [WIP][FLINK-22790] HybridSource E2E tests URL: https://github.com/apache/flink/pull/17314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] afedulov closed pull request #17215: [FLINK-22790] HybridSource E2E tests

2023-06-21 Thread via GitHub
afedulov closed pull request #17215: [FLINK-22790] HybridSource E2E tests URL: https://github.com/apache/flink/pull/17215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] lincoln-lil commented on a diff in pull request #22827: [FLINK-20887][table-planner] Disable project merge during sql2rel phase by default to avoid incorrectly project merge

2023-06-21 Thread via GitHub
lincoln-lil commented on code in PR #22827: URL: https://github.com/apache/flink/pull/22827#discussion_r1236728489 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/PushProjectIntoTableSourceScanRuleTest.java: ## @@ -352,8

[jira] [Created] (FLINK-32409) Remove MultipleComponentLeaderElectionDriverAdapter

2023-06-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32409: - Summary: Remove MultipleComponentLeaderElectionDriverAdapter Key: FLINK-32409 URL: https://issues.apache.org/jira/browse/FLINK-32409 Project: Flink Issue

[jira] [Assigned] (FLINK-32409) Remove MultipleComponentLeaderElectionDriverAdapter

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32409: - Assignee: Matthias Pohl > Remove MultipleComponentLeaderElectionDriverAdapter >

[jira] [Commented] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735722#comment-17735722 ] Gyula Fora commented on FLINK-32408: If you are using Operator 1.5.0 with Flink 1.17.1 you need to

[jira] [Comment Edited] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735717#comment-17735717 ] dongwoo.kim edited comment on FLINK-32408 at 6/21/23 1:22 PM: -- I think this

[jira] [Comment Edited] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735717#comment-17735717 ] dongwoo.kim edited comment on FLINK-32408 at 6/21/23 1:21 PM: -- I think this

[jira] [Commented] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735717#comment-17735717 ] dongwoo.kim commented on FLINK-32408: - I think this is fixed in new version because in main branch's

[jira] [Updated] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dongwoo.kim updated FLINK-32408: Description: In flink 1.17 documentation it says, to configure job manger ha we have to

[GitHub] [flink] XComp commented on pull request #22661: [WIP][FLINK-31783][runtime] Migrates DefaultLeaderElectionService from LeaderElectionDriver to the MultipleComponentLeaderElectionDriver interf

2023-06-21 Thread via GitHub
XComp commented on PR #22661: URL: https://github.com/apache/flink/pull/22661#issuecomment-1600813763 https://github.com/apache/flink/pull/22661/commits/4338f36dee313ca5d5901a753961323e9f299372 is the "initial" commit that refactors the interfaces. The outcome were failing test because I

[jira] [Updated] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dongwoo.kim updated FLINK-32408: Description: In flink 1.17 documentation it says, to configure job manger ha we have to

[jira] [Created] (FLINK-32408) JobManager HA configuration update needed in Flink k8s Operator

2023-06-21 Thread dongwoo.kim (Jira)
dongwoo.kim created FLINK-32408: --- Summary: JobManager HA configuration update needed in Flink k8s Operator Key: FLINK-32408 URL: https://issues.apache.org/jira/browse/FLINK-32408 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #22840: [WIP][FLINK-32376] Extend Sink#InitContext

2023-06-21 Thread via GitHub
flinkbot commented on PR #22840: URL: https://github.com/apache/flink/pull/22840#issuecomment-1600790449 ## CI report: * 7495b60bb3d5c27b68bc9b79d733ca1c9b9758b7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32376) [FLIP-287] Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and JobID

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32376: --- Labels: pull-request-available (was: ) > [FLIP-287] Extend Sink#InitContext to expose

[GitHub] [flink] eskabetxe opened a new pull request, #22840: [WIP][FLINK-32376] Extend Sink#InitContext

2023-06-21 Thread via GitHub
eskabetxe opened a new pull request, #22840: URL: https://github.com/apache/flink/pull/22840 ## What is the purpose of the change Address the [FLIP-287 Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-21 Thread via GitHub
1996fanrui commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1236917373 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] flinkbot commented on pull request #22839: [FLINK-32349][table] Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-21 Thread via GitHub
flinkbot commented on PR #22839: URL: https://github.com/apache/flink/pull/22839#issuecomment-1600710495 ## CI report: * 9604ce4793f3f9dcbf6d65fbbb9cf64bd690e6ce UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32349) Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32349: --- Labels: pull-request-available (was: ) > Support atomic for CREATE TABLE AS SELECT(CTAS)

[GitHub] [flink] Tartarus0zm opened a new pull request, #22839: [FLINK-32349][table] Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-21 Thread via GitHub
Tartarus0zm opened a new pull request, #22839: URL: https://github.com/apache/flink/pull/22839 ## What is the purpose of the change Support atomic for CREATE TABLE AS SELECT(CTAS) statement ## Brief change log Introduce StagedTable interface that support atomic

[GitHub] [flink] luoyuxia commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-21 Thread via GitHub
luoyuxia commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1236760683 ## docs/content/docs/connectors/table/filesystem.md: ## @@ -50,6 +50,10 @@ CREATE TABLE MyUserTable ( -- section for more

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-21 Thread via GitHub
gaborgsomogyi commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1236809906 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/DelegationTokenIdentifier.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed

[GitHub] [flink] afedulov commented on pull request #21774: [FLINK-28227][connectors] Migrate o.a.f.streaming.examples to the new Source API

2023-06-21 Thread via GitHub
afedulov commented on PR #21774: URL: https://github.com/apache/flink/pull/21774#issuecomment-1600653013 @reswqa I just pushed the latest changes, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-32375) Flink AWS Source AssumeRole in VPC

2023-06-21 Thread Tomas Witzany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735668#comment-17735668 ] Tomas Witzany commented on FLINK-32375: --- Thanks for the reply, ill look into backporting the fix.

[GitHub] [flink] xintongsong commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-21 Thread via GitHub
xintongsong commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1236252253 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/file/PartitionFileWriter.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[jira] [Updated] (FLINK-31901) AbstractBroadcastWrapperOperator should not block checkpoint barriers when processing cached records

2023-06-21 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31901: - Fix Version/s: ml-2.4.0 (was: ml-2.3.0) > AbstractBroadcastWrapperOperator

[jira] [Updated] (FLINK-32335) Fix the Flink ML unittest failure

2023-06-21 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-32335: - Fix Version/s: ml-2.4.0 (was: ml-2.3.0) > Fix the Flink ML unittest failure >

[jira] [Updated] (FLINK-31948) Supports triggering CI manually

2023-06-21 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31948: - Fix Version/s: ml-2.4.0 (was: ml-2.3.0) > Supports triggering CI manually >

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #614: [FLINK-32057] Support 1.18 rescale api for applying parallelism overrides

2023-06-21 Thread via GitHub
gyfora commented on PR #614: URL: https://github.com/apache/flink-kubernetes-operator/pull/614#issuecomment-1600576306 Addressed your comments @mxm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] jiaoqingbo commented on pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-21 Thread via GitHub
jiaoqingbo commented on PR #22694: URL: https://github.com/apache/flink/pull/22694#issuecomment-1600558583 @pvary could you help take a look when you have time? Thanks. I added some UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30342: -- Parent: FLINK-26522 Issue Type: Sub-task (was: Technical Debt) > Migrate

[jira] [Resolved] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30342. --- Fix Version/s: 1.18.0 Resolution: Fixed master:

[jira] [Updated] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30342: -- Parent: (was: FLINK-30338) Issue Type: Technical Debt (was: Sub-task) > Migrate

[GitHub] [flink] XComp merged pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-21 Thread via GitHub
XComp merged PR #22829: URL: https://github.com/apache/flink/pull/22829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] CasperTDK commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

2023-06-21 Thread via GitHub
CasperTDK commented on PR #22393: URL: https://github.com/apache/flink/pull/22393#issuecomment-1600537399 Allowing myself to give this a bump. Any way to prioritize the review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] afedulov commented on pull request #21774: [FLINK-28227][connectors] Migrate o.a.f.streaming.examples to the new Source API

2023-06-21 Thread via GitHub
afedulov commented on PR #21774: URL: https://github.com/apache/flink/pull/21774#issuecomment-1600536032 Hi @reswqa I actually just finished reimplementing the `SocketSource(Function)` as the new Source and - this unblocks https://github.com/apache/flink/pull/20049 . I just need to go

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-21 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735631#comment-17735631 ] Fang Yong commented on FLINK-32370: --- [~mapohl] I have created a new PR

[jira] [Created] (FLINK-32407) Notify catalog listener for table events

2023-06-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32407: - Summary: Notify catalog listener for table events Key: FLINK-32407 URL: https://issues.apache.org/jira/browse/FLINK-32407 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32406) Notify catalog listener for database events

2023-06-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32406: - Summary: Notify catalog listener for database events Key: FLINK-32406 URL: https://issues.apache.org/jira/browse/FLINK-32406 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32405) Initialize catalog listener for CatalogManager

2023-06-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32405: - Summary: Initialize catalog listener for CatalogManager Key: FLINK-32405 URL: https://issues.apache.org/jira/browse/FLINK-32405 Project: Flink Issue Type:

[jira] [Created] (FLINK-32404) Introduce catalog modification listener and factory interfaces

2023-06-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32404: - Summary: Introduce catalog modification listener and factory interfaces Key: FLINK-32404 URL: https://issues.apache.org/jira/browse/FLINK-32404 Project: Flink

[jira] [Created] (FLINK-32403) Add database related operations in catalog manager

2023-06-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32403: - Summary: Add database related operations in catalog manager Key: FLINK-32403 URL: https://issues.apache.org/jira/browse/FLINK-32403 Project: Flink Issue Type:

[GitHub] [flink] reswqa commented on pull request #22835: [hotfix] Remove local timeout for Hybrid and Tiered result partition test.

2023-06-21 Thread via GitHub
reswqa commented on PR #22835: URL: https://github.com/apache/flink/pull/22835#issuecomment-1600495258 Thanks @TanYuxin-tyx for the quick review, I have updated and force pushed this as it is only minor fix. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] swuferhong commented on pull request #22805: [FLINK-32365][orc]get orc table statistics in parallel

2023-06-21 Thread via GitHub
swuferhong commented on PR #22805: URL: https://github.com/apache/flink/pull/22805#issuecomment-1600493415 > @luoyuxia I find the code is called in multiple places. We make it configurable, we need change more moudles and we get more parameters. if we set parameter in hadoop config,both

[GitHub] [flink] reswqa commented on a diff in pull request #22835: [hotfix] Remove local timeout for Hybrid and Tiered result partition test.

2023-06-21 Thread via GitHub
reswqa commented on code in PR #22835: URL: https://github.com/apache/flink/pull/22835#discussion_r1236686281 ## flink-core/src/main/java/org/apache/flink/util/concurrent/IgnoreShutdownRejectedExecutionHandler.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (FLINK-32402) FLIP-294: Support Customized Catalog Modification Listener

2023-06-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32402: - Summary: FLIP-294: Support Customized Catalog Modification Listener Key: FLINK-32402 URL: https://issues.apache.org/jira/browse/FLINK-32402 Project: Flink Issue

[GitHub] [flink] flinkbot commented on pull request #22838: [FLINK-32370][jdbc-driver] Debug error log for jdbc gateway e2e test

2023-06-21 Thread via GitHub
flinkbot commented on PR #22838: URL: https://github.com/apache/flink/pull/22838#issuecomment-1600491747 ## CI report: * bf99f60859b1a36224aaf0e5a539b14e1c9421fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest commented on a diff in pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-21 Thread via GitHub
LadyForest commented on code in PR #22818: URL: https://github.com/apache/flink/pull/22818#discussion_r1236679027 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -203,54 +193,75 @@ public void close() throws

[GitHub] [flink] FangYongs opened a new pull request, #22838: [FLINK-32370][jdbc-driver] Debug error log for jdbc gateway e2e test

2023-06-21 Thread via GitHub
FangYongs opened a new pull request, #22838: URL: https://github.com/apache/flink/pull/22838 ## What is the purpose of the change This PR aims to debug error log for jdbc gateway e2e test ## Verifying this change This change is a trivial rework / code cleanup without any

[GitHub] [flink] LadyForest commented on a diff in pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-21 Thread via GitHub
LadyForest commented on code in PR #22818: URL: https://github.com/apache/flink/pull/22818#discussion_r1236671845 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -296,4 +319,85 @@ private Path

[GitHub] [flink] LadyForest commented on a diff in pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-21 Thread via GitHub
LadyForest commented on code in PR #22818: URL: https://github.com/apache/flink/pull/22818#discussion_r1236617192 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -89,52 +90,41 @@ public ResourceManager(ReadableConfig

[GitHub] [flink] LadyForest commented on a diff in pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-21 Thread via GitHub
LadyForest commented on code in PR #22818: URL: https://github.com/apache/flink/pull/22818#discussion_r1236665067 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -731,38 +731,46 @@ public TableResultInternal

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-21 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735615#comment-17735615 ] Fang Yong commented on FLINK-32370: --- Thanks [~mapohl], I think I miss the error log in JobManager. I

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22835: [hotfix] Remove local timeout for Hybrid and Tiered result partition test.

2023-06-21 Thread via GitHub
TanYuxin-tyx commented on code in PR #22835: URL: https://github.com/apache/flink/pull/22835#discussion_r1236654517 ## flink-core/src/main/java/org/apache/flink/util/concurrent/IgnoreShutdownRejectedExecutionHandler.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[GitHub] [flink] LadyForest commented on a diff in pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-21 Thread via GitHub
LadyForest commented on code in PR #22818: URL: https://github.com/apache/flink/pull/22818#discussion_r1236617192 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -89,52 +90,41 @@ public ResourceManager(ReadableConfig

[GitHub] [flink] flinkbot commented on pull request #22837: [FLINK-31957][docs][table] Add user story for configuring operator-level state TTL via compiled plan

2023-06-21 Thread via GitHub
flinkbot commented on PR #22837: URL: https://github.com/apache/flink/pull/22837#issuecomment-1600417210 ## CI report: * a861c95ba2fe65798002daaf9072e48df7b7dfff UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31957) Add documentation for the user story

2023-06-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31957: --- Labels: pull-request-available (was: ) > Add documentation for the user story >

[GitHub] [flink] LadyForest opened a new pull request, #22837: [FLINK-31957][docs][table] Add user story for configuring operator-level state TTL via compiled plan

2023-06-21 Thread via GitHub
LadyForest opened a new pull request, #22837: URL: https://github.com/apache/flink/pull/22837 ## What is the purpose of the change Add user story for FLIP-292 ## Brief change log Add description on how to configure operator-level state TTL to `overview.md`

[GitHub] [flink-web] klion26 opened a new pull request, #658: [hotfix] Fix the wrong conflic resolve

2023-06-21 Thread via GitHub
klion26 opened a new pull request, #658: URL: https://github.com/apache/flink-web/pull/658 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #244: Fix some bugs when preparing the release of 2.3.0

2023-06-21 Thread via GitHub
lindong28 commented on code in PR #244: URL: https://github.com/apache/flink-ml/pull/244#discussion_r1236512750 ## tools/releasing/deploy_staging_jars.sh: ## @@ -41,7 +41,11 @@ fi cd ${PROJECT_ROOT} -echo "Deploying to repository.apache.org" -${MVN} clean deploy

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #244: Fix some bugs when preparing the release of 2.3.0

2023-06-21 Thread via GitHub
jiangxin369 opened a new pull request, #244: URL: https://github.com/apache/flink-ml/pull/244 ## What is the purpose of the change Fix some bugs when preparing the release of 2.3.0. ## Brief change log - Replace the version with perl to avoid different

[jira] [Closed] (FLINK-32401) KafkaSourceBuilder reset the 'auto.offset.reset'

2023-06-21 Thread KianChen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KianChen closed FLINK-32401. Resolution: Fixed > KafkaSourceBuilder reset the 'auto.offset.reset' >

[GitHub] [flink] luoyuxia commented on pull request #22620: [FLINK-31413][hive] Change scope of flink-table-planner dependency from provided to test in Hive connector

2023-06-21 Thread via GitHub
luoyuxia commented on PR #22620: URL: https://github.com/apache/flink/pull/22620#issuecomment-1600289821 @LadyForest Thanks for reviewing. I have addressed your comments in the last three commits. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] XComp commented on pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-21 Thread via GitHub
XComp commented on PR #22829: URL: https://github.com/apache/flink/pull/22829#issuecomment-1600287893 force-push due to rebase and commit squash for a final CI run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-32401) KafkaSourceBuilder reset the 'auto.offset.reset'

2023-06-21 Thread KianChen (Jira)
KianChen created FLINK-32401: Summary: KafkaSourceBuilder reset the 'auto.offset.reset' Key: FLINK-32401 URL: https://issues.apache.org/jira/browse/FLINK-32401 Project: Flink Issue Type:

[GitHub] [flink] luoyuxia commented on a diff in pull request #22620: [FLINK-31413][hive] Change scope of flink-table-planner dependency from provided to test in Hive connector

2023-06-21 Thread via GitHub
luoyuxia commented on code in PR #22620: URL: https://github.com/apache/flink/pull/22620#discussion_r1236467570 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserUtils.java: ## @@ -641,6 +644,62 @@ public static

[jira] [Updated] (FLINK-30343) Migrate KubernetesLeaderElectionAndRetrievalITCase

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30343: -- Parent: FLINK-26522 Issue Type: Sub-task (was: Technical Debt) > Migrate

[jira] [Updated] (FLINK-30343) Migrate KubernetesLeaderElectionAndRetrievalITCase

2023-06-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30343: -- Parent: (was: FLINK-30338) Issue Type: Technical Debt (was: Sub-task) > Migrate

[GitHub] [flink] luoyuxia commented on a diff in pull request #22620: [FLINK-31413][hive] Change scope of flink-table-planner dependency from provided to test in Hive connector

2023-06-21 Thread via GitHub
luoyuxia commented on code in PR #22620: URL: https://github.com/apache/flink/pull/22620#discussion_r1236464418 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserUtils.java: ## @@ -641,6 +644,62 @@ public static

  1   2   >