[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779340#comment-17779340 ] Yun Tang commented on FLINK-33355: -- [~edmond_j] could you please share the code to reproduce this

[jira] [Comment Edited] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779330#comment-17779330 ] Wencong Liu edited comment on FLINK-33356 at 10/25/23 5:58 AM: --- Hello

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779336#comment-17779336 ] zhang commented on FLINK-33355: --- [~yunta]   I know that modifying the max parallelism is not possible, but

Re: [PR] [FLINK-30768] [Project Website] flink-web version cleanup [flink-web]

2023-10-24 Thread via GitHub
victor9309 commented on PR #683: URL: https://github.com/apache/flink-web/pull/683#issuecomment-1778542189 Thanks @XComp for the review. Thank you very much for your advice. ``` $ cat foo-utils.sh function foo() { echo 'foo...' >&2 exit 1 } $ cat foo-main.sh

[jira] [Assigned] (FLINK-33357) add Apache Software License 2

2023-10-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-33357: - Assignee: 蔡灿材 > add Apache Software License 2 > - > >

[jira] [Created] (FLINK-33358) Flink SQL Client fails to start in Flink on YARN

2023-10-24 Thread Prabhu Joseph (Jira)
Prabhu Joseph created FLINK-33358: - Summary: Flink SQL Client fails to start in Flink on YARN Key: FLINK-33358 URL: https://issues.apache.org/jira/browse/FLINK-33358 Project: Flink Issue

[jira] [Updated] (FLINK-33358) Flink SQL Client fails to start in Flink on YARN

2023-10-24 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph updated FLINK-33358: -- Description: Flink SQL Client fails to start in Flink on YARN with below error {code:java}

[jira] [Commented] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779330#comment-17779330 ] Wencong Liu commented on FLINK-33356: - Hello [~JunRuiLi] , I found this case is due to the commit

[jira] [Updated] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wencong Liu updated FLINK-33356: Attachment: image-2023-10-25-12-34-22-790.png > The navigation bar on Flink’s official website is

Re: [PR] [FLINK-33090][checkpointing] CheckpointsCleaner clean individual chec… [flink]

2023-10-24 Thread via GitHub
yigress commented on PR #23425: URL: https://github.com/apache/flink/pull/23425#issuecomment-1778479885 @pnowojski I rebased and it kicked off a rerun successfully. I also run some job for a day without problem. if looks good can you help merge it too? thank you so much! -- This is an

[jira] [Updated] (FLINK-33357) add Apache Software License 2

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33357: --- Labels: pull-request-available (was: ) > add Apache Software License 2 >

[PR] [FLINK-33357] add Apache Software License 2 [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
caicancai opened a new pull request, #688: URL: https://github.com/apache/flink-kubernetes-operator/pull/688 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

[jira] [Created] (FLINK-33357) add Apache Software License 2

2023-10-24 Thread Jira
蔡灿材 created FLINK-33357: --- Summary: add Apache Software License 2 Key: FLINK-33357 URL: https://issues.apache.org/jira/browse/FLINK-33357 Project: Flink Issue Type: Improvement Components:

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779315#comment-17779315 ] Yun Tang commented on FLINK-33355: -- Changing the max-parallelism (instead of parallelism), would break

[jira] [Closed] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-33355. Resolution: Information Provided > can't reduce the parallelism from 'n' to '1' when recovering through a

[jira] [Created] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Junrui Li (Jira)
Junrui Li created FLINK-33356: - Summary: The navigation bar on Flink’s official website is messed up. Key: FLINK-33356 URL: https://issues.apache.org/jira/browse/FLINK-33356 Project: Flink

Re: [PR] [FLINK-33316][runtime] Avoid unnecessary heavy getStreamOperatorFactory [flink]

2023-10-24 Thread via GitHub
1996fanrui commented on code in PR #23550: URL: https://github.com/apache/flink/pull/23550#discussion_r1371104358 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java: ## @@ -368,7 +373,8 @@ public void setStreamOperator(StreamOperator

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module [flink]

2023-10-24 Thread via GitHub
Jiabao-Sun commented on PR #23572: URL: https://github.com/apache/flink/pull/23572#issuecomment-1778455547 Hi @RocMarshal, please help review it when you have time. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-24 Thread via GitHub
RocMarshal commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1778448738 > This PR is too huge to review. I will split it into multiple PRs. SGTM +1. Looking forward to it~ -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread zhang (Jira)
zhang created FLINK-33355: - Summary: can't reduce the parallelism from 'n' to '1' when recovering through a savepoint. Key: FLINK-33355 URL: https://issues.apache.org/jira/browse/FLINK-33355 Project: Flink

[jira] [Created] (FLINK-33354) Reuse the TaskInformation for multiple slots

2023-10-24 Thread Rui Fan (Jira)
Rui Fan created FLINK-33354: --- Summary: Reuse the TaskInformation for multiple slots Key: FLINK-33354 URL: https://issues.apache.org/jira/browse/FLINK-33354 Project: Flink Issue Type: Sub-task

[jira] [Comment Edited] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779300#comment-17779300 ] Xin Chen edited comment on FLINK-26603 at 10/25/23 2:58 AM: [~luoyuxia]

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779300#comment-17779300 ] Xin Chen commented on FLINK-26603: -- [~luoyuxia] Ok,thank you very much. :D(y) > [Umbrella] Decouple

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779299#comment-17779299 ] luoyuxia commented on FLINK-26603: -- [~xinchen147] Yes, you're right. Nothing special to

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-24 Thread via GitHub
Jiabao-Sun closed pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime URL: https://github.com/apache/flink/pull/23200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-33315) Optimize memory usage of large StreamOperator

2023-10-24 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33315: Component/s: Runtime / Task > Optimize memory usage of large StreamOperator >

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-24 Thread via GitHub
Jiabao-Sun commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1778414947 This PR is too huge to review. I will split it into multiple PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779298#comment-17779298 ] Xin Chen commented on FLINK-26603: -- Hi, [~luoyuxia] Thank you. Yes, as the table-planner-loader module

[jira] [Updated] (FLINK-33315) Optimize memory usage of large StreamOperator

2023-10-24 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33315: Attachment: 130f436613b52b321bd9bd0211dd109f0b010220e860f292a13c0702016976850466192b.png > Optimize

[jira] [Updated] (FLINK-33315) Optimize memory usage of large StreamOperator

2023-10-24 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33315: Description: Some of our batch jobs are upgraded from flink-1.15 to flink-1.17, and TM always fail with

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
afedulov commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1778150546 > That being said, @afedulov, do you think it's worthwhile bringing up the new feature on the mailing list to discuss? This was my initial thought, yes. Ideally we do not want to

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1778137755 @zentol thanks a lot for the review!! I addressed all comments from your first pass, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370875073 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370869459 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OutputTypeConfigurable.java: ## @@ -27,7 +27,10 @@ * at {@link

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370869459 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OutputTypeConfigurable.java: ## @@ -27,7 +27,10 @@ * at {@link

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757489 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java: ## @@ -566,15 +567,15 @@ public void

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1778108982 thanks for the contribution in general it looks ok from my side i left a couple of minor comments -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on code in PR #23519: URL: https://github.com/apache/flink/pull/23519#discussion_r1370858120 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java: ## @@ -66,12 +70,17 @@ * * * - * Once Flink applies

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on code in PR #23519: URL: https://github.com/apache/flink/pull/23519#discussion_r1370857278 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java: ## @@ -66,12 +70,17 @@ * * * - * Once Flink applies

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757728 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370845998 ## flink-tests/pom.xml: ## @@ -284,6 +284,13 @@ under the License. test + +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370845998 ## flink-tests/pom.xml: ## @@ -284,6 +284,13 @@ under the License. test + +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370841305 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java: ## @@ -123,7

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370841305 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java: ## @@ -123,7

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370832543 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1188,14 +1191,14 @@ void

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370824409 ## flink-formats/flink-parquet/src/test/resources/avro/user.avsc: ## @@ -1,9 +0,0 @@ -{ - "namespace": "org.apache.flink.connector.datagen.source.generated", -

Re: [PR] [FLINK-33121] Failed precondition in JobExceptionsHandler due to concurrent global failures [flink]

2023-10-24 Thread via GitHub
pgaref commented on PR #23440: URL: https://github.com/apache/flink/pull/23440#issuecomment-1778042754 Hey @dmvk -- thanks for the comments! 1. Was debating about that, however testing e2e would require to add the mocked AdaptiveScheduler dependency (like `ExceptionHistoryTester`)

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1778020433 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1777990170 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370765358 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1161,9 +1163,10 @@ void

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370762519 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370762519 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757864 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757728 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757489 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java: ## @@ -566,15 +567,15 @@ public void

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-10-24 Thread via GitHub
jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1777952204 Hi @snuyanzin Could you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33321][hotfix] VertexFlameGraphFactoryTest#verifyRecursively doesn't work on java 21 [flink]

2023-10-24 Thread via GitHub
snuyanzin merged PR #23583: URL: https://github.com/apache/flink/pull/23583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32896][Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-24 Thread via GitHub
tzy-0x7cf commented on PR #23518: URL: https://github.com/apache/flink/pull/23518#issuecomment-1777866572 > Could squash the commits and rebase the branch to most-recent `master`? We don't want have merge commits cluttering the git history. > > The Flink CI bot is

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1777847541 Thanks for the reviews - much appreciated  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1370689647 ## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowDataDeSerializationSchemaTest.java: ## @@ -222,12 +234,14 @@ void

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1370649857 ## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroDeserializationSchemaTest.java: ## @@ -37,46 +38,56 @@ class AvroDeserializationSchemaTest

Re: [PR] [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data [flink-connector-kafka]

2023-10-24 Thread via GitHub
tzulitai closed pull request #52: [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data URL: https://github.com/apache/flink-connector-kafka/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-33187) Don't record duplicate event if no change

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779195#comment-17779195 ] Gyula Fora commented on FLINK-33187: merged to main faaff564e1bb3d8ca51c939d34dd416585a3de74 >

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
gyfora merged PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370455045 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -201,8 +201,8 @@ private static

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779150#comment-17779150 ] Jing Ge edited comment on FLINK-33301 at 10/24/23 3:45 PM: --- The value(my

[jira] [Updated] (FLINK-31863) Add 'Hostname' enum val to k8s NodeAddress type.

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31863: -- Fix Version/s: (was: 1.17.2) > Add 'Hostname' enum val to k8s NodeAddress type. >

[jira] [Updated] (FLINK-31601) While waiting for resources, resources check might be scheduled unlimited number of times (Adaptive Scheduler)

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31601: -- Fix Version/s: (was: 1.17.2) > While waiting for resources, resources check might be

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779101#comment-17779101 ] Jing Ge edited comment on FLINK-33301 at 10/24/23 3:45 PM: --- Thanks for sharing

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779150#comment-17779150 ] Jing Ge edited comment on FLINK-33301 at 10/24/23 3:44 PM: --- The value(my

[jira] [Updated] (FLINK-31875) OSS throwns NoClassDefFoundError due to old hadoop-common version

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31875: -- Fix Version/s: (was: 1.16.3) (was: 1.17.2) > OSS throwns

[jira] [Updated] (FLINK-30219) Fetch results api in sql gateway return error result.

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30219: -- Fix Version/s: (was: 1.16.3) > Fetch results api in sql gateway return error result. >

[jira] [Updated] (FLINK-33089) Drop Flink 1.13 and 1.14 support for the operator

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33089: --- Description: As agreed with the community we will only support the last 4 stable Flink minor

[jira] [Updated] (FLINK-33089) Drop Flink 1.13 and 1.14 support for the operator

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33089: --- Summary: Drop Flink 1.13 and 1.14 support for the operator (was: Drop Flink 1.13 support) > Drop

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779150#comment-17779150 ] Jing Ge commented on FLINK-33301: - The value(my intention) is to fail faster before maven is called,

[jira] [Created] (FLINK-33353) SQL fails because "TimestampType.kind" is not serialized

2023-10-24 Thread Ferenc Csaky (Jira)
Ferenc Csaky created FLINK-33353: Summary: SQL fails because "TimestampType.kind" is not serialized Key: FLINK-33353 URL: https://issues.apache.org/jira/browse/FLINK-33353 Project: Flink

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
gyfora commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370421339 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventUtils.java: ## @@ -197,4 +198,19 @@ private static Event

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370421148 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -201,8 +201,8 @@ private static

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370420200 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventUtils.java: ## @@ -197,4 +198,19 @@ private static Event

[jira] [Closed] (FLINK-33306) Use observed true processing rate when source metrics are incorrect

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33306. -- Resolution: Fixed merged to main cc680e142bb8d52c4db215658ee7f4c4159a0fe4 > Use observed true

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
gyfora merged PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33274][release] Add release note for version 1.18 [flink]

2023-10-24 Thread via GitHub
JingGe merged PR #23527: URL: https://github.com/apache/flink/pull/23527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33341) Use available local state for rescaling

2023-10-24 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779129#comment-17779129 ] Stefan Richter commented on FLINK-33341: FYI, here is a link to the development branch:

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779122#comment-17779122 ] Matthias Pohl commented on FLINK-33301: --- {quote} Yes, using pom to control the versions centrally

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779122#comment-17779122 ] Matthias Pohl edited comment on FLINK-33301 at 10/24/23 2:52 PM: -

[jira] [Commented] (FLINK-33341) Use available local state for rescaling

2023-10-24 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779124#comment-17779124 ] Stefan Richter commented on FLINK-33341: [~Yanfei Lei], yes only the previous local state is

Re: [PR] [FLINK-33352][rest][docs] Add schema mappings to discriminator properties [flink]

2023-10-24 Thread via GitHub
flinkbot commented on PR #23588: URL: https://github.com/apache/flink/pull/23588#issuecomment-1777387430 ## CI report: * 7a802e3654a0e6f2d68cad0deb6af0c4557f082b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
RyanSkraba commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1368636472 ## docs/content/docs/connectors/table/formats/avro.md: ## @@ -80,6 +80,14 @@ Format Options String Specify what format to use, here should be 'avro'.

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-10-24 Thread via GitHub
tzulitai commented on PR #23555: URL: https://github.com/apache/flink/pull/23555#issuecomment-1777382337 I gave the refactoring a stab as well, and also can't come up with something better. Looking around in other parts of the code, this seems to be a common problem in various classes. A

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-10-24 Thread via GitHub
tzulitai commented on code in PR #23555: URL: https://github.com/apache/flink/pull/23555#discussion_r1370318341 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -77,4 +97,42 @@ interface PrecommittingSinkWriter extends

[jira] [Updated] (FLINK-33352) OpenAPI spec is lacking mappings for discriminator properties

2023-10-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-33352: - Priority: Minor (was: Major) > OpenAPI spec is lacking mappings for discriminator

[jira] [Updated] (FLINK-33352) OpenAPI spec is lacking mappings for discriminator properties

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33352: --- Labels: pull-request-available (was: ) > OpenAPI spec is lacking mappings for

[PR] [FLINK-33352][rest][docs] Add schema mappings to discriminator properties [flink]

2023-10-24 Thread via GitHub
zentol opened a new pull request, #23588: URL: https://github.com/apache/flink/pull/23588 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-33334][table] Make map entries sorted by keys in json plan to have it stable for java21 [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on PR #23562: URL: https://github.com/apache/flink/pull/23562#issuecomment-1777359316 @LadyForest , @lincoln-lil since you contributed to this area could you please have a look here? This should allow flink-table tests passing on jdk21 -- This is an automated

[jira] [Created] (FLINK-33352) OpenAPI spec is lacking mappings for discriminator properties

2023-10-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-33352: Summary: OpenAPI spec is lacking mappings for discriminator properties Key: FLINK-33352 URL: https://issues.apache.org/jira/browse/FLINK-33352 Project: Flink

Re: [PR] [FLINK-33255] [table] Validate argument count during type inference [flink]

2023-10-24 Thread via GitHub
bvarghese1 commented on code in PR #23520: URL: https://github.com/apache/flink/pull/23520#discussion_r1370291200 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInferenceUtil.java: ## @@ -209,6 +209,47 @@ public static TableException

[jira] [Commented] (FLINK-33341) Use available local state for rescaling

2023-10-24 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779106#comment-17779106 ] Yanfei Lei commented on FLINK-33341: Hi [~srichter] IIUC, only subtasks that are assigned to the

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable [flink]

2023-10-24 Thread via GitHub
flinkbot commented on PR #23587: URL: https://github.com/apache/flink/pull/23587#issuecomment-1777288734 ## CI report: * ce6df92c0f289815bb78ce3465fe81f1e57d1573 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-10-24 Thread via GitHub
flinkbot commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1777288158 ## CI report: * 802b741f9f76c8d86c98df88f8cf76f9d15b442a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33309] Add `-Djava.security.manager=allow` [flink]

2023-10-24 Thread via GitHub
zentol commented on code in PR #23547: URL: https://github.com/apache/flink/pull/23547#discussion_r1370228773 ## flink-core/pom.xml: ## @@ -34,7 +34,14 @@ under the License. jar -

  1   2   3   >