Re: [PR] [FLINK-33033][olap][haservice] Add haservice micro benchmark for olap [flink-benchmarks]

2023-10-26 Thread via GitHub
KarmaGYZ merged PR #78: URL: https://github.com/apache/flink-benchmarks/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-33033) Add haservice micro benchmark for olap

2023-10-26 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo closed FLINK-33033. -- Fix Version/s: 1.19.0 Resolution: Fixed > Add haservice micro benchmark for olap >

[jira] [Commented] (FLINK-33033) Add haservice micro benchmark for olap

2023-10-26 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780163#comment-17780163 ] Yangze Guo commented on FLINK-33033: master: 6e61678dc7fffa4529d27ec674a6b57a1e79b097 > Add

[jira] [Updated] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2023-10-26 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-33121: --- Description: {{JobExceptionsHandler#createRootExceptionInfo}} makes the

[jira] [Updated] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2023-10-26 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-33121: --- Description: {{JobExceptionsHandler#createRootExceptionInfo}} makes the

[jira] [Commented] (FLINK-26050) Too many small sst files in rocksdb state backend when using processing time window

2023-10-26 Thread wuzq (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780139#comment-17780139 ] wuzq commented on FLINK-26050: -- [~shenjiaqi] [~mayuehappy] Is there a solution to this problem.Using 

Re: [PR] [FLINK-33341][state] Add support for rescaling from local keyed state [flink]

2023-10-26 Thread via GitHub
rkhachatryan commented on code in PR #23591: URL: https://github.com/apache/flink/pull/23591#discussion_r1373904163 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalLocalKeyedStateHandle.java: ## @@ -138,22 +108,43 @@ public void discardState() throws

Re: [PR] Draft [FLINK-33335] (CI) [flink]

2023-10-26 Thread via GitHub
afedulov commented on PR #23605: URL: https://github.com/apache/flink/pull/23605#issuecomment-1781935549 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Draft [FLINK-33335] (CI) [flink]

2023-10-26 Thread via GitHub
afedulov closed pull request #23605: Draft [FLINK-5] (CI) URL: https://github.com/apache/flink/pull/23605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Draft [FLINK-33335] (CI) [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23605: URL: https://github.com/apache/flink/pull/23605#issuecomment-1781931508 ## CI report: * d9061be6ae8e9d7d246f19d7103c8d01b9db1574 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31332] Limit the use of ExecutionConfig on JdbcOutputFormat [flink-connector-jdbc]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #73: URL: https://github.com/apache/flink-connector-jdbc/pull/73#discussion_r1373843729 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcOutputFormatBuilder.java: ## @@ -100,10 +98,7 @@ public

[PR] Draft [FLINK-33335] (CI) [flink]

2023-10-26 Thread via GitHub
afedulov opened a new pull request, #23605: URL: https://github.com/apache/flink/pull/23605 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [FLINK-31332] Limit the use of ExecutionConfig on JdbcOutputFormat [flink-connector-jdbc]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #73: URL: https://github.com/apache/flink-connector-jdbc/pull/73#discussion_r1373838435 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/internal/JdbcOutputSerializerTest.java: ## @@ -0,0 +1,36 @@ +package

[jira] [Updated] (FLINK-33335) Reactivate missing e2e tests

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-5: --- Labels: pull-request-available (was: ) > Reactivate missing e2e tests >

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1373724108 ## .github/workflows/ci.yml: ## @@ -88,6 +93,10 @@ jobs: if: ${{ inputs.run_dependency_convergence }} run: echo

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1373724108 ## .github/workflows/ci.yml: ## @@ -88,6 +93,10 @@ jobs: if: ${{ inputs.run_dependency_convergence }} run: echo

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1373724108 ## .github/workflows/ci.yml: ## @@ -88,6 +93,10 @@ jobs: if: ${{ inputs.run_dependency_convergence }} run: echo

[jira] [Closed] (FLINK-33367) Invalid Check in DefaultFileFilter

2023-10-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov closed FLINK-33367. - Release Note: Not an actual issue. Resolution: Won't Fix I am closing this as

[jira] [Commented] (FLINK-33368) Support for SNI in the Flink Client

2023-10-26 Thread Mihai L Lalescu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780027#comment-17780027 ] Mihai L Lalescu commented on FLINK-33368: - Yes this is a duplicate of the above. > Support for

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.buffer package of flink-runtime module [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23604: URL: https://github.com/apache/flink/pull/23604#issuecomment-1781511688 ## CI report: * a3ca65d40309be72c6ca7117e1e8cc2a80aaba86 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.buffer package of flink-runtime module [flink]

2023-10-26 Thread via GitHub
Jiabao-Sun commented on PR #23604: URL: https://github.com/apache/flink/pull/23604#issuecomment-1781511559 Hi @RocMarshal, sorry for bothering you again. Would you mind to help review this PR as well? Many thanks for that. -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis [flink]

2023-10-26 Thread via GitHub
Jiabao-Sun commented on PR #23564: URL: https://github.com/apache/flink/pull/23564#issuecomment-1781504928 Hi @leonardBang, do you have time to help review it? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.buffer package of flink-runtime module [flink]

2023-10-26 Thread via GitHub
Jiabao-Sun opened a new pull request, #23604: URL: https://github.com/apache/flink/pull/23604 ## What is the purpose of the change [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.buffer package of flink-runtime module ## Brief change log

[jira] [Assigned] (FLINK-33360) HybridSource fails to clear the previous round's state when switching sources, leading to data loss

2023-10-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-33360: -- Assignee: Feng Jiajie > HybridSource fails to clear the previous round's state when

[jira] [Commented] (FLINK-33360) HybridSource fails to clear the previous round's state when switching sources, leading to data loss

2023-10-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779998#comment-17779998 ] Leonard Xu commented on FLINK-33360: Thanks [~fengjiajie] for report this issue, I assigned this

Re: [PR] [FLINK-33309] Add `-Djava.security.manager=allow` [flink]

2023-10-26 Thread via GitHub
snuyanzin commented on PR #23547: URL: https://github.com/apache/flink/pull/23547#issuecomment-1781460690 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33377) When Flink version >= 1.15 and Flink Operator is used, there is a waste of resources when running Flink batch jobs.

2023-10-26 Thread hjw (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779984#comment-17779984 ] hjw commented on FLINK-33377: - [~gsomogyi] Can you take a look? > When Flink version >= 1.15 and Flink

[jira] [Created] (FLINK-33377) When Flink version >= 1.15 and Flink Operator is used, there is a waste of resources when running Flink batch jobs.

2023-10-26 Thread hjw (Jira)
hjw created FLINK-33377: --- Summary: When Flink version >= 1.15 and Flink Operator is used, there is a waste of resources when running Flink batch jobs. Key: FLINK-33377 URL: https://issues.apache.org/jira/browse/FLINK-33377

Re: [PR] [FLINK-33121] Failed precondition in JobExceptionsHandler due to concurrent global failures [flink]

2023-10-26 Thread via GitHub
pgaref commented on code in PR #23440: URL: https://github.com/apache/flink/pull/23440#discussion_r1373418508 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -1619,12 +1619,18 @@ void

Re: [PR] [FLINK-33121] Failed precondition in JobExceptionsHandler due to concurrent global failures [flink]

2023-10-26 Thread via GitHub
dmvk commented on code in PR #23440: URL: https://github.com/apache/flink/pull/23440#discussion_r1373417213 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -1619,12 +1619,18 @@ void

[jira] [Closed] (FLINK-33128) TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on converter

2023-10-26 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao closed FLINK-33128. --- > TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on > converter >

[jira] [Resolved] (FLINK-33128) TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on converter

2023-10-26 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao resolved FLINK-33128. - Resolution: Fixed > TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on >

[jira] [Updated] (FLINK-33128) TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on converter

2023-10-26 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-33128: Affects Version/s: 1.19.0 (was: 1.16.2) >

[jira] [Assigned] (FLINK-33128) TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on converter

2023-10-26 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao reassigned FLINK-33128: --- Assignee: Jerome Gagnon > TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open()

[jira] [Commented] (FLINK-33128) TestValuesRuntimeFunctions$TestValuesLookupFunction does not call open() on converter

2023-10-26 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779959#comment-17779959 ] Yun Gao commented on FLINK-33128: - Merged on master via f31770fcf5769052f1ac32a6529de979eaf339a4 >

Re: [PR] [FLINK-33128] Add converter.open() method call on TestValuesRuntimeFunctions [flink]

2023-10-26 Thread via GitHub
gaoyunhaii closed pull request #23453: [FLINK-33128] Add converter.open() method call on TestValuesRuntimeFunctions URL: https://github.com/apache/flink/pull/23453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33375] Implement restore test base [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23603: URL: https://github.com/apache/flink/pull/23603#issuecomment-1781372184 ## CI report: * d8d49116263be7f4819fec276692ee59ef5f9003 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-33359) Kubernetes operator supports compiling with Java 17

2023-10-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33359: --- Assignee: Sergey Nuyanzin > Kubernetes operator supports compiling with Java 17 >

[jira] [Updated] (FLINK-33375) Add a RestoreTestBase

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33375: --- Labels: pull-request-available (was: ) > Add a RestoreTestBase > - > >

[jira] [Closed] (FLINK-33359) Kubernetes operator supports compiling with Java 17

2023-10-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33359. -- Resolution: Fixed Merged to main: d0ee0e947badcba7ed351a3ce5fdf95ee5b79847

[jira] [Updated] (FLINK-33359) Kubernetes operator supports compiling with Java 17

2023-10-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33359: --- Fix Version/s: kubernetes-operator-1.7.0 > Kubernetes operator supports compiling with Java 17 >

[PR] [FLINK-33375] Implement restore test base [flink]

2023-10-26 Thread via GitHub
dawidwys opened a new pull request, #23603: URL: https://github.com/apache/flink/pull/23603 ## What is the purpose of the change This introduces a test base for writing restore tests. ## Verifying this change It contains a single test as an example for a simple calc.

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora merged PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#issuecomment-1781354452 looks good! thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-29549) Add Aws Glue Catalog support in Flink

2023-10-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779953#comment-17779953 ] Danny Cranmer commented on FLINK-29549: --- [~martijnvisser] yes, but have not had capacity to finish

[jira] [Assigned] (FLINK-29549) Add Aws Glue Catalog support in Flink

2023-10-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-29549: - Assignee: Samrat Deb > Add Aws Glue Catalog support in Flink >

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373348800 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -522,11 +540,13 @@ public void

[jira] [Commented] (FLINK-33376) Add AuthInfo config option for Zookeeper configuration

2023-10-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779947#comment-17779947 ] Oleksandr Nitavskyi commented on FLINK-33376: - For implementation we could add an additional

[jira] [Created] (FLINK-33376) Add AuthInfo config option for Zookeeper configuration

2023-10-26 Thread Oleksandr Nitavskyi (Jira)
Oleksandr Nitavskyi created FLINK-33376: --- Summary: Add AuthInfo config option for Zookeeper configuration Key: FLINK-33376 URL: https://issues.apache.org/jira/browse/FLINK-33376 Project: Flink

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373338635 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -522,11 +540,13 @@ public void

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373335550 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -522,11 +540,13 @@ public void

Re: [PR] [hotfix] Update NOTICE files to reflect year 2023 [flink-connector-elasticsearch]

2023-10-26 Thread via GitHub
boring-cyborg[bot] commented on PR #75: URL: https://github.com/apache/flink-connector-elasticsearch/pull/75#issuecomment-1781294565 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [hotfix] Update NOTICE files to reflect year 2023 [flink-connector-elasticsearch]

2023-10-26 Thread via GitHub
MartijnVisser merged PR #75: URL: https://github.com/apache/flink-connector-elasticsearch/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables [flink]

2023-10-26 Thread via GitHub
pvary commented on PR #23555: URL: https://github.com/apache/flink/pull/23555#issuecomment-1781292345 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-29549) Add Aws Glue Catalog support in Flink

2023-10-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779939#comment-17779939 ] Martijn Visser commented on FLINK-29549: [~dannycranmer] Do you have eyes on this? > Add Aws

Re: [PR] [docs] Add a README to the flink-autoscaler module [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
mxm merged PR #694: URL: https://github.com/apache/flink-kubernetes-operator/pull/694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-26 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1781183357 @zentol I made two major changes as per our discussions above: - https://github.com/apache/flink/commit/2712c1813ca6420905e06b9e417de0eb61d586d9 - direct type passing without the

Re: [PR] add announcement blog post for Flink 1.18 [flink-web]

2023-10-26 Thread via GitHub
knaufk merged PR #680: URL: https://github.com/apache/flink-web/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-33375) Add a RestoreTestBase

2023-10-26 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33375: Summary: Add a RestoreTestBase Key: FLINK-33375 URL: https://issues.apache.org/jira/browse/FLINK-33375 Project: Flink Issue Type: Sub-task

Re: [PR] test [flink]

2023-10-26 Thread via GitHub
JunRuiLee commented on PR #23598: URL: https://github.com/apache/flink/pull/23598#issuecomment-1781151972 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-33374) Execute REMOVE JAR command failed via SQL gateway

2023-10-26 Thread Xianxun Ye (Jira)
Xianxun Ye created FLINK-33374: -- Summary: Execute REMOVE JAR command failed via SQL gateway Key: FLINK-33374 URL: https://issues.apache.org/jira/browse/FLINK-33374 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-33316) Avoid unnecessary heavy getStreamOperatorFactory

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778510#comment-17778510 ] Rui Fan edited comment on FLINK-33316 at 10/26/23 1:31 PM: --- The change is

Re: [PR] [FLINK-33316][runtime] Using SERIALIZED_UDF_CLASS instead of SERIALIZED_UDF_CLASS_NAME [flink]

2023-10-26 Thread via GitHub
1996fanrui merged PR #23597: URL: https://github.com/apache/flink/pull/23597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33164] Support write option sink.ignore-null-value [flink-connector-hbase]

2023-10-26 Thread via GitHub
Tan-JiaLiang commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781118161 @ferenc-csaky @MartijnVisser Thanks for the patience guide. Making sense to me. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] test [flink]

2023-10-26 Thread via GitHub
JunRuiLee commented on PR #23598: URL: https://github.com/apache/flink/pull/23598#issuecomment-1781116611 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33373][build] Capture build scans on ge.apache.org to benefit from deep build insights [flink]

2023-10-26 Thread via GitHub
flinkbot commented on PR #23602: URL: https://github.com/apache/flink/pull/23602#issuecomment-1781113268 ## CI report: * 416aec02e4876e743df8c76656ad4cf71214cf69 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33373][build] Capture build scans on ge.apache.org to benefit from deep build insights [flink]

2023-10-26 Thread via GitHub
clayburn commented on code in PR #23602: URL: https://github.com/apache/flink/pull/23602#discussion_r1373154854 ## tools/azure-pipelines/build-apache-repo.yml: ## @@ -55,6 +55,7 @@ variables: SECRET_S3_BUCKET: $[variables.IT_CASE_S3_BUCKET] SECRET_S3_ACCESS_KEY:

[jira] [Updated] (FLINK-33373) Capture build scans on ge.apache.org to benefit from deep build insights

2023-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33373: --- Labels: pull-request-available (was: ) > Capture build scans on ge.apache.org to benefit

[PR] [FLINK-33373][build] Capture build scans on ge.apache.org to benefit from deep build insights [flink]

2023-10-26 Thread via GitHub
clayburn opened a new pull request, #23602: URL: https://github.com/apache/flink/pull/23602 It was nice meeting some of you at the Gradle booth at Community over Code. We discussed Develocity with some of you, and this would be the PR that enables it. ## What is the purpose

[PR] [docs] Add a README to the flink-autoscaler module [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
mxm opened a new pull request, #694: URL: https://github.com/apache/flink-kubernetes-operator/pull/694 This adds a README to the flink-autoscaler module, to clarify its purpose and usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (FLINK-33373) Capture build scans on ge.apache.org to benefit from deep build insights

2023-10-26 Thread Clay Johnson (Jira)
Clay Johnson created FLINK-33373: Summary: Capture build scans on ge.apache.org to benefit from deep build insights Key: FLINK-33373 URL: https://issues.apache.org/jira/browse/FLINK-33373 Project:

[jira] [Created] (FLINK-33372) Cryptic exception for a sub query in a CompiledPlan

2023-10-26 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33372: Summary: Cryptic exception for a sub query in a CompiledPlan Key: FLINK-33372 URL: https://issues.apache.org/jira/browse/FLINK-33372 Project: Flink

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1373126000 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373121357 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

[jira] [Closed] (FLINK-25809) Introduce test infra for building FLIP-190 tests

2023-10-26 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-25809. Fix Version/s: 1.19.0 Resolution: Fixed Fixed in master:

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373034259 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-25809][table-api-java] Add table test program infrastructure [flink]

2023-10-26 Thread via GitHub
twalthr merged PR #23584: URL: https://github.com/apache/flink/pull/23584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33164] Support write option sink.ignore-null-value [flink-connector-hbase]

2023-10-26 Thread via GitHub
MartijnVisser commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781047396 It's recommended to have multiple commits in a lot of situations, see https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/ - We can squash

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2023-10-26 Thread via GitHub
Samrat002 commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-1781024903 [gentle ping] @dannycranmer, i have addressed to all the review comments . Please review the PR whenever time -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33164] Support write option sink.ignore-null-value [flink-connector-hbase]

2023-10-26 Thread via GitHub
ferenc-csaky commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1781023023 > @ferenc-csaky I rebase the main branch and squash all my changes. > > And one more question master. there will be multiple commits during code reviews, Should I

[jira] [Commented] (FLINK-29549) Add Aws Glue Catalog support in Flink

2023-10-26 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779870#comment-17779870 ] Samrat Deb commented on FLINK-29549: please help reviewing the PR

Re: [PR] [FLINK-33304] Introduce mutationBuffer to resolve the mutation write conflicts problem [flink-connector-hbase]

2023-10-26 Thread via GitHub
ferenc-csaky commented on PR #30: URL: https://github.com/apache/flink-connector-hbase/pull/30#issuecomment-1780977002 @Tan-JiaLiang that's even better  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373034259 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373034259 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373031168 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373020057 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-26 Thread via GitHub
JingGe commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1373016512 ## docs/content/docs/connectors/table/formats/avro.md: ## @@ -80,6 +80,14 @@ Format Options String Specify what format to use, here should be 'avro'.

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
dawidwys commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1373006392 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1373005879 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1372999282 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33371] Make TestValues sinks return results as Rows [flink]

2023-10-26 Thread via GitHub
twalthr commented on code in PR #23601: URL: https://github.com/apache/flink/pull/23601#discussion_r1372989815 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java: ## @@ -283,22 +293,29 @@ private abstract

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on code in PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#discussion_r1372996355 ## .github/workflows/ci.yml: ## @@ -24,12 +24,15 @@ jobs: test_ci: runs-on: ubuntu-latest name: test_ci +strategy: + matrix: +

Re: [PR] [FLINK-33360] HybridSourceSplitEnumerator clear finishedReaders when … [flink]

2023-10-26 Thread via GitHub
fengjiajie commented on code in PR #23593: URL: https://github.com/apache/flink/pull/23593#discussion_r1372988296 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java: ## @@ -252,6 +252,41 @@

Re: [PR] [FLINK-33359][FLINK-25002] add-opens jvm args to support jdk17 for kubernetes operator [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
snuyanzin commented on PR #691: URL: https://github.com/apache/flink-kubernetes-operator/pull/691#issuecomment-1780905589 @gyfora i added here #693 please have a look once you have time -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33260] Allow user to provide a list of recoverable exceptions [flink-connector-aws]

2023-10-26 Thread via GitHub
iemre commented on code in PR #110: URL: https://github.com/apache/flink-connector-aws/pull/110#discussion_r1372984660 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ExceptionConfig.java: ## @@ -0,0 +1,17 @@

Re: [PR] [FLINK-33089] Drop support for Flink 1.13 and 1.14 and clean up related codepaths [flink-kubernetes-operator]

2023-10-26 Thread via GitHub
gyfora commented on PR #692: URL: https://github.com/apache/flink-kubernetes-operator/pull/692#issuecomment-1780902179 I will wait until the 1.18.0 release is finalised for Flink before merging as I also included the respective updates from snapshot to 1.18 images for CI -- This is an

[jira] [Comment Edited] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779841#comment-17779841 ] Rui Fan edited comment on FLINK-32850 at 10/26/23 11:05 AM: Merged master

[jira] [Commented] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-10-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779841#comment-17779841 ] Rui Fan commented on FLINK-32850: - Merged via: 0ccd95ef48bcd7246f8c88c9aa7b69ffa268c865 > [JUnit5

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module [flink]

2023-10-26 Thread via GitHub
1996fanrui merged PR #23572: URL: https://github.com/apache/flink/pull/23572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32806]EmbeddedJobResultStore set ttly for non dirty job [flink]

2023-10-26 Thread via GitHub
Samrat002 commented on PR #23531: URL: https://github.com/apache/flink/pull/23531#issuecomment-1780893257 @XComp please review whenever time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   >