Re: [PR] [FLINK-27986] Refactor the name of finish method for JdbcOutputFormatBuilder [flink]

2024-01-17 Thread via GitHub
xleoken closed pull request #18794: [FLINK-27986] Refactor the name of finish method for JdbcOutputFormatBuilder URL: https://github.com/apache/flink/pull/18794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-17 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1897966163 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]

2024-01-17 Thread via GitHub
XComp commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1457044758 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -143,12 +144,14 @@ private

[jira] [Commented] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream

2024-01-17 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808053#comment-17808053 ] Jiabao Sun commented on FLINK-33717: Hi [~jackylau], are you still working on this? Could I help

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-17 Thread via GitHub
X-czh commented on code in PR #24127: URL: https://github.com/apache/flink/pull/24127#discussion_r1457027155 ## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-01-17 Thread via GitHub
lajith2006 commented on PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#issuecomment-1897888444 Sure, I will open FLIP with design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on PR #24068: URL: https://github.com/apache/flink/pull/24068#issuecomment-1897862786 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-34141) Bash exited with code '143'

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34141: --- Description:

[jira] [Created] (FLINK-34141) Bash exited with code '143'

2024-01-17 Thread xuyang (Jira)
xuyang created FLINK-34141: -- Summary: Bash exited with code '143' Key: FLINK-34141 URL: https://issues.apache.org/jira/browse/FLINK-34141 Project: Flink Issue Type: Bug Components: Build

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-17 Thread via GitHub
X-czh commented on code in PR #24127: URL: https://github.com/apache/flink/pull/24127#discussion_r1456946751 ## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-17 Thread via GitHub
reswqa commented on code in PR #24127: URL: https://github.com/apache/flink/pull/24127#discussion_r1456941270 ## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (FLINK-34129) MiniBatchGlobalGroupAggFunction will make -D as +I then make +I as -U when state expired

2024-01-17 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808018#comment-17808018 ] Hongshun Wang commented on FLINK-34129: --- [~fsk119] ,[~lsy] , [~andrewlinc...@gmail.com] , CC >

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on PR #24068: URL: https://github.com/apache/flink/pull/24068#issuecomment-1897831028 Hi, @fsk119 . Thank you for your review. I think some of the questions you raised are valuable and meaningful. I have created several independent JIRA to follow up and further

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24127: URL: https://github.com/apache/flink/pull/24127#issuecomment-1897829521 ## CI report: * 5dacb13c87a7a1a8b957d1d93d35ff481a360cd5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]

2024-01-17 Thread via GitHub
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897827367 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-34090) Introduce SerializerConfig for serialization

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34090: --- Labels: pull-request-available (was: ) > Introduce SerializerConfig for serialization >

[PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-17 Thread via GitHub
X-czh opened a new pull request, #24127: URL: https://github.com/apache/flink/pull/24127 ## What is the purpose of the change Introduce SerializerConfig for serializers decouple the serializer from ExecutionConfig. ## Brief change log Introduce SerializerConfig

[jira] [Commented] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-17 Thread dizhou cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808008#comment-17808008 ] dizhou cao commented on FLINK-34105: [~zhuzh] Great suggestion. We've tried to move the

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-17 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1897803207 @davidradl Thanks for the work. I think the `testSelectStatementWithWeirdCharacters` you added is an orthogonal problem with current one, it fails without current changes,

Re: [PR] [FLINK-33182][table] Allow metadata columns in Ndu-analyze with ChangelogNormalize [flink]

2024-01-17 Thread via GitHub
lincoln-lil commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1897800621 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33434][runtime-web] Support invoke async-profiler on TaskManager via REST API [flink]

2024-01-17 Thread via GitHub
yuchen-ecnu commented on PR #24041: URL: https://github.com/apache/flink/pull/24041#issuecomment-1897790800 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-31449) Remove DeclarativeSlotManager related logic

2024-01-17 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-31449. --- Resolution: Fixed resolved in master: 551b776a82193eeb6bb4a9b8a6925a386ea502e4 > Remove

Re: [PR] [FLINK-31449][resourcemanager] Remove DeclarativeSlotManager related logic [flink]

2024-01-17 Thread via GitHub
huwh merged PR #24102: URL: https://github.com/apache/flink/pull/24102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456843664 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/windowtvf/common/WindowAssigner.java: ## @@ -0,0 +1,43 @@ +/* + *

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456843334 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/groupwindow/context/WindowContext.java: ## @@ -0,0 +1,74 @@ +/* +

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456843334 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/groupwindow/context/WindowContext.java: ## @@ -0,0 +1,74 @@ +/* +

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456842979 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/groupwindow/context/WindowContext.java: ## @@ -0,0 +1,74 @@ +/* +

[jira] [Comment Edited] (FLINK-30656) Provide more logs for schema compatibility check

2024-01-17 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807968#comment-17807968 ] Hangxiang Yu edited comment on FLINK-30656 at 1/18/24 3:57 AM: --- We should

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456822860 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/MergeCallback.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456817705 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/builder/AbstractWindowAggOperatorBuilder.java: ## @@

Re: [PR] [FLINK-34049][table]Refactor classes related to window TVF aggregation to prepare for non-aligned windows [flink]

2024-01-17 Thread via GitHub
xuyangzhong commented on code in PR #24068: URL: https://github.com/apache/flink/pull/24068#discussion_r1456817108 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/logical/WindowSpec.java: ## @@ -31,4 +32,15 @@ public interface WindowSpec {

Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]

2024-01-17 Thread via GitHub
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897742954 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-34140) Rename WindowContext and TriggerContext in window

2024-01-17 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-34140: - Assignee: xuyang > Rename WindowContext and TriggerContext in window >

[jira] [Assigned] (FLINK-34139) The slice assigner should not reveal its event time or process time at the interface level.

2024-01-17 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-34139: - Assignee: xuyang > The slice assigner should not reveal its event time or process time

[jira] [Updated] (FLINK-34140) Rename WindowContext and TriggerContext in window

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34140: --- Summary: Rename WindowContext and TriggerContext in window (was: Rename WindowContext in window) > Rename

[jira] [Updated] (FLINK-34140) Rename WindowContext and TriggerContext in window

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34140: --- Description: Currently, WindowContext and TriggerContext not only contains a series of get methods to

[jira] [Updated] (FLINK-34140) Rename WindowContext and TriggerContext in window

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34140: --- Description: Currently, WindowContext and TriggerContext not only contains a series of get methods to

[jira] [Updated] (FLINK-34140) Rename WindowContext in window

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34140: --- Description: Currently, WindowContext not only contains a series of get methods to obtain context

[jira] [Created] (FLINK-34140) Rename WindowContext in window

2024-01-17 Thread xuyang (Jira)
xuyang created FLINK-34140: -- Summary: Rename WindowContext in window Key: FLINK-34140 URL: https://issues.apache.org/jira/browse/FLINK-34140 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-34138) Improve the interface about MergeCallback in window

2024-01-17 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-34138: - Assignee: xuyang > Improve the interface about MergeCallback in window >

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-17 Thread via GitHub
1996fanrui commented on code in PR #24003: URL: https://github.com/apache/flink/pull/24003#discussion_r1456812210 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExecutionFailureHandlerTest.java: ## @@ -183,6 +194,55 @@ void

[jira] [Updated] (FLINK-34138) Improve the interface about MergeCallback in window

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34138: --- Description: As a merge method, the return value type is `void`, that is confusing. > Improve the

[jira] [Updated] (FLINK-34139) The slice assigner should not reveal its event time or process time at the interface level.

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34139: --- Description: Currently, there is a function `boolean isEventTime()` to tell other that it is by event time

[jira] [Updated] (FLINK-34139) The slice assigner should not reveal its event time or process time at the interface level.

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34139: --- Summary: The slice assigner should not reveal its event time or process time at the interface level. (was:

[jira] [Updated] (FLINK-34139) The window assigner should not reveal its event time or process time at the interface level.

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34139: --- Description: Currently, there is a function  > The window assigner should not reveal its event time or

[jira] [Updated] (FLINK-34130) Mark setBytes and getBytes of Configuration as @Internal

2024-01-17 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34130: Fix Version/s: 2.0.0 (was: 1.19.0) > Mark setBytes and getBytes of Configuration

Re: [PR] [FLINK-34132][runtime] Correct the error message and doc of AdaptiveBatch only supports all edges being BLOCKING or HYBRID_FULL/HYBRID_SELECTIVE. [flink]

2024-01-17 Thread via GitHub
JunRuiLee commented on PR #24118: URL: https://github.com/apache/flink/pull/24118#issuecomment-1897703554 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-34139) The window assigner should not reveal its event time or process time at the interface level.

2024-01-17 Thread xuyang (Jira)
xuyang created FLINK-34139: -- Summary: The window assigner should not reveal its event time or process time at the interface level. Key: FLINK-34139 URL: https://issues.apache.org/jira/browse/FLINK-34139

Re: [PR] [FLINK-34132][runtime] Correct the error message and doc of AdaptiveBatch only supports all edges being BLOCKING or HYBRID_FULL/HYBRID_SELECTIVE. [flink]

2024-01-17 Thread via GitHub
JunRuiLee commented on code in PR #24118: URL: https://github.com/apache/flink/pull/24118#discussion_r1456765220 ## docs/content/docs/deployment/elastic_scaling.md: ## @@ -238,7 +238,7 @@ In addition, there are several related configuration options that may need adjus ###

Re: [PR] Update operators link in First Steps documentation [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24126: URL: https://github.com/apache/flink/pull/24126#issuecomment-1897701307 ## CI report: * 352762507edb48e1eb514c16d799a1b8afad4cf8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34138) Improve the interface about MergeCallback in window

2024-01-17 Thread xuyang (Jira)
xuyang created FLINK-34138: -- Summary: Improve the interface about MergeCallback in window Key: FLINK-34138 URL: https://issues.apache.org/jira/browse/FLINK-34138 Project: Flink Issue Type:

[PR] Update operators link in First Steps documentation [flink]

2024-01-17 Thread via GitHub
ryanvickr opened a new pull request, #24126: URL: https://github.com/apache/flink/pull/24126 The link leads to a blank operators page which is confusing, when it should really lead to the operators overview page. ## What is the purpose of the change *(For example: This

Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]

2024-01-17 Thread via GitHub
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897687775 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]

2024-01-17 Thread via GitHub
swuferhong commented on PR #24096: URL: https://github.com/apache/flink/pull/24096#issuecomment-1897681337 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-34072) Use JAVA_RUN in shell scripts

2024-01-17 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-34072. -- Resolution: Fixed merged in master: e7c8cd1562ebd45c1f7b48f519a11c6cd4fdf100 > Use JAVA_RUN in shell

Re: [PR] [FLINK-34072][scripts] Replace java command to JAVA_RUN in config.sh [flink]

2024-01-17 Thread via GitHub
Myasuka merged PR #24085: URL: https://github.com/apache/flink/pull/24085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31511][doc-zh] Update the document sql_functions_zh.yml and fix some parts in sql_functions.yml [flink]

2024-01-17 Thread via GitHub
ruanhang1993 commented on PR #5: URL: https://github.com/apache/flink/pull/5#issuecomment-1897676303 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-31449][resourcemanager] Remove DeclarativeSlotManager related logic [flink]

2024-01-17 Thread via GitHub
huwh commented on PR #24102: URL: https://github.com/apache/flink/pull/24102#issuecomment-1897673795 @KarmaGYZ @reswqa Can you help review it? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (FLINK-34119) Improve description about changelog in document

2024-01-17 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-34119. -- Fix Version/s: 1.19.0 Resolution: Fixed merged 2ec8f81 into master > Improve

Re: [PR] [FLINK-34119][doc] Improve description about changelog in document [flink]

2024-01-17 Thread via GitHub
masteryhx merged PR #24111: URL: https://github.com/apache/flink/pull/24111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-17 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1897661962 > Thanks for addressing comments in general it looks ok from my side i guess there is one little thing: since it is based on Calcite parser it allows to have `ORDER BY` inside... At

Re: [PR] [FLINK-34119][doc] Improve description about changelog in document [flink]

2024-01-17 Thread via GitHub
masteryhx commented on PR #24111: URL: https://github.com/apache/flink/pull/24111#issuecomment-1897661018 > @masteryhx Thanks for the contribution, LGTM. CI seems broken by https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34077 Thanks for the review. The failed python

Re: [PR] [FLINK-34080][configuration] Simplify the Configuration [flink]

2024-01-17 Thread via GitHub
1996fanrui commented on PR #24088: URL: https://github.com/apache/flink/pull/24088#issuecomment-1897658106 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-30656) Provide more logs for schema compatibility check

2024-01-17 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807968#comment-17807968 ] Hangxiang Yu commented on FLINK-30656: -- We should support to remain some messages for

[jira] [Commented] (FLINK-34133) Merge MiniBatchInterval when propagate traits to child block

2024-01-17 Thread zhouli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807965#comment-17807965 ] zhouli commented on FLINK-34133: Hi [~xuyangzhong] , I have put the code and plan in the attachments

[jira] [Updated] (FLINK-34133) Merge MiniBatchInterval when propagate traits to child block

2024-01-17 Thread zhouli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhouli updated FLINK-34133: --- Attachment: plan.txt > Merge MiniBatchInterval when propagate traits to child block >

[jira] [Updated] (FLINK-34133) Merge MiniBatchInterval when propagate traits to child block

2024-01-17 Thread zhouli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhouli updated FLINK-34133: --- Attachment: StreamWindowSQLExample.java > Merge MiniBatchInterval when propagate traits to child block >

[jira] [Updated] (FLINK-34133) Merge MiniBatchInterval when propagate traits to child block

2024-01-17 Thread zhouli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhouli updated FLINK-34133: --- Attachment: (was: MinibatchIntervalTest.java) > Merge MiniBatchInterval when propagate traits to child

Re: [PR] [FLINK-34132][runtime] Correct the error message and doc of AdaptiveBatch only supports all edges being BLOCKING or HYBRID_FULL/HYBRID_SELECTIVE. [flink]

2024-01-17 Thread via GitHub
wanglijie95 commented on code in PR #24118: URL: https://github.com/apache/flink/pull/24118#discussion_r1456018455 ## docs/content/docs/deployment/elastic_scaling.md: ## @@ -238,7 +238,7 @@ In addition, there are several related configuration options that may need adjus ###

Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]

2024-01-17 Thread via GitHub
lindong28 commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1456726081 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -143,12 +144,14 @@ private

Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]

2024-01-17 Thread via GitHub
lindong28 commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1456726081 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -143,12 +144,14 @@ private

[jira] [Comment Edited] (FLINK-34133) Merge MiniBatchInterval when propagate traits to child block

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807963#comment-17807963 ] xuyang edited comment on FLINK-34133 at 1/18/24 1:38 AM: - Hi, [~Leo Zhou] can

[jira] [Commented] (FLINK-34133) Merge MiniBatchInterval when propagate traits to child block

2024-01-17 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807963#comment-17807963 ] xuyang commented on FLINK-34133: Hi, can you attach the code and plan as text in the `code` block? I'll

Re: [PR] [FLINK-34132][runtime] Correct the error message and doc of AdaptiveBatch only supports all edges being BLOCKING or HYBRID_FULL/HYBRID_SELECTIVE. [flink]

2024-01-17 Thread via GitHub
JunRuiLee commented on PR #24118: URL: https://github.com/apache/flink/pull/24118#issuecomment-1897604825 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34126][configuration] Correct the description of jobmanager.scheduler [flink]

2024-01-17 Thread via GitHub
JunRuiLee commented on PR #24112: URL: https://github.com/apache/flink/pull/24112#issuecomment-1897604085 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

2024-01-17 Thread via GitHub
Sxnan commented on PR #24089: URL: https://github.com/apache/flink/pull/24089#issuecomment-1897598262 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-17 Thread via GitHub
snuyanzin commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1897393850 Thanks for addressing comments in general it looks ok from my side i guess there is one little thing: since it is based on Calcite parser it allows to have `ORDER BY` inside...

Re: [PR] [hotfix] Synchronize CI pipeline setup [flink-connector-kafka]

2024-01-17 Thread via GitHub
snuyanzin commented on PR #78: URL: https://github.com/apache/flink-connector-kafka/pull/78#issuecomment-1896939681 yeah... initially there were already 2 jdks (8, 11) in ci for PRs and that's why I've just added other jdks there... Now amount of ci jobs per is growing together with

[jira] [Commented] (FLINK-32416) Initial DynamicKafkaSource Implementation

2024-01-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807888#comment-17807888 ] Martijn Visser commented on FLINK-32416: Fixed in apache/flink-connector-kafka:main initial

[jira] [Closed] (FLINK-32416) Initial DynamicKafkaSource Implementation

2024-01-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32416. -- Resolution: Fixed > Initial DynamicKafkaSource Implementation >

Re: [PR] [FLINK-32416] Fix flaky tests by ensuring test utilities produce records w… [flink-connector-kafka]

2024-01-17 Thread via GitHub
MartijnVisser merged PR #79: URL: https://github.com/apache/flink-connector-kafka/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32416] Fix flaky tests by ensuring test utilities produce records w… [flink-connector-kafka]

2024-01-17 Thread via GitHub
MartijnVisser commented on PR #79: URL: https://github.com/apache/flink-connector-kafka/pull/79#issuecomment-1896516685 > which thing to fix are you referring to? I misread https://github.com/apache/flink-connector-kafka/pull/79#discussion_r1454686838 as that you still wanted to

Re: [PR] [FLINK-32622][table-planner] Optimize mini-batch assignment [flink]

2024-01-17 Thread via GitHub
jeyhunkarimov commented on PR #23470: URL: https://github.com/apache/flink/pull/23470#issuecomment-1896341427 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.18) [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24125: URL: https://github.com/apache/flink/pull/24125#issuecomment-1896298802 ## CI report: * 4d83dffb1e1ba29ef45c92c130c25a79491cef71 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.17) [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24124: URL: https://github.com/apache/flink/pull/24124#issuecomment-1896297492 ## CI report: * 7b779ec4eae3df491b3f3a2b72bca99c996e3473 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-17 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1896292338 It looks like we have used the approach from

[PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.18) [flink]

2024-01-17 Thread via GitHub
patricklucas opened a new pull request, #24125: URL: https://github.com/apache/flink/pull/24125 This is a backport of #23836 to 1.18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL (backport to 1.17) [flink]

2024-01-17 Thread via GitHub
patricklucas opened a new pull request, #24124: URL: https://github.com/apache/flink/pull/24124 This is a backport of #23836 to 1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32622][table-planner] Optimize mini-batch assignment [flink]

2024-01-17 Thread via GitHub
jeyhunkarimov commented on PR #23470: URL: https://github.com/apache/flink/pull/23470#issuecomment-1896275667 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2024-01-17 Thread via GitHub
patricklucas commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1896272486 @XComp sure, coming up shortly. Thanks for the review, @afedulov. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2024-01-17 Thread via GitHub
XComp commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1896250037 Sure. Could you provide backport PRs for 1.18 and 1.17? Then I can merge all the necessary PRs at once. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33844][doc] Update japicmp configuration for 1.18.1 [flink]

2024-01-17 Thread via GitHub
flinkbot commented on PR #24123: URL: https://github.com/apache/flink/pull/24123#issuecomment-1896231867 ## CI report: * 8e6b149eae970cae1d2cb8c497943694124907d7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-17 Thread via GitHub
justin-chen commented on code in PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1456093406 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java: ## @@ -55,4 +55,7 @@

[jira] [Updated] (FLINK-33776) Allow to specify optional profile for connectors

2024-01-17 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot updated FLINK-33776: - Component/s: Build System / CI > Allow to specify optional profile for connectors >

[jira] [Updated] (FLINK-33776) Allow to specify optional profile for connectors

2024-01-17 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot updated FLINK-33776: - Issue Type: Improvement (was: Bug) > Allow to specify optional profile for connectors

[jira] [Updated] (FLINK-33776) Allow to specify optional profile for connectors

2024-01-17 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot updated FLINK-33776: - Fix Version/s: (was: connector-parent-1.1.0) > Allow to specify optional profile

[jira] [Comment Edited] (FLINK-33776) Allow to specify optional profile for connectors

2024-01-17 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807803#comment-17807803 ] Etienne Chauchot edited comment on FLINK-33776 at 1/17/24 5:01 PM: ---

[jira] [Comment Edited] (FLINK-33776) Allow to specify optional profile for connectors

2024-01-17 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807803#comment-17807803 ] Etienne Chauchot edited comment on FLINK-33776 at 1/17/24 5:01 PM: ---

[jira] [Comment Edited] (FLINK-34135) A number of ci failures with Access to the path '.../_work/_temp/containerHandlerInvoker.js' is denied.

2024-01-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807809#comment-17807809 ] Sergey Nuyanzin edited comment on FLINK-34135 at 1/17/24 4:56 PM: -- most

Re: [PR] [hotfix] Fix flaky tests by ensuring test utilities produce records w… [flink-connector-kafka]

2024-01-17 Thread via GitHub
mas-chen commented on PR #79: URL: https://github.com/apache/flink-connector-kafka/pull/79#issuecomment-1896211992 @MartijnVisser which thing to fix are you referring to? I think this PR is ready as-is if it blocking your other work. The ticket I'll need a few days to look into, probably

  1   2   3   >