[jira] [Created] (FLINK-29749) flink info command support dynamic properties

2022-10-24 Thread jackylau (Jira)
jackylau created FLINK-29749: Summary: flink info command support dynamic properties Key: FLINK-29749 URL: https://issues.apache.org/jira/browse/FLINK-29749 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot commented on pull request #21144: [FLINK-29747] refactor: module-based app to standalone components

2022-10-24 Thread GitBox
flinkbot commented on PR #21144: URL: https://github.com/apache/flink/pull/21144#issuecomment-1290004035 ## CI report: * aa898fd31f50a69d8bad471df434fb02ab0f28fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29711) Topic notification not present in metadata after 60000 ms.

2022-10-24 Thread Durgesh Mishra (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623561#comment-17623561 ] Durgesh Mishra commented on FLINK-29711: [~martijnvisser]  and [~mason6345]  Can you guys help

[jira] [Updated] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29747: --- Labels: pull-request-available (was: ) > [UI] Refactor runtime web from module-based to

[GitHub] [flink] yangjunhan opened a new pull request, #21144: [FLINK-29747] refactor: module-based app to standalone components

2022-10-24 Thread GitBox
yangjunhan opened a new pull request, #21144: URL: https://github.com/apache/flink/pull/21144 ## What is the purpose of the change FLINK-29747 ## Brief change log Refactor module-based app to standalone components with lazy loading. ## Verifying this

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #328: [FLINK-29714] Merge TableWrite and TableCompact into one interface

2022-10-24 Thread GitBox
JingsongLi commented on code in PR #328: URL: https://github.com/apache/flink-table-store/pull/328#discussion_r1004006577 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeWriter.java: ## @@ -137,6 +137,11 @@ public void write(KeyValue

[GitHub] [flink] xintongsong commented on pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

2022-10-24 Thread GitBox
xintongsong commented on PR #20910: URL: https://github.com/apache/flink/pull/20910#issuecomment-1289993309 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] xintongsong commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
xintongsong commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1004004779 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherImpl.java: ## @@ -148,102 +156,106 @@ private void fetchMetrics()

[jira] [Assigned] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-29609: -- Assignee: Sriram Ganesh > Clean up jobmanager deployment on suspend after recording

[jira] [Commented] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-10-24 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623554#comment-17623554 ] Sriram Ganesh commented on FLINK-29609: --- [~gyfora] - Please assign this to me. > Clean up

[GitHub] [flink] TanYuxin-tyx commented on pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
TanYuxin-tyx commented on PR #21132: URL: https://github.com/apache/flink/pull/21132#issuecomment-1289958870 @xintongsong @reswqa Thanks for reviewing the change. I have addressed the comments. Could you take a look again? -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #21143: [hotfix] Fix some typo in HiveOptions.

2022-10-24 Thread GitBox
flinkbot commented on PR #21143: URL: https://github.com/apache/flink/pull/21143#issuecomment-1289954801 ## CI report: * a1c7b649082670669fdb9af042171c744e48e8b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
TanYuxin-tyx commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1003979797 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java: ## @@ -263,7 +220,151 @@ public void

[GitHub] [flink] reswqa commented on pull request #21143: [hotfix] Fix some typo in HiveOptions.

2022-10-24 Thread GitBox
reswqa commented on PR #21143: URL: https://github.com/apache/flink/pull/21143#issuecomment-1289950821 cc @luoyuxia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] reswqa opened a new pull request, #21143: [hotfix] Fix some typo in HiveOptions.

2022-10-24 Thread GitBox
reswqa opened a new pull request, #21143: URL: https://github.com/apache/flink/pull/21143 ## What is the purpose of the change *Fix some typo in HiveOptions.* ## Brief change log - *Using `withDescription` instead of `withDeprecatedKeys` for some config options.*

[GitHub] [flink] flinkbot commented on pull request #21142: [FLINK-29737][Table] Support DataGen on waveform function.

2022-10-24 Thread GitBox
flinkbot commented on PR #21142: URL: https://github.com/apache/flink/pull/21142#issuecomment-1289946308 ## CI report: * 000fb8030dc23459a3669eb62b54a58691641d06 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29737) Support DataGen on waveform function

2022-10-24 Thread chenzihao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623546#comment-17623546 ] chenzihao commented on FLINK-29737: --- [~fsk119] Thanks for your reply. I have opened the PR, please

[jira] [Updated] (FLINK-29737) Support DataGen on waveform function

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29737: --- Labels: pull-request-available (was: ) > Support DataGen on waveform function >

[GitHub] [flink] chenzihao5 opened a new pull request, #21142: [FLINK-29737][Table] Support DataGen on waveform function.

2022-10-24 Thread GitBox
chenzihao5 opened a new pull request, #21142: URL: https://github.com/apache/flink/pull/21142 ## What is the purpose of the change Support DataGen on waveform function. ## Brief change log - add three parameters: - waveform-function-enabled: Apply the

[jira] [Updated] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-29745: - Fix Version/s: table-store-0.3.0 (was: shammon) > Split reader/writer

[jira] [Assigned] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-29745: Assignee: Shammon > Split reader/writer factory for compaction in MergeTreeTest >

[jira] [Closed] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29745. Fix Version/s: shammon Resolution: Fixed master: 537e8cf4b3733d93720381c65b30024870ece533

[GitHub] [flink-table-store] JingsongLi merged pull request #331: [FLINK-29745] Use independent reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread GitBox
JingsongLi merged PR #331: URL: https://github.com/apache/flink-table-store/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] cuibo01 commented on pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

2022-10-24 Thread GitBox
cuibo01 commented on PR #20910: URL: https://github.com/apache/flink/pull/20910#issuecomment-1289929840 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-29748) Expose the optimize phase in the connector context

2022-10-24 Thread Aitozi (Jira)
Aitozi created FLINK-29748: -- Summary: Expose the optimize phase in the connector context Key: FLINK-29748 URL: https://issues.apache.org/jira/browse/FLINK-29748 Project: Flink Issue Type:

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #160: [FLINK-29434] Add AlgoOperator for Splitter

2022-10-24 Thread GitBox
yunfengzhou-hub commented on code in PR #160: URL: https://github.com/apache/flink-ml/pull/160#discussion_r1003935113 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/randomsplitter/RandomSplitterParams.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] reswqa commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
reswqa commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1003944639 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java: ## @@ -43,120 +43,77 @@ import org.junit.Test; Review

[GitHub] [flink] flinkbot commented on pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.

2022-10-24 Thread GitBox
flinkbot commented on PR #21141: URL: https://github.com/apache/flink/pull/21141#issuecomment-1289913250 ## CI report: * 45299902af8abdcc2da247f590416cf657cb9988 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] yuzelin commented on pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-10-24 Thread GitBox
yuzelin commented on PR #21133: URL: https://github.com/apache/flink/pull/21133#issuecomment-1289910411 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-29742) Support completing statement in SqlGatewayService.

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29742: --- Labels: pull-request-available (was: ) > Support completing statement in

[GitHub] [flink] yuzelin opened a new pull request, #21141: [FLINK-29742] Support completing statement in SqlGatewayService.

2022-10-24 Thread GitBox
yuzelin opened a new pull request, #21141: URL: https://github.com/apache/flink/pull/21141 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] luoyuxia commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
luoyuxia commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1289904570 @jiangjiguang Also, could you please help rebase the master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components

2022-10-24 Thread Junhan Yang (Jira)
Junhan Yang created FLINK-29747: --- Summary: [UI] Refactor runtime web from module-based to standalone components Key: FLINK-29747 URL: https://issues.apache.org/jira/browse/FLINK-29747 Project: Flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
luoyuxia commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1003945031 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[GitHub] [flink] luoyuxia commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
luoyuxia commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1003942184 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[GitHub] [flink] reswqa commented on pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-10-24 Thread GitBox
reswqa commented on PR #21137: URL: https://github.com/apache/flink/pull/21137#issuecomment-1289898634 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29745: --- Labels: pull-request-available (was: ) > Split reader/writer factory for compaction in

[GitHub] [flink-table-store] zjureel opened a new pull request, #331: [FLINK-29745] Use independent reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread GitBox
zjureel opened a new pull request, #331: URL: https://github.com/apache/flink-table-store/pull/331 Use independent reader/writer factory for compaction in `MergeTreeTest`, otherwise, there may be concurrency problems in the test case -- This is an automated message from the Apache Git

[GitHub] [flink] czy006 commented on a diff in pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

2022-10-24 Thread GitBox
czy006 commented on code in PR #21012: URL: https://github.com/apache/flink/pull/21012#discussion_r1003931113 ## flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerParameterTest.java: ## @@ -211,6 +218,37 @@ void testProvideJobId() throws

[jira] [Closed] (FLINK-20732) Implement Pulsar Sink on extend Sink API (FLIP-191)

2022-10-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-20732. - Resolution: Fixed > Implement Pulsar Sink on extend Sink API (FLIP-191) >

[jira] [Updated] (FLINK-26027) Add FLIP-33 metrics to new PulsarSink

2022-10-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-26027: -- Parent: (was: FLINK-20732) Issue Type: Improvement (was: Sub-task) > Add FLIP-33 metrics

[GitHub] [flink-table-store] zjureel commented on pull request #326: [FLINK-29702] Add micro benchmarks module and merge tree reader/writer benchmarks

2022-10-24 Thread GitBox
zjureel commented on PR #326: URL: https://github.com/apache/flink-table-store/pull/326#issuecomment-1289880133 Hi @JingsongLi I have split the reader/writer factory for compaction in the micro benchmarks and fix the concurrency problem, please review again, thanks -- This is an

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
zhipeng93 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003924160 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [flink] libenchao commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-24 Thread GitBox
libenchao commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1003920728 ## flink-connectors/flink-connector-jdbc/src/test/resources/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.xml: ## @@ -51,4 +51,22 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
zhipeng93 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003921280 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
zhipeng93 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003921280 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (FLINK-29737) Support DataGen on waveform function

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623501#comment-17623501 ] Shengkai Fang commented on FLINK-29737: --- Thanks for your idea. Could you share the PR link here?

[jira] [Updated] (FLINK-29217) CoordinatorEventsToStreamOperatorRecipientExactlyOnceITCase.testConcurrentCheckpoint failed with AssertionFailedError

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29217: - Fix Version/s: 1.16.1 (was: 1.16.0) >

[GitHub] [flink-web] godfreyhe commented on a diff in pull request #574: Announcement blogpost for the 1.16 release

2022-10-24 Thread GitBox
godfreyhe commented on code in PR #574: URL: https://github.com/apache/flink-web/pull/574#discussion_r1003917397 ## _posts/2022-10-15-1.16-announcement.md: ## @@ -0,0 +1,402 @@ +--- +layout: post +title: "Announcing the Release of Apache Flink 1.16" +subtitle: "" +date:

[jira] [Closed] (FLINK-28914) Could not find any factories that implement

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-28914. - Resolution: Fixed > Could not find any factories that implement >

[jira] [Commented] (FLINK-27773) Introduce the E2E tests for SQL Gateway

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623496#comment-17623496 ] Shengkai Fang commented on FLINK-27773: --- [~martijnvisser] It has been implemented in the 1.16. >

[jira] [Updated] (FLINK-27773) Introduce the E2E tests for SQL Gateway

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-27773: -- Fix Version/s: 1.16.0 > Introduce the E2E tests for SQL Gateway >

[jira] [Assigned] (FLINK-29732) Support configuring session with SQL statement

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-29732: - Assignee: yuzelin > Support configuring session with SQL statement >

[GitHub] [flink-web] godfreyhe commented on a diff in pull request #574: Announcement blogpost for the 1.16 release

2022-10-24 Thread GitBox
godfreyhe commented on code in PR #574: URL: https://github.com/apache/flink-web/pull/574#discussion_r1003914702 ## _posts/2022-10-15-1.16-announcement.md: ## @@ -0,0 +1,402 @@ +--- +layout: post +title: "Announcing the Release of Apache Flink 1.16" +subtitle: "" +date:

[GitHub] [flink-kubernetes-operator] morhidi closed pull request #372: [FLINK-29261] Use FAIL_ON_UNKNOWN_PROPERTIES=false in ReconciliationUtils

2022-10-24 Thread GitBox
morhidi closed pull request #372: [FLINK-29261] Use FAIL_ON_UNKNOWN_PROPERTIES=false in ReconciliationUtils URL: https://github.com/apache/flink-kubernetes-operator/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #410: Added the CRD compatability check to kubernetes operator 1.2.0

2022-10-24 Thread GitBox
morhidi commented on PR #410: URL: https://github.com/apache/flink-kubernetes-operator/pull/410#issuecomment-1289856878 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-29746) Add workflow in github for micro benchmarks

2022-10-24 Thread Shammon (Jira)
Shammon created FLINK-29746: --- Summary: Add workflow in github for micro benchmarks Key: FLINK-29746 URL: https://issues.apache.org/jira/browse/FLINK-29746 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-29692) Support early/late fires for Windowing TVFs

2022-10-24 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623481#comment-17623481 ] Benchao Li commented on FLINK-29692: {quote}'Early fire' would periodically sent intermediate result

[jira] [Created] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Shammon (Jira)
Shammon created FLINK-29745: --- Summary: Split reader/writer factory for compaction in MergeTreeTest Key: FLINK-29745 URL: https://issues.apache.org/jira/browse/FLINK-29745 Project: Flink Issue

[jira] [Updated] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29744: --- Labels: pull-request-available (was: ) > Throw DeploymentFailedException on

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #411: [FLINK-29744] Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread GitBox
morhidi opened a new pull request, #411: URL: https://github.com/apache/flink-kubernetes-operator/pull/411 ## What is the purpose of the change Handle cases when pod is unable to pull images. (a.k.a `ImagePullBackOff`) ## Brief change log Code is already handling

[GitHub] [flink] RocMarshal commented on pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2022-10-24 Thread GitBox
RocMarshal commented on PR #20990: URL: https://github.com/apache/flink/pull/20990#issuecomment-1289823623 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-29744: -- Affects Version/s: kubernetes-operator-1.3.0 > Throw DeploymentFailedException on

[jira] [Updated] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-29744: -- Component/s: Kubernetes Operator > Throw DeploymentFailedException on ImagePullBackOff >

[jira] [Created] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-29744: - Summary: Throw DeploymentFailedException on ImagePullBackOff Key: FLINK-29744 URL: https://issues.apache.org/jira/browse/FLINK-29744 Project: Flink Issue

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289657005 > @morhidi > > Thanks for the feedback and sharing your test result: > > > It resulted in an string, that might not be a valid JSON: > > I will do

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289654405 > @morhidi > > Thanks for the feedback and sharing your test result: > > > It resulted in an string, that might not be a valid JSON: > > I will do

[GitHub] [flink-kubernetes-operator] darenwkt commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289640460 @morhidi Thanks for the feedback and sharing your test result: >It resulted in an string, that might not be a valid JSON: I will do some testing on

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003776097 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + *

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003775892 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + *

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003775450 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + *

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003775090 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + *

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003773876 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/AbstractFlinkSpec.java: ## @@ -57,6 +57,9 @@ public abstract

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289601914 Another thing that I found is the structure of the stacktrace probably too verbose: ```{ "type":

[jira] [Comment Edited] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-10-24 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623369#comment-17623369 ] Sergio Sainz edited comment on FLINK-29235 at 10/24/22 7:45 PM: Hello

[jira] [Comment Edited] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-10-24 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623369#comment-17623369 ] Sergio Sainz edited comment on FLINK-29235 at 10/24/22 7:45 PM: Hello

[jira] [Commented] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-10-24 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623369#comment-17623369 ] Sergio Sainz commented on FLINK-29235: -- Hello [~chesnay]  Noticed the flink-shaded-jackson

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-24 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1289455651 Hi @libenchao , thank you very much for your review  I've addressed all of your concern. On the TablePlanTest, do you mind to check if that's how it supposed to work? I don't

[jira] [Closed] (FLINK-29529) Update flink version in flink-python-example of flink k8s operator

2022-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29529. -- Resolution: Fixed merged to main a978375daeefbf23b548aab940a7ad3c366aa661 > Update flink version in

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003629002 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/util/PrimaryKeyBuilder.java: ## @@ -0,0 +1,104 @@ +/* + *

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #408: Added improvements on the flink python example Dockerfile

2022-10-24 Thread GitBox
gyfora merged PR #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
dannycranmer commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003626614 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkBuilder.java: ## @@ -0,0 +1,144 @@ +/* + *

[jira] [Commented] (FLINK-29731) Protobuf-confluent format

2022-10-24 Thread gang ye (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623316#comment-17623316 ] gang ye commented on FLINK-29731: - Is this for adding ConfluentSchemaRegistryCoder for Protobuf (like

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289362006 I tested it and it almost works great, apart from the minor things, Gyula mentioned. There'll be probably issues with JSON encoding: I've tested it with the following

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003539179 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,216 @@ +/* + *

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003539179 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,216 @@ +/* + *

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003536293 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,179 @@ +/* + *

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003528260 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkBuilder.java: ## @@ -0,0 +1,144 @@ +/* + *

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003526661 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,179 @@ +/* + *

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-24 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1003526661 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkWriter.java: ## @@ -0,0 +1,179 @@ +/* + *

[GitHub] [flink] Samrat002 commented on pull request #21135: [FLINK-29733][hotfix/test] fix test error in flink-connector-hive

2022-10-24 Thread GitBox
Samrat002 commented on PR #21135: URL: https://github.com/apache/flink/pull/21135#issuecomment-1289169354 test failed due to [FLINK-24119](https://issues.apache.org/jira/browse/FLINK-24119) Please review ! @HuangXingBo -- This is an automated message from the Apache

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-24 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623232#comment-17623232 ] Samrat Deb commented on FLINK-24119:

[jira] [Commented] (FLINK-29545) kafka consuming stop when trigger first checkpoint

2022-10-24 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623212#comment-17623212 ] xiaogang zhou commented on FLINK-29545: --- [~pnowojski] Hi Master, I could clearly find the netty

[GitHub] [flink-web] godfreyhe commented on a diff in pull request #574: Announcement blogpost for the 1.16 release

2022-10-24 Thread GitBox
godfreyhe commented on code in PR #574: URL: https://github.com/apache/flink-web/pull/574#discussion_r1003354068 ## _config.yml: ## @@ -244,6 +260,10 @@ component_releases: release_archive: flink: + - +version_short: "1.16" +version_long: 1.16.0 +

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite

2022-10-24 Thread GitBox
RyanSkraba commented on code in PR #20267: URL: https://github.com/apache/flink/pull/20267#discussion_r1003342134 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemBehaviorTest.java: ## @@ -23,26 +23,25 @@ import org.apache.flink.core.fs.FileSystemKind;

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite

2022-10-24 Thread GitBox
RyanSkraba commented on code in PR #20267: URL: https://github.com/apache/flink/pull/20267#discussion_r1003341622 ## flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HdfsBehaviorTest.java: ## @@ -47,19 +43,17 @@ public class HdfsBehaviorTest

[GitHub] [flink] ferenc-csaky commented on pull request #21127: [FLINK-29707][cli] Fix possible comparator violation for "flink list"

2022-10-24 Thread GitBox
ferenc-csaky commented on PR #21127: URL: https://github.com/apache/flink/pull/21127#issuecomment-1289067927 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-25802) OverWindow in batch mode failed

2022-10-24 Thread Runkang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623197#comment-17623197 ] Runkang He commented on FLINK-25802: Hi, [~TsReaper] is there some update on this issue? >

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite

2022-10-24 Thread GitBox
RyanSkraba commented on code in PR #20267: URL: https://github.com/apache/flink/pull/20267#discussion_r1003339435 ## flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java: ## @@ -70,12 +60,30 @@ public class

[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite

2022-10-24 Thread GitBox
RyanSkraba commented on code in PR #20267: URL: https://github.com/apache/flink/pull/20267#discussion_r1003338793 ## flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java: ## @@ -85,9 +93,9 @@ private static boolean

  1   2   3   >