[jira] [Commented] (MBUILDCACHE-76) pom project version change not detected

2023-12-02 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792486#comment-17792486 ] Olivier Lamy commented on MBUILDCACHE-76: - a temporary workaround is to disable the cache

[jira] [Commented] (SUREFIRE-2219) Option to include stdOut/stdErr console logs into test report

2023-12-02 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792470#comment-17792470 ] Alexander Kriegisch commented on SUREFIRE-2219: --- [~michael-o]: One example is [this

[jira] [Commented] (MSHARED-1327) Change output directory default in AbstractMavenReport

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792467#comment-17792467 ] ASF GitHub Bot commented on MSHARED-1327: - kriegaex commented on PR #26: URL:

Re: [PR] [MSHARED-1327] Change output directory default [maven-reporting-impl]

2023-12-02 Thread via GitHub
kriegaex commented on PR #26: URL: https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1837317841 > I was solely refering to the fact that this `@Parameter` is read-only Hm, right. Maybe it should not be read-only. > but some don't say that the user can change

[jira] [Closed] (SUREFIRE-683) Xref link generation regression with Maven 3

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-683. --- Resolution: Not A Problem I believe that this one isn't valid anymore. The mentioned

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven-build-cache-extension]

2023-12-02 Thread via GitHub
dependabot[bot] merged PR #116: URL: https://github.com/apache/maven-build-cache-extension/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (SUREFIRE-1298) surefire-junit4 contains commons-io 2.2 pom.xml

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-1298. Fix Version/s: (was: Backlog) Assignee: Michael Osipov (was: Tibor Digana)

[jira] [Commented] (SUREFIRE-1519) intermittent "VM terminated without properly saying goodbye" failures

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792455#comment-17792455 ] Michael Osipov commented on SUREFIRE-1519: -- Is this one still valid? > intermittent "VM

[jira] [Updated] (SUREFIRE-1519) intermittent "VM terminated without properly saying goodbye" failures

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1519: - Fix Version/s: waiting-for-feedback > intermittent "VM terminated without properly

[jira] [Commented] (SUREFIRE-1671) Improve error message in case dependency cannot be downloaded

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792454#comment-17792454 ] Michael Osipov commented on SUREFIRE-1671: -- Is this one still valid? > Improve error message

[jira] [Closed] (SUREFIRE-1665) JUnits fail with Java11: IllegalArgumentException: Stream stdin corrupted. Expected comma after third character in command 'FATAL ERROR in native method: processing of

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-1665. Resolution: Invalid > JUnits fail with Java11: IllegalArgumentException: Stream stdin

[jira] [Updated] (SUREFIRE-1671) Improve error message in case dependency cannot be downloaded

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1671: - Fix Version/s: waiting-for-feedback > Improve error message in case dependency cannot

[jira] [Updated] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1810: - Fix Version/s: waiting-for-feedback > Surefire plugin SurefireBooterForkException if

[jira] [Commented] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792453#comment-17792453 ] Michael Osipov commented on SUREFIRE-1810: -- Is this one still the case? Can you provide a

[jira] [Commented] (SUREFIRE-1818) Surefire buffers log messages in memory instead of printing them out to the terminal which leads to OOM error.

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792452#comment-17792452 ] Michael Osipov commented on SUREFIRE-1818: -- Is this still the case? If yes, can you easily

[jira] [Updated] (SUREFIRE-1818) Surefire buffers log messages in memory instead of printing them out to the terminal which leads to OOM error.

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1818: - Fix Version/s: waiting-for-feedback > Surefire buffers log messages in memory instead

[jira] [Commented] (MSHARED-1327) Change output directory default in AbstractMavenReport

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792450#comment-17792450 ] ASF GitHub Bot commented on MSHARED-1327: - michael-o commented on PR #26: URL:

Re: [PR] [MSHARED-1327] Change output directory default [maven-reporting-impl]

2023-12-02 Thread via GitHub
michael-o commented on PR #26: URL: https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1837267557 > @michael-o, the way I understand it, the description applies to what I call the _base_ directory, i.e. the `${project.reporting.outputDirectory}` in case of site

[jira] [Commented] (DOXIA-710) Inconsistent anchors between toc macro and headers

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792448#comment-17792448 ] ASF GitHub Bot commented on DOXIA-710: -- michael-o commented on PR #180: URL:

Re: [PR] [DOXIASITETOOLS-320] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-02 Thread via GitHub
michael-o commented on PR #180: URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1837260464 > > This seems like a reimplementation of RandomAccessSink: The RandomAccessSink provides the ability to create a {https://github.com/link Sink} with hooks. Why not evaluate it if it

Re: [PR] Experiment; Fix for scope selector [maven-resolver]

2023-12-02 Thread via GitHub
cstamas commented on code in PR #306: URL: https://github.com/apache/maven-resolver/pull/306#discussion_r1412878989 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/selector/ScopeDependencySelector.java: ## @@ -82,15 +82,15 @@ public

Re: [PR] Experiment; Fix for scope selector [maven-resolver]

2023-12-02 Thread via GitHub
cstamas commented on code in PR #306: URL: https://github.com/apache/maven-resolver/pull/306#discussion_r1412878945 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/selector/ScopeDependencySelector.java: ## @@ -100,11 +100,11 @@ public boolean

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792445#comment-17792445 ] ASF GitHub Bot commented on MENFORCER-490: -- cstamas commented on PR #282: URL:

Re: [PR] [MENFORCER-490] Declare maven-enforcer-extension dependencies [maven-enforcer]

2023-12-02 Thread via GitHub
cstamas commented on PR #282: URL: https://github.com/apache/maven-enforcer/pull/282#issuecomment-1837253654 Stop relying on dependency:analyze output, as it declares many false positives (and negatives), typical example is slf4j-simple etc. -- This is an automated message from the

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792444#comment-17792444 ] ASF GitHub Bot commented on MENFORCER-490: -- cstamas commented on PR #282: URL:

Re: [PR] [MENFORCER-490] Declare maven-enforcer-extension dependencies [maven-enforcer]

2023-12-02 Thread via GitHub
cstamas commented on PR #282: URL: https://github.com/apache/maven-enforcer/pull/282#issuecomment-1837253314 This is completely wrong PR: how is plexus-utils provided? It WAS provided in Maven 3.8 and before, but read release notes of Maven 3.9 (same for all 3.9.x version):

[jira] [Commented] (MINSTALL-187) Switch to the new maven 4 api

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINSTALL-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792436#comment-17792436 ] ASF GitHub Bot commented on MINSTALL-187: - cstamas commented on code in PR #35: URL:

[jira] [Commented] (MINSTALL-187) Switch to the new maven 4 api

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINSTALL-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792435#comment-17792435 ] ASF GitHub Bot commented on MINSTALL-187: - cstamas commented on code in PR #35: URL:

Re: [PR] [MINSTALL-187] Switch to the new maven 4 api [maven-install-plugin]

2023-12-02 Thread via GitHub
cstamas commented on code in PR #35: URL: https://github.com/apache/maven-install-plugin/pull/35#discussion_r1412868204 ## pom.xml: ## @@ -169,24 +131,39 @@ org.slf4j - slf4j-api + slf4j-nop ${slf4jVersion} - provided + test

Re: [PR] [MINSTALL-187] Switch to the new maven 4 api [maven-install-plugin]

2023-12-02 Thread via GitHub
cstamas commented on code in PR #35: URL: https://github.com/apache/maven-install-plugin/pull/35#discussion_r1412868134 ## pom.xml: ## @@ -169,24 +131,39 @@ org.slf4j - slf4j-api + slf4j-nop ${slf4jVersion} - provided + test

[jira] [Updated] (MARTIFACT-54) In multi-module projects check-buildplan fails on project.build.outputTimestamp

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MARTIFACT-54: --- Summary: In multi-module projects check-buildplan fails on project.build.outputTimestamp

[jira] [Closed] (MARTIFACT-53) improve message when outputTimestamp not defined in reactor: WARN only

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MARTIFACT-53. -- Resolution: Fixed done in

[jira] [Updated] (MARTIFACT-53) improve message when outputTimestamp not defined in reactor: WARN only

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MARTIFACT-53: --- Description: {{[ERROR] project.build.outputTimestamp property should not be inherited but

[jira] [Updated] (MARTIFACT-53) improve message when outputTimestamp not defined in reactor: WARN only

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MARTIFACT-53: --- Summary: improve message when outputTimestamp not defined in reactor: WARN only (was:

[jira] [Assigned] (MARTIFACT-53) improve message when outputTimestamp not defined in reactor: WARN only

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy reassigned MARTIFACT-53: -- Assignee: Herve Boutemy > improve message when outputTimestamp not defined in

[jira] [Comment Edited] (MARTIFACT-53) improve message when outputTimestamp not defined in reactor: WARN only and show value

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787621#comment-17787621 ] Herve Boutemy edited comment on MARTIFACT-53 at 12/2/23 6:33 PM: - pass:

[jira] [Updated] (MARTIFACT-53) improve message when outputTimestamp not defined in reactor: WARN only and show value

2023-12-02 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MARTIFACT-53: --- Affects Version/s: 3.3.0 > improve message when outputTimestamp not defined in reactor:

[jira] [Created] (MNG-7950) Support new version scheme selector in Maven

2023-12-02 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7950: Summary: Support new version scheme selector in Maven Key: MNG-7950 URL: https://issues.apache.org/jira/browse/MNG-7950 Project: Maven Issue Type: Task

[jira] [Commented] (MRESOLVER-446) Version Scheme Provider

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792395#comment-17792395 ] ASF GitHub Bot commented on MRESOLVER-446: -- cstamas opened a new pull request, #384: URL:

[PR] [MRESOLVER-446] Introduce version scheme selector [maven-resolver]

2023-12-02 Thread via GitHub
cstamas opened a new pull request, #384: URL: https://github.com/apache/maven-resolver/pull/384 Open the gates to support multiple version schemes (currently per session). --- https://issues.apache.org/jira/browse/MRESOLVER-446 -- This is an automated message from the Apache

[jira] [Created] (MRESOLVER-446) Version Scheme Provider

2023-12-02 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-446: - Summary: Version Scheme Provider Key: MRESOLVER-446 URL: https://issues.apache.org/jira/browse/MRESOLVER-446 Project: Maven Resolver Issue Type:

[jira] [Commented] (SUREFIRE-2219) Option to include stdOut/stdErr console logs into test report

2023-12-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792381#comment-17792381 ] Michael Osipov commented on SUREFIRE-2219: -- Interesting...I am surprised that we don't do

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792380#comment-17792380 ] ASF GitHub Bot commented on MSHARED-1285: - laeubi commented on PR #83: URL:

Re: [PR] [MSHARED-1285] - incremental build does not honor `BuildContext#isUptodate()` [maven-filtering]

2023-12-02 Thread via GitHub
laeubi commented on PR #83: URL: https://github.com/apache/maven-filtering/pull/83#issuecomment-1837142122 @lalmeras thanks for the PR on working on test-case and @slawekjaranowski for aproving the workflow run, so this verifies that the described test-case fail with the current

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792377#comment-17792377 ] ASF GitHub Bot commented on MSHARED-1285: - lalmeras commented on PR #83: URL:

Re: [PR] [MSHARED-1285] - incremental build does not honor `BuildContext#isUptodate()` [maven-filtering]

2023-12-02 Thread via GitHub
lalmeras commented on PR #83: URL: https://github.com/apache/maven-filtering/pull/83#issuecomment-1837140014 PR only contains test to exhibit the issue. You can check with CI build that the two added test fail. Once the issue demonstrated, proposal from @laeubi in #77 can be applied

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792378#comment-17792378 ] ASF GitHub Bot commented on MSHARED-1285: - lalmeras commented on PR #77: URL:

Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2023-12-02 Thread via GitHub
lalmeras commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837140171 @laeubi PR #83 with failing test cases and updated commit messages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792376#comment-17792376 ] ASF GitHub Bot commented on MSHARED-1285: - lalmeras opened a new pull request, #83: URL:

[PR] [MSHARED-1285] - incremental build does not honor `BuildContext#isUptodate()` [maven-filtering]

2023-12-02 Thread via GitHub
lalmeras opened a new pull request, #83: URL: https://github.com/apache/maven-filtering/pull/83 (this is a follow-up to #77) Current incremental build does not honor isUptodate(), so changed or removed target resources are not refreshed until sources are modified or a full build is

[jira] [Commented] (MRESOLVER-445) Simplify session handling, move out logic from session builder

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792375#comment-17792375 ] ASF GitHub Bot commented on MRESOLVER-445: -- cstamas commented on PR #383: URL:

Re: [PR] [MRESOLVER-445] Simplify session handling, move out logic from session builder [maven-resolver]

2023-12-02 Thread via GitHub
cstamas commented on PR #383: URL: https://github.com/apache/maven-resolver/pull/383#issuecomment-1837138916 @gnodet "refurbished" this PR (and JIRA) as it went it totally other direction, but I perso like this simplification. Basically, the "copy" method is gone (was present due Maven

Re: [PR] Bump actions/setup-java from 3 to 4 [maven-gh-actions-shared]

2023-12-02 Thread via GitHub
slawekjaranowski commented on PR #84: URL: https://github.com/apache/maven-gh-actions-shared/pull/84#issuecomment-1837138485 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump actions/setup-java from 3 to 4 [maven-gh-actions-shared]

2023-12-02 Thread via GitHub
slawekjaranowski merged PR #85: URL: https://github.com/apache/maven-gh-actions-shared/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump actions/setup-java from 3 to 4 [maven-gh-actions-shared]

2023-12-02 Thread via GitHub
slawekjaranowski merged PR #86: URL: https://github.com/apache/maven-gh-actions-shared/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Use Maven 3.9.6 as default [maven-gh-actions-shared]

2023-12-02 Thread via GitHub
slawekjaranowski opened a new pull request, #87: URL: https://github.com/apache/maven-gh-actions-shared/pull/87 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792370#comment-17792370 ] ASF GitHub Bot commented on MSHARED-1285: - laeubi commented on PR #77: URL:

Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2023-12-02 Thread via GitHub
laeubi commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837123822 @lalmeras can you open a PR here so we see the test is currently failing? I'll then fetch the PR and add my one on top of it to prove it fixes the failing test! -- This is an

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792369#comment-17792369 ] ASF GitHub Bot commented on MSHARED-1285: - lalmeras commented on PR #77: URL:

Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2023-12-02 Thread via GitHub
lalmeras commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837123168 Thank you for your feedback. @laeubi Do you want to update your PR with my proposal so we now both have unit test demonstrating your use case (and failing with the current

Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2023-12-02 Thread via GitHub
laeubi commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837114983 @lalmeras I think you are right that m2e assumes that if the target is newer than the source it is up-todate... but I think that can be ignored for now as this is an implementation

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792360#comment-17792360 ] ASF GitHub Bot commented on MSHARED-1285: - laeubi commented on PR #77: URL:

[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792357#comment-17792357 ] ASF GitHub Bot commented on MSHARED-1285: - lalmeras commented on PR #77: URL:

[jira] [Updated] (MRESOLVER-445) Simplify session handling, move out logic from session builder

2023-12-02 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-445: -- Description: Simplify session handling (copy is gone), also move out logic from

Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2023-12-02 Thread via GitHub
lalmeras commented on PR #77: URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837113152 @laeubi Can you check

[jira] [Updated] (MRESOLVER-445) Simplify session handling, move out logic from session builder

2023-12-02 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-445: -- Summary: Simplify session handling, move out logic from session builder (was: