Re: [PR] [MNG-8081] Profile property activation interpolation [maven]

2024-04-25 Thread via GitHub
gnodet closed pull request #1477: [MNG-8081] Profile property activation interpolation URL: https://github.com/apache/maven/pull/1477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [MNG-8081] Profile property activation interpolation [maven]

2024-04-25 Thread via GitHub
gnodet commented on PR #1477: URL: https://github.com/apache/maven/pull/1477#issuecomment-2076700480 Similar to #1447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MNG-8081] Profile property activation interpolation [maven]

2024-04-22 Thread via GitHub
mbenson commented on PR #1477: URL: https://github.com/apache/maven/pull/1477#issuecomment-2069413063 Sorry @cstamas, was working late and apparently not 100%. Edited my comment with changed text in bold. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [MNG-8081] Profile property activation interpolation [maven]

2024-04-22 Thread via GitHub
cstamas commented on PR #1477: URL: https://github.com/apache/maven/pull/1477#issuecomment-2069092211 @mbenson can you clarify what you mean by "only [...] property activations" vs "all property activations" as I think don't understand it fully... -- This is an automated message from the

Re: [PR] [MNG-8081] Profile property activation interpolation [maven]

2024-04-21 Thread via GitHub
mbenson commented on PR #1477: URL: https://github.com/apache/maven/pull/1477#issuecomment-2068442626 I notice that this implementation _only_ interpolates properties in property activations, whereas my submitted implementations for both v3.9.x and v4 attempt to satisfy the "least