[GitHub] [maven-ear-plugin] dependabot[bot] commented on pull request #84: Bump maven-plugins from 37 to 39

2023-08-30 Thread via GitHub
dependabot[bot] commented on PR #84: URL: https://github.com/apache/maven-ear-plugin/pull/84#issuecomment-1699017693 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven] cstamas opened a new pull request, #1223: [MNG-7856] Maven Resolver Provider ctor and other minor code changes

2023-09-05 Thread via GitHub
cstamas opened a new pull request, #1223: URL: https://github.com/apache/maven/pull/1223 Maven Resolver Provider gets similar change as other Resolver components had in MRESOLVER-386. Also, some minor code updates like adding Override and other cosmetic stuff. ---

[GitHub] [maven] kun-lu20 commented on pull request #1218: [MNG-7863] don't email on s390 failures. The regular results are enough.

2023-09-05 Thread via GitHub
kun-lu20 commented on PR #1218: URL: https://github.com/apache/maven/pull/1218#issuecomment-1706832838 Thanks @olamy ! I appreciate it. I've talked to our team and we decided to have someone monitor the s390x pipeline regularly, so it's ok for now without sending notification emails.

[GitHub] [maven] gnodet merged pull request #1222: [MNG-7871] Fix location tracking

2023-09-05 Thread via GitHub
gnodet merged PR #1222: URL: https://github.com/apache/maven/pull/1222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] gnodet commented on a diff in pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-05 Thread via GitHub
gnodet commented on code in PR #1205: URL: https://github.com/apache/maven/pull/1205#discussion_r1315974257 ## maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java: ## @@ -104,16 +113,53 @@ private TransformerContext getTransformerContext(Map

[GitHub] [maven] cstamas opened a new pull request, #1224: [MNG-7870] Undeprecate G level metadata

2023-09-05 Thread via GitHub
cstamas opened a new pull request, #1224: URL: https://github.com/apache/maven/pull/1224 The modello generated classes should not be deprecated, and they are in use. --- https://issues.apache.org/jira/browse/MNG-7870 -- This is an automated message from the Apache Git

[GitHub] [maven-mvnd] cstamas commented on issue #836: `Could not acquire write lock for…` errors

2023-09-05 Thread via GitHub
cstamas commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-1706509873 Locking in Mavem aims to solve two things: * parallel build coordination (within one Maven parallel building process) * shared local repository across several Maven (ST or MT,

[GitHub] [maven] sebastien-doyon commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-05 Thread via GitHub
sebastien-doyon commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1315813792 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,14 +150,15 @@ private ClassRealm createRealm( List

[GitHub] [maven-mvnd] cstamas commented on issue #836: `Could not acquire write lock for…` errors

2023-09-05 Thread via GitHub
cstamas commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-1706525360 > IMHO this issue here is kind of invalid as it is a bug in maven itself and not in mvnd. I agree with this assesment, and is perfectly clear: mvnd only suffers from this

[GitHub] [maven-mvnd] eliasbalasis commented on issue #836: `Could not acquire write lock for…` errors

2023-09-05 Thread via GitHub
eliasbalasis commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-1706521125 This is a very good direction. I have witnessed locking failures on larger projects even with Redisson and Hazelcast (as mentioned in the past). These are probably

[GitHub] [maven] norrisjeremy commented on pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-05 Thread via GitHub
norrisjeremy commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1706520125 > > Would you consider adding a CLI option that a user can specify to Maven to explicitly tell it not to support remote entities / xinclude stuff (and possibly even default the option

[GitHub] [maven] gnodet commented on pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-05 Thread via GitHub
gnodet commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1706936762 @elharo can I go ahead with this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] sebastien-doyon commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-05 Thread via GitHub
sebastien-doyon commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1315813792 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,14 +150,15 @@ private ClassRealm createRealm( List

[GitHub] [maven-mvnd] hohwille commented on issue #836: `Could not acquire write lock for…` errors

2023-09-05 Thread via GitHub
hohwille commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-1706508653 I was now able to reproduce the lock errors also with pure maven and without mvnd. Therefore I created [MNG-7868](https://issues.apache.org/jira/browse/MNG-7868). IMHO this

[GitHub] [maven] sebastien-doyon commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-05 Thread via GitHub
sebastien-doyon commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1315813792 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,14 +150,15 @@ private ClassRealm createRealm( List

[GitHub] [maven-mvnd] eliasbalasis commented on issue #836: `Could not acquire write lock for…` errors

2023-09-05 Thread via GitHub
eliasbalasis commented on issue #836: URL: https://github.com/apache/maven-mvnd/issues/836#issuecomment-1706614396 Noted, the disgnostics work only with Maven 3.9.4 and resolver 1.9.14+ However, the timeout change didn't work: using

[GitHub] [maven-ear-plugin] slachiewicz commented on pull request #97: [MEAR-327] update to parent pom 39

2023-09-03 Thread via GitHub
slachiewicz commented on PR #97: URL: https://github.com/apache/maven-ear-plugin/pull/97#issuecomment-1704325339 You have duplicate license headers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-09-05 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1316362150 ## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ## @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [maven] gnodet commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-09-05 Thread via GitHub
gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1707329632 @elharo we can't refactor the `Os` class in a different PR unless we merge it first, as the PR removes the plexus-utils dependency... I'll refactor the class completely. -- This is an

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-05 Thread via GitHub
slawekjaranowski commented on PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#issuecomment-1707405320 I did a test, in test project execute `mvn clean javadoc:3.5.0:javadoc` - build pass `mvn clean package javadoc:3.5.0:javadoc` - build failed so I

[GitHub] [maven] gnodet opened a new pull request, #1225: [MNG-7864] Disable broken s390x jenkins

2023-09-05 Thread via GitHub
gnodet opened a new pull request, #1225: URL: https://github.com/apache/maven/pull/1225 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet merged pull request #1225: [MNG-7864] Disable broken s390x jenkins

2023-09-05 Thread via GitHub
gnodet merged PR #1225: URL: https://github.com/apache/maven/pull/1225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] gnodet opened a new pull request, #290: [MNG-7792] Fix shaded javaagent to relocate the asm package

2023-09-05 Thread via GitHub
gnodet opened a new pull request, #290: URL: https://github.com/apache/maven-integration-testing/pull/290 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-05 Thread via GitHub
slawekjaranowski commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1316470527 ## src/it/projects/MJAVADOC-769/src/main/java/mavenbugs/mjavadoc769/InternalImportBindingBuilder.java: ## @@ -0,0 +1,116 @@ +package

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-09-05 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1316213195 ## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ## @@ -0,0 +1,383 @@ +/* Review Comment: This class is used in two cases: for profile activation

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-05 Thread via GitHub
slawekjaranowski commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1316473035 ## src/it/projects/MJAVADOC-769/pom.xml: ## @@ -0,0 +1,170 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-05 Thread via GitHub
slawekjaranowski commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1316473897 ## src/it/projects/MJAVADOC-769/pom.xml: ## @@ -0,0 +1,169 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [maven] gnodet commented on pull request #1126: [MNG-7792] Use a standalone asm version

2023-09-05 Thread via GitHub
gnodet commented on PR #1126: URL: https://github.com/apache/maven/pull/1126#issuecomment-1707223581 > The failing IT uses this agent, and I'd look into it

[GitHub] [maven] gnodet merged pull request #1126: [MNG-7792] Use a standalone asm version

2023-09-05 Thread via GitHub
gnodet merged PR #1126: URL: https://github.com/apache/maven/pull/1126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] gnodet merged pull request #290: [MNG-7792] Fix shaded javaagent to relocate the asm package

2023-09-05 Thread via GitHub
gnodet merged PR #290: URL: https://github.com/apache/maven-integration-testing/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-05 Thread via GitHub
slawekjaranowski commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1316473897 ## src/it/projects/MJAVADOC-769/pom.xml: ## @@ -0,0 +1,169 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [maven] cstamas merged pull request #1223: [MNG-7856] Maven Resolver Provider ctor and other minor code changes

2023-09-05 Thread via GitHub
cstamas merged PR #1223: URL: https://github.com/apache/maven/pull/1223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] gnodet commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-09-05 Thread via GitHub
gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1707384017 > @elharo we can't refactor the `Os` class in a different PR unless we merge it first, as the PR removes the plexus-utils dependency... I'll refactor the class completely. Done.

[GitHub] [maven-javadoc-plugin] hgschmie commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314451026 ## src/it/projects/MJAVADOC-769/pom.xml: ## @@ -0,0 +1,169 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
slawekjaranowski commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314315492 ## src/it/projects/MJAVADOC-769/src/main/java/mavenbugs/mjavadoc769/InternalImportBindingBuilder.java: ## @@ -0,0 +1,116 @@ +package

[GitHub] [maven-site] oliveryasuna opened a new pull request, #445: Update pom.apt.vm

2023-09-03 Thread via GitHub
oliveryasuna opened a new pull request, #445: URL: https://github.com/apache/maven-site/pull/445 Replaced link to "Maven 2 Pom Demystified". The current link no longer works. I replaced it with the latest working Internet Archive link. -- This is an automated message from the

[GitHub] [maven] gnodet commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-03 Thread via GitHub
gnodet commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1314461642 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,14 +150,15 @@ private ClassRealm createRealm( List

[GitHub] [maven-javadoc-plugin] hgschmie commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314450414 ## src/it/projects/MJAVADOC-769/src/test/java/mavenbugs/mjavadoc769/RightTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed under the Apache License, Version

[GitHub] [maven-javadoc-plugin] hgschmie commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314455927 ## src/it/projects/MJAVADOC-769/src/main/java/mavenbugs/mjavadoc769/InternalImportBindingBuilder.java: ## @@ -0,0 +1,116 @@ +package

[GitHub] [maven] elharo commented on a diff in pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-05 Thread via GitHub
elharo commented on code in PR #1205: URL: https://github.com/apache/maven/pull/1205#discussion_r1316556058 ## api/maven-api-core/src/main/java/org/apache/maven/api/feature/Features.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [maven] gnodet opened a new pull request, #1226: Remove useless @author tags

2023-09-06 Thread via GitHub
gnodet opened a new pull request, #1226: URL: https://github.com/apache/maven/pull/1226 This information is usually more accurately given by the GIT history Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a

[GitHub] [maven] CrazyHZM commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-09-05 Thread via GitHub
CrazyHZM commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1707614613 > > @elharo we can't refactor the `Os` class in a different PR unless we merge it first, as the PR removes the plexus-utils dependency... I'll refactor the class completely. > >

[GitHub] [maven] gnodet opened a new pull request, #1227: Deprecate all classes in maven-compat

2023-09-06 Thread via GitHub
gnodet opened a new pull request, #1227: URL: https://github.com/apache/maven/pull/1227 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #228: [MJAVADOC-770] Implement legacy mode for Java 9+

2023-09-05 Thread via GitHub
slawekjaranowski commented on code in PR #228: URL: https://github.com/apache/maven-javadoc-plugin/pull/228#discussion_r1316494591 ## src/it/projects/MJAVADOC-770/pom.xml: ## @@ -0,0 +1,83 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [maven-resolver] kwin commented on a diff in pull request #326: [MRESOLVER-396] Back off on too many requests

2023-09-04 Thread via GitHub
kwin commented on code in PR #326: URL: https://github.com/apache/maven-resolver/pull/326#discussion_r1314879612 ## src/site/markdown/configuration.md: ## @@ -43,8 +43,11 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix

[GitHub] [maven-resolver] gnodet commented on a diff in pull request #326: [MRESOLVER-396] Back off on too many requests

2023-09-04 Thread via GitHub
gnodet commented on code in PR #326: URL: https://github.com/apache/maven-resolver/pull/326#discussion_r1314912695 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -704,4 +738,93 @@ public void writeTo(OutputStream os)

[GitHub] [maven-deploy-plugin] sratz commented on a diff in pull request #42: [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload

2023-09-04 Thread via GitHub
sratz commented on code in PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1314926092 ## src/test/java/org/apache/maven/plugins/deploy/DeployFileMojoTest.java: ## @@ -276,6 +276,45 @@ public void testDeployIfArtifactIsNotJar() throws Exception {

[GitHub] [maven-deploy-plugin] sratz commented on a diff in pull request #42: [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload

2023-09-04 Thread via GitHub
sratz commented on code in PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1314925033 ## src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java: ## @@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException,

[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-09-04 Thread via GitHub
kbuntrock commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1315087882 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -633,13 +714,7 @@ private static boolean isReadable(Path entry)

[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-09-04 Thread via GitHub
kbuntrock commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1315095649 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -165,45 +185,101 @@ public MavenProjectInput(

[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-09-04 Thread via GitHub
kbuntrock commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1315097184 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -165,45 +185,101 @@ public MavenProjectInput(

[GitHub] [maven] gnodet commented on pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-06 Thread via GitHub
gnodet commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1708243541 > I'm still not convinced this is a good idea, but if it's going in, there are still some ciode issues to be addressed. Well, I tried to kick [a discussion on

[GitHub] [maven-resolver] cstamas merged pull request #328: [MRESOLVER-397] Deprecate Guice integration

2023-09-06 Thread via GitHub
cstamas merged PR #328: URL: https://github.com/apache/maven-resolver/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] gnodet commented on a diff in pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-06 Thread via GitHub
gnodet commented on code in PR #1205: URL: https://github.com/apache/maven/pull/1205#discussion_r1317222361 ## maven-stax-xinclude/src/main/java/org/apache/maven/stax/xpointer/ElementPointerPart.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven-resolver] cstamas merged pull request #329: [MRESOLVER-399][MRESOLVER-398] Update Redisson to 3.23.4, Hazelcast 5.3.2

2023-09-06 Thread via GitHub
cstamas merged PR #329: URL: https://github.com/apache/maven-resolver/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on PR #1224: URL: https://github.com/apache/maven/pull/1224#issuecomment-1708247331 ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven] cstamas closed pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas closed pull request #1224: [MNG-7870] Undeprecate G level metadata URL: https://github.com/apache/maven/pull/1224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on code in PR #1224: URL: https://github.com/apache/maven/pull/1224#discussion_r1316874385 ## maven-repository-metadata/src/site/apt/index.apt: ## @@ -54,11 +54,3 @@ Maven Repository Metadata Model * {{{./apidocs/index.html}Java sources}} with Reader and

[GitHub] [maven-resolver] gnodet commented on pull request #328: [MRESOLVER-397] Deprecate Guice integration

2023-09-06 Thread via GitHub
gnodet commented on PR #328: URL: https://github.com/apache/maven-resolver/pull/328#issuecomment-1707960171 > Lowering the provided instantiation support from 3 to 2, to lower resources for maintenance all these. > > SL is about to be dropped, Guice same. Users should either use Sisu

[GitHub] [maven-apache-parent] kwin commented on pull request #92: [MPOM-337] load plugins containing lifecycle mappings with extensions

2023-09-06 Thread via GitHub
kwin commented on PR #92: URL: https://github.com/apache/maven-apache-parent/pull/92#issuecomment-1708115793 @hboutemy Do you still have concerns with merging this? If so can you please elaborate on the why? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on code in PR #1224: URL: https://github.com/apache/maven/pull/1224#discussion_r1317120384 ## maven-repository-metadata/src/site/apt/index.apt: ## @@ -27,38 +27,8 @@ Maven Repository Metadata Model This is strictly the model for Maven Repository Metadata,

[GitHub] [maven] cstamas commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on code in PR #1224: URL: https://github.com/apache/maven/pull/1224#discussion_r1317126822 ## maven-repository-metadata/src/site/apt/index.apt: ## @@ -27,38 +27,8 @@ Maven Repository Metadata Model This is strictly the model for Maven Repository Metadata,

[GitHub] [maven] hboutemy commented on a diff in pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
hboutemy commented on code in PR #1224: URL: https://github.com/apache/maven/pull/1224#discussion_r1317109620 ## maven-repository-metadata/src/site/apt/index.apt: ## @@ -27,38 +27,8 @@ Maven Repository Metadata Model This is strictly the model for Maven Repository Metadata,

[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on PR #1224: URL: https://github.com/apache/maven/pull/1224#issuecomment-1707840631 Yes, it was done as part of MNG-7055: * https://github.com/apache/maven/pull/555 (master) * https://github.com/apache/maven/pull/691 (port to maven-3.9.x) -- This is an

[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on PR #1224: URL: https://github.com/apache/maven/pull/1224#issuecomment-1707855200 My point is, that the related code change simply made G level metadata work the "same way" as GA and GAV level metadata worked: user needs not to manage it, it all happens transparently

[GitHub] [maven] cstamas commented on pull request #1224: [MNG-7870] Undeprecate G level metadata

2023-09-06 Thread via GitHub
cstamas commented on PR #1224: URL: https://github.com/apache/maven/pull/1224#issuecomment-1707871954 And finally, i find this page (rendered as part of maven-repository-metadata site) a bit anemic, and IMHO missing the point:

[GitHub] [maven] gnodet merged pull request #1226: Remove useless @author tags

2023-09-06 Thread via GitHub
gnodet merged PR #1226: URL: https://github.com/apache/maven/pull/1226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG-7836] Support alternative syntaxes for POMs

2023-09-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1315406561 ## api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [maven] gnodet commented on pull request #1205: [MNG-5862] Support XML entities and XInclude

2023-09-05 Thread via GitHub
gnodet commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1706323837 > > I tried to mitigate the risks by only loading from rejecting any absolute URI. Also, no file with such entities / xinclude import should end up in maven central, those are translated

[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request, #108: Bump actions/checkout from 3 to 4

2023-09-04 Thread via GitHub
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/maven-wrapper/pull/108 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases.

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG-7836] Support alternative syntaxes for POMs

2023-09-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1315404890 ## api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request, #80: Bump actions/checkout from 3 to 4

2023-09-04 Thread via GitHub
dependabot[bot] opened a new pull request, #80: URL: https://github.com/apache/maven-gh-actions-shared/pull/80 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's

[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request, #79: Bump actions/checkout from 3 to 4

2023-09-04 Thread via GitHub
dependabot[bot] opened a new pull request, #79: URL: https://github.com/apache/maven-gh-actions-shared/pull/79 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's

[GitHub] [maven-javadoc-plugin] hgschmie commented on pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-06 Thread via GitHub
hgschmie commented on PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#issuecomment-1709250741 I am not sure that the behavior that you are observing is related to this PR. With the current release (3.5.0): When running "clean javadoc:javadoc", the

[GitHub] [maven-build-cache-extension] dependabot[bot] opened a new pull request, #101: Bump com.github.tomakehurst:wiremock-jre8 from 2.35.0 to 2.35.1

2023-09-07 Thread via GitHub
dependabot[bot] opened a new pull request, #101: URL: https://github.com/apache/maven-build-cache-extension/pull/101 Bumps [com.github.tomakehurst:wiremock-jre8](https://github.com/wiremock/wiremock) from 2.35.0 to 2.35.1. Release notes Sourced from

[GitHub] [maven-javadoc-plugin] hgschmie commented on pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-06 Thread via GitHub
hgschmie commented on PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#issuecomment-1709311461 This is the slightly longer (and a bit more winded) explanation of what that patch does: consider a project that spits out a module. This can be a defined module or

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven] hboutemy commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320812506 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] hboutemy commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320856958 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320857116 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320858589 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on PR #1231: URL: https://github.com/apache/maven/pull/1231#issuecomment-1712915939 using slf4j vs console is completely orthogonal: it does not change anything to this issue. Don't hesitate to open a Jira and a PR in parallel on `Downloading

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320854377 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320858231 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven-site] elharo opened a new pull request, #446: [MNGSITE-393] Remove Maven 2 references

2023-09-10 Thread via GitHub
elharo opened a new pull request, #446: URL: https://github.com/apache/maven-site/pull/446 and other minor copy edits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] michael-o commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
michael-o commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320855548 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven] hboutemy commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320808439 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven] gnodet opened a new pull request, #1233: XML fixes

2023-09-10 Thread via GitHub
gnodet opened a new pull request, #1233: URL: https://github.com/apache/maven/pull/1233 - Remove unused method in generated xml writers - Fix stax writer to generate nicer XML - Use XMLConstants - Do not build location information if not needed -- This is an automated message

[GitHub] [maven] michael-o commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
michael-o commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320792496 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] hboutemy commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320808439 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -184,14 +189,19 @@ protected

[GitHub] [maven] hboutemy commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320856876 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven-javadoc-plugin] hgschmie opened a new pull request, #237: fix jenkins link

2023-09-10 Thread via GitHub
hgschmie opened a new pull request, #237: URL: https://github.com/apache/maven-javadoc-plugin/pull/237 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC)

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320853550 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] cstamas commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
cstamas commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320853289 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven-javadoc-plugin] slawekjaranowski opened a new pull request, #236: Fix build on jenkins

2023-09-10 Thread via GitHub
slawekjaranowski opened a new pull request, #236: URL: https://github.com/apache/maven-javadoc-plugin/pull/236 On Jenkins we also use Maven 3.6.3 we need specified maven.compiler.target/source at least --- Following this checklist to help us incorporate your contribution

[GitHub] [maven] michael-o commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
michael-o commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320770513 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven] hboutemy commented on a diff in pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub
hboutemy commented on code in PR #1231: URL: https://github.com/apache/maven/pull/1231#discussion_r1320790948 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent

[GitHub] [maven-javadoc-plugin] hgschmie opened a new pull request, #238: [MJAVADOC-642] Make offline mode configurable

2023-09-10 Thread via GitHub
hgschmie opened a new pull request, #238: URL: https://github.com/apache/maven-javadoc-plugin/pull/238 Turns out that `mvn deploy` and `mvn clean deploy` do different things with settings. Explicitly add settings to the test-javadoc-test-plugin config, otherwise it throws a NPE when

  1   2   3   4   5   6   7   8   9   10   >