[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846730#comment-17846730
]
ASF GitHub Bot commented on MPLUGIN-519:
cstamas commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1602074186
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
This change is unrelated. What happened is that those users had no prefix
set (ever), so remote metadata has no prefix either, and now that they
upgraded, and forced to set plugin prefix (in latest m-p-p), NPE happens.
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.13.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)
[
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846726#comment-17846726
]
ASF GitHub Bot commented on MNG-8121:
-
kwin commented on PR #1508:
URL: https://github.com/apache/maven/pull/1508#issuecomment-2113118088
This is what I proposed in
https://github.com/apache/maven/commit/bc03b1762f6fab02985145e70bf6edd97102e2dc
(even together with test cases and this was declined by @michael-o back then).
Can we please add some test cases?
> NullPointerException at
> org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
>
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-3
>
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of
> a plugin did not have a goalPrefix set.
>
> At least, this is my interpretation of what is going on.
>
> Background
> -
>
> I have an open-source project at
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1]
> with the following coordinates:
>
> com.googlecode.cmake-maven-project
> cmake
>
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced
> to set "" because of
> https://issues.apache.org/jira/browse/MPLUGIN-450 and
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>
> In my particular case, I set "cmake-binaries" inside
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following
> exception stack trace:
>
>
> {noformat}
> java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:99)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:59)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:56)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:399)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:294)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:202)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:393)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:131)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> (AbstractDeployStrategy.java:213)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
> (StagingDeployStrategy.java:125)
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute
> (DeployMojo.java:213)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126){noformat}
>
> I assume that this is caused by {{preExisting.getPrefix()}} returning null,
> but I have no idea why this is happening. Perhaps this is caused by previous
> versions not have a goalPrefix set? Shouldn't the implementation handle this
> possibility?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)
[
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846720#comment-17846720
]
ASF GitHub Bot commented on MNG-8121:
-
cstamas merged PR #1508:
URL: https://github.com/apache/maven/pull/1508
> NullPointerException at
> org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
>
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-3
>
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of
> a plugin did not have a goalPrefix set.
>
> At least, this is my interpretation of what is going on.
>
> Background
> -
>
> I have an open-source project at
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1]
> with the following coordinates:
>
> com.googlecode.cmake-maven-project
> cmake
>
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced
> to set "" because of
> https://issues.apache.org/jira/browse/MPLUGIN-450 and
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>
> In my particular case, I set "cmake-binaries" inside
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following
> exception stack trace:
>
>
> {noformat}
> java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:99)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:59)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:56)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:399)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:294)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:202)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:393)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:131)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> (AbstractDeployStrategy.java:213)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
> (StagingDeployStrategy.java:125)
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute
> (DeployMojo.java:213)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126){noformat}
>
> I assume that this is caused by {{preExisting.getPrefix()}} returning null,
> but I have no idea why this is happening. Perhaps this is caused by previous
> versions not have a goalPrefix set? Shouldn't the implementation handle this
> possibility?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)
[
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846719#comment-17846719
]
ASF GitHub Bot commented on MNG-8121:
-
cstamas merged PR #1509:
URL: https://github.com/apache/maven/pull/1509
> NullPointerException at
> org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
>
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-3
>
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of
> a plugin did not have a goalPrefix set.
>
> At least, this is my interpretation of what is going on.
>
> Background
> -
>
> I have an open-source project at
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1]
> with the following coordinates:
>
> com.googlecode.cmake-maven-project
> cmake
>
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced
> to set "" because of
> https://issues.apache.org/jira/browse/MPLUGIN-450 and
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>
> In my particular case, I set "cmake-binaries" inside
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following
> exception stack trace:
>
>
> {noformat}
> java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:99)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:59)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:56)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:399)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:294)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:202)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:393)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:131)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> (AbstractDeployStrategy.java:213)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
> (StagingDeployStrategy.java:125)
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute
> (DeployMojo.java:213)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126){noformat}
>
> I assume that this is caused by {{preExisting.getPrefix()}} returning null,
> but I have no idea why this is happening. Perhaps this is caused by previous
> versions not have a goalPrefix set? Shouldn't the implementation handle this
> possibility?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)
[
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846716#comment-17846716
]
ASF GitHub Bot commented on MNG-8121:
-
cstamas opened a new pull request, #1509:
URL: https://github.com/apache/maven/pull/1509
There is an NPE if existing metadata due bug of nx-staging-m-p had no prefix
present.
---
https://issues.apache.org/jira/browse/MNG-8121
> NullPointerException at
> org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
>
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7
>
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of
> a plugin did not have a goalPrefix set.
>
> At least, this is my interpretation of what is going on.
>
> Background
> -
>
> I have an open-source project at
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1]
> with the following coordinates:
>
> com.googlecode.cmake-maven-project
> cmake
>
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced
> to set "" because of
> https://issues.apache.org/jira/browse/MPLUGIN-450 and
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>
> In my particular case, I set "cmake-binaries" inside
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following
> exception stack trace:
>
>
> {noformat}
> java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:99)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:59)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:56)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:399)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:294)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:202)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:393)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:131)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> (AbstractDeployStrategy.java:213)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
> (StagingDeployStrategy.java:125)
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute
> (DeployMojo.java:213)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126){noformat}
>
> I assume that this is caused by {{preExisting.getPrefix()}} returning null,
> but I have no idea why this is happening. Perhaps this is caused by previous
> versions not have a goalPrefix set? Shouldn't the implementation handle this
> possibility?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)
[
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846711#comment-17846711
]
ASF GitHub Bot commented on MNG-8121:
-
cstamas opened a new pull request, #1508:
URL: https://github.com/apache/maven/pull/1508
There is an NPE if existing metadata due bug of nx-staging-m-p had no prefix
present.
---
https://issues.apache.org/jira/browse/MNG-8121
> NullPointerException at
> org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
>
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Priority: Major
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of
> a plugin did not have a goalPrefix set.
>
> At least, this is my interpretation of what is going on.
>
> Background
> -
>
> I have an open-source project at
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1]
> with the following coordinates:
>
> com.googlecode.cmake-maven-project
> cmake
>
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced
> to set "" because of
> https://issues.apache.org/jira/browse/MPLUGIN-450 and
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>
> In my particular case, I set "cmake-binaries" inside
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following
> exception stack trace:
>
>
> {noformat}
> java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:293)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:99)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:59)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:56)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:399)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:294)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:202)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:393)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:131)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> (AbstractDeployStrategy.java:213)
> at
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
> (StagingDeployStrategy.java:125)
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute
> (DeployMojo.java:213)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126){noformat}
>
> I assume that this is caused by {{preExisting.getPrefix()}} returning null,
> but I have no idea why this is happening. Perhaps this is caused by previous
> versions not have a goalPrefix set? Shouldn't the implementation handle this
> possibility?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846614#comment-17846614
]
ASF GitHub Bot commented on MPLUGIN-519:
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1601571108
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
Is it materialized https://issues.apache.org/jira/browse/MNG-8121 ❓
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.13.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7375) Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with invalid/incomplete plugin metadata
[
https://issues.apache.org/jira/browse/MNG-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846608#comment-17846608
]
ASF GitHub Bot commented on MNG-7375:
-
cowwoc commented on PR #645:
URL: https://github.com/apache/maven/pull/645#issuecomment-2112376584
@cstamas Apologies. I should have linked to the related issue:
https://issues.apache.org/jira/browse/MNG-8121
nexus-staging-maven-plugin works in version 3.12.0 but breaks in 3.13.0.
> Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with
> invalid/incomplete plugin metadata
> ---
>
> Key: MNG-7375
> URL: https://issues.apache.org/jira/browse/MNG-7375
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Affects Versions: 3.8.4
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: NEXUS-30749 - Broken groupId metadata and follow-up NPE
> during
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> - Sonatype JIRA.pdf
>
>
> Currently the metadata at
> https://repository.apache.org/service/local/repositories/snapshots/content/org/apache/jackrabbit/maven-metadata.xml
> contains an invalid entry without a prefix:
> {code:xml}
>
>
>
> Apache Jackrabbit FileVault - Package Maven Plugin
> filevault-package
> filevault-package-maven-plugin
>
>
> filevault-package-maven-plugin
> filevault-package-maven-plugin
>
>
>
> {code}
> This leads to an NPE when trying to deploy a new version with
> {{org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy(...)}}:
> {noformat}
> Caused by: java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:276)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:121)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:67)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:65)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:433)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:321)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:213)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:386)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:142)
> {noformat}
> Although this happened in the context of using
> "[org.sonatype.plugins:nexus-staging-maven-plugin|https://github.com/sonatype/nexus-maven-plugins]:1.6.8;
> (issue https://issues.sonatype.org/browse/NEXUS-30749 opened, exported to
> [^NEXUS-30749 - Broken groupId metadata and follow-up NPE during
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> - Sonatype JIRA.pdf] ), the affected code is in Maven.
> The metadata is probably invalid but the Metadata class should be more robust
> when trying to do the merge in
> https://github.com/apache/maven/blob/951b5ee95f40147abbc2bb9d928e408b85d5aef3/maven-repository-metadata/src/main/mdo/metadata.mdo#L100
> and just ignore all plugin entries without all mandatory elements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7375) Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with invalid/incomplete plugin metadata
[
https://issues.apache.org/jira/browse/MNG-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846579#comment-17846579
]
ASF GitHub Bot commented on MNG-7375:
-
cstamas commented on PR #645:
URL: https://github.com/apache/maven/pull/645#issuecomment-2112235172
Unsure what is there to backport here? All the affected code is deprecated,
so IMHO should be just left as is. Why is m-p-p 3.13.0 unusable with Maven 3?
> Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with
> invalid/incomplete plugin metadata
> ---
>
> Key: MNG-7375
> URL: https://issues.apache.org/jira/browse/MNG-7375
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Affects Versions: 3.8.4
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: NEXUS-30749 - Broken groupId metadata and follow-up NPE
> during
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> - Sonatype JIRA.pdf
>
>
> Currently the metadata at
> https://repository.apache.org/service/local/repositories/snapshots/content/org/apache/jackrabbit/maven-metadata.xml
> contains an invalid entry without a prefix:
> {code:xml}
>
>
>
> Apache Jackrabbit FileVault - Package Maven Plugin
> filevault-package
> filevault-package-maven-plugin
>
>
> filevault-package-maven-plugin
> filevault-package-maven-plugin
>
>
>
> {code}
> This leads to an NPE when trying to deploy a new version with
> {{org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy(...)}}:
> {noformat}
> Caused by: java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:276)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:121)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:67)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:65)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:433)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:321)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:213)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:386)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:142)
> {noformat}
> Although this happened in the context of using
> "[org.sonatype.plugins:nexus-staging-maven-plugin|https://github.com/sonatype/nexus-maven-plugins]:1.6.8;
> (issue https://issues.sonatype.org/browse/NEXUS-30749 opened, exported to
> [^NEXUS-30749 - Broken groupId metadata and follow-up NPE during
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> - Sonatype JIRA.pdf] ), the affected code is in Maven.
> The metadata is probably invalid but the Metadata class should be more robust
> when trying to do the merge in
> https://github.com/apache/maven/blob/951b5ee95f40147abbc2bb9d928e408b85d5aef3/maven-repository-metadata/src/main/mdo/metadata.mdo#L100
> and just ignore all plugin entries without all mandatory elements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7375) Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with invalid/incomplete plugin metadata
[
https://issues.apache.org/jira/browse/MNG-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846479#comment-17846479
]
ASF GitHub Bot commented on MNG-7375:
-
cowwoc commented on PR #645:
URL: https://github.com/apache/maven/pull/645#issuecomment-2111493326
Consider backporting this to Maven 3.x; otherwise, maven-plugin-plugin
version 3.13.0 cannot be used.
What is the updated status of this PR?
> Potential NPE in o.a.m.artifact.repository.metadata.Metadata.merge(...) with
> invalid/incomplete plugin metadata
> ---
>
> Key: MNG-7375
> URL: https://issues.apache.org/jira/browse/MNG-7375
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Affects Versions: 3.8.4
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: NEXUS-30749 - Broken groupId metadata and follow-up NPE
> during
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> - Sonatype JIRA.pdf
>
>
> Currently the metadata at
> https://repository.apache.org/service/local/repositories/snapshots/content/org/apache/jackrabbit/maven-metadata.xml
> contains an invalid entry without a prefix:
> {code:xml}
>
>
>
> Apache Jackrabbit FileVault - Package Maven Plugin
> filevault-package
> filevault-package-maven-plugin
>
>
> filevault-package-maven-plugin
> filevault-package-maven-plugin
>
>
>
> {code}
> This leads to an NPE when trying to deploy a new version with
> {{org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy(...)}}:
> {noformat}
> Caused by: java.lang.NullPointerException
> at org.apache.maven.artifact.repository.metadata.Metadata.merge
> (Metadata.java:276)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
> (AbstractRepositoryMetadata.java:121)
> at
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
> (AbstractRepositoryMetadata.java:67)
> at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge
> (MetadataBridge.java:65)
> at org.eclipse.aether.internal.impl.DefaultDeployer.upload
> (DefaultDeployer.java:433)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:321)
> at org.eclipse.aether.internal.impl.DefaultDeployer.deploy
> (DefaultDeployer.java:213)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy
> (DefaultRepositorySystem.java:386)
> at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy
> (DefaultArtifactDeployer.java:142)
> {noformat}
> Although this happened in the context of using
> "[org.sonatype.plugins:nexus-staging-maven-plugin|https://github.com/sonatype/nexus-maven-plugins]:1.6.8;
> (issue https://issues.sonatype.org/browse/NEXUS-30749 opened, exported to
> [^NEXUS-30749 - Broken groupId metadata and follow-up NPE during
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
> - Sonatype JIRA.pdf] ), the affected code is in Maven.
> The metadata is probably invalid but the Metadata class should be more robust
> when trying to do the merge in
> https://github.com/apache/maven/blob/951b5ee95f40147abbc2bb9d928e408b85d5aef3/maven-repository-metadata/src/main/mdo/metadata.mdo#L100
> and just ignore all plugin entries without all mandatory elements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1397) Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2
[ https://issues.apache.org/jira/browse/MSHARED-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846391#comment-17846391 ] ASF GitHub Bot commented on MSHARED-1397: - slachiewicz merged PR #34: URL: https://github.com/apache/maven-reporting-impl/pull/34 > Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2 > > > Key: MSHARED-1397 > URL: https://issues.apache.org/jira/browse/MSHARED-1397 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-impl >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-reporting-impl-4.0.0, > maven-reporting-impl-4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-365) Allow to pre-build script to set user properties
[ https://issues.apache.org/jira/browse/MINVOKER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846033#comment-17846033 ] ASF GitHub Bot commented on MINVOKER-365: - slawekjaranowski merged PR #236: URL: https://github.com/apache/maven-invoker-plugin/pull/236 > Allow to pre-build script to set user properties > > > Key: MINVOKER-365 > URL: https://issues.apache.org/jira/browse/MINVOKER-365 > Project: Maven Invoker Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > We can have a scenario when in pre-build script we run a mock server, eg by > WireMock or simply by other tools. > In such situation we have a random a use random port for listening > connection, so we need pass it to Maven execution. > Other simple scenario is when we create a temporary file with test data. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845972#comment-17845972 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o closed pull request #22: [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-reporting-exec/pull/22 > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNGSITE-538) Drop generation of site JAR
[ https://issues.apache.org/jira/browse/MNGSITE-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845967#comment-17845967 ] ASF GitHub Bot commented on MNGSITE-538: michael-o merged PR #526: URL: https://github.com/apache/maven-site/pull/526 > Drop generation of site JAR > --- > > Key: MNGSITE-538 > URL: https://issues.apache.org/jira/browse/MNGSITE-538 > Project: Maven Project Web Site > Issue Type: Task >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > > Is is highly questionable that anyone needs this site JAR. It wastes cycles. > Let's drop it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8115) Upgrade dependencies
[ https://issues.apache.org/jira/browse/MNG-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845900#comment-17845900 ] ASF GitHub Bot commented on MNG-8115: - cstamas merged PR #1496: URL: https://github.com/apache/maven/pull/1496 > Upgrade dependencies > > > Key: MNG-8115 > URL: https://issues.apache.org/jira/browse/MNG-8115 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.9.7, 3.9.x-candidate > > > Changes: > * classworlds 2.8.0 > * commons-cli 1.7.0 > * commons-io 2.16.1 > * commons-lang 3.14.0 > * plexus-interpolation 1.27 > * maven-shared-util 3.4.2 > * jansi 2.4.1 > * (test) xml-unit 2.10.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8119) Remove build section in consumer pom profiles
[ https://issues.apache.org/jira/browse/MNG-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845893#comment-17845893 ] ASF GitHub Bot commented on MNG-8119: - gnodet merged PR #1503: URL: https://github.com/apache/maven/pull/1503 > Remove build section in consumer pom profiles > - > > Key: MNG-8119 > URL: https://issues.apache.org/jira/browse/MNG-8119 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8108) Failure to create the consumer POM
[
https://issues.apache.org/jira/browse/MNG-8108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845885#comment-17845885
]
ASF GitHub Bot commented on MNG-8108:
-
gnodet merged PR #1506:
URL: https://github.com/apache/maven/pull/1506
> Failure to create the consumer POM
> --
>
> Key: MNG-8108
> URL: https://issues.apache.org/jira/browse/MNG-8108
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-1
>
>
> {code}
> [INFO] Camel :: Integration Tests
> ...
> SKIPPED
> [INFO] Camel :: Docs
>
> SKIPPED
> [INFO] Camel :: Assembly
>
> SKIPPED
> [INFO]
> --
> [INFO] BUILD FAILURE
> [INFO]
> --
> [INFO] Total time: 02:53 min
> [INFO] Finished at: 2024-04-26T15:34:00+02:00
> [INFO]
> --
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install)
> on project camel-debezium-common-parent: Execution default-install of goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install failed: 2
> problems were encountered while building the effective model for
> /Users/gnodet/work/git/camel/components/camel-debezium/camel-debezium-common/target/camel-debezium-common-parent-4.6.0-SNAPSHOT.pom
> [ERROR] - [WARNING] 'parent.relativePath' points at
> org.apache.camel:camel-debezium-common-parent instead of
> org.apache.camel:camel-debezium-parent, please verify your project structure
> @ line 22, column 3
> [ERROR] - [FATAL] Non-parseable POM
> org.apache.camel:camel-debezium-parent:4.6.0-SNAPSHOT: Unable to read model:
> Is a directory
> [ERROR] -> [Help 1]org.apache.maven.lifecycle.LifecycleExecutionException:
> Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install)
> on project camel-debezium-common-parent: Execution default-install of goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install failed: 2
> problems were encountered while building the effective model for
> /Users/gnodet/work/git/camel/components/camel-debezium/camel-debezium-common/target/camel-debezium-common-parent-4.6.0-SNAPSHOT.pom
> - [WARNING] 'parent.relativePath' points at
> org.apache.camel:camel-debezium-common-parent instead of
> org.apache.camel:camel-debezium-parent, please verify your project structure
> @ line 22, column 3
> - [FATAL] Non-parseable POM
> org.apache.camel:camel-debezium-parent:4.6.0-SNAPSHOT: Unable to read model:
> Is a directory
> [ERROR]
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -r
> ➜ camel git:(code-cleanup)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845879#comment-17845879 ] ASF GitHub Bot commented on MNG-8084: - desruisseaux commented on PR #1457: URL: https://github.com/apache/maven/pull/1457#issuecomment-2107269631 A few more changes seem to be necessary for allowing `maven-plugin-tools` and `maven-plugin-testing` to compile. I created a commit there, but no pull request yet because I'm not sure if I got the intent right: https://github.com/Geomatys/maven/commit/60a60503dda6e352a680774d7e3ab3b71c2b5c11 > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845863#comment-17845863
]
ASF GitHub Bot commented on MNG-8015:
-
gnodet merged PR #1501:
URL: https://github.com/apache/maven/pull/1501
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-13
>
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which may happen when
> {{jar}} is used), then an heuristic rule similar to Maven 3 can
> be applied: check if a {{module-info.class}} file or an {{Automatic-Name}}
> manifest attribute is present, and base the decision on that.
> This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-538) Drop generation of site JAR
[ https://issues.apache.org/jira/browse/MNGSITE-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845862#comment-17845862 ] ASF GitHub Bot commented on MNGSITE-538: michael-o opened a new pull request, #526: URL: https://github.com/apache/maven-site/pull/526 (no comment) > Drop generation of site JAR > --- > > Key: MNGSITE-538 > URL: https://issues.apache.org/jira/browse/MNGSITE-538 > Project: Maven Project Web Site > Issue Type: Task >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > > Is is highly questionable that anyone needs this site JAR. It wastes cycles. > Let's drop it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8108) Failure to create the consumer POM
[
https://issues.apache.org/jira/browse/MNG-8108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845857#comment-17845857
]
ASF GitHub Bot commented on MNG-8108:
-
gnodet opened a new pull request, #1506:
URL: https://github.com/apache/maven/pull/1506
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Failure to create the consumer POM
> --
>
> Key: MNG-8108
> URL: https://issues.apache.org/jira/browse/MNG-8108
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-1
>
>
> {code}
> [INFO] Camel :: Integration Tests
> ...
> SKIPPED
> [INFO] Camel :: Docs
>
> SKIPPED
> [INFO] Camel :: Assembly
>
> SKIPPED
> [INFO]
> --
> [INFO] BUILD FAILURE
> [INFO]
> --
> [INFO] Total time: 02:53 min
> [INFO] Finished at: 2024-04-26T15:34:00+02:00
> [INFO]
> --
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install)
> on project camel-debezium-common-parent: Execution default-install of goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install failed: 2
> problems were encountered while building the effective model for
> /Users/gnodet/work/git/camel/components/camel-debezium/camel-debezium-common/target/camel-debezium-common-parent-4.6.0-SNAPSHOT.pom
> [ERROR] - [WARNING] 'parent.relativePath' points at
> org.apache.camel:camel-debezium-common-parent instead of
> org.apache.camel:camel-debezium-parent, please verify your project structure
> @ line 22, column 3
> [ERROR] - [FATAL] Non-parseable POM
> org.apache.camel:camel-debezium-parent:4.6.0-SNAPSHOT: Unable to read model:
> Is a directory
> [ERROR] -> [Help 1]org.apache.maven.lifecycle.LifecycleExecutionException:
> Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install)
> on project camel-debezium-common-parent: Execution default-install of goal
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install failed: 2
> problems were encountered while building the effective model for
>
[jira] [Commented] (MNG-8118) Dependency-management "client" exclusions overwrite BOM exclusions
[ https://issues.apache.org/jira/browse/MNG-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845791#comment-17845791 ] ASF GitHub Bot commented on MNG-8118: - gnodet merged PR #1504: URL: https://github.com/apache/maven/pull/1504 > Dependency-management "client" exclusions overwrite BOM exclusions > -- > > Key: MNG-8118 > URL: https://issues.apache.org/jira/browse/MNG-8118 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-13, 4.0.x-candidate > Environment: Any >Reporter: Lenny Primak >Assignee: Guillaume Nodet >Priority: Major > > When importing BOM and introducing exclusions, they overwrite exclusions > already present in the BOM. They should not > Slack conversation link: > https://the-asf.slack.com/archives/C7Q9JB404/p1714938396499939 > Regressed by https://issues.apache.org/jira/browse/MNG-5600 > Reproducer app: [https://github.com/lprimak/apps/tree/main/emailmanager] > Fixed by: https://github.com/apache/maven/pull/1504 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1394) Upgrade Maven core dependencies to the latest and make as provided
[ https://issues.apache.org/jira/browse/MSHARED-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845724#comment-17845724 ] ASF GitHub Bot commented on MSHARED-1394: - slawekjaranowski merged PR #119: URL: https://github.com/apache/maven-dependency-analyzer/pull/119 > Upgrade Maven core dependencies to the latest and make as provided > -- > > Key: MSHARED-1394 > URL: https://issues.apache.org/jira/browse/MSHARED-1394 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > We need not to have a Maven core dependencies in compile scope. > When we use this artifact in another for analyze project all Maven > dependencies are in place also in provided scope. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-637) PomUtils.addNewModule Pretty-Printing has issue on java 9+
[ https://issues.apache.org/jira/browse/ARCHETYPE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845722#comment-17845722 ] ASF GitHub Bot commented on ARCHETYPE-637: -- slawekjaranowski commented on PR #128: URL: https://github.com/apache/maven-archetype/pull/128#issuecomment-2106279995 Ok, We need review / resolve existing issues planed for next version: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317122%20AND%20fixVersion%20%3D%2012351178%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC Helping in this case is appreciated By the way there are many resolved issues and the last release was a more than two years ago So I added it to my release queue > PomUtils.addNewModule Pretty-Printing has issue on java 9+ > -- > > Key: ARCHETYPE-637 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-637 > Project: Maven Archetype > Issue Type: Bug > Components: Generator >Reporter: qxo >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.3.0 > > > > *As of Java 9, the _Transformer_ class's pretty-print feature doesn't define > the actual format. Therefore, whitespace-only nodes will be outputted as > well.* This has been discussed in this [JDK bug > ticket|https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list]. > Also, [Java 9's release > note|https://www.oracle.com/java/technologies/javase/9-notes.html] has > explained this in the xml/jaxp section. > *If we want our pretty-print method to always generate the same format under > various Java versions, we need to provide a stylesheet file.* > ref： > [https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list] > > [https://www.baeldung.com/java-pretty-print-xml#pretty-printing-xml-with-the-transformer-class] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-139) Shell scripts break on LF in config for Windows
[
https://issues.apache.org/jira/browse/MWRAPPER-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845698#comment-17845698
]
ASF GitHub Bot commented on MWRAPPER-139:
-
ascopes opened a new pull request, #139:
URL: https://github.com/apache/maven-wrapper/pull/139
MWRAPPER-139: Remove trailing whitespace from fields in
maven-wrapper.properties
This prevents issues due to confusion between CRLF and LF when running in
more exotic locations such as MINGW on Windows but using ./mvnw rather than
./mvnw.cmd. A prime example of where this is an issue would be on
windows-latest GitHub Actions runners.
Fixes MWRAPPER-139, MWRAPPER-137 (which I didn't spot for some reason when
reviewing the
existing tickets on JIRA... might have been a blip in JIRA that didn't
display it?).
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
> Shell scripts break on LF in config for Windows
> ---
>
> Key: MWRAPPER-139
> URL: https://issues.apache.org/jira/browse/MWRAPPER-139
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.3.1
>Reporter: Ashley Scopes
>Priority: Major
>
> Today, I updated the Maven Wrapper in a project I have on GitHub by running
> `./mvnw wrapper:wrapper`, and then pushed it to GitHub.
> It appears that upon doing this, the bash scripts no longer work due to how
> newlines are being interpreted in the maven-wrapper.properties file.
> {code}
> + ./mvnw --version
> distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but
> found
> 'https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip
> '
> {code}
> This appears to just affect when running on GitHub actions with a Windows
> runner and the `bash` shell.
> I will see if I can find the issue and raise a fix in an MR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-1030) Manifest entries from archive configuration are not added in final MANIFEST
[
https://issues.apache.org/jira/browse/MASSEMBLY-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845690#comment-17845690
]
ASF GitHub Bot commented on MASSEMBLY-1030:
---
olamy merged PR #205:
URL: https://github.com/apache/maven-assembly-plugin/pull/205
> Manifest entries from archive configuration are not added in final MANIFEST
> ---
>
> Key: MASSEMBLY-1030
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1030
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: manifest
>Affects Versions: 3.7.1
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.7.2
>
>
> given the follow configuration
> {code:java}
>
>
> src/main/assembly/web-bundle.xml
>
>
>
> ${project.build.outputDirectory}/META-INF/MANIFEST.MF
>
> ee10
>
>
> merge
> {code}
> he entries from manifestEntries are not added to MANIFEST file
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSKINS-245) Maven Site 4 will break code highlight of site generated by Markdown
[ https://issues.apache.org/jira/browse/MSKINS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845647#comment-17845647 ] ASF GitHub Bot commented on MSKINS-245: --- michael-o commented on PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2106023820 This can now reduced to: ```patch diff --git a/src/main/resources/META-INF/maven/site.vm b/src/main/resources/META-INF/maven/site.vm index 5e0604f..26bb876 100644 - > Maven Site 4 will break code highlight of site generated by Markdown > > > Key: MSKINS-245 > URL: https://issues.apache.org/jira/browse/MSKINS-245 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: Xavi Lee >Assignee: Konrad Windszus >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > Attachments: maven-site-3.png, maven-site-4.png, test-v3.html, > test-v4.html > > > repro repo https://github.com/awxiaoxian2020/code-render-bug > master branch is Maven Site 3 with Fluido skin 1 > v4 branch is Maven Site 4 with Fluido skin 2. > Open their respective `target/site/test.html` files in local to see the > rendered result. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845640#comment-17845640 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o opened a new pull request, #22: URL: https://github.com/apache/maven-reporting-exec/pull/22 This closes #22 Approach copied from Maven Doxia Sitetools > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845637#comment-17845637 ] ASF GitHub Bot commented on MSHARED-1392: - asfgit closed pull request #40: [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-reporting-impl/pull/40 > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-637) PomUtils.addNewModule Pretty-Printing has issue on java 9+
[ https://issues.apache.org/jira/browse/ARCHETYPE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845629#comment-17845629 ] ASF GitHub Bot commented on ARCHETYPE-637: -- oeiutomo commented on PR #128: URL: https://github.com/apache/maven-archetype/pull/128#issuecomment-2105954687 Hi all.. Thank you for sharing and explain the problem here Me too waiting for the next plugin release..is there any plan to release this changes? Thank you so much > PomUtils.addNewModule Pretty-Printing has issue on java 9+ > -- > > Key: ARCHETYPE-637 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-637 > Project: Maven Archetype > Issue Type: Bug > Components: Generator >Reporter: qxo >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.3.0 > > > > *As of Java 9, the _Transformer_ class's pretty-print feature doesn't define > the actual format. Therefore, whitespace-only nodes will be outputted as > well.* This has been discussed in this [JDK bug > ticket|https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list]. > Also, [Java 9's release > note|https://www.oracle.com/java/technologies/javase/9-notes.html] has > explained this in the xml/jaxp section. > *If we want our pretty-print method to always generate the same format under > various Java versions, we need to provide a stylesheet file.* > ref： > [https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list] > > [https://www.baeldung.com/java-pretty-print-xml#pretty-printing-xml-with-the-transformer-class] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-1030) Manifest entries from archive configuration are not added in final MANIFEST
[
https://issues.apache.org/jira/browse/MASSEMBLY-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845626#comment-17845626
]
ASF GitHub Bot commented on MASSEMBLY-1030:
---
slawekjaranowski commented on code in PR #205:
URL:
https://github.com/apache/maven-assembly-plugin/pull/205#discussion_r1597465312
##
src/it/projects/mojo-configuration/manifest-with-customEntry-manifest-file/verify.bsh:
##
Review Comment:
I like more groovy for such scripts ... but it is a personal habit
> Manifest entries from archive configuration are not added in final MANIFEST
> ---
>
> Key: MASSEMBLY-1030
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1030
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: manifest
>Affects Versions: 3.7.1
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.7.2
>
>
> given the follow configuration
> {code:java}
>
>
> src/main/assembly/web-bundle.xml
>
>
>
> ${project.build.outputDirectory}/META-INF/MANIFEST.MF
>
> ee10
>
>
> merge
> {code}
> he entries from manifestEntries are not added to MANIFEST file
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845594#comment-17845594
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski opened a new pull request, #390:
URL: https://github.com/apache/maven-dependency-plugin/pull/390
(no comment)
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin
[
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845588#comment-17845588
]
ASF GitHub Bot commented on MINVOKER-307:
-
slawekjaranowski opened a new pull request, #241:
URL: https://github.com/apache/maven-invoker-plugin/pull/241
https://issues.apache.org/jira/browse/MINVOKER-307
> invoker should also support the @{ } syntax like the surefire plugin
>
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late'
> resolution of maven properties (not at POM evaluation time but at plugin
> execution time). See
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
> for details.
>
> It would be great if the invoker plugin would support the same syntax for the
> configuration setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-367) Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0
[ https://issues.apache.org/jira/browse/MINVOKER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845585#comment-17845585 ] ASF GitHub Bot commented on MINVOKER-367: - slawekjaranowski merged PR #240: URL: https://github.com/apache/maven-invoker-plugin/pull/240 > Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 > -- > > Key: MINVOKER-367 > URL: https://issues.apache.org/jira/browse/MINVOKER-367 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845584#comment-17845584
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski opened a new pull request, #389:
URL: https://github.com/apache/maven-dependency-plugin/pull/389
this method is only needed in CopyMojo and CopyDependenciesMojo so it is not
needed in AbstractDependencyMojo
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845582#comment-17845582
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105666204
Ok, but am on Fedora 40, not MacOS
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845580#comment-17845580
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105664165
> With current master (of both, m-dep-p and maven beta1) I have this UT
failure:
>
> ```
> [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
1.465 s <<< FAILURE!
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845579#comment-17845579
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105663494
With current master (of both, m-dep-p and maven beta1) I have this UT
failure:
```
[ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
1.465 s <<< FAILURE!
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845578#comment-17845578
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105663152
It does, but it does via "middleman" the Context:
https://github.com/maveniverse/mima/blob/main/runtime/embedded-maven/src/main/java/eu/maveniverse/maven/mima/runtime/maven/MavenRuntime.java#L91
(which in case of Maven Runtime "runs embedded in maven" and project being
present)
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845577#comment-17845577
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105660694
Toolbox propabbly doesn't use a `getProject().getRemoteProjectRepositories()`
https://github.com/maveniverse/mima/blob/main/context/src/main/java/eu/maveniverse/maven/mima/context/ContextOverrides.java#L36
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845575#comment-17845575
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105659462
> @slawekjaranowski how to reproduce? Is this m-dep-p IT?
Yes, there is `src/it/projects/list-repositories`
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845574#comment-17845574 ] ASF GitHub Bot commented on MSHARED-1392: - cstamas commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105659226 If you check out this: https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/resources/META-INF/maven/extension.xml you will see that same stands for plexus... There is ONE tricky dep: resolver-util IF you don't use it, nothing. IF YOU DO use it, it has to be _compile_ to make compatible with Maven 3.8 and 3.9 (where change happened, as resolver-util became provided as well, it was not in previous versions). > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845573#comment-17845573
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105656773
@slawekjaranowski how to reproduce? Is this m-dep-p IT?
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845572#comment-17845572 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105655308 @cstamas Changed, please have a look. > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845570#comment-17845570 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105654284 > Anything that executes "like a maven plugin" should have them provided. Now, in case of site/reports am aware you have some intermediate libs that are not plugins, but can execute only in context of plugin/report. > > It does not have to, as "root" dependency will be plugin (or report that is like a plugin) and it will force maven deps into provided anyway (as these intermediate stuff will always be deeper in dep tree). Yes, reporting impl always executes as a Maven Plugin from command line, so provided seems to be right here. > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845569#comment-17845569 ] ASF GitHub Bot commented on MSHARED-1392: - cstamas commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105653241 Anything that executes "like a maven plugin" should have them provided. Now, in case of site/reports am aware you have some intermediate libs that are not plugins, but can execute only in context of plugin/report. It does not have to, as "root" dependency will be plugin (or report that is like a plugin) and it will force maven deps into provided anyway (as these intermediate stuff will always be deeper in dep tree). > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845568#comment-17845568 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o opened a new pull request, #40: URL: https://github.com/apache/maven-reporting-impl/pull/40 @cstamas Can you tell me whether the Maven dependencies should move to `provided` scope? > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845564#comment-17845564
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105645151
Will take a peek. In the meantime, what does toolbox list-repositories say?
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-1030) Manifest entries from archive configuration are not added in final MANIFEST
[
https://issues.apache.org/jira/browse/MASSEMBLY-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845563#comment-17845563
]
ASF GitHub Bot commented on MASSEMBLY-1030:
---
olamy opened a new pull request, #205:
URL: https://github.com/apache/maven-assembly-plugin/pull/205
Signed-off-by: Olivier Lamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Manifest entries from archive configuration are not added in final MANIFEST
> ---
>
> Key: MASSEMBLY-1030
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1030
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: manifest
>Affects Versions: 3.7.1
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.7.2
>
>
> given the follow configuration
> {code:java}
>
>
> src/main/assembly/web-bundle.xml
>
>
>
> ${project.build.outputDirectory}/META-INF/MANIFEST.MF
>
> ee10
>
>
> merge
> {code}
> he entries from manifestEntries are not added to MANIFEST file
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248
[ https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845554#comment-17845554 ] ASF GitHub Bot commented on MSHARED-1393: - slawekjaranowski merged PR #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118 > Allow to exclude classes from verification - revert MSHARED-1248 > > > Key: MSHARED-1393 > URL: https://issues.apache.org/jira/browse/MSHARED-1393 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > In some situation project can contains corrupted classes. > Instead of skip it with only warning like in: MSHARED-1248 we should have > possibility to skip only known corrupted classes - not all. > When we skip all - we can stop analyzing anything when asm does not support > next byte code version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845478#comment-17845478
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105232231
Maven 4:
Maven 3
@cstamas @gnodet we have difference in result of `mirroredRepositories`
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1395) Remove dependency on commons-io
[
https://issues.apache.org/jira/browse/MSHARED-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845434#comment-17845434
]
ASF GitHub Bot commented on MSHARED-1395:
-
slawekjaranowski merged PR #120:
URL: https://github.com/apache/maven-dependency-analyzer/pull/120
> Remove dependency on commons-io
> ---
>
> Key: MSHARED-1395
> URL: https://issues.apache.org/jira/browse/MSHARED-1395
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.14.0
>
>
> Only one simple method is used {{IOUtils#toByteArra}} ... we can do it in
> project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845389#comment-17845389 ] ASF GitHub Bot commented on MPMD-395: - michael-o commented on PR #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150#issuecomment-2104773821 Will try to review in the next couple of days. > Build doesn't fail for invalid CPD format > - > > Key: MPMD-395 > URL: https://issues.apache.org/jira/browse/MPMD-395 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD >Affects Versions: 3.22.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > > See > [https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392] > > If an exception occurs while the CPD report is created, the exception is only > logged but doesn't fail the build. This means, that build appears to be > successful, although it didn't produce all expected build artifacts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248
[ https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845349#comment-17845349 ] ASF GitHub Bot commented on MSHARED-1393: - garydgregory commented on PR #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118#issuecomment-2104602026 Hello @slawekjaranowski TY for the heads up. OK, I'll adapt when this trickles down. > Allow to exclude classes from verification - revert MSHARED-1248 > > > Key: MSHARED-1393 > URL: https://issues.apache.org/jira/browse/MSHARED-1393 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > In some situation project can contains corrupted classes. > Instead of skip it with only warning like in: MSHARED-1248 we should have > possibility to skip only known corrupted classes - not all. > When we skip all - we can stop analyzing anything when asm does not support > next byte code version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845265#comment-17845265 ] ASF GitHub Bot commented on MPMD-395: - michael-o commented on PR #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150#issuecomment-2104284197 Is this the fix for https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392? > Build doesn't fail for invalid CPD format > - > > Key: MPMD-395 > URL: https://issues.apache.org/jira/browse/MPMD-395 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD >Affects Versions: 3.22.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > > See > [https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392] > > If an exception occurs while the CPD report is created, the exception is only > logged but doesn't fail the build. This means, that build appears to be > successful, although it didn't produce all expected build artifacts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845253#comment-17845253 ] ASF GitHub Bot commented on MPMD-379: - adangel commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2104232352 > @adangel That merge was a pile of junk. You imported all intermediate work into master making it impossible to trace down the actual change. Don't do that again please, always squash and rebase first. Clearly a -1 for the methodology. I was not aware, that the general rule of thumb for merging PRs is "squash and rebase". If this is the common decision around the maven project, then I'd expect this to be clearly documented, e.g. on https://maven.apache.org/developers/conventions/git.html . I'm missing there an example on how to merge PRs which consist of more than one commits. E.g. it says there "commit it to a branch, fix it up, and merge the branch." instead of "commit it to a branch, fix it up and squash and rebase this branch onto master/main". To be honest, I'm not sure if it would have prevented my merge push... (because I don't think I would have read this doc before pushing). Following the discussion on https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243030 - which is very helpful - it seems the decision is to try to have a linear history on the master/main branch: > Simply we require linear commit on master branch - from master perspective final result is important - we needn't history of work on PR in master. This decision should be somehow officially be documented to be transparent for everyone... For me, as a casual committer, who only pushes once every blue moon and working mostly on other projects, I would suggest to - Update the PR Template on GitHub with a section "Before merging... Maven Project requires a linear history, ... squash+rebase. Either before merge or whoever merges this. See also https://maven.apache.org/developers/conventions/git.html;. I think, this would help to remember this decision. - Enforce via push/update hook to prevent merge commits pushed to master/main. GitHub has some options to enforce a linear history. I'm sure, the infra team can configure something similar on gitbox.apache.org. That would at least prevent someone like me from simply pushing a merge. Of course, it wouldn't prevent me from pushing the complete rebased history of a PR (which is also not desired)... > Upgrade to use PMD 7.0.0 by default > --- > > Key: MPMD-379 > URL: https://issues.apache.org/jira/browse/MPMD-379 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.22.0 > > > Add support for the new major version of PMD. > This gives support for analyzing Java 21 code. > The upgrade from PMD 6 to PMD 7 is a major upgrade, that might impact > end-users, if they use custom rulesets (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/usingRuleSets.html]) > or if they override the dependencies to upgrade PMD at runtime and currently > use PMD 6.x (see > [https://maven.apache.org/plugins/maven-pmd-plugin/examples/upgrading-PMD-at-runtime.html]). > > Most likely, end-users have to review their rulesets and migrate them to PMD > 7. Rules might have been renamed or replaced. See > [https://docs.pmd-code.org/latest/pmd_release_notes_pmd7.html] and > [https://docs.pmd-code.org/latest/pmd_userdocs_migrating_to_pmd7.html] . > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format
[ https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845251#comment-17845251 ] ASF GitHub Bot commented on MPMD-395: - adangel opened a new pull request, #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150 https://issues.apache.org/jira/browse/MPMD-395 Refs https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094372771 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`, where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Build doesn't fail for invalid CPD format > - > > Key: MPMD-395 > URL: https://issues.apache.org/jira/browse/MPMD-395 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD >Affects Versions: 3.22.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > > See > [https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392] > > If an exception occurs while the CPD report is created, the exception is only > logged but doesn't fail the build. This means, that build appears to be > successful, although it didn't produce all expected build artifacts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-338) Upgrade to Parent 42
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845236#comment-17845236 ] ASF GitHub Bot commented on DOXIASITETOOLS-338: --- asfgit closed pull request #153: [DOXIASITETOOLS-338] Upgrade to Parent 42 URL: https://github.com/apache/maven-doxia-sitetools/pull/153 > Upgrade to Parent 42 > > > Key: DOXIASITETOOLS-338 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-338 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M19 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1395) Remove dependency on commons-io
[
https://issues.apache.org/jira/browse/MSHARED-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845219#comment-17845219
]
ASF GitHub Bot commented on MSHARED-1395:
-
slawekjaranowski opened a new pull request, #120:
URL: https://github.com/apache/maven-dependency-analyzer/pull/120
https://issues.apache.org/jira/browse/MSHARED-1395
> Remove dependency on commons-io
> ---
>
> Key: MSHARED-1395
> URL: https://issues.apache.org/jira/browse/MSHARED-1395
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.14.0
>
>
> Only one simple method is used {{IOUtils#toByteArra}} ... we can do it in
> project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1394) Upgrade Maven core dependencies to the latest and make as provided
[ https://issues.apache.org/jira/browse/MSHARED-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845129#comment-17845129 ] ASF GitHub Bot commented on MSHARED-1394: - slawekjaranowski opened a new pull request, #119: URL: https://github.com/apache/maven-dependency-analyzer/pull/119 https://issues.apache.org/jira/browse/MSHARED-1394 > Upgrade Maven core dependencies to the latest and make as provided > -- > > Key: MSHARED-1394 > URL: https://issues.apache.org/jira/browse/MSHARED-1394 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > We need not to have a Maven core dependencies in compile scope. > When we use this artifact in another for analyze project all Maven > dependencies are in place also in provided scope. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8117) Improve prerequisite evaluation and plugin version selection logging
[
https://issues.apache.org/jira/browse/MNG-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845117#comment-17845117
]
ASF GitHub Bot commented on MNG-8117:
-
cstamas merged PR #1505:
URL: https://github.com/apache/maven/pull/1505
> Improve prerequisite evaluation and plugin version selection logging
>
>
> Key: MNG-8117
> URL: https://issues.apache.org/jira/browse/MNG-8117
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7, 4.0.0, 4.0.0-beta-1
>
>
> Currently, when user uses {{G:A}} the plugin tried is {{G:A:LATEST}} and is
> checked for "compatibility" (Maven prerequisite in Maven3 and Maven4, plus
> for Java prerequisite in Maven4 only). This may lead that "latest" (by Maven
> Metadata) version is not compatible, and Maven will cycle toward older
> versions. But the console output is a mess.
> Current output can be seen in this gist:
> [https://gist.github.com/cstamas/e44a2e51f5ec9f2e803dfb1d487d2fd5]
> PR creates output like this:
> https://gist.github.com/cstamas/3ca4bc6cea5f701054061871b5db3f35
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248
[ https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845109#comment-17845109 ] ASF GitHub Bot commented on MSHARED-1393: - slawekjaranowski commented on PR #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118#issuecomment-2103312054 @garydgregory - this revert only logs from https://github.com/apache/maven-dependency-analyzer/pull/89 But we have possibility to exclude what we want. Please look > Allow to exclude classes from verification - revert MSHARED-1248 > > > Key: MSHARED-1393 > URL: https://issues.apache.org/jira/browse/MSHARED-1393 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > In some situation project can contains corrupted classes. > Instead of skip it with only warning like in: MSHARED-1248 we should have > possibility to skip only known corrupted classes - not all. > When we skip all - we can stop analyzing anything when asm does not support > next byte code version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248
[ https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845108#comment-17845108 ] ASF GitHub Bot commented on MSHARED-1393: - slawekjaranowski opened a new pull request, #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118 https://issues.apache.org/jira/browse/MSHARED-1393 > Allow to exclude classes from verification - revert MSHARED-1248 > > > Key: MSHARED-1393 > URL: https://issues.apache.org/jira/browse/MSHARED-1393 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > In some situation project can contains corrupted classes. > Instead of skip it with only warning like in: MSHARED-1248 we should have > possibility to skip only known corrupted classes - not all. > When we skip all - we can stop analyzing anything when asm does not support > next byte code version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844824#comment-17844824 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- olamy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2101725049 vote started https://lists.apache.org/thread/do2dc2tpmq2zknyqnf55xpvllop94bq5 if not issues this should be available early next week > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844794#comment-17844794 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- kbuntrock commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2101600438 > I'm really looking forward to testing this out, is there a new release planned or a place where I can track it? Yes, Olivier mentioned on the maven dev list that he is planning to create a release probably this week. (https://lists.apache.org/list.html?d...@maven.apache.org) > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1356) Upgrade Parent to 42
[ https://issues.apache.org/jira/browse/MSHARED-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844770#comment-17844770 ] ASF GitHub Bot commented on MSHARED-1356: - slawekjaranowski merged PR #115: URL: https://github.com/apache/maven-dependency-analyzer/pull/115 > Upgrade Parent to 42 > > > Key: MSHARED-1356 > URL: https://issues.apache.org/jira/browse/MSHARED-1356 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.13.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-590) Upgrade Parent to 42
[ https://issues.apache.org/jira/browse/MCOMPILER-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844763#comment-17844763 ] ASF GitHub Bot commented on MCOMPILER-590: -- elharo merged PR #235: URL: https://github.com/apache/maven-compiler-plugin/pull/235 > Upgrade Parent to 42 > > > Key: MCOMPILER-590 > URL: https://issues.apache.org/jira/browse/MCOMPILER-590 > Project: Maven Compiler Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1272) commons-io from 2.11.0 to 2.16.0
[ https://issues.apache.org/jira/browse/MSHARED-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844759#comment-17844759 ] ASF GitHub Bot commented on MSHARED-1272: - slawekjaranowski merged PR #114: URL: https://github.com/apache/maven-dependency-analyzer/pull/114 > commons-io from 2.11.0 to 2.16.0 > > > Key: MSHARED-1272 > URL: https://issues.apache.org/jira/browse/MSHARED-1272 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: maven-dependency-analyzer-1.13.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSKINS-246) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSKINS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844743#comment-17844743 ] ASF GitHub Bot commented on MSKINS-246: --- michael-o commented on PR #60: URL: https://github.com/apache/maven-fluido-skin/pull/60#issuecomment-2101165859 > #58 references a different JIRA ticket. Please split up in two separate commits each referencing different JIRA IDs Alright, will do. > Upgrade plugins and components (in ITs) > --- > > Key: MSKINS-246 > URL: https://issues.apache.org/jira/browse/MSKINS-246 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Site Plugin 4.0.0-M14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844656#comment-17844656 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- hacosta commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2100572149 I'm really looking forward to testing this out, is there a new release planned or a place where I can track it? > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8118) Dependency-management "client" exclusions overwrite BOM exclusions
[ https://issues.apache.org/jira/browse/MNG-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844591#comment-17844591 ] ASF GitHub Bot commented on MNG-8118: - cstamas opened a new pull request, #1505: URL: https://github.com/apache/maven/pull/1505 Backport same fix, as very same issue stands there, user cannot really tell what and why is happening. Still, Maven 3 has only Maven prerequisite, but still same code is present. This is the backport of https://github.com/apache/maven/pull/1502 --- https://issues.apache.org/jira/browse/MNG-8117 > Dependency-management "client" exclusions overwrite BOM exclusions > -- > > Key: MNG-8118 > URL: https://issues.apache.org/jira/browse/MNG-8118 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-13, 4.0.x-candidate > Environment: Any >Reporter: Lenny Primak >Assignee: Guillaume Nodet >Priority: Major > > When importing BOM and introducing exclusions, they overwrite exclusions > already present in the BOM. They should not > Slack conversation link: > https://the-asf.slack.com/archives/C7Q9JB404/p1714938396499939 > Regressed by https://issues.apache.org/jira/browse/MNG-5600 > Reproducer app: [https://github.com/lprimak/apps/tree/main/emailmanager] > Fixed by: https://github.com/apache/maven/pull/1504 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8117) Improve prerequisite evaluation and plugin version selection logging
[
https://issues.apache.org/jira/browse/MNG-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844582#comment-17844582
]
ASF GitHub Bot commented on MNG-8117:
-
cstamas commented on code in PR #1502:
URL: https://github.com/apache/maven/pull/1502#discussion_r1593562470
##
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java:
##
@@ -261,8 +291,12 @@ private boolean isCompatible(PluginVersionRequest request,
String version) {
try {
pluginManager.checkPrerequisites(pluginDescriptor);
-} catch (Exception e) {
-logger.warn("Ignoring incompatible plugin version {}", version, e);
+} catch (PluginIncompatibleException e) {
+if (logger.isDebugEnabled()) {
+logger.warn("Ignoring incompatible plugin version {}: {}",
version, e.getMessage(), e);
Review Comment:
done
> Improve prerequisite evaluation and plugin version selection logging
>
>
> Key: MNG-8117
> URL: https://issues.apache.org/jira/browse/MNG-8117
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Currently, when user uses {{G:A}} the plugin tried is {{G:A:LATEST}} and is
> checked for "compatibility" (Maven prerequisite in Maven3 and Maven4, plus
> for Java prerequisite in Maven4 only). This may lead that "latest" (by Maven
> Metadata) version is not compatible, and Maven will cycle toward older
> versions. But the console output is a mess.
> Current output can be seen in this gist:
> [https://gist.github.com/cstamas/e44a2e51f5ec9f2e803dfb1d487d2fd5]
> PR creates output like this:
> https://gist.github.com/cstamas/3ca4bc6cea5f701054061871b5db3f35
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8117) Improve prerequisite evaluation and plugin version selection logging
[
https://issues.apache.org/jira/browse/MNG-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844580#comment-17844580
]
ASF GitHub Bot commented on MNG-8117:
-
cstamas commented on code in PR #1502:
URL: https://github.com/apache/maven/pull/1502#discussion_r1593543359
##
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java:
##
@@ -261,8 +291,12 @@ private boolean isCompatible(PluginVersionRequest request,
String version) {
try {
pluginManager.checkPrerequisites(pluginDescriptor);
-} catch (Exception e) {
-logger.warn("Ignoring incompatible plugin version {}", version, e);
+} catch (PluginIncompatibleException e) {
+if (logger.isDebugEnabled()) {
+logger.warn("Ignoring incompatible plugin version {}: {}",
version, e.getMessage(), e);
Review Comment:
Well, mvn -X output is already quite confusing :smile: so unsure will _this_
confuse anyone... but agreed, will fix.
> Improve prerequisite evaluation and plugin version selection logging
>
>
> Key: MNG-8117
> URL: https://issues.apache.org/jira/browse/MNG-8117
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Currently, when user uses {{G:A}} the plugin tried is {{G:A:LATEST}} and is
> checked for "compatibility" (Maven prerequisite in Maven3 and Maven4, plus
> for Java prerequisite in Maven4 only). This may lead that "latest" (by Maven
> Metadata) version is not compatible, and Maven will cycle toward older
> versions. But the console output is a mess.
> Current output can be seen in this gist:
> [https://gist.github.com/cstamas/e44a2e51f5ec9f2e803dfb1d487d2fd5]
> PR creates output like this:
> https://gist.github.com/cstamas/3ca4bc6cea5f701054061871b5db3f35
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8117) Improve prerequisite evaluation and plugin version selection logging
[
https://issues.apache.org/jira/browse/MNG-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844573#comment-17844573
]
ASF GitHub Bot commented on MNG-8117:
-
michael-o commented on code in PR #1502:
URL: https://github.com/apache/maven/pull/1502#discussion_r1593518657
##
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java:
##
@@ -261,8 +291,12 @@ private boolean isCompatible(PluginVersionRequest request,
String version) {
try {
pluginManager.checkPrerequisites(pluginDescriptor);
-} catch (Exception e) {
-logger.warn("Ignoring incompatible plugin version {}", version, e);
+} catch (PluginIncompatibleException e) {
+if (logger.isDebugEnabled()) {
+logger.warn("Ignoring incompatible plugin version {}: {}",
version, e.getMessage(), e);
Review Comment:
I know, but that would rather confuse when the message appears twice
> Improve prerequisite evaluation and plugin version selection logging
>
>
> Key: MNG-8117
> URL: https://issues.apache.org/jira/browse/MNG-8117
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Currently, when user uses {{G:A}} the plugin tried is {{G:A:LATEST}} and is
> checked for "compatibility" (Maven prerequisite in Maven3 and Maven4, plus
> for Java prerequisite in Maven4 only). This may lead that "latest" (by Maven
> Metadata) version is not compatible, and Maven will cycle toward older
> versions. But the console output is a mess.
> Current output can be seen in this gist:
> [https://gist.github.com/cstamas/e44a2e51f5ec9f2e803dfb1d487d2fd5]
> PR creates output like this:
> https://gist.github.com/cstamas/3ca4bc6cea5f701054061871b5db3f35
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8117) Improve prerequisite evaluation and plugin version selection logging
[
https://issues.apache.org/jira/browse/MNG-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844571#comment-17844571
]
ASF GitHub Bot commented on MNG-8117:
-
cstamas commented on code in PR #1502:
URL: https://github.com/apache/maven/pull/1502#discussion_r1593510428
##
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java:
##
@@ -261,8 +291,12 @@ private boolean isCompatible(PluginVersionRequest request,
String version) {
try {
pluginManager.checkPrerequisites(pluginDescriptor);
-} catch (Exception e) {
-logger.warn("Ignoring incompatible plugin version {}", version, e);
+} catch (PluginIncompatibleException e) {
+if (logger.isDebugEnabled()) {
+logger.warn("Ignoring incompatible plugin version {}: {}",
version, e.getMessage(), e);
Review Comment:
Agreed, all I wanted to distinguish is "with stack trace" or "without stack
trace".
> Improve prerequisite evaluation and plugin version selection logging
>
>
> Key: MNG-8117
> URL: https://issues.apache.org/jira/browse/MNG-8117
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Currently, when user uses {{G:A}} the plugin tried is {{G:A:LATEST}} and is
> checked for "compatibility" (Maven prerequisite in Maven3 and Maven4, plus
> for Java prerequisite in Maven4 only). This may lead that "latest" (by Maven
> Metadata) version is not compatible, and Maven will cycle toward older
> versions. But the console output is a mess.
> Current output can be seen in this gist:
> [https://gist.github.com/cstamas/e44a2e51f5ec9f2e803dfb1d487d2fd5]
> PR creates output like this:
> https://gist.github.com/cstamas/3ca4bc6cea5f701054061871b5db3f35
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8117) Improve prerequisite evaluation and plugin version selection logging
[
https://issues.apache.org/jira/browse/MNG-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844568#comment-17844568
]
ASF GitHub Bot commented on MNG-8117:
-
michael-o commented on code in PR #1502:
URL: https://github.com/apache/maven/pull/1502#discussion_r1593508817
##
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java:
##
@@ -261,8 +291,12 @@ private boolean isCompatible(PluginVersionRequest request,
String version) {
try {
pluginManager.checkPrerequisites(pluginDescriptor);
-} catch (Exception e) {
-logger.warn("Ignoring incompatible plugin version {}", version, e);
+} catch (PluginIncompatibleException e) {
+if (logger.isDebugEnabled()) {
+logger.warn("Ignoring incompatible plugin version {}: {}",
version, e.getMessage(), e);
Review Comment:
This looks duplicate when you pass `e` already.
> Improve prerequisite evaluation and plugin version selection logging
>
>
> Key: MNG-8117
> URL: https://issues.apache.org/jira/browse/MNG-8117
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-1
>
>
> Currently, when user uses {{G:A}} the plugin tried is {{G:A:LATEST}} and is
> checked for "compatibility" (Maven prerequisite in Maven3 and Maven4, plus
> for Java prerequisite in Maven4 only). This may lead that "latest" (by Maven
> Metadata) version is not compatible, and Maven will cycle toward older
> versions. But the console output is a mess.
> Current output can be seen in this gist:
> [https://gist.github.com/cstamas/e44a2e51f5ec9f2e803dfb1d487d2fd5]
> PR creates output like this:
> https://gist.github.com/cstamas/3ca4bc6cea5f701054061871b5db3f35
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-971) System environment variable are always added to maven-invoker
[
https://issues.apache.org/jira/browse/MSHARED-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1784#comment-1784
]
ASF GitHub Bot commented on MSHARED-971:
slawekjaranowski merged PR #79:
URL: https://github.com/apache/maven-invoker/pull/79
> System environment variable are always added to maven-invoker
> -
>
> Key: MSHARED-971
> URL: https://issues.apache.org/jira/browse/MSHARED-971
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker, maven-shared-utils
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: maven-invoker-3.3.0
>
>
> In {{org.apache.maven.shared.invoker.MavenCommandLineBuilder}}
> [https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242]
> we have code:
> {code}
> if ( request.isShellEnvironmentInherited() )
> {
> cli.addSystemEnvironment();
> }
> {code}
> but in {{org.apache.maven.shared.utils.cli.Commandline}} we have:
> {code}
> public String[] getEnvironmentVariables()
> {
> addSystemEnvironment();
>...
> }
> {code}
> System environment variable are always added - it is inconsistent
> implementation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-366) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MINVOKER-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844430#comment-17844430 ] ASF GitHub Bot commented on MINVOKER-366: - slawekjaranowski merged PR #238: URL: https://github.com/apache/maven-invoker-plugin/pull/238 > Require Maven 3.6.3 > --- > > Key: MINVOKER-366 > URL: https://issues.apache.org/jira/browse/MINVOKER-366 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-971) System environment variable are always added to maven-invoker
[
https://issues.apache.org/jira/browse/MSHARED-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844428#comment-17844428
]
ASF GitHub Bot commented on MSHARED-971:
slawekjaranowski opened a new pull request, #79:
URL: https://github.com/apache/maven-invoker/pull/79
https://issues.apache.org/jira/browse/MSHARED-971
> System environment variable are always added to maven-invoker
> -
>
> Key: MSHARED-971
> URL: https://issues.apache.org/jira/browse/MSHARED-971
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker, maven-shared-utils
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Minor
>
> In {{org.apache.maven.shared.invoker.MavenCommandLineBuilder}}
> [https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242]
> we have code:
> {code}
> if ( request.isShellEnvironmentInherited() )
> {
> cli.addSystemEnvironment();
> }
> {code}
> but in {{org.apache.maven.shared.utils.cli.Commandline}} we have:
> {code}
> public String[] getEnvironmentVariables()
> {
> addSystemEnvironment();
>...
> }
> {code}
> System environment variable are always added - it is inconsistent
> implementation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-338) Upgrade to Parent 42
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844423#comment-17844423 ] ASF GitHub Bot commented on DOXIASITETOOLS-338: --- michael-o opened a new pull request, #153: URL: https://github.com/apache/maven-doxia-sitetools/pull/153 This closes #153 > Upgrade to Parent 42 > > > Key: DOXIASITETOOLS-338 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-338 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M19 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844221#comment-17844221 ] ASF GitHub Bot commented on MPLUGIN-522: cstamas commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097841309 But just for the record: current m-p-p releases produce broken Maven Plugin XML, in a way that plugin works just fine with Maven3, while Maven4 explodes with invalid error messages. > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844220#comment-17844220 ] ASF GitHub Bot commented on MPLUGIN-522: cstamas commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097838429 This PR should be redone once Maven3 and Maven4 m-p-p are split (into maven-3.x and master) branch. And then: * default Java prerequisite should pick up from compiler plugin (in pretty much similar way as report does) * default Maven prerequisite should be "3.2.5" on maven-3.x branch and "4.0.0" on master branch. Originally, the lack of prerequisite meant "it works with Maven3" (no range specified). IMO, using "3.2.5" today is completely okay, it covers 10 years of history. If users wants to go more backward, it can explicitly configure prerequisite to "3.1.1" or whatever. > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844218#comment-17844218 ] ASF GitHub Bot commented on MPLUGIN-522: cstamas commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097814145 > I think enforcing and explicitly stating prerequisites is a good thing and the default matches for 99% of the cases. For other cases just overwrite with explicit values. Not stating prerequisites should no longer be supported because it is frustratring for users to figure out the implicit prerequisites through trial and error... Just to repeat myself, the prerequisites are documented, so no need for user trial-and-error. This table shows Maven and Java prerequisites clearly: https://maven.apache.org/plugins/maven-jar-plugin/plugin-info.html#system-requirements-history > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844200#comment-17844200 ] ASF GitHub Bot commented on MPLUGIN-522: kwin commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097722820 > Putting prerequisites which are greater than the one actually used to build are, at first, very weird. Let's focus on issue with the automatic detection. Please point me to a concrete example where this is the case and where it is wrong. > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844199#comment-17844199 ] ASF GitHub Bot commented on MPLUGIN-522: cstamas commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097721382 Also, unsure how then this thing works? https://maven.apache.org/plugins/maven-jar-plugin/plugin-info.html#system-requirements-history > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844198#comment-17844198 ] ASF GitHub Bot commented on MPLUGIN-522: gnodet commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097717570 > I think enforcing prerequisites is a good thing and the default match for 99% of the cases. For other cases just overwrite with explicit values. Not stating prerequisites should no longer be supported because it is frustratring for users to figure out the implicit prerequisites through trial and error... Putting prerequisites which are greater than the one actually used to build are, at first, very weird. For example, if you project requires jdk 11, you build with jdk 11, test it with jdk 11, but your prerequisites ends up with jdk 22... ? That's really unexpected, and the user has no real knowledge about the value used. The prerequisites should not be higher than the target JDK. > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844197#comment-17844197 ] ASF GitHub Bot commented on MPLUGIN-522: cstamas commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097716799 Ok, then we have similar situation as with prefix: fail the build. Plugin should be modified to: * if none set, fail the build * if "auto", as now * if value set, use that We must make users aware of this requirement (hence the build failure), as otherwise they implicitly use "auto" and end result is wrong. > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844186#comment-17844186 ] ASF GitHub Bot commented on MPLUGIN-522: kwin commented on PR #282: URL: https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097692140 > and in fact, plain wrong. I disagree with this statement, and also disagree that they should be opt in. Details in the JIRA. > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-522) The auto prerequisites are way to aggressive
[ https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844181#comment-17844181 ] ASF GitHub Bot commented on MPLUGIN-522: cstamas opened a new pull request, #282: URL: https://github.com/apache/maven-plugin-tools/pull/282 But they are not. In fact, if user does not deal with them, they are way too aggressive and in fact, plain wrong. Prerequisite was opt-in and should have remain opt-in. --- https://issues.apache.org/jira/browse/MPLUGIN-522 > The auto prerequisites are way to aggressive > > > Key: MPLUGIN-522 > URL: https://issues.apache.org/jira/browse/MPLUGIN-522 > Project: Maven Plugin Tools > Issue Type: Bug > Components: Plugin Plugin >Reporter: Tamas Cservenak >Priority: Major > > IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong. > They are way too aggresive and violate backward compatibility: if new feature > is not explicitly set by user, code should not "come up" with some automatic > value. By having the value not set simply means user does not want to use it. > This is especially true for (maven or java) prerequisite, as it creates HARD > BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto > user. > [~kwin] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1152) Switch project unit tests to JUnit 5
[ https://issues.apache.org/jira/browse/MSHARED-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844141#comment-17844141 ] ASF GitHub Bot commented on MSHARED-1152: - slawekjaranowski merged PR #77: URL: https://github.com/apache/maven-invoker/pull/77 > Switch project unit tests to JUnit 5 > > > Key: MSHARED-1152 > URL: https://issues.apache.org/jira/browse/MSHARED-1152 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: maven-invoker-3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-591) testCompile wrong detects target less than 1.9 if provided as 8
[
https://issues.apache.org/jira/browse/MCOMPILER-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844140#comment-17844140
]
ASF GitHub Bot commented on MCOMPILER-591:
--
slawekjaranowski merged PR #240:
URL: https://github.com/apache/maven-compiler-plugin/pull/240
> testCompile wrong detects target less than 1.9 if provided as 8
> ---
>
> Key: MCOMPILER-591
> URL: https://issues.apache.org/jira/browse/MCOMPILER-591
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> When we provide target as *8* testCompile wrong detect that is less than
> {*}1.9/9{*}.
> Method is used to detect if should use modulepath when module descriptor is
> present in main code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1391) Code cleanups
[ https://issues.apache.org/jira/browse/MSHARED-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843913#comment-17843913 ] ASF GitHub Bot commented on MSHARED-1391: - slawekjaranowski merged PR #78: URL: https://github.com/apache/maven-invoker/pull/78 > Code cleanups > - > > Key: MSHARED-1391 > URL: https://issues.apache.org/jira/browse/MSHARED-1391 > Project: Maven Shared Components > Issue Type: Task > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-591) testCompile wrong detects target less than 1.9 if provided as 8
[
https://issues.apache.org/jira/browse/MCOMPILER-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843912#comment-17843912
]
ASF GitHub Bot commented on MCOMPILER-591:
--
slawekjaranowski opened a new pull request, #240:
URL: https://github.com/apache/maven-compiler-plugin/pull/240
https://issues.apache.org/jira/browse/MCOMPILER-591
> testCompile wrong detects target less than 1.9 if provided as 8
> ---
>
> Key: MCOMPILER-591
> URL: https://issues.apache.org/jira/browse/MCOMPILER-591
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> When we provide target as *8* testCompile wrong detect that is less than
> {*}1.9/9{*}.
> Method is used to detect if should use modulepath when module descriptor is
> present in main code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843865#comment-17843865
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski merged PR #388:
URL: https://github.com/apache/maven-dependency-plugin/pull/388
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843710#comment-17843710
]
ASF GitHub Bot commented on MDEP-799:
-
elharo commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1590867632
##
src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.tree;
+
+import java.io.IOException;
+import java.io.Writer;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.shared.dependency.graph.DependencyNode;
+import
org.apache.maven.shared.dependency.graph.traversal.DependencyNodeVisitor;
+
+/**
+ * A dependency node visitor that serializes visited nodes to a writer using
the JSON format.
+ */
+public class JsonDependencyNodeVisitor extends AbstractSerializingVisitor
implements DependencyNodeVisitor {
+
+private static final String LINE_SEPARATOR = "\n";
+private String indentChar = " ";
+
+/**
+ * Creates a new instance of {@link JsonDependencyNodeVisitor}. The writer
will be used to write the output.
+ * @param writer the writer to write to
+ */
+public JsonDependencyNodeVisitor(Writer writer) {
+super(writer);
+}
+
+@Override
+public boolean visit(DependencyNode node) {
Review Comment:
add a test for this case, see what works
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -127,6 +127,24 @@ public void _testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void _testTreeJsonSerialzing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"testGroupId\": \"project\""));
Review Comment:
contains is clearer
##
src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.tree;
+
+import java.io.IOException;
+import java.io.Writer;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.shared.dependency.graph.DependencyNode;
+import
org.apache.maven.shared.dependency.graph.traversal.DependencyNodeVisitor;
+
+/**
+ * A dependency node visitor that serializes visited nodes to a writer using
the JSON format.
+ */
+public class JsonDependencyNodeVisitor extends AbstractSerializingVisitor
implements DependencyNodeVisitor {
+
+private String indentChar = " ";
+
+/**
+ * Creates a new instance of {@link JsonDependencyNodeVisitor}. The writer
will be used to write the output.
+ * @param writer the writer to write to
+ */
+public JsonDependencyNodeVisitor(Writer writer) {
+super(writer);
+}
+
+@Override
+public boolean visit(DependencyNode node) {
+if (node.getParent() == null || node.getParent() == node) {
+writeRootNode(node, writer);
+}
+return true;
+}
+
+/**
+
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843632#comment-17843632 ] ASF GitHub Bot commented on MNG-8084: - gnodet merged PR #1500: URL: https://github.com/apache/maven/pull/1500 > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843631#comment-17843631 ] ASF GitHub Bot commented on MDEP-799: - monperrus commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-209537 @pombredanne @elharo if we are able to drive to merge, we can put more effort on this PR. > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Priority: Major > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration
[ https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843577#comment-17843577 ] ASF GitHub Bot commented on MCOMPILER-588: -- slawekjaranowski merged PR #236: URL: https://github.com/apache/maven-compiler-plugin/pull/236 > JUnit4 test framework to JUnit5 migration > - > > Key: MCOMPILER-588 > URL: https://issues.apache.org/jira/browse/MCOMPILER-588 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Mikhail Deviatov >Assignee: Slawomir Jaranowski >Priority: Major > > We have JUnit5 test framework for a long time. > It have modular architecture, good support in IDE and quite fast. It would be > good to add support JUnit5 to the project. > The problem is that there are 2 library used for testing in project > *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both > don't have JUnit5 support. > I created a solution that overrides parts of code used derived and my own > implementation. > Please take a look at it > https://github.com/apache/maven-compiler-plugin/pull/233 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-366) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MINVOKER-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843566#comment-17843566 ] ASF GitHub Bot commented on MINVOKER-366: - slawekjaranowski opened a new pull request, #238: URL: https://github.com/apache/maven-invoker-plugin/pull/238 https://issues.apache.org/jira/browse/MINVOKER-366 > Require Maven 3.6.3 > --- > > Key: MINVOKER-366 > URL: https://issues.apache.org/jira/browse/MINVOKER-366 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[ https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843558#comment-17843558 ] ASF GitHub Bot commented on MSHARED-1390: - slawekjaranowski merged PR #76: URL: https://github.com/apache/maven-invoker/pull/76 > Deprecate InvocationRequest#setGoals > > > Key: MSHARED-1390 > URL: https://issues.apache.org/jira/browse/MSHARED-1390 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-3.3.0 > > > We should avoid parsing command line arguments. > Raw arguments should be used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
