[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833892#comment-17833892
]
Mattias Andersson commented on SCM-1022:
[~michael-o] we created the PR above. Any feedback would be appreciated.
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833532#comment-17833532
]
Mattias Andersson commented on SCM-1022:
The problem seems to be that the return value from JGitUtils.push is ignored in:
{noformat}
org.apache.maven.scm.provider.git.jgit.command.checkin.JGitCheckInCommand#executeCheckInCommand{noformat}
We could try to provide a PR if that would be interesting?
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SCM-1022) jgit push failure is not failing the build
Mattias Andersson created SCM-1022:
--
Summary: jgit push failure is not failing the build
Key: SCM-1022
URL: https://issues.apache.org/jira/browse/SCM-1022
Project: Maven SCM
Issue Type: Bug
Components: maven-scm-provider-jgit
Affects Versions: 2.0.1
Reporter: Mattias Andersson
If the push command fails, the maven build does not fail. This means binaries
are deployed, but the remote repo is not updated. The issue seems related to
SCM-854.
We use Gerrit and have the merge strategy set to "fast forward only". If
someone pushes a commit during the release job, only an INFO message is logged,
but the maven build is successful.
The same use case with the maven-scm-provider-gitexe (the default) fails the
build as expected (git push returns a non-zero exit code)
{code:java}
10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
10:28:03 [INFO] fetch url: ssh://xxx@xxx
10:28:03 [INFO] push url: ssh://xxx@xxx
10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
net.i2p.crypto.eddsa.EdDSASecurityProvider
10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
Nio2ServiceFactoryFactory
10:28:04 [INFO] REJECTED_NONFASTFORWARD -
RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
srcRef=refs/heads/master, message=null]
10:28:04 [INFO] 12/17 prepare:scm-tag
10:28:04 [INFO] Tagging release with the label 2.15.0...
10:28:04 [INFO] push tag [2.15.0] to remote...
10:28:04 [INFO] fetch url: ssh://xxx@xxx
10:28:04 [INFO] push url: ssh://xxx@xxx
10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
...968d97de8331ce19d43c719e870890def5ee65d9,
fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-871) Unable to release Maven artifacts which are not in the root of the Git repository
[
https://issues.apache.org/jira/browse/SCM-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385043#comment-16385043
]
Mattias Andersson commented on SCM-871:
---
I have a Git repo where the java part of the project is located in a sub-folder.
> Unable to release Maven artifacts which are not in the root of the Git
> repository
> -
>
> Key: SCM-871
> URL: https://issues.apache.org/jira/browse/SCM-871
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 1.9.5
> Environment: Linux, Java version 1.8.0_144
>Reporter: Mattias Andersson
>Priority: Major
> Attachments: pom.xml
>
>
> I have a Maven project that is not in the root of the Git repository. When I
> run a release:prepare the pom.xml is changed but never checked in.
> {code:java}
> 07:52:47 [INFO] Checking in modified POMs...
> 07:52:47 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 07:52:47 [INFO] fetch url: ssh://myurl
> 07:52:47 [INFO] push url: ssh://myurl
> {code}
> In another project where the pom.xml is in the root of the repo i get
> following line printed after the “Checking in modified POMs…” line.
> {code:java}
> 09:28:24 [INFO] commit done: [maven-release-plugin] prepare release
> my-prod-1.0.0
> {code}
> For a maven project in the following directory:
> {{/home/me/git/my-repo/src/pom.xml}}
> The problem seems to be that in
> {{org.apache.maven.scm.provider.git.jgit.command.JGitUtils.addAllFiles(Git,
> ScmFileSet)}}. The baseUri of the fileSet is /home/me/git/my-repo/src so the
> relativized path become pom.xml. But
> {{org.eclipse.jgit.api.AddCommand.addFilepattern(String)}} expects a
> repository relative path, i.e. src/pom.xml.
>
> This patch [https://github.com/apache/maven-scm/compare/master...attiand:fix]
> relativize the path against the Git repo rather than the fileset, works for
> me.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SCM-871) Unable to release Maven artefacts that is not in the root of the Git repository
Mattias Andersson created SCM-871:
-
Summary: Unable to release Maven artefacts that is not in the root
of the Git repository
Key: SCM-871
URL: https://issues.apache.org/jira/browse/SCM-871
Project: Maven SCM
Issue Type: Bug
Components: maven-scm-provider-jgit
Affects Versions: 1.9.5
Environment: Linux, Java version 1.8.0_144
Reporter: Mattias Andersson
Attachments: pom.xml
I have a Maven project that is not in the root of the Git repository. When I
run a release:prepare the pom.xml is changed but never checked in.
{code:java}
07:52:47 [INFO] Checking in modified POMs...
07:52:47 [INFO] push changes to remote... refs/heads/master:refs/heads/master
07:52:47 [INFO] fetch url: ssh://myurl
07:52:47 [INFO] push url: ssh://myurl
{code}
In another project where the pom.xml is in the root of the repo i get following
line printed after the “Checking in modified POMs…” line.
{code:java}
09:28:24 [INFO] commit done: [maven-release-plugin] prepare release
my-prod-1.0.0
{code}
For a maven project in the following directory:
{{/home/me/git/my-repo/src/pom.xml}}
The problem seems to be that in
{{org.apache.maven.scm.provider.git.jgit.command.JGitUtils.addAllFiles(Git,
ScmFileSet)}}. The baseUri of the fileSet is /home/me/git/my-repo/src so the
relativized path become pom.xml. But
{{org.eclipse.jgit.api.AddCommand.addFilepattern(String)}} expects a repository
relative path, i.e. src/pom.xml.
This patch [https://github.com/apache/maven-scm/compare/master...attiand:fix]
relativize the path against the Git repo rather than the fileset, works for me.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] Commented: (CONTINUUM-827) notification emails missing svn information
[ http://jira.codehaus.org/browse/CONTINUUM-827?page=comments#action_73092 ] Mattias Andersson commented on CONTINUUM-827: - I see the same behaviour with CVS as SCM provider. Only a list of files changed and no developer or commit message (this worked fine in 1.0.2). See the exampel below. It's the same in the build result view (See attached picture). Online report : http://sorken-wm2:8080/continuum/servlet/continuum/target/ProjectBuild.vm/view/ProjectBuild/id/11/buildId/999 Build statistics: State: Ok Previous State: Building Started at: fr, 2006-08-18 01:19:51 +0200 Finished at: fr, 2006-08-18 02:14:54 +0200 Total time: 55m 2s Build Trigger: Schedule Exit code: 0 Building machine hostname: sorken-wm2 Operating system : Windows 2003(Service Pack 1) Java version : 1.4.2_10(Sun Microsystems Inc.) Changes scripts/Database/factorydata/CAT_CUSTOMER_GROUP.dat scripts/Database/factorydata/SYS_SUBSYSTEM_ROLE_ACCESS.dat scripts/Database/factorydata/SYS_USER_GROUPS.dat ... notification emails missing svn information --- Key: CONTINUUM-827 URL: http://jira.codehaus.org/browse/CONTINUUM-827 Project: Continuum Issue Type: Bug Components: SCM Affects Versions: 1.0.3 Reporter: Brian Fox Fix For: 1.1 I'm using 1.0.3 and svn 1.3.2. 99% of the time, the notifications do not list the developer or the commit message. I just get a list of changed files. I have seen it in the past occasionally but almost always the info isn't there. This includes times when there was only 1 commit since the last build. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
