Re: [PR] Use Maven Wrapper to build [maven]
laeubi commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2143285471 There is a setup-maven action: https://github.com/marketplace/actions/setup-maven-action -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]
elharo commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1623046215
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.pmd.exec;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.Writer;
+import java.util.function.Consumer;
+import java.util.function.Predicate;
+
+import net.sourceforge.pmd.cpd.CPDReport;
+import net.sourceforge.pmd.cpd.CPDReportRenderer;
+import net.sourceforge.pmd.cpd.Match;
+import net.sourceforge.pmd.cpd.XMLRenderer;
+import org.apache.maven.plugins.pmd.ExcludeDuplicationsFromFile;
+import org.apache.maven.reporting.MavenReportException;
+import org.codehaus.plexus.util.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class CpdReportConsumer implements Consumer {
+private static final Logger LOG =
LoggerFactory.getLogger(CpdReportConsumer.class);
+
+private final CpdRequest request;
+private final ExcludeDuplicationsFromFile excludeDuplicationsFromFile;
+
+CpdReportConsumer(CpdRequest request, ExcludeDuplicationsFromFile
excludeDuplicationsFromFile) {
+this.request = request;
+this.excludeDuplicationsFromFile = excludeDuplicationsFromFile;
+}
+
+@Override
+public void accept(CPDReport report) {
+try {
+// always create XML format. we need to output it even if the file
list is empty or we have no
+// duplications so that the "check" goals can check for violations
+writeXmlReport(report);
+
+// html format is handled by maven site report, xml format has
already been rendered
+// a renderer is only needed for other formats
+String format = request.getFormat();
+if (!"html".equals(format) && !"xml".equals(format)) {
+writeFormattedReport(report);
+}
+} catch (MavenReportException e) {
+// Exceptions happening during this consumer are logged by PMD
+// through the CPDConfiguration's reporter, which is in this case
PmdErrorMessageReporter.
+throw new RuntimeException(e);
+}
+}
+
+private void writeXmlReport(CPDReport cpd) throws MavenReportException {
+File targetFile = writeReport(cpd, new
XMLRenderer(request.getOutputEncoding()), "xml");
+if (request.isIncludeXmlInSite()) {
+File siteDir = new File(request.getReportOutputDirectory());
+siteDir.mkdirs();
+try {
+FileUtils.copyFile(targetFile, new File(siteDir, "cpd.xml"));
+} catch (IOException e) {
+throw new MavenReportException("Error while copying cpd.xml
report to site dir", e);
+}
+}
+}
+
+private void writeFormattedReport(CPDReport cpd) throws
MavenReportException {
+CPDReportRenderer r = CpdExecutor.createRenderer(request.getFormat(),
request.getOutputEncoding());
+writeReport(cpd, r, request.getFormat());
+}
+
+private File writeReport(CPDReport cpd, CPDReportRenderer r, String
extension) throws MavenReportException {
Review Comment:
r --> renderer
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -167,66 +163,20 @@ private CpdResult run() throws MavenReportException {
request.getFiles().forEach(f ->
cpdConfiguration.addInputPath(f.toPath()));
LOG.debug("Executing CPD...");
-
-// always create XML format. we need to output it even if the file
list is empty or we have no duplications
-// so the "check" goals can check for violations
try (CpdAnalysis cpd = CpdAnalysis.create(cpdConfiguration)) {
-cpd.performAnalysis(report -> {
-try {
-writeXmlReport(report);
-
-// html format is handled by maven site report, xml format
has already been rendered
-String format = request.getFormat();
-if
Re: [PR] Workaround: Windows Junction Link handling issue in mvnw.cmd [maven-wrapper]
fp024 commented on PR #143:
URL: https://github.com/apache/maven-wrapper/pull/143#issuecomment-2143129380
hello.
I received a GitHub Action build failure email and checked the code again.
Here's what I saw in PowerShell ISE after separating that part:
```powershell
# Set MAVEN_USER_HOME manually
# $env:MAVEN_USER_HOME="D:/MAVEN2/.m2"
$env:MAVEN_USER_HOME=$null
$MAVEN_M2_PATH = "$HOME/.m2"
if ($env:MAVEN_USER_HOME) {
$MAVEN_M2_PATH = "$env:MAVEN_USER_HOME"
}
Write-Output "MAVEN_M2_PATH: $MAVEN_M2_PATH"
if (-not (Test-Path -Path $MAVEN_M2_PATH)) {
New-Item -Path $MAVEN_M2_PATH -ItemType Directory | Out-Null
}
$MAVEN_WRAPPER_DISTS = $null
if ((Get-Item $MAVEN_M2_PATH).Target[0] -eq $null) { # Re-edited part
Write-Output "is null: actual path"
$MAVEN_WRAPPER_DISTS = "$MAVEN_M2_PATH/wrapper/dists"
Write-Output "MAVEN_WRAPPER_DISTS: $MAVEN_WRAPPER_DISTS"
} else {
$MAVEN_WRAPPER_DISTS = (Get-Item $MAVEN_M2_PATH).Target[0] +
"/wrapper/dists"
Write-Output "not null: junction path -> actual path"
Write-Output "MAVEN_WRAPPER_DISTS: $MAVEN_WRAPPER_DISTS"
}
```
### When MAVEN_USER_HOME is not set as an environment variable
* MAVEN_M2_PATH="HOME/.m2"
* `C:\Users\{UserName}/.m2` is the junction path
* `G:\Maven\m2/wrapper/dists` is the actual path
* The actual path to the picture in the first comment is incorrect: my
actual path environment is `G:\Maven\m2`, not `G:\Maven\.m2`.
### When MAVEN_USER_HOME is set as an environment variable
* MAVEN_M2_PATH="D:/MAVEN2/.m2"
* `D:/MAVEN2/.m2` is the actual path
* Compared to the first uploaded commit, we changed it to always check the
junction link condition with Target[0].
*
https://github.com/apache/maven-wrapper/compare/eaddcc6d7d1490059e286eef80a2176e560e3d6e..cefb22592fe3397c7652bc3a3866bd73cf5ec8c5
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-site-plugin from 4.0.0-M8 to 4.0.0-M15 [maven-site]
dependabot[bot] opened a new pull request, #537: URL: https://github.com/apache/maven-site/pull/537 Bumps [org.apache.maven.plugins:maven-site-plugin](https://github.com/apache/maven-site-plugin) from 4.0.0-M8 to 4.0.0-M15. Commits https://github.com/apache/maven-site-plugin/commit/e3166b31487ee69f4adde7126a6a30e996417a30;>e3166b3 [maven-release-plugin] prepare release maven-site-plugin-4.0.0-M15 https://github.com/apache/maven-site-plugin/commit/0f45c49cb765a0433da6d295ce894e3049069c93;>0f45c49 [MSITE-1009] Upgrade plugins and components (in ITs) https://github.com/apache/maven-site-plugin/commit/64c42984682095fa82a4f1d0c295b342b5513b16;>64c4298 [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 (2) https://github.com/apache/maven-site-plugin/commit/deee90af4e539095cfc6f3208db3df1fa9395ed8;>deee90a [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 https://github.com/apache/maven-site-plugin/commit/22b76704b043cac8797a4c2c37ccf1b9f203dc73;>22b7670 Bump maven-gh-actions-shared to v4 https://github.com/apache/maven-site-plugin/commit/c1c781b33d74756cbc49b7ec898564320adfbd1a;>c1c781b [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-site-plugin/commit/67624ffb51130541febf488cec401df9e841504a;>67624ff [maven-release-plugin] prepare release maven-site-plugin-4.0.0-M14 https://github.com/apache/maven-site-plugin/commit/b3a063b17f2a2a15b02b179b84103e0bf6330c87;>b3a063b [MSITE-1006] MSITE-723 causes duplicate document rendering and log output https://github.com/apache/maven-site-plugin/commit/86c6d37f7a65b57a70c4faf67b7da015e17462fb;>86c6d37 Fix broken commit 1bbad2d356a4ede8ebbe3a523533b660d66d9b58 https://github.com/apache/maven-site-plugin/commit/1bbad2d356a4ede8ebbe3a523533b660d66d9b58;>1bbad2d [MSITE-1003] Upgrade plugins and components (in ITs) Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-4.0.0-M8...maven-site-plugin-4.0.0-M15;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MCHECKSTYLE-448] Upgrade to Parent 42 and Maven 3.6.3 [maven-checkstyle-plugin]
michael-o opened a new pull request, #137: URL: https://github.com/apache/maven-checkstyle-plugin/pull/137 This closes #137 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]
rmannibucau commented on PR #219: URL: https://github.com/apache/maven-shade-plugin/pull/219#issuecomment-2142942628 Open question: fix pluginxml generation instead of fixing all mojo since it is valid to use the default value for primitives? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]
michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1622919499
##
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.pmd.exec;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import net.sourceforge.pmd.util.log.PmdReporter;
+import org.apache.maven.reporting.MavenReportException;
+import org.checkerframework.checker.nullness.qual.Nullable;
+import org.slf4j.event.Level;
+
+class PmdErrorMessageReporter implements PmdReporter {
+private final PmdReporter delegate;
+private List errors = new ArrayList<>();
+
+PmdErrorMessageReporter(PmdReporter delegate) {
+this.delegate = delegate;
+}
+
+@Override
+public boolean isLoggable(Level level) {
+return delegate.isLoggable(level);
+}
+
+@Override
+public void logEx(Level level, @Nullable String message, Object[]
formatArgs, @Nullable Throwable error) {
+if (error != null) {
+if (error instanceof RuntimeException && error.getCause()
instanceof MavenReportException) {
+errors.add(error.getCause());
+} else {
+errors.add(error);
+}
+}
+
+delegate.logEx(level, message, formatArgs, error);
+}
+
+@Override
+public int numErrors() {
+return delegate.numErrors();
+}
+
+public void rethrowErrorsAsMavenReportException() throws
MavenReportException {
+if (errors.isEmpty()) {
+return;
+}
+
+final MavenReportException exception;
+
+Throwable firstError = errors.get(0);
Review Comment:
I am bit confused, you log multiple issue -- yet this one processes only the
first one? Can multiple ones happen? What ist the purpose to log them if they
are rethrown and printed by the system anyway? Doesn't this produce duplicate
output?
@elharo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.springframework:spring-context from 4.3.29.RELEASE to 5.2.21.RELEASE in /src/it/projects/MJAVADOC-434_fixcompile [maven-javadoc-plugin]
slachiewicz merged PR #280: URL: https://github.com/apache/maven-javadoc-plugin/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]
michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1613420382
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -161,13 +163,15 @@ private CpdResult run() throws MavenReportException {
request.getFiles().forEach(f ->
cpdConfiguration.addInputPath(f.toPath()));
LOG.debug("Executing CPD...");
-CpdReportConsumer reportConsumer = new CpdReportConsumer(request,
excludeDuplicationsFromFile);
try (CpdAnalysis cpd = CpdAnalysis.create(cpdConfiguration)) {
+CpdReportConsumer reportConsumer = new CpdReportConsumer(request,
excludeDuplicationsFromFile);
cpd.performAnalysis(reportConsumer);
} catch (IOException e) {
throw new MavenReportException("Error while executing CPD", e);
}
-reportConsumer.rethrowAnyMavenReportException();
+// in constrast to pmd goal, we don't have a parameter for cpd like
"skipPmdError" - if there
+// are any errors during CPD analysis, the maven build will be failed.
Review Comment:
.. the Maven build will fail.
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.pmd.exec;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.Writer;
+import java.util.function.Consumer;
+import java.util.function.Predicate;
+
+import net.sourceforge.pmd.cpd.CPDReport;
+import net.sourceforge.pmd.cpd.CPDReportRenderer;
+import net.sourceforge.pmd.cpd.Match;
+import net.sourceforge.pmd.cpd.XMLRenderer;
+import org.apache.maven.plugins.pmd.ExcludeDuplicationsFromFile;
+import org.apache.maven.reporting.MavenReportException;
+import org.codehaus.plexus.util.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class CpdReportConsumer implements Consumer {
+private static final Logger LOG =
LoggerFactory.getLogger(CpdReportConsumer.class);
+
+private final CpdRequest request;
+private final ExcludeDuplicationsFromFile excludeDuplicationsFromFile;
+private MavenReportException reportException;
+
+CpdReportConsumer(CpdRequest request, ExcludeDuplicationsFromFile
excludeDuplicationsFromFile) {
+this.request = request;
+this.excludeDuplicationsFromFile = excludeDuplicationsFromFile;
+}
+
+@Override
+public void accept(CPDReport report) {
+try {
+// always create XML format. we need to output it even if the file
list is empty or we have no
+// duplications so that the "check" goals can check for violations
+writeXmlReport(report);
+
+// html format is handled by maven site report, xml format has
already been rendered
+// a renderer is only needed for other formats
+String format = request.getFormat();
+if (!"html".equals(format) && !"xml".equals(format)) {
+writeFormattedReport(report);
+}
+} catch (MavenReportException e) {
+// Exceptions happening during this consumer are only logged by
PMD.
+// Remembering the exception here, so that we can rethrow it later
to fail the build.
+reportException = e;
+throw new RuntimeException(e);
Review Comment:
OK, I see. Let me review that again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Document behaviour around 'destDir' naming [maven-jxr]
michael-o commented on PR #113: URL: https://github.com/apache/maven-jxr/pull/113#issuecomment-2142921435 Thank you for your PR, that parameter along with other inconsistencies have already been cleaned up/removed in #64. I hope to merge that this summer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Document behaviour around 'destDir' naming [maven-jxr]
michael-o closed pull request #113: Document behaviour around 'destDir' naming URL: https://github.com/apache/maven-jxr/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix misformatted plugin documentation [maven-jxr]
asfgit closed pull request #112: Fix misformatted plugin documentation URL: https://github.com/apache/maven-jxr/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [JXR-191] Upgrade to Parent 42 and Maven 3.6.3 [maven-jxr]
michael-o opened a new pull request, #114: URL: https://github.com/apache/maven-jxr/pull/114 This closes #114 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/JXR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[JXR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `JXR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use Maven Wrapper to build [maven]
slawekjaranowski commented on PR #1548: URL: https://github.com/apache/maven/pull/1548#issuecomment-2142844431 or we can add: ``` - name: Set up Maven run: mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.3.2:wrapper "-Dmaven=3.9.7" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPIR-457] Upgrade to Parent 42 and Maven 3.6.3 [maven-project-info-reports-plugin]
asfgit closed pull request #66: [MPIR-457] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-project-info-reports-plugin/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Testing Eclipse Sisu update to upcoming 0.9.0.M3 [maven]
cstamas commented on PR #1546: URL: https://github.com/apache/maven/pull/1546#issuecomment-2142775593 Will do once we sort out ITs, as something is fishy here: it fails on macOS only (and error seems m-p-p related) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [3.9.x] Testing Eclipse Sisu update to upcoming 0.9.0.M3 [maven]
cstamas opened a new pull request, #1547: URL: https://github.com/apache/maven/pull/1547 Same as for master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Testing Eclipse Sisu update to upcoming 0.9.0.M3 [maven]
cstamas commented on PR #1546: URL: https://github.com/apache/maven/pull/1546#issuecomment-2142664684 @kwin this locally failed on me (it's maybe me), just heads up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Testing Eclipse Sisu update to upcoming 0.9.0.M3 [maven]
cstamas opened a new pull request, #1546: URL: https://github.com/apache/maven/pull/1546 Using the snapshot deployment version `0.9.0-20240531.165402-20` from OSSRH snapshots repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
michael-o commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1622646254
##
src/main/java/org/apache/maven/shared/jar/classes/JarRuntimeVersion.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.jar.classes;
+
+import java.util.List;
+import java.util.jar.JarEntry;
+
+public class JarRuntimeVersion {
Review Comment:
Then please rename to `JarVersionedRuntime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MSHARED-1407] Track dependency usage by referencing classes [maven-dependency-analyzer]
jaredstehler opened a new pull request, #125: URL: https://github.com/apache/maven-dependency-analyzer/pull/125 This enhances the functionality which shows specific classes in use per dependency, by mapping those uses to classes which are referencing them. The resulting API addition is: ```java Set analyzeUsages(URL url, ClassesPatterns excludeClasses) ``` which I plan on adding a PR to `maven-dependency-plugin` to show how we use this feature in practice. This was originally proposed via this PR https://github.com/apache/maven-dependency-analyzer/pull/20 which was closed due to lack of support for default interface methods prior to JDK8. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. Also be sure having selected the correct component. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1407] Track dependency usage by referencing classes [maven-dependency-analyzer]
jaredstehler closed pull request #124: [MSHARED-1407] Track dependency usage by referencing classes URL: https://github.com/apache/maven-dependency-analyzer/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
michael-o commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1622627017
##
src/main/java/org/apache/maven/shared/jar/classes/JarRuntimeVersion.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.jar.classes;
+
+import java.util.List;
+import java.util.jar.JarEntry;
+
+public class JarRuntimeVersion {
+
+/**
+ * The JAR entries.
+ */
+private final List entries;
+
+private final JarClasses jarClasses;
+
+public JarRuntimeVersion(List entries, JarClasses jarClasses) {
Review Comment:
Right, we we have the in the level about, leave as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MSHARED-1407] Track dependency usage by referencing classes [maven-dependency-analyzer]
jaredstehler opened a new pull request, #124: URL: https://github.com/apache/maven-dependency-analyzer/pull/124 This enhances the functionality which shows specific classes in use per dependency, by mapping those uses to classes which are referencing them. The resulting API addition is: ```java Set analyzeUsages(URL url, ClassesPatterns excludeClasses) ``` which I plan on adding a PR to `maven-dependency-plugin` to show how we use this feature in practice. This was originally proposed via this PR https://github.com/apache/maven-dependency-analyzer/pull/20 which was closed due to lack of support for default interface methods prior to JDK8. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. Also be sure having selected the correct component. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
michael-o commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1622622242
##
src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java:
##
@@ -51,8 +57,17 @@
@Named
@SuppressWarnings("checkstyle:MagicNumber")
public class JarClassesAnalysis {
+
private final Logger logger = LoggerFactory.getLogger(getClass());
+/**
+ * Constant representing the classes in the root of a Multi-Release JAR
file.
+ * Meaning outside of any given META-INF/versions/NN/... entry.
+ */
+private static final Integer ROOT = 0;
+
+private static final Pattern ENTRY_FILTER_MULTI_RELEASE =
Pattern.compile("^META-INF/versions/(\\d{1,2})/.*$");
Review Comment:
I don't that that only having `module-info.class` is unsual, there might be
cases you need that info to make it properly work for modules, but simply don't
need for 8. So for me empty does not qualify, at least one class should be in...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2246] Clean up dependencies reported by dependencies:analyze [maven-surefire]
michael-o commented on PR #738: URL: https://github.com/apache/maven-surefire/pull/738#issuecomment-2142514325 This requires #737 first... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-5693] Remove unhelpful links that don't describe failure reasons from output [maven]
elharo commented on PR #1545: URL: https://github.com/apache/maven/pull/1545#issuecomment-2142050136 Is the MacOS CI borked? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Workaround: Windows Junction Link handling issue in mvnw.cmd [maven-wrapper]
cstamas commented on PR #143: URL: https://github.com/apache/maven-wrapper/pull/143#issuecomment-2141976433 @michael-o ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Workaround: Windows Junction Link handling issue in mvnw.cmd [maven-wrapper]
fp024 opened a new pull request, #143:
URL: https://github.com/apache/maven-wrapper/pull/143
hello.
I applied to join Apache JIRA, but I wasn't sure if I would be approved as a
member, so I submitted a PR for issue reporting purposes.
## Issue
`Move-Item` fails when the `.m2` path is in the following state:
* Junction link reference status of m2 directory on my system
* `G:\Maven\.m2` is the actual path.
The argument value of `-Destnation` in PowerShell's `Move-Item` command must
be an actual path, but in my environment, it is a **junction link** and is
bound to fail.
## Workaround
So I modified the code to get `$MAVEN_HOME_PARENT` as follows.
```powershell
# ...
$MAVEN_M2_PATH = "$HOME/.m2"
if ($env:MAVEN_USER_HOME) {
$MAVEN_M2_PATH = "$env:MAVEN_USER_HOME"
}
if (-not (Test-Path -Path $MAVEN_M2_PATH)) {
New-Item -Path $MAVEN_M2_PATH -ItemType Directory | Out-Null
}
$MAVEN_WRAPPER_DISTS = $null
if ((Get-Item $MAVEN_M2_PATH).Target -eq $null) {
$MAVEN_WRAPPER_DISTS = "$MAVEN_M2_PATH/wrapper/dists"
} else {
$MAVEN_WRAPPER_DISTS = (Get-Item $MAVEN_M2_PATH).Target[0] +
"/wrapper/dists"
}
$MAVEN_HOME_PARENT = "$MAVEN_WRAPPER_DISTS/$distributionUrlNameMain"
# ...
```
* The actual path could be obtained by obtaining Target[0] on the Item
obtained with Get-Item -Path {Path}.
* If the path passed as an argument is an actual path rather than a
junction link path, it is `$null`.
This PR commit was posted for issue reporting purposes only, so it may
require expert editing.
Please confirm. thank you have a good day.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [[JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER)](https://issues.apache.org/jira/browse/MWRAPPER)
filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf)](https://www.apache.org/licenses/icla.pdf)
if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [[Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [[Apache
License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [[Apache Individual Contributor
License
Agreement](https://www.apache.org/licenses/icla.pdf)](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-5693] Remove unhelpful links that don't describe failure reasons from output [maven]
elharo commented on PR #1545: URL: https://github.com/apache/maven/pull/1545#issuecomment-2141909545 Error: Failures: Error: MavenITmng5482AetherNotFoundTest.testPluginDependency:47->check:82->AbstractMavenIntegrationTestCase.assertTrue:359 Url to ClassNotFoundAether was not found in output. ==> expected: but was: Error: MavenITmng5482AetherNotFoundTest.testPluginSite:52->check:82->AbstractMavenIntegrationTestCase.assertTrue:359 Url to ClassNotFoundAether was not found in output. ==> expected: but was: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-5693] Remove unhelpful links that don't describe failure reasons from output [maven]
elharo opened a new pull request, #1545: URL: https://github.com/apache/maven/pull/1545 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622214652
##
maven-plugin-plugin/src/it/skip/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java:
##
@@ -18,47 +18,15 @@
*/
package org.apache.maven.plugin.coreit;
-import java.io.File;
-
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Mojo;
/**
* Touches a test file.
- *
- * @goal first
- * @requiresDependencyResolution test
- * @phase integration-test
- * @execute phase="generate-sources" lifecycle="cobertura"
- * @deprecated Don't use!
- * @since 1.2
*/
+@Mojo(name = "test")
public class FirstMojo extends AbstractMojo {
Review Comment:
Those mojos are just built and used to verify a few specific things
depending on each test. The annotations are usually not used or tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622213397
##
maven-plugin-report-plugin/src/it/mplugin-319_report-since/src/main/java/org/MyMojo.java:
##
@@ -19,41 +19,32 @@
package org;
import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
/**
* Does nothing.
*
- * @goal noop
- * @phase process-sources
- * @requiresDependencyResolution test
- * @requiresDirectInvocation true
- * @requiresOnline
- * @inheritByDefault false
- * @execute phase="compile"
- * @aggregator
* @since 1.0
*
* @deprecated You don't use test goals, do you?
*/
+@Mojo(name = "noop")
public class MyMojo extends AbstractMojo {
Review Comment:
No, but again, those are not tested. I think the one creating the original
test just copy/pasted an existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]
thijsrijpert commented on code in PR #244:
URL:
https://github.com/apache/maven-compiler-plugin/pull/244#discussion_r1622040960
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1239,7 +1239,9 @@ public void execute() throws MojoExecutionException,
CompilationFailureException
}
}
-if (outputTimestamp != null && (outputTimestamp.length() > 1 ||
Character.isDigit(outputTimestamp.charAt(0 {
+if (outputTimestamp != null
+&& !outputTimestamp.isEmpty()
Review Comment:
I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]
michael-o commented on code in PR #244:
URL:
https://github.com/apache/maven-compiler-plugin/pull/244#discussion_r1622036071
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1239,7 +1239,9 @@ public void execute() throws MojoExecutionException,
CompilationFailureException
}
}
-if (outputTimestamp != null && (outputTimestamp.length() > 1 ||
Character.isDigit(outputTimestamp.charAt(0 {
+if (outputTimestamp != null
+&& !outputTimestamp.isEmpty()
Review Comment:
While I consider your fix as reasonable, I'd prefer to see the actual cause
to be addressed as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]
thijsrijpert commented on code in PR #244:
URL:
https://github.com/apache/maven-compiler-plugin/pull/244#discussion_r1622033060
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1239,7 +1239,9 @@ public void execute() throws MojoExecutionException,
CompilationFailureException
}
}
-if (outputTimestamp != null && (outputTimestamp.length() > 1 ||
Character.isDigit(outputTimestamp.charAt(0 {
+if (outputTimestamp != null
+&& !outputTimestamp.isEmpty()
Review Comment:
Yes, I think it would be set by another plugin. The project I was working on
has a lot of plugins, so I would not know which plugin exactly sets this value.
When I encountered this issue, the value was not set in the projects pom, but
it was a non-null empty string when this line was run, indicating it was set
somewhere in the compilation process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622028381
##
maven-plugin-report-plugin/src/it/mplugin-319_report-since/src/main/java/org/MyMojo.java:
##
@@ -19,41 +19,32 @@
package org;
import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
/**
* Does nothing.
*
- * @goal noop
- * @phase process-sources
- * @requiresDependencyResolution test
- * @requiresDirectInvocation true
- * @requiresOnline
- * @inheritByDefault false
- * @execute phase="compile"
- * @aggregator
* @since 1.0
*
* @deprecated You don't use test goals, do you?
*/
+@Mojo(name = "noop")
public class MyMojo extends AbstractMojo {
Review Comment:
The previous config had a lot of stuff:
```
* @goal noop
* @phase process-sources
* @requiresDependencyResolution test
* @requiresDirectInvocation true
* @requiresOnline
* @inheritByDefault false
* @execute phase="compile"
* @aggregator
```
Plain `@Mojo` isn't an equivalent, is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622028975
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java:
##
@@ -43,7 +42,7 @@
* Reads enhanced plugin.xml files as generated by
* {@link PluginDescriptorFilesGenerator} and used by {@link PluginReport}.
* Populates the slightly extended {@link Parameter} object {@link
EnhancedParameterWrapper}.
- * In addition populates all (optional) elements added after Maven Plugin API
3.2.5.
+ * In addition, populates all (optional) elements added after Maven Plugin API
3.2.5.
Review Comment:
Alright, let's keep the wording as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622025316 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java: ## @@ -48,8 +54,14 @@ import org.apache.maven.tools.plugin.scanner.MojoScanner; import org.codehaus.plexus.component.repository.ComponentDependency; import org.codehaus.plexus.util.ReaderFactory; +import org.codehaus.plexus.util.io.CachingOutputStream; +import org.codehaus.plexus.util.io.CachingWriter; +import org.objectweb.asm.*; Review Comment: Accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622016198
##
maven-plugin-report-plugin/src/it/mplugin-319_report-since/src/main/java/org/MyMojo.java:
##
@@ -19,41 +19,32 @@
package org;
import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
/**
* Does nothing.
*
- * @goal noop
- * @phase process-sources
- * @requiresDependencyResolution test
- * @requiresDirectInvocation true
- * @requiresOnline
- * @inheritByDefault false
- * @execute phase="compile"
- * @aggregator
* @since 1.0
*
* @deprecated You don't use test goals, do you?
*/
+@Mojo(name = "noop")
public class MyMojo extends AbstractMojo {
Review Comment:
Why ? if not specified, the plugin won't have a default phase, but that's
not a problem here. We don't even use this plugin, we're only building it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622012613
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java:
##
@@ -43,7 +42,7 @@
* Reads enhanced plugin.xml files as generated by
* {@link PluginDescriptorFilesGenerator} and used by {@link PluginReport}.
* Populates the slightly extended {@link Parameter} object {@link
EnhancedParameterWrapper}.
- * In addition populates all (optional) elements added after Maven Plugin API
3.2.5.
+ * In addition, populates all (optional) elements added after Maven Plugin API
3.2.5.
Review Comment:
Unfortunately, the `requiredJavaVersion` has been added in this plugin more
recently, but has not been added in the descriptor API in maven... Even if
we add it, we'll then raise the requirement to latest 3.9.x.
However, this field is available in the v4 api, so we will be able to get
rid of those when we fully switch to Maven 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622007268 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java: ## @@ -48,8 +54,14 @@ import org.apache.maven.tools.plugin.scanner.MojoScanner; import org.codehaus.plexus.component.repository.ComponentDependency; import org.codehaus.plexus.util.ReaderFactory; +import org.codehaus.plexus.util.io.CachingOutputStream; +import org.codehaus.plexus.util.io.CachingWriter; +import org.objectweb.asm.*; Review Comment: The imports are used to generate the factories for Maven 4.x mojos. They are not using plexus, as they are booted by the new DI framework in Maven. But this framework recognises beans annotated with `@org.apache.maven.api.di.Named`, which is not the case for mojos. To avoid forcing the user to add this annotation, a factory (annotated with the needed annotation) is generated by the plugin. And to avoid having to do another compile phase, the byte code is directly generated instead of generating source code. Those new imports are needed for this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1622003767 ## maven-plugin-plugin/src/it/v4api/invoker.properties: ## @@ -15,4 +15,5 @@ # specific language governing permissions and limitations # under the License. +invoker.java.version = 17+ Review Comment: Ah, OK. This makes sense. My oversight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621998036 ## maven-plugin-plugin/src/it/v4api/invoker.properties: ## @@ -15,4 +15,5 @@ # specific language governing permissions and limitations # under the License. +invoker.java.version = 17+ Review Comment: The entire project is JDK 8. The mojos run on Maven 3.x + JDK 8 if you want to build Maven 3.x plugins. If you build a Maven 4.x plugin, you'll need JDK 17. That's the case for this IT. Other ITs are unchanged. The migration to Maven 4 only should imho happen at the same time as m-plugin-p is migrated to be a Maven 4 plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]
michael-o commented on code in PR #244:
URL:
https://github.com/apache/maven-compiler-plugin/pull/244#discussion_r1621995663
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1239,7 +1239,9 @@ public void execute() throws MojoExecutionException,
CompilationFailureException
}
}
-if (outputTimestamp != null && (outputTimestamp.length() > 1 ||
Character.isDigit(outputTimestamp.charAt(0 {
+if (outputTimestamp != null
+&& !outputTimestamp.isEmpty()
Review Comment:
I'd like to understand how the value can be empty: ``? This basically
can happen in any plugin using this value, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621991740
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
> > Maven 4 mojos have to be thread safe, so that annotation is gone.
>
> You cannot enforce that, right? Only by contract...
Right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]
thijsrijpert commented on PR #244: URL: https://github.com/apache/maven-compiler-plugin/pull/244#issuecomment-2141522932 From JIRA issue: Due to a combination of plugins, it is possible for the project.build.outputTimestamp property to have an empty string as a value. This causes an IndexOutOfBoundsException on line 1242 when it tries to access the first character in the string. This can be fixed by doing an isEmpty check before doing the charAt check. I will create an PR for this. While this bug is caused by another plugin, I think this should be fixed in the compiler because the error returned (IndexOutOfBoundsException), is vague and hard to debug. The workaround for this issue is setting the project.build.outputTimestamp property with an arbitrary value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]
thijsrijpert opened a new pull request, #244: URL: https://github.com/apache/maven-compiler-plugin/pull/244 …Timestamp is empty Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MENFORCER-500] New rule to enforce that Maven coordinates match given [maven-enforcer]
Bananeweizen commented on code in PR #309:
URL: https://github.com/apache/maven-enforcer/pull/309#discussion_r1621974649
##
enforcer-rules/src/site/apt/requireMatchingCoordinates.apt.vm:
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+ --
+ Require Matching Coordinates
+ --
+ Konrad Windszus
+ --
+ 2024-03-22
+ --
+
+Require Matching Coordinates
+
+ This rule checks that the Maven coordinates (i.e. the project's
<<>> and <<>>) each match a given pattern.
+ Optionally one can also enforce that in a multi-module build the module
directory name is always equal to the module's <<>>.
+
+ The following parameters are supported by this rule:
+
+ * <> - an optional message to the user if the rule fails. If not
set a default message will be used.
+
+ * <> - an optional
{{{https://docs.oracle.com/javase/tutorial/essential/regex/}regular
expression}}, which must match the project's <<>>. If not set there is
no check on the <<>>.
+
+ * <> - an optional
{{{https://docs.oracle.com/javase/tutorial/essential/regex/}regular
expression}}, which must match the project's <<>>. If not set there
is no check on the <<>>.
+
+ * <> - boolean flag to enforce that the the
module's directory name is always equal to the module's <<>>. By
default <<>>.
+
+ []
+
+
+ Sample Plugin Configuration:
+
++---+
+
+ [...]
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+${project.version}
+
+
+enforce-group-id
+
+ enforce
+
+
+
+
+ com\.example.\namespace\..*
+
Review Comment:
copy paste error, see https://issues.apache.org/jira/browse/MENFORCER-505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621933072
##
maven-plugin-report-plugin/src/it/mplugin-319_report-since/src/main/java/org/MyMojo.java:
##
@@ -19,41 +19,32 @@
package org;
import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
/**
* Does nothing.
*
- * @goal noop
- * @phase process-sources
- * @requiresDependencyResolution test
- * @requiresDirectInvocation true
- * @requiresOnline
- * @inheritByDefault false
- * @execute phase="compile"
- * @aggregator
* @since 1.0
*
* @deprecated You don't use test goals, do you?
*/
+@Mojo(name = "noop")
public class MyMojo extends AbstractMojo {
Review Comment:
Phases?
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java:
##
@@ -43,7 +42,7 @@
* Reads enhanced plugin.xml files as generated by
* {@link PluginDescriptorFilesGenerator} and used by {@link PluginReport}.
* Populates the slightly extended {@link Parameter} object {@link
EnhancedParameterWrapper}.
- * In addition populates all (optional) elements added after Maven Plugin API
3.2.5.
+ * In addition, populates all (optional) elements added after Maven Plugin API
3.2.5.
Review Comment:
I think this can be simplified because 3.2.5 is long gone...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621931005 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java: ## @@ -48,8 +54,14 @@ import org.apache.maven.tools.plugin.scanner.MojoScanner; import org.codehaus.plexus.component.repository.ComponentDependency; import org.codehaus.plexus.util.ReaderFactory; +import org.codehaus.plexus.util.io.CachingOutputStream; +import org.codehaus.plexus.util.io.CachingWriter; +import org.objectweb.asm.*; Review Comment: Is this necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286: URL: https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621929663 ## maven-plugin-plugin/src/it/v4api/invoker.properties: ## @@ -15,4 +15,5 @@ # specific language governing permissions and limitations # under the License. +invoker.java.version = 17+ Review Comment: Confusing if the entire project require Java 17, why here especially? ## maven-plugin-plugin/src/it/v4api/invoker.properties: ## @@ -15,4 +15,5 @@ # specific language governing permissions and limitations # under the License. +invoker.java.version = 17+ Review Comment: Confusing if the entire project requires Java 17, why here especially? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621928560
##
maven-plugin-plugin/src/it/skip/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java:
##
@@ -18,47 +18,15 @@
*/
package org.apache.maven.plugin.coreit;
-import java.io.File;
-
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugins.annotations.Mojo;
/**
* Touches a test file.
- *
- * @goal first
- * @requiresDependencyResolution test
- * @phase integration-test
- * @execute phase="generate-sources" lifecycle="cobertura"
- * @deprecated Don't use!
- * @since 1.2
*/
+@Mojo(name = "test")
public class FirstMojo extends AbstractMojo {
Review Comment:
This is now completely different, how?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621924860
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
> Maven 4 mojos have to be thread safe, so that annotation is gone.
You cannot enforce that right? Only by contract...
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
> Maven 4 mojos have to be thread safe, so that annotation is gone.
You cannot enforce that, right? Only by contract...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.simplify4u.plugins:pgpverify-maven-plugin from 1.17.0 to 1.18.1 [maven-artifact-plugin]
dependabot[bot] opened a new pull request, #46: URL: https://github.com/apache/maven-artifact-plugin/pull/46 Bumps [org.simplify4u.plugins:pgpverify-maven-plugin](https://github.com/s4u/pgpverify-maven-plugin) from 1.17.0 to 1.18.1. Release notes Sourced from https://github.com/s4u/pgpverify-maven-plugin/releases;>org.simplify4u.plugins:pgpverify-maven-plugin's releases. v1.18.1 What's Changed :lady_beetle: Bug Fixes Plugins dependencies should be filtered (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/552;>#552) https://github.com/slawekjaranowski;>@slawekjaranowski Fix plugin documentation generation (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/553;>#553) https://github.com/slawekjaranowski;>@slawekjaranowski :heart: Thanks Many thanks for collaboration on this release for: https://github.com/slawekjaranowski;>@slawekjaranowski v1.18.0 What's Changed :fire: New features Resolve signatures by Resolver API (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/523;>#523) https://github.com/slawekjaranowski;>@slawekjaranowski Support for new algorithm in ShowMojo (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/524;>#524) https://github.com/slawekjaranowski;>@slawekjaranowski Resolve project artifacts by Resolver API (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/526;>#526) https://github.com/slawekjaranowski;>@slawekjaranowski Resolve plugins by Resolver API (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/529;>#529) https://github.com/slawekjaranowski;>@slawekjaranowski Use maven-gpg-plugin with new parent (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/532;>#532) https://github.com/slawekjaranowski;>@slawekjaranowski Required Maven 3.6.3 as minimum for plugin (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/530;>#530) https://github.com/slawekjaranowski;>@slawekjaranowski Provide a path for not existing key in exception in offline mode (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/546;>#546) https://github.com/slawekjaranowski;>@slawekjaranowski :lady_beetle: Bug Fixes Use BaseVersion for artifacts version checking - fix https://redirect.github.com/s4u/pgpverify-maven-plugin/issues/499;>#499 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/534;>#534) https://github.com/slawekjaranowski;>@slawekjaranowski Use remotePluginRepositories for resolving plugins - fix https://redirect.github.com/s4u/pgpverify-maven-plugin/issues/537;>#537 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/545;>#545) https://github.com/slawekjaranowski;>@slawekjaranowski :hammer: Maintenance migrate to JUnit from TestNG (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/436;>#436) https://github.com/siwonpawel;>@siwonpawel Fix typo (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/510;>#510) https://github.com/Godin;>@Godin Fix some typos in docs (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/542;>#542) https://github.com/pzygielo;>@pzygielo Code cleanups (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/547;>#547) https://github.com/slawekjaranowski;>@slawekjaranowski :toolbox: Dependency updates Bump jackson.version from 2.14.1 to 2.14.2 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/437;>#437) https://github.com/dependabot;>@dependabot Bump lombok from 1.18.24 to 1.18.26 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/440;>#440) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.12.22 to 1.12.23 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/441;>#441) https://github.com/dependabot;>@dependabot Bump junit-jupiter-api from 5.9.1 to 5.9.2 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/443;>#443) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.12.23 to 1.13.0 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/444;>#444) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.13.0 to 1.14.0 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/446;>#446) https://github.com/dependabot;>@dependabot Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/447;>#447) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.14.0 to 1.14.1 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/449;>#449) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.14.1 to 1.14.2 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/451;>#451) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.14.2 to 1.14.3 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/453;>#453) https://github.com/dependabot;>@dependabot Bump
[PR] Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.4.1 to 3.5.0 [maven-apache-parent]
dependabot[bot] opened a new pull request, #225: URL: https://github.com/apache/maven-apache-parent/pull/225 Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.4.1 to 3.5.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases;>org.apache.maven.plugins:maven-enforcer-plugin's releases. 3.5.0 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-497;>[MENFORCER-497] - Require Maven 3.6.3+ (https://redirect.github.com/apache/maven-enforcer/pull/317;>#317) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-494;>[MENFORCER-494] - Allow banning dynamic versions in whole tree (https://redirect.github.com/apache/maven-enforcer/pull/294;>#294) https://github.com/JimmyAx;>@JimmyAx https://issues.apache.org/jira/browse/MENFORCER-500;>[MENFORCER-500] - New rule to enforce that Maven coordinates match given (https://redirect.github.com/apache/maven-enforcer/pull/309;>#309) https://github.com/kwin;>@kwin Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-503;>[MENFORCER-503] - Pass context to ProfileActivator - fix NPE in Maven 3.9.7 (https://redirect.github.com/apache/maven-enforcer/pull/315;>#315) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.16.0 to 2.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/311;>#311) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (https://redirect.github.com/apache/maven-enforcer/pull/312;>#312) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-504;>[MENFORCER-504] - Bump org.apache.maven:maven-parent from 41 to 42 (https://redirect.github.com/apache/maven-enforcer/pull/314;>#314) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (https://redirect.github.com/apache/maven-enforcer/pull/298;>#298) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/305;>#305) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.13.0 to 2.16.0 (https://redirect.github.com/apache/maven-enforcer/pull/310;>#310) https://github.com/dependabot;>@dependabot Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/307;>#307) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/apache/maven-enforcer/pull/308;>#308) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-498;>[MENFORCER-498] - Update parent pom to 41 (https://redirect.github.com/apache/maven-enforcer/pull/306;>#306) https://github.com/slachiewicz;>@slachiewicz Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-enforcer/pull/303;>#303) https://github.com/dependabot;>@dependabot Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 (https://redirect.github.com/apache/maven-enforcer/pull/301;>#301) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 (https://redirect.github.com/apache/maven-enforcer/pull/295;>#295) https://github.com/dependabot;>@dependabot Bump org.junit:junit-bom from 5.10.0 to 5.10.1 (https://redirect.github.com/apache/maven-enforcer/pull/296;>#296) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-492;>[MENFORCER-492] - Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0 (https://redirect.github.com/apache/maven-enforcer/pull/291;>#291) https://github.com/slawekjaranowski;>@slawekjaranowski Bump org.xerial.snappy:snappy-java from 1.1.10.1 to 1.1.10.4 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/292;>#292) https://github.com/dependabot;>@dependabot Maintenance https://issues.apache.org/jira/browse/MENFORCER-490;>[MENFORCER-490] - Remove unused dependency (https://redirect.github.com/apache/maven-enforcer/pull/316;>#316) https://github.com/elharo;>@elharo Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in
[PR] Bump org.simplify4u.plugins:pgpverify-maven-plugin from 1.17.0 to 1.18.1 [maven-gpg-plugin]
dependabot[bot] opened a new pull request, #104: URL: https://github.com/apache/maven-gpg-plugin/pull/104 Bumps [org.simplify4u.plugins:pgpverify-maven-plugin](https://github.com/s4u/pgpverify-maven-plugin) from 1.17.0 to 1.18.1. Release notes Sourced from https://github.com/s4u/pgpverify-maven-plugin/releases;>org.simplify4u.plugins:pgpverify-maven-plugin's releases. v1.18.1 What's Changed :lady_beetle: Bug Fixes Plugins dependencies should be filtered (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/552;>#552) https://github.com/slawekjaranowski;>@slawekjaranowski Fix plugin documentation generation (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/553;>#553) https://github.com/slawekjaranowski;>@slawekjaranowski :heart: Thanks Many thanks for collaboration on this release for: https://github.com/slawekjaranowski;>@slawekjaranowski v1.18.0 What's Changed :fire: New features Resolve signatures by Resolver API (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/523;>#523) https://github.com/slawekjaranowski;>@slawekjaranowski Support for new algorithm in ShowMojo (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/524;>#524) https://github.com/slawekjaranowski;>@slawekjaranowski Resolve project artifacts by Resolver API (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/526;>#526) https://github.com/slawekjaranowski;>@slawekjaranowski Resolve plugins by Resolver API (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/529;>#529) https://github.com/slawekjaranowski;>@slawekjaranowski Use maven-gpg-plugin with new parent (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/532;>#532) https://github.com/slawekjaranowski;>@slawekjaranowski Required Maven 3.6.3 as minimum for plugin (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/530;>#530) https://github.com/slawekjaranowski;>@slawekjaranowski Provide a path for not existing key in exception in offline mode (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/546;>#546) https://github.com/slawekjaranowski;>@slawekjaranowski :lady_beetle: Bug Fixes Use BaseVersion for artifacts version checking - fix https://redirect.github.com/s4u/pgpverify-maven-plugin/issues/499;>#499 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/534;>#534) https://github.com/slawekjaranowski;>@slawekjaranowski Use remotePluginRepositories for resolving plugins - fix https://redirect.github.com/s4u/pgpverify-maven-plugin/issues/537;>#537 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/545;>#545) https://github.com/slawekjaranowski;>@slawekjaranowski :hammer: Maintenance migrate to JUnit from TestNG (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/436;>#436) https://github.com/siwonpawel;>@siwonpawel Fix typo (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/510;>#510) https://github.com/Godin;>@Godin Fix some typos in docs (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/542;>#542) https://github.com/pzygielo;>@pzygielo Code cleanups (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/547;>#547) https://github.com/slawekjaranowski;>@slawekjaranowski :toolbox: Dependency updates Bump jackson.version from 2.14.1 to 2.14.2 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/437;>#437) https://github.com/dependabot;>@dependabot Bump lombok from 1.18.24 to 1.18.26 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/440;>#440) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.12.22 to 1.12.23 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/441;>#441) https://github.com/dependabot;>@dependabot Bump junit-jupiter-api from 5.9.1 to 5.9.2 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/443;>#443) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.12.23 to 1.13.0 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/444;>#444) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.13.0 to 1.14.0 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/446;>#446) https://github.com/dependabot;>@dependabot Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/447;>#447) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.14.0 to 1.14.1 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/449;>#449) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.14.1 to 1.14.2 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/451;>#451) https://github.com/dependabot;>@dependabot Bump byte-buddy from 1.14.2 to 1.14.3 (https://redirect.github.com/s4u/pgpverify-maven-plugin/pull/453;>#453) https://github.com/dependabot;>@dependabot Bump
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
belingueres commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1621535738
##
src/main/java/org/apache/maven/shared/jar/classes/JarRuntimeVersion.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.jar.classes;
+
+import java.util.List;
+import java.util.jar.JarEntry;
+
+public class JarRuntimeVersion {
Review Comment:
no problem to change the name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
belingueres commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1621535379
##
src/main/java/org/apache/maven/shared/jar/classes/JarRuntimeVersion.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.jar.classes;
+
+import java.util.List;
+import java.util.jar.JarEntry;
+
+public class JarRuntimeVersion {
+
+/**
+ * The JAR entries.
+ */
+private final List entries;
+
+private final JarClasses jarClasses;
+
+public JarRuntimeVersion(List entries, JarClasses jarClasses) {
Review Comment:
The version could be easily added, but an instance of JarRuntimeVersions is
one of such holders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
belingueres commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1621534246
##
src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java:
##
@@ -51,8 +57,17 @@
@Named
@SuppressWarnings("checkstyle:MagicNumber")
public class JarClassesAnalysis {
+
private final Logger logger = LoggerFactory.getLogger(getClass());
+/**
+ * Constant representing the classes in the root of a Multi-Release JAR
file.
+ * Meaning outside of any given META-INF/versions/NN/... entry.
+ */
+private static final Integer ROOT = 0;
+
+private static final Pattern ENTRY_FILTER_MULTI_RELEASE =
Pattern.compile("^META-INF/versions/(\\d{1,2})/.*$");
Review Comment:
I don't foresee any use for storing an empty entry. Should the user want to
just query if an specific version is present, it can use other means, like
querying the JarRuntimeVersions.getRuntimeVersionMap().
Some corner cases to think: which version should a jar with just a single
'module-info.class' file should return? How about a JAR with a single file
'META-INF/versions/17/module-info.class'? it is 17? or it is whatever the
module-info. class target version is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.4.1 to 3.5.0 [maven-site]
dependabot[bot] opened a new pull request, #536: URL: https://github.com/apache/maven-site/pull/536 Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.4.1 to 3.5.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases;>org.apache.maven.plugins:maven-enforcer-plugin's releases. 3.5.0 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-497;>[MENFORCER-497] - Require Maven 3.6.3+ (https://redirect.github.com/apache/maven-enforcer/pull/317;>#317) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-494;>[MENFORCER-494] - Allow banning dynamic versions in whole tree (https://redirect.github.com/apache/maven-enforcer/pull/294;>#294) https://github.com/JimmyAx;>@JimmyAx https://issues.apache.org/jira/browse/MENFORCER-500;>[MENFORCER-500] - New rule to enforce that Maven coordinates match given (https://redirect.github.com/apache/maven-enforcer/pull/309;>#309) https://github.com/kwin;>@kwin Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-503;>[MENFORCER-503] - Pass context to ProfileActivator - fix NPE in Maven 3.9.7 (https://redirect.github.com/apache/maven-enforcer/pull/315;>#315) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.16.0 to 2.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/311;>#311) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (https://redirect.github.com/apache/maven-enforcer/pull/312;>#312) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-504;>[MENFORCER-504] - Bump org.apache.maven:maven-parent from 41 to 42 (https://redirect.github.com/apache/maven-enforcer/pull/314;>#314) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (https://redirect.github.com/apache/maven-enforcer/pull/298;>#298) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/305;>#305) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.13.0 to 2.16.0 (https://redirect.github.com/apache/maven-enforcer/pull/310;>#310) https://github.com/dependabot;>@dependabot Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/307;>#307) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/apache/maven-enforcer/pull/308;>#308) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-498;>[MENFORCER-498] - Update parent pom to 41 (https://redirect.github.com/apache/maven-enforcer/pull/306;>#306) https://github.com/slachiewicz;>@slachiewicz Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-enforcer/pull/303;>#303) https://github.com/dependabot;>@dependabot Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 (https://redirect.github.com/apache/maven-enforcer/pull/301;>#301) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 (https://redirect.github.com/apache/maven-enforcer/pull/295;>#295) https://github.com/dependabot;>@dependabot Bump org.junit:junit-bom from 5.10.0 to 5.10.1 (https://redirect.github.com/apache/maven-enforcer/pull/296;>#296) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-492;>[MENFORCER-492] - Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0 (https://redirect.github.com/apache/maven-enforcer/pull/291;>#291) https://github.com/slawekjaranowski;>@slawekjaranowski Bump org.xerial.snappy:snappy-java from 1.1.10.1 to 1.1.10.4 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/292;>#292) https://github.com/dependabot;>@dependabot Maintenance https://issues.apache.org/jira/browse/MENFORCER-490;>[MENFORCER-490] - Remove unused dependency (https://redirect.github.com/apache/maven-enforcer/pull/316;>#316) https://github.com/elharo;>@elharo Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r162130
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
I raised https://issues.apache.org/jira/browse/MNG-8134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Publish maven 4.0.0-beta-3 schemas [maven-site]
gnodet merged PR #535: URL: https://github.com/apache/maven-site/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
slawekjaranowski merged PR #398: URL: https://github.com/apache/maven-dependency-plugin/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140642939 > This works: > > ``` > $ git diff > diff --git a/surefire-its/src/test/resources/junit-4-5/pom.xml b/surefire-its/src/test/resources/junit-4-5/pom.xml > index 9a9d69c27..e55fd9b4e 100644 > --- a/surefire-its/src/test/resources/junit-4-5/pom.xml > +++ b/surefire-its/src/test/resources/junit-4-5/pom.xml > @@ -139,7 +139,7 @@ > > > org.junit.jupiter > -junit-jupiter-api > +junit-jupiter > 5.9.1 > test > > @@ -155,18 +155,6 @@ > > org.apache.maven.plugins > maven-surefire-plugin > - > - > -org.junit.jupiter > - junit-jupiter-engine > -5.9.1 > - > - > -org.junit.platform > - junit-platform-engine > -1.9.1 > - > - > > > > ``` > > I'll try that... Tried, while it works it gives a different classpath, thus different results. Profile `select-junit4` does not select 4. I will leave as-is now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140566960 This works: ``` $ git diff diff --git a/surefire-its/src/test/resources/junit-4-5/pom.xml b/surefire-its/src/test/resources/junit-4-5/pom.xml index 9a9d69c27..e55fd9b4e 100644 --- a/surefire-its/src/test/resources/junit-4-5/pom.xml +++ b/surefire-its/src/test/resources/junit-4-5/pom.xml @@ -139,7 +139,7 @@ org.junit.jupiter -junit-jupiter-api +junit-jupiter 5.9.1 test @@ -155,18 +155,6 @@ org.apache.maven.plugins maven-surefire-plugin - - -org.junit.jupiter - junit-jupiter-engine -5.9.1 - - -org.junit.platform - junit-platform-engine -1.9.1 - - ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737:
URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140503023
> > Outdated in terms of what?
>
> In lacking a line for `args.add(new Object[] {"1.10.2", "5.10.2", "1.3.0",
"1.1.2"});`
>
> > Tried to following:
>
> Going from `junit-jupiter-api` to
`junit-jupiter` does not help either?
Did, no change. fails with:
```
Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException:
There was an error in the forked process
org.junit.platform.engine.TestDescriptor.getAncestors()Ljava/util/Set;
java.lang.NoSuchMethodError:
org.junit.platform.engine.TestDescriptor.getAncestors()Ljava/util/Set;
at
org.junit.platform.launcher.core.StackTracePruningEngineExecutionListener.getTestClassNames(StackTracePruningEngineExecutionListener.java:50)
at
org.junit.platform.launcher.core.StackTracePruningEngineExecutionListener.executionFinished(StackTracePruningEngineExecutionListener.java:39)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1621196292
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##
@@ -367,6 +390,141 @@ public void generate() throws MojoExecutionException {
}
}
+private void generateIndex() throws GeneratorException {
+try {
+Set diBeans = new TreeSet<>();
+try (Stream paths =
Files.walk(classOutputDirectory.toPath())) {
+List classes = paths.filter(
+p ->
p.getFileName().toString().endsWith(".class"))
+.collect(Collectors.toList());
+for (Path classFile : classes) {
+String fileString = classFile.toString();
+String className = fileString
+.substring(0, fileString.length() -
".class".length())
+.replace('/', '.');
+try (InputStream is = Files.newInputStream(classFile)) {
+ClassReader rdr = new ClassReader(is);
+rdr.accept(
+new ClassVisitor(Opcodes.ASM9) {
+String className;
+
+@Override
+public void visit(
+int version,
+int access,
+String name,
+String signature,
+String superName,
+String[] interfaces) {
+super.visit(version, access, name,
signature, superName, interfaces);
+className = name;
+}
+
+@Override
+public AnnotationVisitor
visitAnnotation(String descriptor, boolean visible) {
+if
("Lorg/apache/maven/api/di/Named;".equals(descriptor)) {
+diBeans.add(className.replace('/',
'.'));
+}
+return null;
+}
+},
+ClassReader.SKIP_FRAMES |
ClassReader.SKIP_CODE | ClassReader.SKIP_DEBUG);
+}
+
+//Class clazz =
project.getClassRealm().loadClass(className);
+//boolean hasQualifier =
Stream.of(clazz.getAnnotations())
+//.flatMap(ann ->
Stream.of(ann.getClass().getAnnotations()))
+//.anyMatch(ann ->
"org.apache.maven.api.di.Qualifier"
+//
.equals(ann.annotationType().getName()));
+//if (hasQualifier) {
+//diBeans.add(className);
+//}
+}
+}
+Path path =
outputDirectory.toPath().resolve("org.apache.maven.api.di.Inject");
+if (diBeans.isEmpty()) {
+Files.deleteIfExists(path);
+} else {
+try (CachingWriter w = new CachingWriter(path,
StandardCharsets.UTF_8)) {
+String content =
diBeans.stream().collect(Collectors.joining("\n", "", "\n"));
Review Comment:
Fixed
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##
@@ -78,6 +90,12 @@ public class DescriptorGeneratorMojo extends
AbstractGeneratorMojo {
@Parameter(defaultValue =
"${project.build.outputDirectory}/META-INF/maven", readonly = true)
private File outputDirectory;
+/**
+ * The directory where the generated class files will be put.
+ */
+@Parameter(defaultValue = "${project.build.outputDirectory}", readonly =
true)
+private File classOutputDirectory;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140277555 > IIRC there's some mapping magic in Surefire code that tries to find the correct Platform version based on the Jupiter version used in tests. Perhaps, that magic is outdated too? 樂 That maybe true, but that is out of scope for this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
sormuras commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140177155 IIRC there's some mapping magic in Surefire code that tries to find the correct Platform version based on the Jupiter version used in tests. Perhaps, that magic is outdated too? 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
sormuras commented on PR #737:
URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140171588
> Outdated in terms of what?
In lacking a line for `args.add(new Object[] {"1.10.2", "5.10.2", "1.3.0",
"1.1.2"});`
> Tried to following:
Going from `junit-jupiter-api` to
`junit-jupiter` does not help either?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140161031 > According to https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven "it is recommended to use the JUnit Platform BOM to align the versions of all JUnit 5 artifacts." Perhaps the Surefire ITs should follow this advice. > > Reading on [it says](https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven-engines-configure): > > > To configure support for JUnit Jupiter based tests, configure test scoped dependencies on the JUnit Jupiter API and the JUnit Jupiter TestEngine implementation similar to the following. > > ``` > > org.junit.jupiter > junit-jupiter > 5.10.2 > test > > ``` Tried to following: ``` osipovmi@deblndw011x:~/var/Projekte/maven-surefire/surefire-its/src/test/resources/junit-4-5 (parent-42-maven-3.6.3 *=) $ git diff diff --git a/surefire-its/src/test/resources/junit-4-5/pom.xml b/surefire-its/src/test/resources/junit-4-5/pom.xml index 9a9d69c27..9dddede92 100644 --- a/surefire-its/src/test/resources/junit-4-5/pom.xml +++ b/surefire-its/src/test/resources/junit-4-5/pom.xml @@ -135,12 +135,26 @@ -select-junit5 + select-junit5 + + + + + +org.junit +junit-bom +5.9.1 +pom +import + + + + + org.junit.jupiter junit-jupiter-api -5.9.1 test @@ -161,11 +175,6 @@ junit-jupiter-engine 5.9.1 - -org.junit.platform - junit-platform-engine -1.9.1 - ``` and I am back to ``` [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.2.6-SNAPSHOT:test (default-test) on project junit-4-5: [ERROR] [ERROR] Please refer to /var/osipovmi/Projekte/maven-surefire/surefire-its/src/test/resources/junit-4-5/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] There was an error in the forked process [ERROR] org.junit.platform.commons.util.ExceptionUtils.findNestedThrowables(Ljava/lang/Throwable;)Ljava/util/List; [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process [ERROR] org.junit.platform.commons.util.ExceptionUtils.findNestedThrowables(Ljava/lang/Throwable;)Ljava/util/List; [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:628) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1224) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1073) ``` because of the plugin classpath: ``` [DEBUG] Populating class realm plugin>org.apache.maven.plugins:maven-surefire-plugin:3.2.6-SNAPSHOT [DEBUG] Included: org.apache.maven.plugins:maven-surefire-plugin:jar:3.2.6-SNAPSHOT [DEBUG] Included: org.junit.jupiter:junit-jupiter-engine:jar:5.9.1 [DEBUG] Included: org.junit.platform:junit-platform-engine:jar:1.10.2 [DEBUG] Included: org.opentest4j:opentest4j:jar:1.3.0 [DEBUG] Included: org.junit.platform:junit-platform-commons:jar:1.10.2 [DEBUG] Included: org.junit.jupiter:junit-jupiter-api:jar:5.10.2 [DEBUG] Included: org.apiguardian:apiguardian-api:jar:1.1.2 [DEBUG] Included: org.apache.maven.surefire:maven-surefire-common:jar:3.2.6-SNAPSHOT [DEBUG] Included: org.apache.maven.surefire:surefire-api:jar:3.2.6-SNAPSHOT [DEBUG] Included: org.apache.maven.surefire:surefire-logger-api:jar:3.2.6-SNAPSHOT [DEBUG] Included: org.apache.maven.surefire:surefire-extensions-api:jar:3.2.6-SNAPSHOT [DEBUG] Included: org.apache.maven.surefire:surefire-booter:jar:3.2.6-SNAPSHOT [DEBUG] Included:
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140151794 > Just found another outdated IT: > > https://github.com/apache/maven-surefire/blob/19b16d9b457fca387ef24fdb27a52eeb8970f711/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java#L82 Outdated in terms of what? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
sormuras commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140123639 Just found another outdated IT: https://github.com/apache/maven-surefire/blob/19b16d9b457fca387ef24fdb27a52eeb8970f711/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java#L82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
sormuras commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140097468 According to https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven "it is recommended to use the JUnit Platform BOM to align the versions of all JUnit 5 artifacts." Perhaps the Surefire ITs should follow this advice. Reading on [it says](https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven-engines-configure): > To configure support for JUnit Jupiter based tests, configure test scoped dependencies on the JUnit Jupiter API and the JUnit Jupiter TestEngine implementation similar to the following. ```xml org.junit.jupiter junit-jupiter 5.10.2 test ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140086579 > This IT should include a 5.10.2/1.8.5 row for JUnit 5.10.2 and JQwik 1.8.5: > > https://github.com/apache/maven-surefire/blob/19b16d9b457fca387ef24fdb27a52eeb8970f711/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformIT.java#L58 > > And soon one for JUnit 5.11.0 (could already inserted as `5.11.0-M2`) too. Will do. > > Maven Parent 42 updated to latest JUnit 1.10.x/5.10.x the use case started to fail because of [junit-team/junit5@b41ae69](https://github.com/junit-team/junit5/commit/b41ae69659e8dc3fa230f97d8a751d81e69d06d7). Mixed dependencies, ABI incompat. > > I don't see the "Mixed dependencies, ABI incompat." in the linked commit. Can you please expound? When you run the ITs manually from the dir to analyze the failure you see this classpath: ``` common-java5-3.2.6-SNAPSHOT.jar junit-jupiter-engine-5.9.3.jar junit-platform-engine-1.10.2.jar junit-platform-launcher-1.10.2.jar junit-platform-suite-1.9.3.jar junit-platform-suite-commons-1.9.3.jar junit-platform-suite-engine-1.9.3.jar maven-surefire-common-3.2.6-SNAPSHOT.jar surefire-api-3.2.6-SNAPSHOT.jar surefire-booter-3.2.6-SNAPSHOT.jar surefire-extensions-api-3.2.6-SNAPSHOT.jar surefire-extensions-spi-3.2.6-SNAPSHOT.jar surefire-junit-platform-3.2.6-SNAPSHOT.jar surefire-logger-api-3.2.6-SNAPSHOT.jar surefire-shared-utils-3.2.6-SNAPSHOT.jar ``` The mix of 1.10.2 and 1.9.3/5.9.3 don't play nice together, if you want I can procude the error for you. I had this signature missing due to the broken CP: `org.junit.platform.commons.util.ExceptionUtils.findNestedThrowables(Ljava/lang/Throwable;)Ljava/util/List;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1406] Upgrade to Parent 42 and Maven 3.6.3 [maven-shared-jar]
michael-o closed pull request #39: [MSHARED-1406] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-shared-jar/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
sormuras commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2140059001 This IT should include a 5.10.2/1.10.2 for JUnit 5.10.2: https://github.com/apache/maven-surefire/blob/19b16d9b457fca387ef24fdb27a52eeb8970f711/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformIT.java#L58 And soon one for 5.11.0 (could already inserted as `5.11.0-M2`). > Maven Parent 42 updated to latest JUnit 1.10.x/5.10.x the use case started to fail because of https://github.com/junit-team/junit5/commit/b41ae69659e8dc3fa230f97d8a751d81e69d06d7. Mixed dependencies, ABI incompat. I don't see the "Mixed dependencies, ABI incompat." in the linked commit. Can you please expound? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
Maven 4 mojos have to be thread safe, so that annotation is gone.
In maven 3, the `requiresDependencyResolution` and
`requiresDependencyCollection` are currently used to collect or resolve the
project dependencies in a given scope. Those artifacts are then made available
by Maven by `MavenProject.getArtifacts()`. This brings several problems: for a
single project, two mojos can not be run concurrently, and as we've seen, some
mojos even require runtime + test scope resolution, and that cannot be
provided. In 4.x, mojos will have to use the API to retrieve collect/resolve
the dependencies. Hopefully the result can be cached in the session. So the
latest 4.x release did remove those two bits. However, not having this
information sounds wrong, as this would be needed in at least two scenarii:
* it would be nice to be able to eagerly download dependencies at the
beginning of a given build, and we'd need to know which scopes are needed for a
given project, this could be done by analysing the build plan
* if we experiment a bit more with the [fully concurrent
builder](https://github.com/apache/maven/pull/1429), we need this information
in order to know which goals depend on which projects in the reactor, so that
the goals can be scheduled correctly
So I think we'll need to add those back somehow, but they would be
informational. Another possibility would be to allow injecting the
resolution/collection result in the mojo, this may require a new specific
annotation, but that may be the best solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
Maven 4 mojos have to be thread safe, so that annotation is gone.
In maven 3, the `requiresDependencyResolution` and
`requiresDependencyCollection` are currently used to collect or resolve the
project dependencies in a given scope. Those artifacts are then made available
by Maven by `MavenProject.getArtifacts()`. This brings several problems: for a
single project, two mojos can not be run concurrently, and as we've seen, some
mojos even require runtime + test scope resolution, and that cannot be
provided. In 4.x, mojos will have to use the API to retrieve collect/resolve
the dependencies. Hopefully the result can be cached in the session. So the
latest 4.x release did remove those two bits. However, not having this
information sounds wrong, as this would be needed in at least two scenarii:
* it would be nice to be able to eagerly download dependencies at the
beginning of a given build, and we'd need to know which scopes are needed for a
given project, this could be done by analysing the build plan
* if we experiment a bit more with the [fully concurrent
builder](https://github.com/apache/maven/pull/1429), we need this information
in order to know which goals depend on which projects in the reactor, so that
the goals can be scheduled correctly
So I think we'll need to add those back somehow, but they would be
informational. Another possibility would be to allow injecting the
resolution/collection result in the mojo, this may require a new specific
annotation, but that may be the best solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on PR #737: URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2139799953 @sormuras and @juliette-derancourt: Can you have a look at my changes in: * surefire-its/src/test/resources/junit-4-5/pom.xml * surefire-its/src/test/resources/junit5-suite/pom.xml Maven Parent 42 updated to latest JUnit 1.10.x/5.10.x the use case started to fail because of https://github.com/junit-team/junit5/commit/b41ae69659e8dc3fa230f97d8a751d81e69d06d7. Mixed dependencies, ABI incompat. My questions to you both: * Is that correct to do so in that case? * We have documented in `./maven-surefire-plugin/src/site/apt/examples/jpms.apt.vm`, `./maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm`, `./maven-surefire-plugin/src/site/apt/usage.apt.vm` that only two deps need to be supplied, in contrast to that what I have in those ITs. Should we modify docs and require `junit-platform-engine` to be set as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
gnodet commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
Maven 4 mojos have to be thread safe.
In maven 3, the `requiresDependencyResolution` and
`requiresDependencyCollection` are currently used to collect or resolve the
project dependencies in a given scope. Those artifacts are then made available
by Maven by `MavenProject.getArtifacts()`. This brings several problems: for a
single project, two mojos can not be run concurrently, and as we've seen, some
mojos even require runtime + test scope resolution, and that cannot be
provided. In 4.x, mojos will have to use the API to retrieve collect/resolve
the dependencies. Hopefully the result can be cached in the session. So the
latest 4.x release did remove those two bits. However, not having this
information sounds wrong, as this would be needed in at least two scenarii:
* it would be nice to be able to eagerly download dependencies at the
beginning of a given build, and we'd need to know which scopes are needed for a
given project, this could be done by analysing the build plan
* if we experiment a bit more with the [fully concurrent
builder](https://github.com/apache/maven/pull/1429), we need this information
in order to know which goals depend on which projects in the reactor, so that
the goals can be scheduled correctly
So I think we'll need to add those back somehow, but they would be
informational. Another possibility would be to allow injecting the
resolution/collection result in the mojo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on code in PR #737:
URL: https://github.com/apache/maven-surefire/pull/737#discussion_r1620863362
##
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java:
##
@@ -106,39 +94,17 @@ public void shouldFallthroughToBuildContextWhenNoSpecSet()
throws Exception {
assertThat(actual).isSameAs(expectedFromContext);
}
-@Test
-public void shouldReturnNoToolchainInMaven32() throws Exception {
-Toolchain toolchain = invokeMethod(
-AbstractSurefireMojo.class,
-"getToolchainMaven33x",
-MockToolchainManagerMaven32.class,
-new MockToolchainManagerMaven32(null),
-mock(MavenSession.class),
-emptyMap());
-assertNull(toolchain);
-}
-
@Test(expected = MojoFailureException.class)
-public void shouldThrowMaven33xToolchain() throws Exception {
-invokeMethod(
-AbstractSurefireMojo.class,
-"getToolchainMaven33x",
-MockToolchainManager.class,
-new MockToolchainManager(null, null),
-mock(MavenSession.class),
-emptyMap());
+@Ignore
+public void shouldThrowToolchain() throws Exception {
+invokeMethod(AbstractSurefireMojo.class, "getToolchain");
}
@Test
-public void shouldGetMaven33xToolchain() throws Exception {
+@Ignore
+public void shouldGetToolchain() throws Exception {
Toolchain expected = mock(Toolchain.class);
-Toolchain actual = invokeMethod(
-AbstractSurefireMojo.class,
-"getToolchainMaven33x",
-MockToolchainManager.class,
-new MockToolchainManager(expected, null),
-mock(MavenSession.class),
-emptyMap());
+Toolchain actual = invokeMethod(AbstractSurefireMojo.class,
"getToolchain");
Review Comment:
I have disabled a few tests because they do not work, but I believe that
they are redundant now because we don't use any reflection. I am inclined to
delete all disabled ones. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2245] Upgrade to Parent 42 and Maven 3.6.3 [maven-surefire]
michael-o commented on code in PR #737:
URL: https://github.com/apache/maven-surefire/pull/737#discussion_r1620861999
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -935,31 +932,17 @@ protected final PluginConsoleLogger getConsoleLogger() {
return consoleLogger;
}
-private static Toolchain getToolchainMaven33x(
-Class toolchainManagerType, T toolchainManager, MavenSession
session, Map toolchainArgs)
-throws MojoFailureException {
-Method getToolchainsMethod =
-tryGetMethod(toolchainManagerType, "getToolchains",
MavenSession.class, String.class, Map.class);
-if (getToolchainsMethod != null) {
-//noinspection unchecked
-List tcs =
-invokeMethodWithArray(toolchainManager,
getToolchainsMethod, session, "jdk", toolchainArgs);
-if (tcs.isEmpty()) {
-throw new MojoFailureException(
-"Requested toolchain specification did not match any
configured toolchain: " + toolchainArgs);
-}
-return tcs.get(0);
-}
-return null;
-}
-
-// TODO remove the part with ToolchainManager lookup once we depend on
-// 3.0.9 (have it as prerequisite). Define as regular component field then.
private Toolchain getToolchain() throws MojoFailureException {
Toolchain tc = null;
if (getJdkToolchain() != null) {
-tc = getToolchainMaven33x(ToolchainManager.class,
getToolchainManager(), getSession(), getJdkToolchain());
+List tcs =
getToolchainManager().getToolchains(getSession(), "jdk", getJdkToolchain());
+if (tcs.isEmpty()) {
+throw new MojoFailureException(
+"Requested toolchain specification did not match any
configured toolchain: "
++ getJdkToolchain());
+}
+tc = tcs.get(0);
Review Comment:
Guys, please check wether this is correct logically...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPIR-457] Upgrade to Parent 42 and Maven 3.6.3 [maven-project-info-reports-plugin]
michael-o commented on code in PR #66: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/66#discussion_r1620854300 ## pom.xml: ## @@ -184,7 +177,7 @@ under the License. org.apache.maven.shared maven-dependency-tree - 3.2.1 + 3.3.0 Review Comment: Done: https://issues.apache.org/jira/browse/MPIR-458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-beta-3 [maven-plugin-tools]
michael-o commented on code in PR #286:
URL:
https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620834033
##
maven-plugin-plugin/src/it/v4api/src/main/java/org/apache/maven/its/v4api/FirstMojo.java:
##
@@ -38,15 +37,12 @@
* Test mojo for the v4 api plugin descriptor generation.
* This mojo is not actually runnable because:
* - it's using a custom lifecycle which is not defined
- * - it has a @Component dependency on ArtifactInstaller (hint=test) which
does not exist
+ * - it has a @Inject dependency on ArtifactInstaller (hint=test) which does
not exist
*
* @since 1.2
*/
-@Mojo(
-name = "first",
-requiresDependencyResolution = ResolutionScope.TEST,
-defaultPhase = LifecyclePhase.INTEGRATION_TEST)
-@Execute(phase = LifecyclePhase.GENERATE_SOURCES, lifecycle = "cobertura")
+@Mojo(name = "first", defaultPhase = "integration-test")
+@Execute(phase = "generate-sources", lifecycle = "cobertura")
public class FirstMojo implements org.apache.maven.api.plugin.Mojo {
Review Comment:
Is there a reason why other args to `@Mojo` are gone?
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##
@@ -367,6 +390,141 @@ public void generate() throws MojoExecutionException {
}
}
+private void generateIndex() throws GeneratorException {
+try {
+Set diBeans = new TreeSet<>();
+try (Stream paths =
Files.walk(classOutputDirectory.toPath())) {
+List classes = paths.filter(
+p ->
p.getFileName().toString().endsWith(".class"))
+.collect(Collectors.toList());
+for (Path classFile : classes) {
+String fileString = classFile.toString();
+String className = fileString
+.substring(0, fileString.length() -
".class".length())
+.replace('/', '.');
+try (InputStream is = Files.newInputStream(classFile)) {
+ClassReader rdr = new ClassReader(is);
+rdr.accept(
+new ClassVisitor(Opcodes.ASM9) {
+String className;
+
+@Override
+public void visit(
+int version,
+int access,
+String name,
+String signature,
+String superName,
+String[] interfaces) {
+super.visit(version, access, name,
signature, superName, interfaces);
+className = name;
+}
+
+@Override
+public AnnotationVisitor
visitAnnotation(String descriptor, boolean visible) {
+if
("Lorg/apache/maven/api/di/Named;".equals(descriptor)) {
+diBeans.add(className.replace('/',
'.'));
+}
+return null;
+}
+},
+ClassReader.SKIP_FRAMES |
ClassReader.SKIP_CODE | ClassReader.SKIP_DEBUG);
+}
+
+//Class clazz =
project.getClassRealm().loadClass(className);
+//boolean hasQualifier =
Stream.of(clazz.getAnnotations())
+//.flatMap(ann ->
Stream.of(ann.getClass().getAnnotations()))
+//.anyMatch(ann ->
"org.apache.maven.api.di.Qualifier"
+//
.equals(ann.annotationType().getName()));
+//if (hasQualifier) {
+//diBeans.add(className);
+//}
+}
+}
+Path path =
outputDirectory.toPath().resolve("org.apache.maven.api.di.Inject");
+if (diBeans.isEmpty()) {
+Files.deleteIfExists(path);
+} else {
+try (CachingWriter w = new CachingWriter(path,
StandardCharsets.UTF_8)) {
+String content =
diBeans.stream().collect(Collectors.joining("\n", "", "\n"));
Review Comment:
`System.lineSeparator()`?
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##
@@ -78,6 +90,12 @@ public class
[PR] Fix grammar in validation message [maven]
Bananeweizen opened a new pull request, #1544: URL: https://github.com/apache/maven/pull/1544 Fix grammar and whitespace in validation message. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.16 [maven-plugin-tools]
dependabot[bot] commented on PR #293: URL: https://github.com/apache/maven-plugin-tools/pull/293#issuecomment-2139605104 Superseded by #294. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.16 [maven-plugin-tools]
dependabot[bot] closed pull request #293: Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.16 URL: https://github.com/apache/maven-plugin-tools/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.17 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #294: URL: https://github.com/apache/maven-plugin-tools/pull/294 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.11.13 to 1.14.17. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.14.17 Avoid crashing of Android plugin when there are duplicate files for licenses or license notices. Byte Buddy 1.14.16 Update ASM and introduce support for Java 23. Byte Buddy 1.14.15 Allow attaching from root on J9. Byte Buddy 1.14.14 Adjust type validation to accept additional names that are legal in the class file format. Fix dynamic attach on Windows when a service user is active. Avoid failure when using Android's strict mode. Byte Buddy 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. Byte Buddy 1.14.12 Pin proxy class file version to avoid implicit changes when using Graal native image. Add support for Java 23. Add missing @MaybeNull annotation. Byte Buddy 1.14.11 Adjusts Gradle plugin to support Gradle 8.4 without warnings. Avoid blurry exception on build plugin for fail fast. byte-buddy-1.14.10 Add lazy facade to default TypePool in AgentBuilder to avoid parsing of types ignored by name. Avoid module info classes in Android plugin. Byte Buddy 1.14.9 Update ASM to version 9.6 Support Android plugin to support APG version 7.4 Byte Buddy 1.14.8 Correctly read versions from class file that would use both bytes. Fix Byte Buddy Gradle plugin for Gradle 8.3+. Correct field and static method access on subtypes in MemberSubstitution. Support APK 7.4+ versions in Byte Buddy Gradle for Android plugin. Byte Buddy 1.14.7 Correctly read minor version from class file. Catch type resolution errors when applying Plugin.Engine. Byte Buddy 1.14.6 Add PatchMode.SUBSTITUTE and ResettableClassFileTransformer.Substitutable for in-order patching. Allow for explicit specification og differential matcher when patching an AgentBuilder. Add platform loader to locator for build plugins. ... (truncated) Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>net.bytebuddy:byte-buddy's changelog. 29. May 2024: version 1.14.17 Avoid crashing of Android plugin when there are duplicate files for licenses or license notices. 22. May 2024: version 1.14.16 Update ASM and introduce support for Java 23. 8. May 2024: version 1.14.15 Allow attaching from root on J9. 23. April 2024: version 1.14.14 Adjust type validation to accept additional names that are legal in the class file format. Fix dynamic attach on Windows when a service user is active. Avoid failure when using Android's strict mode. 28. March 2024: version 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. 16. February 2024: version 1.14.12 Pin proxy class file version to avoid implicit changes when using Graal native image. Add support for Java 23. Add missing @MaybeNull annotation. 21. December 2023: version 1.14.11 Adjusts Gradle plugin to support Gradle 8.4 without warnings. Avoid blurry exception on build plugin for fail fast. 16. October 2023: version 1.14.10 Add lazy facade to default TypePool in AgentBuilder to avoid parsing of types ignored by name. Avoid module info classes in Android plugin. 9. October 2023: version 1.14.9 Update ASM to version 9.6 Support Android plugin to support APG version 7.4 15. September 2023: version 1.14.8 Correctly read versions from class file that would use both bytes. Fix Byte Buddy Gradle plugin for Gradle 8.3+. Correct field and static method access on subtypes in MemberSubstitution. ... (truncated) Commits https://github.com/raphw/byte-buddy/commit/bfd4c21cbc6f2cab1a0de8700125099fd96b857c;>bfd4c21 [maven-release-plugin] prepare release byte-buddy-1.14.17 https://github.com/raphw/byte-buddy/commit/d179f5f172f2a4c5ea3fd2bb2a2565012de0ab2f;>d179f5f [release] Release new version https://github.com/raphw/byte-buddy/commit/dd1f6d33ad4f112104207100f8728c47ca4e6218;>dd1f6d3 Update checksums https://github.com/raphw/byte-buddy/commit/32a500ef2d960f43d2f5950d0402d58043984083;>32a500e Ignoring duplicate non-class files (https://redirect.github.com/raphw/byte-buddy/issues/1654;>#1654)
Re: [PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
slawekjaranowski commented on code in PR #398:
URL:
https://github.com/apache/maven-dependency-plugin/pull/398#discussion_r1620690851
##
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##
@@ -86,30 +84,6 @@ public class TreeMojo extends AbstractMojo {
@Parameter(property = "outputEncoding", defaultValue =
"${project.reporting.outputEncoding}")
private String outputEncoding;
-/**
- * Contains the full list of projects in the reactor.
- */
-@Parameter(defaultValue = "${reactorProjects}", readonly = true, required
= true)
Review Comment:
no problem ... like unused variables are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Publish maven 4.0.0-beta-3 schemas [maven-site]
gnodet opened a new pull request, #535: URL: https://github.com/apache/maven-site/pull/535 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.4.1 to 3.5.0 [maven-pdf-plugin]
dependabot[bot] opened a new pull request, #54: URL: https://github.com/apache/maven-pdf-plugin/pull/54 Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.4.1 to 3.5.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases;>org.apache.maven.plugins:maven-enforcer-plugin's releases. 3.5.0 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-497;>[MENFORCER-497] - Require Maven 3.6.3+ (https://redirect.github.com/apache/maven-enforcer/pull/317;>#317) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-494;>[MENFORCER-494] - Allow banning dynamic versions in whole tree (https://redirect.github.com/apache/maven-enforcer/pull/294;>#294) https://github.com/JimmyAx;>@JimmyAx https://issues.apache.org/jira/browse/MENFORCER-500;>[MENFORCER-500] - New rule to enforce that Maven coordinates match given (https://redirect.github.com/apache/maven-enforcer/pull/309;>#309) https://github.com/kwin;>@kwin Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-503;>[MENFORCER-503] - Pass context to ProfileActivator - fix NPE in Maven 3.9.7 (https://redirect.github.com/apache/maven-enforcer/pull/315;>#315) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.16.0 to 2.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/311;>#311) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (https://redirect.github.com/apache/maven-enforcer/pull/312;>#312) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-504;>[MENFORCER-504] - Bump org.apache.maven:maven-parent from 41 to 42 (https://redirect.github.com/apache/maven-enforcer/pull/314;>#314) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (https://redirect.github.com/apache/maven-enforcer/pull/298;>#298) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/305;>#305) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.13.0 to 2.16.0 (https://redirect.github.com/apache/maven-enforcer/pull/310;>#310) https://github.com/dependabot;>@dependabot Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/307;>#307) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/apache/maven-enforcer/pull/308;>#308) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-498;>[MENFORCER-498] - Update parent pom to 41 (https://redirect.github.com/apache/maven-enforcer/pull/306;>#306) https://github.com/slachiewicz;>@slachiewicz Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-enforcer/pull/303;>#303) https://github.com/dependabot;>@dependabot Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 (https://redirect.github.com/apache/maven-enforcer/pull/301;>#301) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 (https://redirect.github.com/apache/maven-enforcer/pull/295;>#295) https://github.com/dependabot;>@dependabot Bump org.junit:junit-bom from 5.10.0 to 5.10.1 (https://redirect.github.com/apache/maven-enforcer/pull/296;>#296) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-492;>[MENFORCER-492] - Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0 (https://redirect.github.com/apache/maven-enforcer/pull/291;>#291) https://github.com/slawekjaranowski;>@slawekjaranowski Bump org.xerial.snappy:snappy-java from 1.1.10.1 to 1.1.10.4 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/292;>#292) https://github.com/dependabot;>@dependabot Maintenance https://issues.apache.org/jira/browse/MENFORCER-490;>[MENFORCER-490] - Remove unused dependency (https://redirect.github.com/apache/maven-enforcer/pull/316;>#316) https://github.com/elharo;>@elharo Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in
Re: [PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
elharo commented on code in PR #398:
URL:
https://github.com/apache/maven-dependency-plugin/pull/398#discussion_r1620629551
##
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##
@@ -86,30 +84,6 @@ public class TreeMojo extends AbstractMojo {
@Parameter(property = "outputEncoding", defaultValue =
"${project.reporting.outputEncoding}")
private String outputEncoding;
-/**
- * Contains the full list of projects in the reactor.
- */
-@Parameter(defaultValue = "${reactorProjects}", readonly = true, required
= true)
Review Comment:
does this cause problems for existing projects that set these?
##
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##
@@ -133,7 +107,8 @@ public class TreeMojo extends AbstractMojo {
/**
* If specified, this parameter will cause the dependency tree to be
written using the specified format. Currently
- * supported format are: text (default), dot,
graphml and tgf.
+ * supported format are: text (default), dot,
graphml, tgf
Review Comment:
format --> formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
slawekjaranowski opened a new pull request, #398: URL: https://github.com/apache/maven-dependency-plugin/pull/398 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-dependency-tree]
dependabot[bot] commented on PR #46: URL: https://github.com/apache/maven-dependency-tree/pull/46#issuecomment-2139052011 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mavenVersion from 3.6.3 to 3.9.7 [maven-dependency-tree]
dependabot[bot] commented on PR #47: URL: https://github.com/apache/maven-dependency-tree/pull/47#issuecomment-2139053029 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mavenVersion from 3.6.3 to 3.9.7 [maven-dependency-tree]
dependabot[bot] closed pull request #47: Bump mavenVersion from 3.6.3 to 3.9.7 URL: https://github.com/apache/maven-dependency-tree/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mavenVersion from 3.6.3 to 3.9.7 [maven-dependency-tree]
slawekjaranowski commented on PR #47: URL: https://github.com/apache/maven-dependency-tree/pull/47#issuecomment-2139052874 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-dependency-tree]
dependabot[bot] closed pull request #46: Bump resolverVersion from 1.4.1 to 1.9.20 URL: https://github.com/apache/maven-dependency-tree/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
