[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230603#comment-17230603 ] Delany commented on MDEPLOY-131: [~rfscholte] If you think this is a code smell wait till you see the shell scripts I've had to deal with because my predecessors felt they couldn't get Maven to do what they needed. What's that, six votes now? https://issues.apache.org/jira/browse/MDEPLOY-277 > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo >Priority: Major > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670349#comment-16670349 ] T Vorschuetz commented on MDEPLOY-131: -- I completely agree with Richard. Where is the problem to implement the few lines of code to increase the usability of this plugin a lot? Why is the ticket not processed for years, even if meaning is clearly defined and the code is already there? > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo >Priority: Major > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935655#comment-15935655 ] Richard Sand commented on MDEPLOY-131: -- By that logic Robert, you should remove the "pomFile" parameter from the deploy-file goal. It only leads to abuse. Just like you should remove the automatic update from the javadoc plugin, or require it to be explicitly invoked like deploy-file, because adding a skip smells so bad too. Maven *is* a complex tool. If you want to constrain how people use it and not only adopt your tool but adopt your philosophies, then dumb it down. But maven isn't that - its a powerful can-do-almost-anything tool. If I want simplicity and a single formulaic method, there are certainly simpler and more straightforward tools out there. But you seem to want to dictate process as well, and keep all of your users in line. I guess you know our businesses best? > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[
https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935248#comment-15935248
]
Robert Scholte commented on MDEPLOY-131:
{{deploy-file}} is designed for uploading artifacts of which you only got the
files. By uploading these files you can make them available as dependencies.
These jars come from a third party and you want to deploy them to your
repository, so providing a URL makes sense.
If you have the sources and these are packaged to an artifact, then there's a
clear build lifecycle. In this case you should make use of the {{deploy}} goal.
Your situation matches the latter, so there should be +no+ need to use
{{deploy-file}}.
Abusing {{deploy-file}} is code-smell to me. Allowing such hacks tend to lead
to the old ant-buildmaster, where only one or a few understand what's happening
by the build tool. Maven says: a pom/GAV can only have main artifact. If you
have multiple main artifacts, you should have more pom.xml files. That's
something everybody will understand.
If one pom.xml generates multiple main artifacts with different GA's a lot of
people will be confused.
I'm willing to think of a solution, but not by letting the {{deploy-file}} goal
use the default repository.
So no matter the number of lines, the patch or the number people who are
interested, the code-smell is really bad so there must be a better solution.
> use default repository when no url specified
>
>
> Key: MDEPLOY-131
> URL: https://issues.apache.org/jira/browse/MDEPLOY-131
> Project: Maven Deploy Plugin
> Issue Type: Improvement
> Components: deploy:deploy-file
>Reporter: raymond domingo
> Labels: contributers-welcome
> Attachments: DeployFileMojo.java,
> maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff
>
>
> When using the deploy goal there is no need to specify the url of the
> repository.
> When using deploy-file you DO need to specify the url. This is a problem,
> because during development I like to deploy to snapshot repository and when
> releasing i deploy to release repository and I can't add this logic to the
> pom.
> Thas is why I like the url paramter to become optional (backwards compatible)
> and add default behaviour when it is null. It should just like the deploy
> plugin use the default repository. Snapshot for snapshots and release for
> none snapshot versions.
> I added a patch file fixing this.
> I also added complete source of patched Mojo
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934013#comment-15934013 ] Richard Sand commented on MDEPLOY-131: -- Hi Robert - i admit my frustration is showing. But my question is still unanswered - forget my use case for a moment. Forget I mentioned anything about deploying multiple shaded artifacts. Just tell me your opinion on the following: 1) the deploy module does not have the ability to inherit the URL from the project - this is a useful feature to have and is doable with a dozen lines of code and an option to enable it 2) the patch is here already 3) including me, there are 5 people who have asked for this feature on this ticket Why would you *not* accept it? > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933389#comment-15933389 ] Robert Scholte commented on MDEPLOY-131: Hi Richard, I think we need to cool down things. When reading your story for the first time I had the same idea as Karl Heinz. I consider suggesting a solution which matches the current Maven behavior as a great help. Reading your situation over again, I see your situation: 1 sourceproject results in multiple artifacts (jar + pom), meaning different artifactIds. I think the situation is too rare to apply the patch. A custom plugin makes more sense. Maybe there's good news: [~stephenconnolly] is working on a proposal for the next major version of Maven. And one of the suggestions is to have a pom for every uploaded artifact. Mapping this to your situation you *could* attach every artifact with the same artifactId, but with a separate classifier. Another option I'm thinking of right is to have multiple pom-files if the root of your project. Maybe even with an aggregator pom.xml (aggregator with modules pointing to every pom below) pom-default.xml pom-jcl.xml pom-jul.xml this way there's no need for multiple separate calls, no need for separate commandline arguments. > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931934#comment-15931934 ] Richard Sand commented on MDEPLOY-131: -- Hi Karl - my customers are using COTS products and often don't even have in-house Java developers. They don't know or care what slf4j is. If you want to tell them to read the slf4j docs feel free to :-). But to answer your question, yes I am using 3 different executions of shade, install-file, and deploy-file in my POM to build the different variations of the main artifact. I am truly baffled by the maven project's philosophy that it is not acceptable for organizations to use maven tools as those orgs see fit. I've hit this barrier before in the maven community with something as trivial as adding a "skip" parameter to one of the few plugin goals that actually didn't have one. Instead of looking at the feature at face value and deciding if it is useful, instead the response is "well why do you need that? stop doing things the way you are and instead do them as we prescribe". I avoid multi-module projects whenever I can. My company has used maven exclusively for its projects since 2010. I invite you to take over writing and maintaining all of our POMs, documenting them, educating our developers, etc. Would you do that for me? :-) Otherwise, can you tell me why you would reject this patch on its face value, rather than making me justify why I'd dare ask about it and submit such a patch? I've never opened an issue on Jira simply asking for some feature - every ticket I've opened over the years has been accompanied by a patch. I don't expect others to just do work for me - I contribute where I can. I follow every e-mail on the maven-dev and users list. I know the hell that the project has gone through with 3.4/3.5 and some of the soul-searching that has gone on within the maven team. I love this tool, but I think the maven team killing itself by trying to dictate to users the one-and-only way it should be used, and rejecting updates by telling users they can re-tool how they do things rather than accept a 10-line patch. I've contributed to other open source projects in the past, including Apache projects, and never had such negativity towards submissions. I truly do not understand it. Maybe the "silence" on the Jira isn't a good thing? I now maintain 4 different plugins in my company's repo for trivial patches that make our company's maven implementation stronger, but I've given up getting dragged into philosophical arguments and having to justify how we've done things. Sorry for the rant. -Richard > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[
https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931920#comment-15931920
]
Karl Heinz Marbaise commented on MDEPLOY-131:
-
Have you bound deploy plugin in your pom with the {{deploy-file}} goal several
times which means you can call simply {{mvn clean deploy}} and that's it?
If so you are violating the separation of concerns of a pom file cause a single
pom file should have only one concern which means produce a single artifact
(identified by groupId, artifactId, version) or maybe several but having the
same dependencies...If you need to have different dependencies this means you
should have different pom files.
Sorry to say if your customers are not familiar with slf4j than they should
read the manual...but I can understand that you like to offer them a convenient
solution which can simply being done by using different pom's with a single
concern which in result produces a multi module build.
Based on others requests..This issue is open for a long time and last comment
is of 2014..more than two years silence so it couldn't be real big
problem..apart from that there clean solutions for this which I already
described...
> use default repository when no url specified
>
>
> Key: MDEPLOY-131
> URL: https://issues.apache.org/jira/browse/MDEPLOY-131
> Project: Maven Deploy Plugin
> Issue Type: Improvement
> Components: deploy:deploy-file
>Reporter: raymond domingo
> Labels: contributers-welcome
> Attachments: DeployFileMojo.java,
> maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff
>
>
> When using the deploy goal there is no need to specify the url of the
> repository.
> When using deploy-file you DO need to specify the url. This is a problem,
> because during development I like to deploy to snapshot repository and when
> releasing i deploy to release repository and I can't add this logic to the
> pom.
> Thas is why I like the url paramter to become optional (backwards compatible)
> and add default behaviour when it is null. It should just like the deploy
> plugin use the default repository. Snapshot for snapshots and release for
> none snapshot versions.
> I added a patch file fixing this.
> I also added complete source of patched Mojo
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931911#comment-15931911 ] Richard Sand commented on MDEPLOY-131: -- Hi Karl - I could make a multi-module project, but why when there is a very simple capability that can let me avoid that and have 1 POM build everything I need? If you take a look at the patch its hardly anything at all and adds a capability that is useful and that others have requested. Regarding the slf4j - there are situations where my customers want a single jar that can be dropped into their application without a single other dependency, which is really the use case for shaded jars in the first place. And they are not familiar with slf4j, so I provide a shaded jar that has slf4j and for example slf4j-jcl or slf4j-jul, so that they can continue to run with whatever log framework they're already using without needing any other jar than the single that our product provides. > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931904#comment-15931904 ] Karl Heinz Marbaise commented on MDEPLOY-131: - It was just an example having different artifacts attached to the same build without deploy-file...If you really need having shaded using different dependencies you need simply make different modules of them. Apart from that using slf4j means you only define a dependency to slf4j-api and the user of that lib/jar decides what is really being used in the end. So maybe I misunderstand a thing but it sounds like the other created jars could be omitted and are not really needed... > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931902#comment-15931902 ] Richard Sand commented on MDEPLOY-131: -- In other words, I'm not replacing the default artifact or default pom, but using shade to create alternative variants with different dependencies and using deploy-file to deploy them all > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931898#comment-15931898 ] Richard Sand commented on MDEPLOY-131: -- Hi Karl - thanks for the quick reply, but the example you posted doesn't address the use case I've described. I'm not building different dev-vs-prod artifacts. I need *all* of the artifacts to be in our repo, the original jar and the shaded uber-jars, and they cannot be under the same artifact ID otherwise they have the same POM and same dependencies. Each shaded artifact produced needs to be deployed along with it's unique dependency-reduced-pom. > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, > maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[
https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931894#comment-15931894
]
Karl Heinz Marbaise commented on MDEPLOY-131:
-
This is an example for using a classifier which can be configured in pom by
multiple executions of the maven-shade-plugin and no need for deploy-file...and
of course not for using a different artifactId.
{code:xml}
org.apache.maven.plugins
maven-shade-plugin
true
test
package
shade
test
dev
package
shade
dev
prod
package
shade
prod
{code}
In any of the configurations you can change the things you would to
include/transform etc.
> use default repository when no url specified
>
>
> Key: MDEPLOY-131
> URL: https://issues.apache.org/jira/browse/MDEPLOY-131
> Project: Maven Deploy Plugin
> Issue Type: Improvement
> Components: deploy:deploy-file
>Reporter: raymond domingo
> Labels: contributers-welcome
> Attachments: DeployFileMojo.java,
> maven-deploy-useProjectRepo-20170319.patch, patch_deploy_file_mojo.diff
>
>
> When using the deploy goal there is no need to specify the url of the
> repository.
> When using deploy-file you DO need to specify the url. This is a problem,
> because during development I like to deploy to snapshot repository and when
> releasing i deploy to release repository and I can't add this logic to the
> pom.
> Thas is why I like the url paramter to become optional (backwards compatible)
> and add default behaviour when it is null. It should just like the deploy
> plugin use the default repository. Snapshot for snapshots and release for
> none snapshot versions.
> I added a patch file fixing this.
> I also added complete source of patched Mojo
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (MDEPLOY-131) use default repository when no url specified
[ https://issues.apache.org/jira/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931887#comment-15931887 ] Richard Sand commented on MDEPLOY-131: -- This thread has been inactive for a couple of years, but I'm guessing that the need for deploy-file to be able to use the existing project's default repositories is still out there. I've attached a very simple patch to enable this without changing the existing behavior of any current deployments. See the attachment "maven-deploy-useProjectRepo-20170319.patch" The patch adds a new configuration parameter called "useProjectRepository" (default false of course). When set to true, it will use the project's default artifactresolver. It changes "url" from required to optional, but throws an error if "url" is missing and "useProjectRepository" isn't explicitly set to true, so it won't disrupt any current behavior. I've used this new parameter in two of my company's projects to good effect. I use it in combination with maven shade plugin, to create multiple permutations of a shaded jar that includes different log capabilities (e.g. one has slf4j and slf4j-jcl, another has slf4j and jcl-over-slf4j, one has only slf4j, etc). I allow the shade plugin to create the dependency reduced pom, then deploy-file to attach the alternate jar and pom to a different artifact ID. It works great! -Richard > use default repository when no url specified > > > Key: MDEPLOY-131 > URL: https://issues.apache.org/jira/browse/MDEPLOY-131 > Project: Maven Deploy Plugin > Issue Type: Improvement > Components: deploy:deploy-file >Reporter: raymond domingo > Labels: contributers-welcome > Attachments: DeployFileMojo.java, patch_deploy_file_mojo.diff > > > When using the deploy goal there is no need to specify the url of the > repository. > When using deploy-file you DO need to specify the url. This is a problem, > because during development I like to deploy to snapshot repository and when > releasing i deploy to release repository and I can't add this logic to the > pom. > Thas is why I like the url paramter to become optional (backwards compatible) > and add default behaviour when it is null. It should just like the deploy > plugin use the default repository. Snapshot for snapshots and release for > none snapshot versions. > I added a patch file fixing this. > I also added complete source of patched Mojo -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] Commented: (MDEPLOY-131) use default repository when no url specified
[ https://jira.codehaus.org/browse/MDEPLOY-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=276658#comment-276658 ] Stephen Connolly commented on MDEPLOY-131: -- I am -1 on the currently attached patch for the following reason It mandates that the deploy:deploy-file be run in a directory that has a pom.xml There are a lot of people who use deploy:deploy-file to get their non-maven projects deployed to maven repositories. These people may not have a pom.xml (and while I agree that they _should_ they are currently not required to do so), or they may not call the pom file pom.xml rather someartifact.pom For that reason I am against the currently attached patch. A patch which has test cases and does not require the user to do mvn deploy:deploy-file -Dfile=someartifact.jar -DpomFile=someartifact.pom -f someartifact.pom but instead lets them do mvn deploy:deploy-file -Dfile=someartifact.jar -DpomFile=someartifact.pom rather than the current mvn deploy:deploy-file -Dfile=someartifact.jar -DpomFile=someartifact.pom -Durl=... if someartifact.pom contains the deployment url would seem like a good improvement use default repository when no url specified Key: MDEPLOY-131 URL: https://jira.codehaus.org/browse/MDEPLOY-131 Project: Maven 2.x Deploy Plugin Issue Type: Improvement Components: deploy:deploy-file Reporter: raymond domingo Labels: contributers-welcome Attachments: DeployFileMojo.java, patch_deploy_file_mojo.diff When using the deploy goal there is no need to specify the url of the repository. When using deploy-file you DO need to specify the url. This is a problem, because during development I like to deploy to snapshot repository and when releasing i deploy to release repository and I can't add this logic to the pom. Thas is why I like the url paramter to become optional (backwards compatible) and add default behaviour when it is null. It should just like the deploy plugin use the default repository. Snapshot for snapshots and release for none snapshot versions. I added a patch file fixing this. I also added complete source of patched Mojo -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
