dsmiley commented on code in PR #2264:
URL: https://github.com/apache/solr/pull/2264#discussion_r1490141634
##
gradle/ge.gradle:
##
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
dsmiley commented on code in PR #2264:
URL: https://github.com/apache/solr/pull/2264#discussion_r1490141248
##
gradle/ge.gradle:
##
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
dsmiley commented on code in PR #2264:
URL: https://github.com/apache/solr/pull/2264#discussion_r1490140328
##
gradle/ge.gradle:
##
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
clayburn commented on code in PR #2264:
URL: https://github.com/apache/solr/pull/2264#discussion_r1490136801
##
gradle/ge.gradle:
##
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817540#comment-17817540
]
David Smiley commented on SOLR-15730:
-
For 10, might as well put all the SolrJ Jetty client stuff in
[
https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817523#comment-17817523
]
Jan Høydahl commented on SOLR-16503:
[~ichattopadhyaya] as we are about to cut the apache-http client
[
https://issues.apache.org/jira/browse/SOLR-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817519#comment-17817519
]
Jan Høydahl commented on SOLR-8680:
---
Now that solrj is being split in several parts, do you think it
[
https://issues.apache.org/jira/browse/SOLR-15731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-15731.
Resolution: Won't Do
> Separate out a solrj-jdbc module
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-15731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817518#comment-17817518
]
Jan Høydahl commented on SOLR-15731:
I'm going to close this, as the solrj-streaming is enough
Jan Høydahl created SOLR-17161:
--
Summary: Separate out a solrj-jetty package / artifact
Key: SOLR-17161
URL: https://issues.apache.org/jira/browse/SOLR-17161
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817514#comment-17817514
]
Jan Høydahl commented on SOLR-15730:
See discussion in sub task SOLR-16078, where I propose a new
[
https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817512#comment-17817512
]
Jan Høydahl commented on SOLR-16078:
Moving this discussion to the parent issue SOLR-15730
> New
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-17157:
---
Description:
Creating and leaving this Jira open for (new) devs to grab.
optional
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-17157:
---
Description:
Creating and leaving this Jira open for (new) devs to grab.
optional
HoustonPutman merged PR #2198:
URL: https://github.com/apache/solr/pull/2198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on PR #2264:
URL: https://github.com/apache/solr/pull/2264#issuecomment-1944395079
And the build details: https://ge.apache.org/s/7tfc5bq6jabyi
--
This is an automated message
dsmiley commented on PR #2260:
URL: https://github.com/apache/solr/pull/2260#issuecomment-1944387038
I forgot to push the BackupRepository case yesterday; did it now.
Converting to Java streams shows very nice results there too :-)
--
This is an automated message from the Apache Git
psalagnac opened a new pull request, #2265:
URL: https://github.com/apache/solr/pull/2265
This is a trivial fix in doc. I did not fill a Jira for it.
Parameter `core` for `STATUS` admin request is (wrongly) required in the
full description, but (correctly) optional just before.
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489895570
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489888413
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489886455
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2400,15 +2402,15 @@ public void rejoinShardLeaderElection(SolrParams
params) {
try (SolrCore
dsmiley commented on PR #2256:
URL: https://github.com/apache/solr/pull/2256#issuecomment-1944344576
Replaced by #2264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dsmiley closed pull request #2256: Build: ge.gradle add tags & projectId=solr
URL: https://github.com/apache/solr/pull/2256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dsmiley opened a new pull request, #2264:
URL: https://github.com/apache/solr/pull/2264
Add more Gradle Enterprise build metadata.
(replacing previous #2256 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gerlowskija commented on PR #2262:
URL: https://github.com/apache/solr/pull/2262#issuecomment-1944317482
> No JIRA ticket or CHANGES.txt entry needed I think
+1 - it'd be overkill here IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1489857592
##
solr/core/src/java/org/apache/solr/search/SolrMultiCollectorManager.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817461#comment-17817461
]
ASF subversion and git services commented on SOLR-17066:
Commit
radu-gheorghe commented on PR #2263:
URL: https://github.com/apache/solr/pull/2263#issuecomment-1944309385
Oh, wow. That's fast :) Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817457#comment-17817457
]
ASF subversion and git services commented on SOLR-17066:
Commit
gerlowskija merged PR #2254:
URL: https://github.com/apache/solr/pull/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1489810761
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1917,6 +1963,203 @@ public ScoreMode scoreMode() {
qr.setDocList(new DocSlice(0,
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1489791031
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1910,6 +1960,203 @@ public ScoreMode scoreMode() {
qr.setDocList(new DocSlice(0,
HoustonPutman commented on issue #687:
URL: https://github.com/apache/solr-operator/issues/687#issuecomment-1944227204
That just configures a repository for your backups to use. You have to use a
separate SolrBackup resource to actually take a backup.
The Solr Helm chart does not
HoustonPutman commented on PR #2263:
URL: https://github.com/apache/solr/pull/2263#issuecomment-1944219543
This should be reflected in the official 9.5 docs after tonight!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489784004
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -622,8 +622,8 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489782985
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -250,17 +253,17 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489775946
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -622,8 +622,8 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
[
https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817448#comment-17817448
]
James Dyer commented on SOLR-16078:
---
bq. Can we even get rid of jackson, or is it needed for JSON
I
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489778608
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -250,17 +253,17 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489775946
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -622,8 +622,8 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489766927
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -250,17 +253,17 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489762243
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -76,7 +77,7 @@ public abstract class RequestHandlerBase
private PluginInfo pluginInfo;
HoustonPutman merged PR #2263:
URL: https://github.com/apache/solr/pull/2263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817440#comment-17817440
]
Houston Putman commented on SOLR-16078:
---
I like those options a lot.
> New solrj-core module
>
gerlowskija commented on PR #2254:
URL: https://github.com/apache/solr/pull/2254#issuecomment-1944175236
Turns out doing this for our 'LB' clients is a little more involved than I
initially thought, due to some of the additional public methods they have (e.g.
`request(LBSolrClient.Req)`).
Pierre Salagnac created SOLR-17160:
--
Summary: Bulk admin operations may fail because of max tracked
requests
Key: SOLR-17160
URL: https://issues.apache.org/jira/browse/SOLR-17160
Project: Solr
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1489700199
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1867,35 +1873,79 @@ public ScoreMode scoreMode() {
cpoerschke commented on PR #2260:
URL: https://github.com/apache/solr/pull/2260#issuecomment-1944079222
Wondering about having similar at lines 646 and 805 in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gus-asf commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489655442
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -250,17 +253,17 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489634706
##
solr/core/src/java/org/apache/solr/update/UpdateHandler.java:
##
@@ -116,10 +116,13 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog) {
clayburn commented on PR #2256:
URL: https://github.com/apache/solr/pull/2256#issuecomment-1943947802
Yes, the concept would be the same. It just deals with a few implementation
specific details regarding where the build scan data is stored on the build
runner, moving it to the privileged
dsmiley commented on PR #2256:
URL: https://github.com/apache/solr/pull/2256#issuecomment-1943944071
Aah! I will move my code to a branch then. I may need to close this PR
to do that.
> where the build runs in the fork, but the scan is uploaded in a separate
privileged step
clayburn commented on PR #2256:
URL: https://github.com/apache/solr/pull/2256#issuecomment-1943935338
I believe it is because these builds are coming from forks, which will not
have access to `secrets.GE_ACCESS_TOKEN` as it is an organization level secret
under the Apache org. This is
gus-asf commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489578308
##
solr/core/src/java/org/apache/solr/search/QueryLimits.java:
##
@@ -41,11 +43,15 @@ private QueryLimits() {}
* statement will hinge on hasXXXLimit() static method
dsmiley commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-1943929588
Observation: I don't think we need the concurrent DocSet builder (the one
from Netflix). Couldn't we build segment level FixedBitSets (no safety issue)
and then at the end combine into a
dsmiley commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489562698
##
solr/core/src/test/org/apache/solr/search/TestCpuQueryTimeLimit.java:
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
dsmiley commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489552446
##
solr/core/src/test/org/apache/solr/search/TestCpuQueryTimeLimit.java:
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
radu-gheorghe opened a new pull request, #2263:
URL: https://github.com/apache/solr/pull/2263
It's a minor change that we tested (if you just do `split=true` it seems to
apply to all fields, which is rarely what you want).
--
This is an automated message from the Apache Git Service.
To
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1489380477
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -1874,35 +1881,74 @@ public ScoreMode scoreMode() {
cpoerschke opened a new pull request, #2262:
URL: https://github.com/apache/solr/pull/2262
@chatman included a few as part of #2248 and looking further there's a few
more, so separating them out here. No JIRA ticket or CHANGES.txt entry needed I
think.
--
This is an automated message
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489287486
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489285471
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2050,15 +2050,13 @@ public void reload(String name, UUID coreId) {
if (docCollection != null)
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489280963
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -583,7 +587,7 @@ public final void doSyncOrReplicateRecovery(SolrCore core)
throws Exception {
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489279539
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -417,8 +419,10 @@ private final void doReplicateOnlyRecovery(SolrCore core)
throws InterruptedExce
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489255103
##
solr/core/src/test/org/apache/solr/search/TestCpuQueryTimeLimit.java:
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
cpoerschke merged PR #2258:
URL: https://github.com/apache/solr/pull/2258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sigram commented on code in PR #2244:
URL: https://github.com/apache/solr/pull/2244#discussion_r1489156800
##
solr/core/src/java/org/apache/solr/search/QueryLimits.java:
##
@@ -41,11 +43,15 @@ private QueryLimits() {}
* statement will hinge on hasXXXLimit() static method
67 matches
Mail list logo
