dsmiley commented on PR #2327:
URL: https://github.com/apache/solr/pull/2327#issuecomment-1974264126
I wrote a tiny script that loops over the code points here and there are
many whitespace chars, including a space char (ASCII digit 32). This and many
others are in the first block.
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1509879152
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -268,13 +258,14 @@ private HttpResponse doPutOrPost(
bodyPublisher =
dsmiley closed pull request #2271: SOLR-17160: Time based tracking of core
admin requests
URL: https://github.com/apache/solr/pull/2271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dsmiley commented on code in PR #2304:
URL: https://github.com/apache/solr/pull/2304#discussion_r1509871223
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -448,25 +458,51 @@ public static class CoreAdminAsyncTracker {
new
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822738#comment-17822738
]
David Smiley commented on SOLR-17160:
-
Even at the top level (ZK), the async IDs are capped at 10K
dsmiley opened a new pull request, #2331:
URL: https://github.com/apache/solr/pull/2331
Isn't needed because it's the default
Note this is on branch_9x. Main already has this; was done some time ago I
guess.
--
This is an automated message from the Apache Git Service.
To respond
magibney commented on PR #2328:
URL: https://github.com/apache/solr/pull/2328#issuecomment-1973873827
Any preference on deprecate vs. remove in `branch_9x`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AndreyBozhko commented on code in PR #2330:
URL: https://github.com/apache/solr/pull/2330#discussion_r1509415642
##
solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java:
##
@@ -37,8 +37,7 @@ public void testExamples() {
me = new
AndreyBozhko opened a new pull request, #2330:
URL: https://github.com/apache/solr/pull/2330
https://issues.apache.org/jira/browse/SOLR-X
# Description
As discussed with @epugh in
https://github.com/apache/solr/pull/2245#discussion_r1479109367, I'm opening a
AndreyBozhko opened a new pull request, #2329:
URL: https://github.com/apache/solr/pull/2329
https://issues.apache.org/jira/browse/SOLR-X
# Description
Fix logic FileBasedSpellChecker that uses wrong method to retrieve fieldType
by its name
# Tests
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1509376127
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
dsmiley commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-1973609964
Sorry; I didn't look at your change enough! I agree that it should work,
and is probably better than having a concurrent ThreadSafeBitSet.
--
This is an automated message from the Apache
cpoerschke commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-1973599897
Commit reverted, though I still have doubts i.e. maybe the commit message
was just unhelpful i.e. _"replace ThreadSafeBitSet[Collector] with
FixedBitSet[Collector]"_ is mechanical
cpoerschke commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-1973524446
> @cpoerschke
[34c7db0](https://github.com/apache/solr/commit/34c7db09e08693a79d87eaa6e43ad6f5aacbc342)
No; that is a single FixedBitSet and as such you've basically changed this to
magibney opened a new pull request, #2328:
URL: https://github.com/apache/solr/pull/2328
https://issues.apache.org/jira/browse/SOLR-17190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-17190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822641#comment-17822641
]
Michael Gibney commented on SOLR-17190:
---
Another improvement: the size arg to
[
https://issues.apache.org/jira/browse/SOLR-17190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney updated SOLR-17190:
--
Description:
The functionality provided by {{org.apache.solr.util.LongSet}} is redundant to
Michael Gibney created SOLR-17190:
-
Summary: Replace org.apache.solr.util.LongSet with hppc LongHashSet
Key: SOLR-17190
URL: https://issues.apache.org/jira/browse/SOLR-17190
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17186.
--
Fix Version/s: 9.6.0
Assignee: Eric Pugh
Resolution: Fixed
> Streaming query breaks if
mariemat commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1509204591
##
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##
@@ -984,8 +985,13 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest
sreq) {
[
https://issues.apache.org/jira/browse/SOLR-17186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822627#comment-17822627
]
ASF subversion and git services commented on SOLR-17186:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822625#comment-17822625
]
ASF subversion and git services commented on SOLR-17186:
Commit
epugh merged PR #2321:
URL: https://github.com/apache/solr/pull/2321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
dsmiley commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1508510783
##
solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dsmiley commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-1973382624
@cpoerschke
https://github.com/apache/solr/commit/34c7db09e08693a79d87eaa6e43ad6f5aacbc342
No; that is a single FixedBitSet and as such you've basically changed this to
Solr's existing
[
https://issues.apache.org/jira/browse/SOLR-17183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822574#comment-17822574
]
ASF subversion and git services commented on SOLR-17183:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17183.
Fix Version/s: main (10.0)
9.6.0
Resolution: Fixed
> Improve PKI
cpoerschke commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-1973204347
> Observation: I don't think we need the concurrent DocSet builder (the one
from Netflix). Couldn't we build segment level FixedBitSets (no safety issue)
and then at the end combine into
[
https://issues.apache.org/jira/browse/SOLR-17183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822565#comment-17822565
]
ASF subversion and git services commented on SOLR-17183:
Commit
gerlowskija merged PR #2312:
URL: https://github.com/apache/solr/pull/2312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sigram commented on PR #100:
URL: https://github.com/apache/solr-sandbox/pull/100#issuecomment-1973117708
@markrmiller @anshumg If there are no objections I'd like to merge this next
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
sigram merged PR #2323:
URL: https://github.com/apache/solr/pull/2323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822491#comment-17822491
]
ASF subversion and git services commented on SOLR-17172:
Commit
33 matches
Mail list logo
