dsmiley commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1512170495
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1017,19 +1023,21 @@ public String getBaseURL() {
}
private static class
dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1978009974
>On a side note, How about we rethink the design decorating the request.
Right now, we recreate the Http2SolrClient to override socketTimeout and
connTimeout.
Which is a fine
iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1977998958
TestPullReplicaWithAuth.testPKIAuthWorksForPullReplication is the one.
On a side note, How about we rethink the design decorating the request.
Right now, we recreate the
[
https://issues.apache.org/jira/browse/SOLR-17196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823417#comment-17823417
]
Sanjay Dutt commented on SOLR-17196:
Yes you are right. We can delete this one. But I do not have the
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511969130
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511969130
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511966490
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511966490
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
dsmiley commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1977700604
Thanks for digging into the authentication issue further; this is shining a
light on an issue I was vaguely aware of but now I can see it directly. And
I'm so glad there are tests; I
jdyer1 commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1511942692
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) {
return
[
https://issues.apache.org/jira/browse/SOLR-17197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823369#comment-17823369
]
ASF subversion and git services commented on SOLR-17197:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17197.
--
Fix Version/s: 9.6.0
Resolution: Fixed
Thank you [~andreybozhko]
> Fix getting fieldType by
[
https://issues.apache.org/jira/browse/SOLR-17197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823368#comment-17823368
]
ASF subversion and git services commented on SOLR-17197:
Commit
epugh merged PR #2329:
URL: https://github.com/apache/solr/pull/2329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17197:
Assignee: Eric Pugh
> Fix getting fieldType by its name in FileBasedSpellChecker
>
mkhludnev commented on PR #2332:
URL: https://github.com/apache/solr/pull/2332#issuecomment-1977426115
@wwang30 what do you think of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
epugh commented on code in PR #2329:
URL: https://github.com/apache/solr/pull/2329#discussion_r1511754332
##
solr/core/src/test-files/solr/collection1/conf/schema-spellchecker.xml:
##
@@ -49,9 +49,22 @@
+
Review Comment:
we probably should `snake_case` it
epugh commented on code in PR #2329:
URL: https://github.com/apache/solr/pull/2329#discussion_r1511754004
##
solr/core/src/test-files/solr/collection1/conf/schema-spellchecker.xml:
##
@@ -49,9 +49,22 @@
+
Review Comment:
thanks for taking the time to check the
mkhludnev opened a new pull request, #2332:
URL: https://github.com/apache/solr/pull/2332
https://issues.apache.org/jira/browse/SOLR-17173
also invert properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
AndreyBozhko commented on code in PR #2329:
URL: https://github.com/apache/solr/pull/2329#discussion_r1511743579
##
solr/CHANGES.txt:
##
@@ -27,7 +27,8 @@ Optimizations
Bug Fixes
-
-(No changes)
+
+* PR#2329: Fix getting fieldType by its name in
Andrey Bozhko created SOLR-17197:
Summary: Fix getting fieldType by its name in FileBasedSpellChecker
Key: SOLR-17197
URL: https://issues.apache.org/jira/browse/SOLR-17197
Project: Solr
AndreyBozhko commented on code in PR #2329:
URL: https://github.com/apache/solr/pull/2329#discussion_r1511715637
##
solr/CHANGES.txt:
##
@@ -27,7 +27,8 @@ Optimizations
Bug Fixes
-
-(No changes)
+
+* PR#2329: Fix getting fieldType by its name in
[
https://issues.apache.org/jira/browse/SOLR-17059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17059.
Resolution: Invalid
Closing this out as it appears to be user error. Feel free to reopen
[
https://issues.apache.org/jira/browse/SOLR-17113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823299#comment-17823299
]
Jason Gerlowski commented on SOLR-17113:
Thanks for the detailed writeup [~pciezkowski]!
bq. I
[
https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823284#comment-17823284
]
Jason Gerlowski commented on SOLR-16397:
bq. Presumably this was forgotten?
Nope. Some of the
[
https://issues.apache.org/jira/browse/SOLR-17155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823274#comment-17823274
]
rajanimaski edited comment on SOLR-17155 at 3/4/24 6:11 PM:
[
https://issues.apache.org/jira/browse/SOLR-17155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823274#comment-17823274
]
rajanimaski edited comment on SOLR-17155 at 3/4/24 6:08 PM:
[
https://issues.apache.org/jira/browse/SOLR-17155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823274#comment-17823274
]
rajanimaski commented on SOLR-17155:
{{SolrDocumentFetcher}} method fetches list of stored fields
dsmiley commented on code in PR #2304:
URL: https://github.com/apache/solr/pull/2304#discussion_r1511522416
##
solr/core/src/java/org/apache/solr/handler/admin/api/GetNodeCommandStatus.java:
##
@@ -51,25 +51,24 @@ public GetNodeCommandStatus(
public
[
https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823265#comment-17823265
]
David Smiley commented on SOLR-16397:
-
I can see there are changes here that got released in 9.5,
[
https://issues.apache.org/jira/browse/SOLR-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823262#comment-17823262
]
wei wang commented on SOLR-17173:
-
[~mkhl] I began on the revisions based on your feedback but have been
janhoy commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511450537
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
psalagnac commented on code in PR #2304:
URL: https://github.com/apache/solr/pull/2304#discussion_r1511341651
##
solr/core/src/java/org/apache/solr/handler/admin/api/GetNodeCommandStatus.java:
##
@@ -51,25 +51,24 @@ public GetNodeCommandStatus(
public
psalagnac commented on code in PR #2304:
URL: https://github.com/apache/solr/pull/2304#discussion_r1511341651
##
solr/core/src/java/org/apache/solr/handler/admin/api/GetNodeCommandStatus.java:
##
@@ -51,25 +51,24 @@ public GetNodeCommandStatus(
public
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511245577
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823206#comment-17823206
]
ASF subversion and git services commented on SOLR-17066:
Commit
gerlowskija merged PR #2302:
URL: https://github.com/apache/solr/pull/2302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511219624
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -287,6 +278,64 @@ private HttpResponse doPutOrPost(
return response;
}
+
Sanjay Dutt created SOLR-17196:
--
Summary: Update IndexFetcher Class to Use Http2SolrClient
Key: SOLR-17196
URL: https://issues.apache.org/jira/browse/SOLR-17196
Project: Solr
Issue Type:
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1511202322
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Jason Gerlowski created SOLR-17195:
--
Summary: Minimum prefix-length soft limit
Key: SOLR-17195
URL: https://issues.apache.org/jira/browse/SOLR-17195
Project: Solr
Issue Type: Sub-task
Eric Pugh created SOLR-17194:
Summary: Export doesn't support basic auth
Key: SOLR-17194
URL: https://issues.apache.org/jira/browse/SOLR-17194
Project: Solr
Issue Type: Sub-task
Jason Gerlowski created SOLR-17193:
--
Summary: Naive-deep-paging soft limit
Key: SOLR-17193
URL: https://issues.apache.org/jira/browse/SOLR-17193
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823185#comment-17823185
]
Eric Pugh commented on SOLR-16824:
--
{color:#00}Now instead of “solrUrl” sometimes meaning
Jason Gerlowski created SOLR-17192:
--
Summary: Maximum-fields-per-core soft limit
Key: SOLR-17192
URL: https://issues.apache.org/jira/browse/SOLR-17192
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823170#comment-17823170
]
Mikhail Khludnev commented on SOLR-17173:
-
[~weiwang19] may I ask you if you wish to take part?
tuannh982 commented on PR #2313:
URL: https://github.com/apache/solr/pull/2313#issuecomment-1976135035
@jdyer1 can you re-review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
47 matches
Mail list logo
