[PR] SOLR-17157: Upgrade to Lucene 9.10.0 [solr]

2024-03-18 Thread via GitHub
hossman opened a new pull request, #2352: URL: https://github.com/apache/solr/pull/2352 https://issues.apache.org/jira/browse/SOLR-17157 Upgrade to Lucene 9.10.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-17157) upgrade to Lucene 9.10.0

2024-03-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828159#comment-17828159 ] ASF subversion and git services commented on SOLR-17157: Commit

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-18 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1529325382 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-18 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1529324002 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-18 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1529320577 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Resolved] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-03-18 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-17164. --- Fix Version/s: 9.6.0 Resolution: Fixed Thanks sanjay! > Add 2 arg variant of

[jira] [Commented] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-03-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828103#comment-17828103 ] ASF subversion and git services commented on SOLR-17164: Commit

[jira] [Commented] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-03-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828093#comment-17828093 ] ASF subversion and git services commented on SOLR-17164: Commit

Re: [PR] Update dependency com.google.guava:guava to v33 [solr]

2024-03-18 Thread via GitHub
solrbot commented on PR #2169: URL: https://github.com/apache/solr/pull/2169#issuecomment-2004911276 ### ⚠ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch,

[jira] [Commented] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-03-18 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828078#comment-17828078 ] Chris M. Hostetter commented on SOLR-17164: --- {quote} I'll add the new 2 arg param ref test

[jira] [Commented] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-03-18 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828076#comment-17828076 ] Chris M. Hostetter commented on SOLR-17164: --- {quote}... +1 to new test cases in

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-18 Thread via GitHub
alessandrobenedetti commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1529028001 ## solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java: ## @@ -233,7 +235,14 @@ protected static boolean scoreSingleHit( boolean logHit =

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-18 Thread via GitHub
alessandrobenedetti commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1529019062 ## solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java: ## @@ -233,7 +235,14 @@ protected static boolean scoreSingleHit( boolean logHit =

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-18 Thread via GitHub
alessandrobenedetti commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1529015878 ## solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java: ## @@ -233,7 +235,14 @@ protected static boolean scoreSingleHit( boolean logHit =

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-18 Thread via GitHub
alessandrobenedetti commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1529011079 ## solr/core/src/java/org/apache/solr/search/ReRankCollector.java: ## @@ -129,21 +129,25 @@ public TopDocs topDocs(int start, int howMany) {

[jira] [Commented] (SOLR-17203) CPU not calculated correctly in ThreadCpuTimer

2024-03-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828050#comment-17828050 ] ASF subversion and git services commented on SOLR-17203: Commit

Re: [PR] SOLR-17203 fix calculation for CpuAllowedLimit [solr]

2024-03-18 Thread via GitHub
gus-asf merged PR #2347: URL: https://github.com/apache/solr/pull/2347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-18 Thread via GitHub
sigram commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1528826795 ## solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java: ## @@ -233,7 +235,14 @@ protected static boolean scoreSingleHit( boolean logHit = false;

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-18 Thread via GitHub
sigram commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1528824258 ## solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java: ## @@ -233,7 +235,14 @@ protected static boolean scoreSingleHit( boolean logHit = false;

[jira] [Commented] (SOLR-17200) "False Positive" Race conditions using "/health?requireHealthyCores=true" near startup

2024-03-18 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828029#comment-17828029 ] Vincent Primault commented on SOLR-17200: - I have encountered several issues already related to

Re: [PR] SOLR-17203 fix calculation for CpuAllowedLimit [solr]

2024-03-18 Thread via GitHub
sigram commented on code in PR #2347: URL: https://github.com/apache/solr/pull/2347#discussion_r1528798498 ## solr/core/src/java/org/apache/solr/search/CpuAllowedLimit.java: ## @@ -57,28 +63,24 @@ public CpuAllowedLimit(SolrQueryRequest req) { throw new

Re: [PR] SOLR-17203 fix calculation for CpuAllowedLimit [solr]

2024-03-18 Thread via GitHub
sigram commented on code in PR #2347: URL: https://github.com/apache/solr/pull/2347#discussion_r1528795286 ## solr/core/src/java/org/apache/solr/search/CpuAllowedLimit.java: ## @@ -17,25 +17,29 @@ package org.apache.solr.search; import

[jira] [Commented] (SOLR-16503) Switch UpdateShardHandler.getDefaultHttpClient to Jetty HTTP2

2024-03-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827996#comment-17827996 ] David Smiley commented on SOLR-16503: - Okay; I could see marking getDefaultHttpClient deprecated and

[PR] Introduce new default Http2SolrClient in UpdateShardHandler [solr]

2024-03-18 Thread via GitHub
iamsanjay opened a new pull request, #2351: URL: https://github.com/apache/solr/pull/2351 https://issues.apache.org/jira/browse/SOLR-16503 Currently default HTTP (Apache Http 1) client in UpdateShardHandler is being used at many places in the codebase and consequently

[jira] [Commented] (SOLR-17164) Add 2 arg variant of vectorSimilarity() function

2024-03-18 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827870#comment-17827870 ] Sanjay Dutt commented on SOLR-17164: [~hossman] Thank you so much for resolving the ref param case.

Re: [PR] SOLR-17164: Add 2 arg variant of vectorSimilarity() function [solr]

2024-03-18 Thread via GitHub
iamsanjay commented on code in PR #2292: URL: https://github.com/apache/solr/pull/2292#discussion_r1528031649 ## solr/core/src/java/org/apache/solr/search/VectorSimilaritySourceParser.java: ## @@ -110,14 +146,38 @@ private ValueSource createSimilarityFunction( } } -

Re: [PR] SOLR-17164: Add 2 arg variant of vectorSimilarity() function [solr]

2024-03-18 Thread via GitHub
iamsanjay commented on code in PR #2292: URL: https://github.com/apache/solr/pull/2292#discussion_r1528010534 ## solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java: ## @@ -911,13 +911,56 @@ public void testFuncVector() throws Exception { } public void

Re: [PR] SOLR-17164: Add 2 arg variant of vectorSimilarity() function [solr]

2024-03-18 Thread via GitHub
iamsanjay commented on code in PR #2292: URL: https://github.com/apache/solr/pull/2292#discussion_r1528010534 ## solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java: ## @@ -911,13 +911,56 @@ public void testFuncVector() throws Exception { } public void