Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2024-04-03 Thread via GitHub
laminelam commented on PR #1994: URL: https://github.com/apache/solr/pull/1994#issuecomment-2035996505 > Are we sure this fits as a Solr module? Since this is client-side solrj code, it could be in e.g. `solrj-aws-secret` instead? Actually, this is a server side code. When Solr

Re: [I] Shards in a down state after an HPA scale up / scale down event. [solr-operator]

2024-04-03 Thread via GitHub
HoustonPutman closed issue #682: Shards in a down state after an HPA scale up / scale down event. URL: https://github.com/apache/solr-operator/issues/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix scaling when using ingress-addressed nodes [solr-operator]

2024-04-03 Thread via GitHub
HoustonPutman merged PR #692: URL: https://github.com/apache/solr-operator/pull/692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
epugh commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2035531253 IIRC it was actually not well supported in recent versions of Solr, it may even not have worked at all in the 8x line... With the V2 api's starting to live under `/api`, we want to make

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2024-04-03 Thread via GitHub
janhoy commented on PR #1994: URL: https://github.com/apache/solr/pull/1994#issuecomment-2035476333 Are we sure this fits as a Solr module? Since this is client-side sloth code, it should be in `solrj-aws-secret` instead? -- This is an automated message from the Apache Git Service. To

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-04-03 Thread via GitHub
dsmiley commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1550359158 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -445,6 +447,17 @@ public CoreContainer(NodeConfig config, CoresLocator locator, boolean asyncSolrC

[jira] [Commented] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2024-04-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833722#comment-17833722 ] David Smiley commented on SOLR-17158: - Fail vs Success should be based on {{shards.tolerant}} --

[jira] [Commented] (SOLR-17205) De-couple SolrJ required Java version from server Java version (main)

2024-04-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833703#comment-17833703 ] David Smiley commented on SOLR-17205: - While I'm supportive of this change, a user can continue to

[jira] [Resolved] (SOLR-17211) HttpJdkSolrClient: Support Async

2024-04-03 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer resolved SOLR-17211. --- Resolution: Fixed > HttpJdkSolrClient: Support Async > - > >

[jira] [Commented] (SOLR-17211) HttpJdkSolrClient: Support Async

2024-04-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833686#comment-17833686 ] ASF subversion and git services commented on SOLR-17211: Commit

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2035026777 @HoustonPutman thanks for the quick reply. I have been reading about that in the Jira and previous issues/PRs. I noticed `hostContext` is still used in

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2034997136 > Will take another look at the javadoc links. What gradle command do I run to build javadocs that should have substituted local javadocs? Do I have to unzip some jdk javadoc file into

Re: [PR] SOLR-17205 De-couple SolrJ Java version from server Java version [solr]

2024-04-03 Thread via GitHub
HoustonPutman commented on PR #2360: URL: https://github.com/apache/solr/pull/2360#issuecomment-2034982016 Currently yes, but there's a PR for one that might be SolrJ compatible: https://github.com/apache/solr/pull/1994. Just thinking about an eventual possibility. -- This is an

Re: [PR] fix: gen-pkcs12-keystore adds ca.crt input option if it exists (#684) [solr-operator]

2024-04-03 Thread via GitHub
HoustonPutman commented on code in PR #685: URL: https://github.com/apache/solr-operator/pull/685#discussion_r1550003188 ## controllers/util/solr_tls_util.go: ## @@ -707,8 +707,11 @@ func (tls *TLSConfig) generatePkcs12InitContainer(imageName string, imagePullPol

[jira] [Commented] (SOLR-17211) HttpJdkSolrClient: Support Async

2024-04-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833652#comment-17833652 ] ASF subversion and git services commented on SOLR-17211: Commit

Re: [PR] SOLR-17211: HttpJdkSolrClient Support Async requests [solr]

2024-04-03 Thread via GitHub
jdyer1 merged PR #2374: URL: https://github.com/apache/solr/pull/2374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17205 De-couple SolrJ Java version from server Java version [solr]

2024-04-03 Thread via GitHub
janhoy commented on PR #2360: URL: https://github.com/apache/solr/pull/2360#issuecomment-2034965063 I might be mis interpreting your statement. But as far as I know, all `modules` are server-side only. The two you mentioned both depend on `solr-core`. -- This is an automated message

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
HoustonPutman commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2034928189 I believe we recently removed the ability to specify a new hostContext in `main`. @epugh @gerlowskija -- This is an automated message from the Apache Git Service. To respond to the

[PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-03 Thread via GitHub
wwelling opened a new pull request, #2388: URL: https://github.com/apache/solr/pull/2388 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Assigned] (SOLR-17211) HttpJdkSolrClient: Support Async

2024-04-03 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Dyer reassigned SOLR-17211: - Assignee: James Dyer > HttpJdkSolrClient: Support Async > - >

Re: [PR] SOLR-17205 De-couple SolrJ Java version from server Java version [solr]

2024-04-03 Thread via GitHub
HoustonPutman commented on PR #2360: URL: https://github.com/apache/solr/pull/2360#issuecomment-2034768833 > @HoustonPutman Which other modules are you thinking about, except the `solrj-*` ones? @janhoy Sorry I missed this, I'm thinking about the ones that would be used by SolrJ,

[jira] [Commented] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState

2024-04-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833595#comment-17833595 ] ASF subversion and git services commented on SOLR-17153: Commit

Re: [I] Run solr-operator and solr helm chart on openshift get error "would violate PodSecurity "restricted:v1.24"" [solr-operator]

2024-04-03 Thread via GitHub
janhoy commented on issue #671: URL: https://github.com/apache/solr-operator/issues/671#issuecomment-2034596523 My client uses [Kyverno](https://kyverno.io/policies/?policytypes=Pod%2520Security%2520Standards%2520%28Baseline%29) to warn or enforce various best practices. They recently

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
janhoy commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2034339316 Will take another look at the javadoc links. What gradle command do I run to build javadocs that should have substituted local javadocs? Do I have to unzip some jdk javadoc file into my git

[jira] [Comment Edited] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from java based application

2024-04-03 Thread Puneet Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833472#comment-17833472 ] Puneet Sharma edited comment on SOLR-17224 at 4/3/24 9:43 AM: -- [~cpoerschke]

[jira] [Commented] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from java based application

2024-04-03 Thread Puneet Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833472#comment-17833472 ] Puneet Sharma commented on SOLR-17224: -- looks like the same kind of issue, but here if we check the

[jira] [Updated] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from java based application

2024-04-03 Thread Puneet Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Sharma updated SOLR-17224: - Attachment: image-2024-04-03-15-11-43-947.png > Getting NPE in apache SOLR 8.11.2 while doing

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
janhoy commented on code in PR #2387: URL: https://github.com/apache/solr/pull/2387#discussion_r1549333462 ## gradle/documentation/render-javadoc.gradle: ## @@ -370,7 +370,7 @@ class RenderJavadocTask extends DefaultTask { opts << [ '-linkoffline', url, dir ] } -

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2033910058 P.S.: I missed this in Lucene, there is also a reference to the JDK Javadocs and its package file above. We may also make this dynamic. -- This is an automated message from the Apache

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
cpoerschke commented on code in PR #2387: URL: https://github.com/apache/solr/pull/2387#discussion_r1549234517 ## gradle/documentation/render-javadoc.gradle: ## @@ -370,7 +370,7 @@ class RenderJavadocTask extends DefaultTask { opts << [ '-linkoffline', url, dir ] }

Re: [PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
uschindler commented on PR #2387: URL: https://github.com/apache/solr/pull/2387#issuecomment-2033894291 The approach you used did not work in Lucene because inputs/outputs and "rootProject" was not known in the task instance. Here it is different, if it works, +1 -- This is an automated

[jira] [Assigned] (SOLR-17223) Port renderJavadoc task fix from Lucene

2024-04-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-17223: -- Assignee: Jan Høydahl > Port renderJavadoc task fix from Lucene >

[PR] SOLR-17223 Remove hardcoded java version in renderJavadoc task [solr]

2024-04-03 Thread via GitHub
janhoy opened a new pull request, #2387: URL: https://github.com/apache/solr/pull/2387 Oneliner :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from java based application

2024-04-03 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833423#comment-17833423 ] Christine Poerschke commented on SOLR-17224: cross-referencing tickets: this sounds a bit

[jira] [Updated] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from java based application

2024-04-03 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17224: --- Component/s: update > Getting NPE in apache SOLR 8.11.2 while doing atomic update

[jira] [Updated] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from java based application

2024-04-03 Thread Puneet Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Sharma updated SOLR-17224: - Summary: Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from

[jira] [Updated] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from my java based application

2024-04-03 Thread Puneet Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Sharma updated SOLR-17224: - Environment: Live in production > Getting NPE in apache SOLR 8.11.2 while doing atomic update

[jira] [Created] (SOLR-17224) Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from my java based application

2024-04-03 Thread Puneet Sharma (Jira)
Puneet Sharma created SOLR-17224: Summary: Getting NPE in apache SOLR 8.11.2 while doing atomic update using add-distinct from my java based application Key: SOLR-17224 URL: