gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1560191241
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/RequestParamsSupplier.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1560189150
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -140,58 +150,64 @@ public void submit(
srsp.setShard(shard);
gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1560188805
##
solr/core/src/java/org/apache/solr/search/Grouping.java:
##
@@ -461,7 +463,7 @@ private void searchWithTimeLimiter(final Query filterQuery,
Collector collector)
gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1560183316
##
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##
@@ -216,24 +222,26 @@ public static void processParams(
boolean isQuery = false;
github-actions[bot] commented on PR #2235:
URL: https://github.com/apache/solr/pull/2235#issuecomment-2048620798
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2048498024
Sorry if I rained on your parade, attempting to get this in by EOW.
I like the idea of having checks like this by default but I'd like Solr to
have such built-in plugins simply be
igiguere commented on PR #1638:
URL: https://github.com/apache/solr/pull/1638#issuecomment-2048377234
> I'd prefer to see a V2 api added instead of a V1 api. Adding more V1 api's
is just adding to the backlog of work on our V2 migration, so I'd love to see
that instead added...!
solrbot opened a new pull request, #2399:
URL: https://github.com/apache/solr/pull/2399
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.semver4j:semver4j](https://togithub.com/semver4j/semver4j) |
dependencies | patch |
[
https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-11535.
---
Fix Version/s: 9.6.0
Resolution: Fixed
> Weird behavior of CollectionStateWatcher
>
[
https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835862#comment-17835862
]
ASF subversion and git services commented on SOLR-11535:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835855#comment-17835855
]
ASF subversion and git services commented on SOLR-11535:
Commit
magibney merged PR #1964:
URL: https://github.com/apache/solr/pull/1964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-12404.
-
Resolution: Fixed
Closing as completed by other work items.
> Start using HTTP/2 instead of
[
https://issues.apache.org/jira/browse/SOLR-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-17176.
---
Fix Version/s: 9.6.0
Resolution: Fixed
> Log history V2 API doesn't serialize
[
https://issues.apache.org/jira/browse/SOLR-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835823#comment-17835823
]
ASF subversion and git services commented on SOLR-17176:
Commit
magibney merged PR #2293:
URL: https://github.com/apache/solr/pull/2293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-17176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835812#comment-17835812
]
ASF subversion and git services commented on SOLR-17176:
Commit
epugh commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1559751361
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldsMonitor.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
janhoy merged PR #2397:
URL: https://github.com/apache/solr/pull/2397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on PR #2398:
URL: https://github.com/apache/solr/pull/2398#issuecomment-2047983195
Draft since it will need a new forbiddenapis release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2047973430
This should all be ready to go: I've added unit and integration tests,
`./gradlew test` passes, there's ref-guide coverage and decent Javadocs, etc.
I'll aim to merge EOW, absent any
elyograg commented on PR #2246:
URL: https://github.com/apache/solr/pull/2246#issuecomment-2047920040
I'm tied up today. If it should happen now, someone else can look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/SOLR-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17213.
--
Fix Version/s: 9.6.0
Resolution: Fixed
> Don't warn users about the /solr in the url when we
[
https://issues.apache.org/jira/browse/SOLR-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835771#comment-17835771
]
ASF subversion and git services commented on SOLR-17213:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835767#comment-17835767
]
ASF subversion and git services commented on SOLR-17213:
Commit
epugh merged PR #2377:
URL: https://github.com/apache/solr/pull/2377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1559563492
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+
[
https://issues.apache.org/jira/browse/SOLR-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17189:
Fix Version/s: 9.6.0
> DockMakerTest.testRealisticUnicode fails from whitespace assumption
>
[
https://issues.apache.org/jira/browse/SOLR-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835745#comment-17835745
]
David Smiley commented on SOLR-17181:
-
Next time, when squash-merging, please cleanup/editorialize
[
https://issues.apache.org/jira/browse/SOLR-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17211:
Fix Version/s: 9.6.0
> HttpJdkSolrClient: Support Async
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-17206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17206:
Fix Version/s: 9.6.0
> Update requests to SolrCloud can return status value of -1
>
[
https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17153.
-
Fix Version/s: 9.6.0
Resolution: Fixed
> CloudSolrClient should not throw "Collection not
[
https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835742#comment-17835742
]
ASF subversion and git services commented on SOLR-17153:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835736#comment-17835736
]
ASF subversion and git services commented on SOLR-17153:
Commit
dsmiley merged PR #2393:
URL: https://github.com/apache/solr/pull/2393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
epugh commented on PR #2393:
URL: https://github.com/apache/solr/pull/2393#issuecomment-2047517535
I just manually gave this PR a run through, and it looks great. Please
merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epugh commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1559411299
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+
cpoerschke commented on PR #2246:
URL: https://github.com/apache/solr/pull/2246#issuecomment-2047498468
Hello again!
I'd love to see this included in the upcoming 9.6 release --
https://lists.apache.org/thread/mn6625txw938l8sy1o9r9rhmnqpdfo6v
@elyograg - would you have
solrbot commented on PR #2213:
URL: https://github.com/apache/solr/pull/2213#issuecomment-2047471572
### Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this
update. You will not get PRs for *any* future `3.x` releases. But if you
solrbot commented on PR #2011:
URL: https://github.com/apache/solr/pull/2011#issuecomment-2047471132
### Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this
update. You will not get PRs for *any* future `7.x` releases. But if you
[
https://issues.apache.org/jira/browse/SOLR-17206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17206.
-
Resolution: Fixed
Thanks for contributing!
> Update requests to SolrCloud can return status
[
https://issues.apache.org/jira/browse/SOLR-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17189.
-
Assignee: David Smiley
Resolution: Fixed
> DockMakerTest.testRealisticUnicode fails from
[
https://issues.apache.org/jira/browse/SOLR-17206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835721#comment-17835721
]
ASF subversion and git services commented on SOLR-17206:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835722#comment-17835722
]
ASF subversion and git services commented on SOLR-17189:
Commit
[
https://issues.apache.org/jira/browse/SOLR-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835717#comment-17835717
]
ASF subversion and git services commented on SOLR-17189:
Commit
dsmiley merged PR #2327:
URL: https://github.com/apache/solr/pull/2327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
solrbot opened a new pull request, #2398:
URL: https://github.com/apache/solr/pull/2398
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [commons-io:commons-io](https://commons.apache.org/proper/commons-io/)
[
https://issues.apache.org/jira/browse/SOLR-17206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835715#comment-17835715
]
ASF subversion and git services commented on SOLR-17206:
Commit
dsmiley merged PR #2368:
URL: https://github.com/apache/solr/pull/2368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on PR #2393:
URL: https://github.com/apache/solr/pull/2393#issuecomment-2047435155
Looks good; I'd like to merge. If you disagree @epugh , please pipe in
today.
Minor nitpick: there's a comment that doesn't flow (newline) nicely but
whatever.
--
This is an
janhoy closed pull request #2326: Update org.eclipse.jetty*:* (major)
URL: https://github.com/apache/solr/pull/2326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
janhoy commented on PR #2326:
URL: https://github.com/apache/solr/pull/2326#issuecomment-2047424908
Closing this as it will have to be manually done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
janhoy closed pull request #2213: Update dependency
org.glassfish.jersey.containers:jersey-container-jetty-http to v3
URL: https://github.com/apache/solr/pull/2213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
janhoy commented on PR #2213:
URL: https://github.com/apache/solr/pull/2213#issuecomment-2047422617
Closing this as won't do, as this will need to be synced with Solr's Jetty
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
janhoy closed pull request #2011: Update dependency
biz.aQute.bnd:biz.aQute.bnd.annotation to v7
URL: https://github.com/apache/solr/pull/2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
janhoy commented on PR #2011:
URL: https://github.com/apache/solr/pull/2011#issuecomment-2047416043
Closing this as won't do, since this version requires JDK17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
janhoy commented on PR #2047:
URL: https://github.com/apache/solr/pull/2047#issuecomment-2047413902
Unfortunate that we cannot upgrade due to requirement for Java 17 in a minor
release... So will have to stick with the one we have I guess...
--
This is an automated message from the
janhoy merged PR #2209:
URL: https://github.com/apache/solr/pull/2209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #2343:
URL: https://github.com/apache/solr/pull/2343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #2049:
URL: https://github.com/apache/solr/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on PR #2049:
URL: https://github.com/apache/solr/pull/2049#issuecomment-2047265089
I'll downgrade this PR to 2.15.1 to match policeman rules to get this
merged. Then we can tackle newer commons-io versions later.
--
This is an automated message from the Apache Git
janhoy merged PR #2390:
URL: https://github.com/apache/solr/pull/2390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy opened a new pull request, #2397:
URL: https://github.com/apache/solr/pull/2397
We always close the renovate PRs for major eclipse upgrades since they need
much more work. So let's skip these
--
This is an automated message from the Apache Git Service.
To respond to the message,
solrbot opened a new pull request, #2396:
URL: https://github.com/apache/solr/pull/2396
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
janhoy merged PR #2394:
URL: https://github.com/apache/solr/pull/2394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on code in PR #2394:
URL: https://github.com/apache/solr/pull/2394#discussion_r1559205658
##
.github/renovate.json:
##
@@ -46,6 +46,26 @@
"description": "Lucene dependencies should be skipped",
"matchPackageNames": ["org.apache.lucene"],
Review
janhoy commented on code in PR #2394:
URL: https://github.com/apache/solr/pull/2394#discussion_r1559202905
##
.github/renovate.json:
##
@@ -46,6 +46,26 @@
"description": "Lucene dependencies should be skipped",
"matchPackageNames": ["org.apache.lucene"],
Review
67 matches
Mail list logo
