dsmiley commented on code in PR #2402:
URL: https://github.com/apache/solr/pull/2402#discussion_r156203
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientTest.java:
##
@@ -51,4 +67,249 @@ public void
dsmiley commented on code in PR #2402:
URL: https://github.com/apache/solr/pull/2402#discussion_r1562016978
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -417,67 +419,101 @@ public void send(OutStream outStream, SolrRequest
req, String
[
https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836390#comment-17836390
]
Matthew Biscocho commented on SOLR-10654:
-
Thanks for the info, [~dsmiley]! Actually came back to
dsmiley commented on code in PR #2349:
URL: https://github.com/apache/solr/pull/2349#discussion_r1561834394
##
solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java:
##
@@ -302,6 +294,53 @@ private boolean closeCacheValue(CacheValue cacheValue) {
return cl;
dsmiley commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-2050682221
Although I haven't looked at this in as much detail as others, I find
Michael's arguments persuasive and would prefer we do #2349 instead.
--
This is an automated message from the Apache
dsmiley merged PR #2364:
URL: https://github.com/apache/solr/pull/2364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on PR #2364:
URL: https://github.com/apache/solr/pull/2364#issuecomment-2050664409
Thanks Radu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dsmiley commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1561815614
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -384,6 +384,9 @@ private static NodeConfig
fillSolrSection(NodeConfig.NodeConfigBuilder builder,
[
https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836368#comment-17836368
]
David Smiley commented on SOLR-10654:
-
Cool to see [your PR|https://github.com/apache/solr/pull/2375]
dsmiley commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1561775883
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+
dsmiley commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1561769753
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+
[
https://issues.apache.org/jira/browse/SOLR-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836360#comment-17836360
]
David Smiley commented on SOLR-8393:
What about Solr's metrics API; has that been explored as a
igiguere commented on PR #1638:
URL: https://github.com/apache/solr/pull/1638#issuecomment-2050511702
@gerlowskija
> Does `size-estimator-lucene-solr.xls` actually work for folks? Do you use
it regularly @igiguere ? Have you found it to be pretty accurate? Any other
folks have
jdyer1 opened a new pull request, #2402:
URL: https://github.com/apache/solr/pull/2402
This adds a standard `CompletableFuture`-based API to `Http2SolrClient`,
`HttpJdkSolrClient` and `LBHttp2SolrClient`. The existing methods `asyncReq`
are marked `@deprecated` and defer to the new API
gerlowskija commented on PR #1638:
URL: https://github.com/apache/solr/pull/1638#issuecomment-2050163434
About to take a look at the code and see if I can help with the v2 side of
things, but before I dive into that I figured it was worth asking:
Does `size-estimator-lucene-solr.xls`
dsmiley commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2050095834
I don't like the complexity in this URP relating to tolerance of where the
URP is placed in the chain; I'd feel better if the URP were simplified from
that concern and we expect the user to
epugh commented on code in PR #2400:
URL: https://github.com/apache/solr/pull/2400#discussion_r1561301167
##
solr/core/src/java/org/apache/solr/util/IndexOutputOutputStream.java:
##
@@ -20,11 +20,12 @@
import java.io.OutputStream;
import org.apache.lucene.store.IndexOutput;
bruno-roustant commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2050033287
Renamed. It was used only in two internal locations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
epugh commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2050014227
The name "IndexOutputOutputStream", while slightly funny, is fine, with just
a bit of docs to highlight what you said "wrap an IndexOutput to expose it as
an OutputStream" would have helped
dsmiley commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2049990316
Lets rename this in main; separate no-JIRA PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bruno-roustant commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2049987103
I think PropertiesOutputStream could be renamed IndexOutputOutputStream
because it is used to wrap an IndexOutput to expose it as an OutputStream.
I can add some JavaDoc. Do you
mariemat commented on code in PR #2111:
URL: https://github.com/apache/solr/pull/2111#discussion_r1561202416
##
solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java:
##
@@ -144,10 +144,14 @@ public SubResponseAccumulatingJerseyResponse
gerlowskija commented on PR #2395:
URL: https://github.com/apache/solr/pull/2395#issuecomment-2049901831
> Sorry if I rained on your parade, attempting to get this in by EOW.
Oh no worries; there's no particular rush. That was just how long I was
planning to wait if no one commented
dsmiley commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-2049895628
I figure that's somewhat pseudocode... so I don't want to over-critique that
but it should have the XOR of the boundary long in-between each `arraycopy`.
In practice you will likely loop
epugh commented on PR #2400:
URL: https://github.com/apache/solr/pull/2400#issuecomment-2049846868
Some JavaDocs on this class would be nice.. I looked at it, and I still
don't quite grok why it is needed for a properties file?
--
This is an automated message from the Apache Git
cpoerschke merged PR #2401:
URL: https://github.com/apache/solr/pull/2401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cpoerschke commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-2049819054
> Yes I mean _the_ FixedBitSet (otherwise I just would have said a bit set).
No I don't know of similar code doing this, and I don't expect it's in
Lucene/Solr already. Lucene is very
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1560999237
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
gerlowskija commented on code in PR #2395:
URL: https://github.com/apache/solr/pull/2395#discussion_r1561009284
##
solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessorFactory.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache
alessandrobenedetti commented on PR #2358:
URL: https://github.com/apache/solr/pull/2358#issuecomment-2049618343
> I glossed over this while simultaneously glossing over the branch_9x
commit to see that you when to the same source files and made similar-ish
looking changes. You did. In the
dsmiley commented on PR #2358:
URL: https://github.com/apache/solr/pull/2358#issuecomment-2049611339
I glossed over this while simultaneously glossing over the branch_9x commit
to see that you when to the same source files and made similar-ish looking
changes. You did. In the branch_9x
cpoerschke commented on PR #2266:
URL: https://github.com/apache/solr/pull/2266#issuecomment-2049418174
> ... We have #2049 pending to upgrade to the latter.
That's merged now. So tentatively requested rebase and will tentatively mark
as ready-to-review then.
--
This is an
cpoerschke commented on PR #2047:
URL: https://github.com/apache/solr/pull/2047#issuecomment-2049412817
Similar to #1821 i.e. blocked on JDK 17+ -- if I find a third solrbot PR
like it I'll create a JIRA and then close out these in favour of that.
cpoerschke commented on PR #1821:
URL: https://github.com/apache/solr/pull/1821#issuecomment-2049409176
Wondering if we'd like to
* close this,
* create a JIRA for manual upgrade later and
* exclude from solrbot trying again
* (and then the exclusion would be removed as part of
cpoerschke opened a new pull request, #2401:
URL: https://github.com/apache/solr/pull/2401
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
alessandrobenedetti commented on PR #2358:
URL: https://github.com/apache/solr/pull/2358#issuecomment-2049310875
Adding @dsmiley as a reviewer as I noticed some work in the same area back
then:
https://github.com/apache/lucene-solr/pull/1726/files
The rationale behind this
bruno-roustant opened a new pull request, #2400:
URL: https://github.com/apache/solr/pull/2400
https://issues.apache.org/jira/browse/SOLR-17232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Bruno Roustant created SOLR-17232:
-
Summary: PropertiesOutputStream does not override write(byte[],
int, int)
Key: SOLR-17232
URL: https://issues.apache.org/jira/browse/SOLR-17232
Project: Solr
38 matches
Mail list logo
