Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-24 Thread via GitHub
dsmiley commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1578800441 ## solr/core/src/java/org/apache/solr/response/transform/SubQueryAugmenterFactory.java: ## @@ -340,7 +346,9 @@ public void transform(SolrDocument doc, int docid) {

[jira] [Commented] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2024-04-24 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840607#comment-17840607 ] Rudi Seitz commented on SOLR-12813: --- Yes, this issue is about BasicAuthPlugin, configured similarly to

[jira] [Commented] (SOLR-17255) ClientUtils.encodeLocalParamVal doesn't work with param refs, breaks SolrParams.toLocalParamsString

2024-04-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840584#comment-17840584 ] Chris M. Hostetter commented on SOLR-17255: --- Thinking about it more:

[jira] [Commented] (SOLR-17255) ClientUtils.encodeLocalParamVal doesn't work with param refs, breaks SolrParams.toLocalParamsString

2024-04-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840583#comment-17840583 ] Chris M. Hostetter commented on SOLR-17255: --- I think you added 

Re: [PR] Improving array list and map init [solr]

2024-04-24 Thread via GitHub
dsmiley commented on code in PR #2197: URL: https://github.com/apache/solr/pull/2197#discussion_r1578530904 ## solr/core/src/java/org/apache/solr/handler/component/SearchComponent.java: ## @@ -111,21 +109,16 @@ public void initializeMetrics(SolrMetricsContext parentContext,

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-24 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1578527066 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1878,7 +1870,6 @@ private int fetchPackets(FastInputStream fis) throws Exception {

Re: [PR] SOLR-17099: snitch does not return spurious tags [solr]

2024-04-24 Thread via GitHub
dsmiley commented on code in PR #2278: URL: https://github.com/apache/solr/pull/2278#discussion_r1578520404 ## solr/CHANGES.txt: ## @@ -103,6 +103,7 @@ Optimizations * GITHUB#2217: Scale to 10K+ collections better in ZkStateReader.refreshCollectionsList (David Smiley) +*

[jira] [Commented] (SOLR-17255) ClientUtils.encodeLocalParamVal doesn't work with param refs, breaks SolrParams.toLocalParamsString

2024-04-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840578#comment-17840578 ] David Smiley commented on SOLR-17255: - Ouch; good catch! I recall writing that a long time ago. >

Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-24 Thread via GitHub
dsmiley commented on PR #2414: URL: https://github.com/apache/solr/pull/2414#issuecomment-2075826049 I think as long as QueryRequest continues to have a getBasePath, there is probably a fundamental conceptual issue with some clients supporting it and some not; it doesn't feel well placed

[jira] [Comment Edited] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2024-04-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840566#comment-17840566 ] David Smiley edited comment on SOLR-12813 at 4/24/24 8:23 PM: -- When using

[jira] [Commented] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2024-04-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840566#comment-17840566 ] David Smiley commented on SOLR-12813: - When using basic auth, is this a reference to BasicAuthPlugin,

Re: [PR] SOLR-16833: Add blog to Solr website [solr-site]

2024-04-24 Thread via GitHub
gerlowskija commented on PR #97: URL: https://github.com/apache/solr-site/pull/97#issuecomment-2075748899 Alright, it took me longer than expected to get the first few posts written, but I finally have those done. As things stand right now, when we merge this we'll launch with two posts:

[jira] [Closed] (SOLR-16044) SlowRequest logging disabled if SolrCore logger set to ERROR

2024-04-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl closed SOLR-16044. -- > SlowRequest logging disabled if SolrCore logger set to ERROR >

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-24 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1578420780 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

[jira] [Created] (SOLR-17255) ClientUtils.encodeLocalParamVal doesn't work with param refs, breaks SolrParams.toLocalParamsString

2024-04-24 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-17255: - Summary: ClientUtils.encodeLocalParamVal doesn't work with param refs, breaks SolrParams.toLocalParamsString Key: SOLR-17255 URL:

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-24 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1578213178 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateProcessorFactory.java: ## @@ -0,0 +1,56 @@ +/* + * + * * Licensed to the Apache Software

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-24 Thread via GitHub
laminelam commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2075351191 > I am most concerned about the SolrClassLoader proliferation in a bunch of other classes. Can you please explain/justify this? In the context if this

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-24 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1578173456 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-24 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1578119949 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-24 Thread via GitHub
dsmiley commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2075257179 I am most concerned about the SolrClassLoader proliferation in a bunch of other classes. Can you please explain/justify this? -- This is an automated message from the Apache Git Service.

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-24 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1578054464 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateProcessorFactory.java: ## @@ -0,0 +1,56 @@ +/* + * + * * Licensed to the Apache Software

Re: [I] adding automountServiceAccountToken [solr-operator]

2024-04-24 Thread via GitHub
jojay commented on issue #701: URL: https://github.com/apache/solr-operator/issues/701#issuecomment-2075123054 BTW: This is the finding in Azure Defender: "Kubernetes clusters should disable automounting API credentials There are multiple ways to opt out of automounting API credentials

[I] adding automountServiceAccountToken [solr-operator]

2024-04-24 Thread via GitHub
jojay opened a new issue, #701: URL: https://github.com/apache/solr-operator/issues/701 Hi, is there an option to set in kind: SolrCloud somehow `automountServiceAccountToken = false` ? This will solve a security recommendation in AKS. So in STS (below the SolrCloud installed with

[jira] [Updated] (SOLR-16044) SlowRequest logging disabled if SolrCore logger set to ERROR

2024-04-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16044: --- Status: Resolved (was: Closed) > SlowRequest logging disabled if SolrCore logger set to ERROR >

[jira] [Resolved] (SOLR-14607) LTR Query, timeAllowed parameter causes a timeout exception with no result

2024-04-24 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti resolved SOLR-14607. - Fix Version/s: main (10.0) 9.6 Resolution: Fixed > LTR

[jira] [Commented] (SOLR-14607) LTR Query, timeAllowed parameter causes a timeout exception with no result

2024-04-24 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840328#comment-17840328 ] Alessandro Benedetti commented on SOLR-14607: - This should be fixed in 9.6 thorugh this:

[jira] [Comment Edited] (SOLR-14607) LTR Query, timeAllowed parameter causes a timeout exception with no result

2024-04-24 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840328#comment-17840328 ] Alessandro Benedetti edited comment on SOLR-14607 at 4/24/24 8:13 AM: