Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-25 Thread via GitHub
dsmiley closed pull request #2414: SOLR-17243: CloudSolrClient support for req.getBasePath URL: https://github.com/apache/solr/pull/2414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SOLR-16974) Global Circuit Breakers

2024-04-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841005#comment-17841005 ] Jan Høydahl commented on SOLR-16974: Seems like a potential for optimization, please open another

[jira] [Updated] (SOLR-14675) CloudSolrClient requestAsync API

2024-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14675: Summary: CloudSolrClient requestAsync API (was: [SolrJ] Http2SolrClient async request through

[jira] [Updated] (SOLR-14675) [SolrJ] Http2SolrClient async request through CloudHttp2SolrClient

2024-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14675: Affects Version/s: (was: 8.7) > [SolrJ] Http2SolrClient async request through

[jira] [Commented] (SOLR-14675) [SolrJ] Http2SolrClient async request through CloudHttp2SolrClient

2024-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840998#comment-17840998 ] David Smiley commented on SOLR-14675: - Now that SOLR-14763 (async API refactoring of Http2SolrClient)

[jira] [Updated] (SOLR-14675) [SolrJ] Http2SolrClient async request through CloudHttp2SolrClient

2024-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14675: Priority: Major (was: Minor) > [SolrJ] Http2SolrClient async request through CloudHttp2SolrClient

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-25 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1580195804 ## solr/core/src/java/org/apache/solr/response/transform/SubQueryAugmenterFactory.java: ## @@ -340,7 +346,9 @@ public void transform(SolrDocument doc, int docid) {

[jira] [Updated] (SOLR-14763) SolrJ Client Async HTTP/2 Requests

2024-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14763: Description: In SOLR-14354, [~caomanhdat] created an API to use Jetty async API to make more

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-25 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1580121540 ## solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java: ## @@ -252,7 +260,11 @@ private SolrQueryRequest buildRequestFrom( new

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-25 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1580121540 ## solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java: ## @@ -252,7 +260,11 @@ private SolrQueryRequest buildRequestFrom( new

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-25 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1580121540 ## solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java: ## @@ -252,7 +260,11 @@ private SolrQueryRequest buildRequestFrom( new

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-25 Thread via GitHub
kotman12 commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2078142747 > So I was trying to learn how the main configuration bits fit together here and high-level the reverse search idea and my _solr-monitor-naive-dinner-demo_ branch (or #2421 diff) off this

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-25 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1578173456 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-25 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1579968386 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-25 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1579968386 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-04-25 Thread via GitHub
dsmiley commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-2077904166 This is an important initiative. If you've given up on it @risdenk, let us know so someone can take over. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SOLR-17247: Fix bug - 'WWW-Authenticate' headers missing in MultiAuthPlugin [solr]

2024-04-25 Thread via GitHub
laminelam commented on PR #2416: URL: https://github.com/apache/solr/pull/2416#issuecomment-2077823343 Hi @janhoy If you have some time, would you please take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] SOLR-4587: solr-monitor-naive-dinner-demo [solr]

2024-04-25 Thread via GitHub
cpoerschke closed pull request #2421: SOLR-4587: solr-monitor-naive-dinner-demo URL: https://github.com/apache/solr/pull/2421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-25 Thread via GitHub
cpoerschke commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2077786562 So I was trying to learn how the main configuration bits fit together here and high-level the reverse search idea and my _solr-monitor-naive-dinner-demo_ branch (or #link-to-follow

[jira] [Commented] (SOLR-16974) Global Circuit Breakers

2024-04-25 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840872#comment-17840872 ] Ilan Ginzburg commented on SOLR-16974: -- Looking at the [SolrCore constructor

Re: [I] Update the default solr.xml to include maxBooleanClauses [solr-operator]

2024-04-25 Thread via GitHub
coolstim closed issue #526: Update the default solr.xml to include maxBooleanClauses URL: https://github.com/apache/solr-operator/issues/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Update the default solr.xml to include maxBooleanClauses [solr-operator]

2024-04-25 Thread via GitHub
coolstim commented on issue #526: URL: https://github.com/apache/solr-operator/issues/526#issuecomment-2077507752 issue is solved in https://github.com/apache/solr-operator/issues/630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-25 Thread via GitHub
dsmiley commented on PR #2414: URL: https://github.com/apache/solr/pull/2414#issuecomment-2077367304 As I said in my last comment, I'd prefer to abandon QueryRequest.getBasePath and setBasePath. https://issues.apache.org/jira/browse/SOLR-17256 It'd still be nice to expose an

[jira] [Resolved] (SOLR-17243) CloudSolrClient should support SolrRequest.getBasePath (a URL)

2024-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17243. - Resolution: Won't Fix > CloudSolrClient should support SolrRequest.getBasePath (a URL) >

[PR] Avoid instantiating NodeStateProvider several times when computing replica placement [solr]

2024-04-25 Thread via GitHub
ycallea opened a new pull request, #2420: URL: https://github.com/apache/solr/pull/2420 https://issues.apache.org/jira/browse/SOLR-X # Description When using either the Minimize Cores or the Affinity placement strategy with Solr 9, positioning a new replica

Re: [PR] SOLR-17243: CloudSolrClient support for req.getBasePath [solr]

2024-04-25 Thread via GitHub
gerlowskija commented on PR #2414: URL: https://github.com/apache/solr/pull/2414#issuecomment-2077004881 > I forgot to share I have the same concern. But I'd like a convenience method like CloudHttpSolrClient.getHttpSolrClient(String url). How does that sound? Ah, glad it's not just

Re: [PR] Improving array list and map init [solr]

2024-04-25 Thread via GitHub
renatoh commented on PR #2197: URL: https://github.com/apache/solr/pull/2197#issuecomment-2076445977 @dsmiley Thanks for picking this up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the