[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933649#comment-15933649
]
Sebb commented on COLLECTIONS-601:
--
Does not fail on Jenkins:
Github user Tomschi commented on the issue:
https://github.com/apache/commons-lang/pull/231
I'm not sure, if we really need the isXXX methods in the Processor class,
because i can directly equal the enums.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/NET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated NET-584:
-
Summary: Error when using org.apache.commons.net.ftp.FTPClient
setControlKeepAliveTimeout (was: Error with
[
https://issues.apache.org/jira/browse/NET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved NET-584.
--
Resolution: Fixed
Fix Version/s: 3.7
Thanks for confirming the fix has worked and the help in testing the issue.
[
https://issues.apache.org/jira/browse/EMAIL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933898#comment-15933898
]
Sebb commented on EMAIL-138:
Associated commit:
URL:
http://svn.apache.org/r1592866
Log: [EMAIL-138] Filenames
[
https://issues.apache.org/jira/browse/EMAIL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb reopened EMAIL-138:
AFAICT, the filename should not be encoded by Commons Email.
See the Javadoc for MimeBodyPart#setFileName(String) [1]
[
https://issues.apache.org/jira/browse/LANG-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pascal Schumacher updated LANG-1124:
Assignee: (was: Loic Guibert)
> Add split by length methods in StringUtils
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: (was: commons-collections.java7.build.log)
> commons-collections
Github user sebbASF commented on the issue:
https://github.com/apache/commons-lang/pull/231
Agreed it's not necessary to have the isXXX methods.
However it makes the user code shorter and simpler.
Currently the code is:
```
Processor processor =
[
https://issues.apache.org/jira/browse/FILEUPLOAD-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932497#comment-15932497
]
Dmitry Katsubo commented on FILEUPLOAD-254:
---
I vote for this improvement. I think the issue
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/231
[](https://coveralls.io/builds/10673667)
Coverage increased (+0.02%) to 94.589% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/231
[](https://coveralls.io/builds/10673667)
Coverage increased (+0.02%) to 94.589% when pulling
Github user sebbASF commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/231#discussion_r106870483
--- Diff: src/test/java/org/apache/commons/lang3/ArchUtilsTest.java ---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: commons-collections.java8.build.log
Unsuccessful build with Java 8
Github user sebbASF commented on the issue:
https://github.com/apache/commons-lang/pull/231
Also it occurs to me that ProcessorArch and ProcessorType could perhaps be
subtypes of Processor (Arch and Type). They don't really have an independent
existence, so do they need separate
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: commons-collections.java7.build.log
> commons-collections unit tests
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: commons-collections.java8.build.log
> commons-collections unit tests
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: (was: commons-collections.java8.build.log)
> commons-collections
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Comment: was deleted
(was: Unsuccessful build with Java 8)
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: commons-collections.java7.build.log
[
https://issues.apache.org/jira/browse/COLLECTIONS-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allon Mureinik updated COLLECTIONS-601:
---
Attachment: (was: commons-collections.java8.build.log)
> commons-collections
Allon Mureinik created COLLECTIONS-601:
--
Summary: commons-collections unit tests broken in Java 8
Key: COLLECTIONS-601
URL: https://issues.apache.org/jira/browse/COLLECTIONS-601
Project: Commons
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/253
Hi @esend7881
thanks for the pull request.
I'm not sure it is a good idea to add at method that is nearly identical to
`StopWatch#createStarted`.
---
If your
Github user esend7881 commented on the issue:
https://github.com/apache/commons-lang/pull/253
@PascalSchumacher good point. I would say the main advantage is my method
would not have the JVM re-create an object. So if you are restarting the timer
over and over, it may be less costly.
24 matches
Mail list logo
