[
https://issues.apache.org/jira/browse/TEXT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968003#comment-15968003
]
Amey Jadiye commented on TEXT-25:
-
Cool, i'm started working on this new features, will keep you posted.
btw,
[
https://issues.apache.org/jira/browse/TEXT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966464#comment-15966464
]
Amey Jadiye commented on TEXT-25:
-
Hi [~kinow]
Is this merged to TEXT code ? if not let me know show stopper
[
https://issues.apache.org/jira/browse/TEXT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968003#comment-15968003
]
Amey Jadiye edited comment on TEXT-25 at 4/14/17 8:24 PM:
--
Cool, i'm starting work
[
https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078527#comment-16078527
]
Amey Jadiye commented on TEXT-97:
-
In that case we have {{.selectFrom()}} API, All I'm expecting is to have
[
https://issues.apache.org/jira/browse/TEXT-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086076#comment-16086076
]
Amey Jadiye commented on TEXT-47:
-
I don't see even java have solution for this ? can we just create map and
[
https://issues.apache.org/jira/browse/DAEMON-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079695#comment-16079695
]
Amey Jadiye commented on DAEMON-370:
[~garydgregory], never mind, moved them to developer section, plz
[
https://issues.apache.org/jira/browse/DAEMON-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079690#comment-16079690
]
Amey Jadiye commented on DAEMON-370:
Hi [~garydgregory],
Almost all authors are present in pom.xml
[
https://issues.apache.org/jira/browse/DAEMON-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079713#comment-16079713
]
Amey Jadiye commented on DAEMON-370:
actually I found Pier In ASF member list so places him in
Amey Jadiye created DAEMON-370:
--
Summary: Remove all the @author tags as per guidelines.
Key: DAEMON-370
URL: https://issues.apache.org/jira/browse/DAEMON-370
Project: Commons Daemon
Issue
Amey Jadiye created DAEMON-369:
--
Summary: Fix and improve general stuff around processes and
quality.
Key: DAEMON-369
URL: https://issues.apache.org/jira/browse/DAEMON-369
Project: Commons Daemon
[
https://issues.apache.org/jira/browse/DAEMON-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye closed DAEMON-370.
--
Code Merged to Repository.
> Move attributions from @author in Javadocs to POM
>
[
https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079025#comment-16079025
]
Amey Jadiye commented on TEXT-96:
-
[~greenth] Thinking of adding some simple and easy to use tools/methods in
Amey Jadiye created NUMBERS-47:
--
Summary: Rename LanczosApproximation.java relative to what exactly
its doing.
Key: NUMBERS-47
URL: https://issues.apache.org/jira/browse/NUMBERS-47
Project: Commons
[
https://issues.apache.org/jira/browse/TEXT-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093415#comment-16093415
]
Amey Jadiye commented on TEXT-79:
-
[~kinow], can you please check above links if they are possible usecases
[
https://issues.apache.org/jira/browse/TEXT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095134#comment-16095134
]
Amey Jadiye commented on TEXT-74:
-
found the bug, you owe me a treat ! [~arendvr.com] ;) . give me some time
[
https://issues.apache.org/jira/browse/TEXT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095134#comment-16095134
]
Amey Jadiye edited comment on TEXT-74 at 7/20/17 6:13 PM:
--
found the bug, you owe me
[
https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070339#comment-16070339
]
Amey Jadiye commented on TEXT-96:
-
{{RandomStringGenerator}} is certainly better and flexible in terms of
[
https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070462#comment-16070462
]
Amey Jadiye commented on TEXT-96:
-
*Yes*, For scope of this JIRA I strongly believe that. what Mr. [~greenth]
[
https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070970#comment-16070970
]
Amey Jadiye commented on TEXT-96:
-
I want to keep both, i dont see any harm in that :)
> Convenience methods
[
https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye updated TEXT-97:
Fix Version/s: 1.2
> RandomStringGenerator should be able to pass multiple ranges to .withinRange()
>
Amey Jadiye created TEXT-97:
---
Summary: RandomStringGenerator should be able to pass multiple
ranges to .withinRange()
Key: TEXT-97
URL: https://issues.apache.org/jira/browse/TEXT-97
Project: Commons Text
[
https://issues.apache.org/jira/browse/TEXT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071290#comment-16071290
]
Amey Jadiye commented on TEXT-96:
-
I have submitted PR for accepting multiple pairs, now the questions is can
[
https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071334#comment-16071334
]
Amey Jadiye commented on TEXT-97:
-
Hi,
Primary motivation to write this method was to have single API which
[
https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071366#comment-16071366
]
Amey Jadiye commented on TEXT-97:
-
Agree, usual use cases are numeric, alphabetic and alphanumeric and we can
[
https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071550#comment-16071550
]
Amey Jadiye commented on TEXT-97:
-
Hmm, lets have extra opinions.
[~chtompki], [~britter],
[
https://issues.apache.org/jira/browse/TEXT-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065269#comment-16065269
]
Amey Jadiye commented on TEXT-79:
-
some of the possible use cases.
*
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074754#comment-16074754
]
Amey Jadiye commented on NUMBERS-38:
Sounds good! Thanks [~erans]
> No unit tests for
[
https://issues.apache.org/jira/browse/TEXT-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993517#comment-15993517
]
Amey Jadiye commented on TEXT-55:
-
pushing this back to master for release 1.1
> Move WordUtils off on to
[
https://issues.apache.org/jira/browse/TEXT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995402#comment-15995402
]
Amey Jadiye commented on TEXT-39:
-
Hi Folks,
this jira is marked for 1.1 release, any update on this ?
[
https://issues.apache.org/jira/browse/TEXT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995505#comment-15995505
]
Amey Jadiye commented on TEXT-41:
-
Hi All,
This was pending since long (2012), created pull request based on
[
https://issues.apache.org/jira/browse/TEXT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995522#comment-15995522
]
Amey Jadiye commented on TEXT-39:
-
Thanks [~pascalschumacher] for confirmation, working on it.
> WordUtils
[
https://issues.apache.org/jira/browse/TEXT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006816#comment-16006816
]
Amey Jadiye commented on TEXT-25:
-
[~kinow], i'm braking the task in smaller parts here, lets start with
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006855#comment-16006855
]
Amey Jadiye commented on NUMBERS-37:
I like the idea also If you want to modularize the things in
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006855#comment-16006855
]
Amey Jadiye edited comment on NUMBERS-37 at 5/11/17 5:38 PM:
-
I like the idea
[
https://issues.apache.org/jira/browse/TEXT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002966#comment-16002966
]
Amey Jadiye commented on TEXT-41:
-
Hi [~chtompki], as PR already merged can we mark this to resolved ?
>
[
https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye updated NUMBERS-37:
---
Comment: was deleted
(was: I like the idea also If you want to modularize the things in commons
[
https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046828#comment-16046828
]
Amey Jadiye commented on TEXT-88:
-
agreed, its a obvious bug looking at code.
{code:java}
public static
Amey Jadiye created LANG-1340:
-
Summary: Add IBM Java 8 CI checks for Commons Lang
Key: LANG-1340
URL: https://issues.apache.org/jira/browse/LANG-1340
Project: Commons Lang
Issue Type:
[
https://issues.apache.org/jira/browse/TEXT-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058078#comment-16058078
]
Amey Jadiye commented on TEXT-79:
-
Hi [~kinow] Lucene don't use the string search algorithms, how it works
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059748#comment-16059748
]
Amey Jadiye commented on TEXT-93:
-
Hi [~pascalschumacher]
Though your code is generating expected output
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060473#comment-16060473
]
Amey Jadiye commented on TEXT-93:
-
Agreed with name change.
For suggested varargs we should have one more
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061412#comment-16061412
]
Amey Jadiye commented on TEXT-93:
-
Committed all the changes we discussed to PR.
> RandomStringGenerator
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061773#comment-16061773
]
Amey Jadiye commented on TEXT-93:
-
Hi Gilles,
That method is removed all together as per previous
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061880#comment-16061880
]
Amey Jadiye commented on TEXT-93:
-
Well, Yes nowadays programmers prefer List over arrays and it's convineant
[
https://issues.apache.org/jira/browse/TEXT-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye updated TEXT-83:
Description: Deprecate CsvTranslators from from commons text in favor of
Commons CSV
> Deprecate
Amey Jadiye created TEXT-83:
---
Summary: Deprecate CsvTranslators from from commons text in favor
of Commons CSV
Key: TEXT-83
URL: https://issues.apache.org/jira/browse/TEXT-83
Project: Commons Text
[
https://issues.apache.org/jira/browse/TEXT-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022969#comment-16022969
]
Amey Jadiye commented on TEXT-83:
-
[~ggregory] [~chtompki], shall we move CsvTranslators to Commons CSV as
[
https://issues.apache.org/jira/browse/TEXT-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026594#comment-16026594
]
Amey Jadiye commented on TEXT-77:
-
I think StringUtils would be better place for this method, good to have
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036031#comment-16036031
]
Amey Jadiye commented on NUMBERS-38:
Ah, got it. will put some coverage around that, Thanks.
> No
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035990#comment-16035990
]
Amey Jadiye commented on NUMBERS-38:
Hi,
I can see one test class here, do we expect more test cases
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036041#comment-16036041
]
Amey Jadiye commented on NUMBERS-38:
PR is raised, please have a look
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036254#comment-16036254
]
Amey Jadiye commented on NUMBERS-38:
Hi [~erans]
My initial thoughts was the formula given in code
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036264#comment-16036264
]
Amey Jadiye commented on NUMBERS-38:
Hi [~erans],
I think all that you copied from commons math is
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036289#comment-16036289
]
Amey Jadiye commented on NUMBERS-38:
bq. I'm now confused as to what the problem is.
Sorry for
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye updated NUMBERS-38:
---
Attachment: NUMBERS-38.patch
> No unit tests for "LanczosApproximation" class
>
[
https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048329#comment-16048329
]
Amey Jadiye commented on NUMBERS-43:
here.
{code}
public static float round(float x, int scale, int
[
https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048366#comment-16048366
]
Amey Jadiye commented on TEXT-88:
-
[~s...@apache.org] +1 , will push those fix to same PR.
>
[
https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048297#comment-16048297
]
Amey Jadiye commented on NUMBERS-43:
Ah, didn't know we have overloaded method for same, just saw the
Amey Jadiye created NUMBERS-44:
--
Summary: IndexOutOfRangeException(int) not thrown in ComplexUtils
Key: NUMBERS-44
URL: https://issues.apache.org/jira/browse/NUMBERS-44
Project: Commons Numbers
[
https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050853#comment-16050853
]
Amey Jadiye commented on TEXT-88:
-
Hmm, we can arrange code so behaviour will desired for those 2-3 methods
[
https://issues.apache.org/jira/browse/TEXT-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045670#comment-16045670
]
Amey Jadiye commented on TEXT-83:
-
any suggestion and action we should go with ?, I just made documentation
[
https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048828#comment-16048828
]
Amey Jadiye commented on TEXT-88:
-
[~gilles] the behavior you are looking as bug , I see it as feature ;-),
[
https://issues.apache.org/jira/browse/NUMBERS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048123#comment-16048123
]
Amey Jadiye commented on NUMBERS-43:
In financial institutes sometimes we might want to round of
[
https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048828#comment-16048828
]
Amey Jadiye edited comment on TEXT-88 at 6/14/17 9:26 AM:
--
[~erans] the behavior
[
https://issues.apache.org/jira/browse/TEXT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048107#comment-16048107
]
Amey Jadiye commented on TEXT-88:
-
Hi [~arunvinud],
I think the output passing nothing *or* null *or* empty
[
https://issues.apache.org/jira/browse/TEXT-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998903#comment-15998903
]
Amey Jadiye commented on TEXT-39:
-
[~pascalschumacher], I have submitted PR please verify
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037408#comment-16037408
]
Amey Jadiye commented on NUMBERS-38:
Hi [~erans]
bq. It is still not clear to me what is the benefit
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036254#comment-16036254
]
Amey Jadiye edited comment on NUMBERS-38 at 6/5/17 7:02 PM:
Hi [~erans]
My
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039506#comment-16039506
]
Amey Jadiye commented on NUMBERS-38:
Hello [~erans],
I have submitted code for your review, now
[
https://issues.apache.org/jira/browse/LANG-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye closed LANG-1340.
-
Resolution: Unresolved
> Add IBM Java 8 CI checks for Commons Lang
>
[
https://issues.apache.org/jira/browse/TEXT-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye closed TEXT-101.
Resolution: Won't Do
> Move RandomStringUtils to Commons-text
> --
>
>
Amey Jadiye created TEXT-101:
Summary: Move RandomStringUtils to Commons-text
Key: TEXT-101
URL: https://issues.apache.org/jira/browse/TEXT-101
Project: Commons Text
Issue Type: Task
[
https://issues.apache.org/jira/browse/TEXT-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye updated TEXT-101:
-
Fix Version/s: 1.2
> Move RandomStringUtils to Commons-text
> --
>
>
[
https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275413#comment-16275413
]
Amey Jadiye commented on NUMBERS-50:
I'm sorry for being not descriptive, the only issues I found was
[
https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276012#comment-16276012
]
Amey Jadiye commented on NUMBERS-50:
bq. Do you mean in directory commons-numbers-complex/target?
[
https://issues.apache.org/jira/browse/NUMBERS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302320#comment-16302320
]
Amey Jadiye commented on NUMBERS-50:
bq. No, but it is not necessary to explicitly "suppress" it since
[
https://issues.apache.org/jira/browse/SANDBOX-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amey Jadiye updated SANDBOX-509:
Issue Type: Improvement (was: Bug)
> Convert commons-graph Multi Module Maven Project
>
[
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134820#comment-17134820
]
Amey Jadiye commented on SANDBOX-510:
-
I have tried fixing it with PRĀ
[
https://issues.apache.org/jira/browse/SANDBOX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134838#comment-17134838
]
Amey Jadiye commented on SANDBOX-510:
-
{quote}
The error in testSudoku disappears when changing this
[
https://issues.apache.org/jira/browse/SANDBOX-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134848#comment-17134848
]
Amey Jadiye commented on SANDBOX-509:
-
[~erans], I have this Jira already created for
80 matches
Mail list logo