garydgregory commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310172501
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
garydgregory merged PR #348:
URL: https://github.com/apache/commons-csv/pull/348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michael-o commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310208954
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
garydgregory commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310162041
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
gbidsilva commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310163383
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
gbidsilva commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310163383
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
michael-o commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310158527
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
gbidsilva commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310178428
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
garydgregory commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310162041
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
garydgregory commented on code in PR #348:
URL: https://github.com/apache/commons-csv/pull/348#discussion_r1310162041
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return
garydgregory commented on PR #183:
URL: https://github.com/apache/commons-bcel/pull/183#issuecomment-1706415360
@nbauma109
Thank you for the reply and please accept my apologies for the delay, I'll
come back around to this PR this week.
--
This is an automated message from the Apache
gbidsilva commented on PR #347:
URL: https://github.com/apache/commons-csv/pull/347#issuecomment-1706553247
@garydgregory @elharo
Exception handling moved to Lexer class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313881637
##
pom.xml:
##
@@ -402,8 +402,8 @@ under the License.
${logkit:logkit:jar}
${javax.servlet:servlet-api:jar}
garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313882636
##
src/test/java/org/apache/commons/logging/pathable/ParentFirstTestCase.java:
##
@@ -145,8 +143,9 @@ public void testPaths() throws Exception {
//
Claudenw commented on PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#issuecomment-1704211915
@garydgregory @aherbert
Gentlemen,
Can I get eyes on the new code please. I think it is correct and fixes all
the previously identified issues.
--
This is
garydgregory commented on PR #157:
URL: https://github.com/apache/commons-logging/pull/157#issuecomment-1703874241
Note: the build is still broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
garydgregory commented on PR #157:
URL: https://github.com/apache/commons-logging/pull/157#issuecomment-1703919025
@SingingBush
Thank you for your work on this issue. It looks like this build was ported
from an Ant build looking at how it builds more than one jar. Normally this is
done
SingingBush commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313940535
##
pom.xml:
##
@@ -402,8 +402,8 @@ under the License.
${logkit:logkit:jar}
${javax.servlet:servlet-api:jar}
SingingBush commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313942189
##
src/test/java/org/apache/commons/logging/pathable/ParentFirstTestCase.java:
##
@@ -145,8 +143,9 @@ public void testPaths() throws Exception {
//
SingingBush commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313942534
##
src/test/java/org/apache/commons/logging/security/SecurityForbiddenTestCase.java:
##
@@ -127,8 +125,8 @@ public void testAllForbidden() {
garydgregory commented on PR #157:
URL: https://github.com/apache/commons-logging/pull/157#issuecomment-1703926085
@SingingBush
The convention is to have the version label at the end for normal code jar
files. Javadoc and source jar files can have a different convention iirc.
--
This
SingingBush commented on PR #157:
URL: https://github.com/apache/commons-logging/pull/157#issuecomment-1703910103
> Note: the build is still broken.
This is odd and frustrating, I've been able to run this locally on both Java
8 and 11
--
This is an automated message from the
kinow commented on code in PR #52:
URL: https://github.com/apache/commons-statistics/pull/52#discussion_r1316419837
##
commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/TestHelper.java:
##
@@ -48,14 +48,14 @@ static double[]
aherbert commented on code in PR #52:
URL: https://github.com/apache/commons-statistics/pull/52#discussion_r1316339953
##
commons-statistics-descriptive/src/main/java/org/apache/commons/statistics/descriptive/SumOfSquaredDeviations.java:
##
@@ -36,31 +36,25 @@
*
* Note that
darkma773r merged PR #218:
URL: https://github.com/apache/commons-geometry/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
elharo commented on code in PR #347:
URL: https://github.com/apache/commons-csv/pull/347#discussion_r1316570099
##
src/main/java/org/apache/commons/csv/Lexer.java:
##
@@ -367,8 +367,7 @@ private Token parseEncapsulatedToken(final Token token)
throws IOException {
aherbert commented on code in PR #52:
URL: https://github.com/apache/commons-statistics/pull/52#discussion_r1316500738
##
commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/TestHelper.java:
##
@@ -48,14 +48,14 @@ static double[]
aherbert commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313823514
##
.github/workflows/maven.yml:
##
@@ -35,18 +35,20 @@ jobs:
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
-
garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313825974
##
.github/workflows/maven.yml:
##
@@ -35,18 +35,20 @@ jobs:
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
-
aherbert commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313827241
##
.github/workflows/maven.yml:
##
@@ -35,18 +35,20 @@ jobs:
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
-
garydgregory commented on code in PR #221:
URL: https://github.com/apache/commons-bcel/pull/221#discussion_r1317176598
##
src/main/java/org/apache/bcel/generic/Type.java:
##
@@ -365,6 +366,24 @@ public int hashCode() {
return type ^ signature.hashCode();
}
+
gbidsilva opened a new pull request, #352:
URL: https://github.com/apache/commons-csv/pull/352
See related Jira issue: https://issues.apache.org/jira/browse/CSV-310
When we try to print CSV content using the `CSVFormat` and `CSVPrinter`, we
can ger it done with following sample code.
garydgregory merged PR #316:
URL: https://github.com/apache/commons-configuration/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jeeppler commented on code in PR #221:
URL: https://github.com/apache/commons-bcel/pull/221#discussion_r1317173715
##
src/main/java/org/apache/bcel/generic/Type.java:
##
@@ -365,6 +366,24 @@ public int hashCode() {
return type ^ signature.hashCode();
}
+
gbidsilva commented on PR #351:
URL: https://github.com/apache/commons-csv/pull/351#issuecomment-1706305851
This PR is created just for the issue discussion purposes and this is not a
merge ready PR.
In the mailing list, comments have been provided.
Closing the PR.
--
This is an
gbidsilva closed pull request #351: adding draft changes
URL: https://github.com/apache/commons-csv/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jglick opened a new pull request, #478:
URL: https://github.com/apache/commons-io/pull/478
At some point between 2.11.0 and 2.13.0, I think as of
323d376b4a934a5a6ebdc552dc923db9e267e569, there seems to have been an
incompatible change due to use of `UncheckedIOException`. I found the
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1320746730
##
src/main/java/org/apache/commons/text/cases/PascalCase.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
elharo commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-1712797585
Guava has `@Beta` for APIs they want to push but not commit to yet. Perhaps
we can add something similar?
--
This is an automated message from the Apache Git Service.
To respond to
garydgregory commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-1712802790
> Guava has `@Beta` for APIs they want to push but not commit to yet.
Perhaps we can add something similar?
This feels unwise to me and I would discourage it. Based on what
sujin0529 commented on PR #1105:
URL: https://github.com/apache/commons-lang/pull/1105#issuecomment-1712976171
Hi, @garydgregory
In this project, the guard conditioning is well done. However, there is no
guard for this function `ReadWriteLockVisitor.`. So I thought it would be
good to
woonsan commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1712962169
Hi @garydgregory ,
Yes, I think so. The Jackrabbit team believes that the Main class actually
needs to be in standalone, not standalone-components and other projects such as
sujin0529 commented on PR #1105:
URL: https://github.com/apache/commons-lang/pull/1105#issuecomment-1712973650
Hi, @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory commented on PR #1110:
URL: https://github.com/apache/commons-lang/pull/1110#issuecomment-1713731724
@a1batr0ss
Please run `mvn` -- which uses the default goal -- locally before pushing
and you'll catch build failures like what just happened.
--
This is an automated
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1713671657
Hi @woonsan
Understood. All we need is for this PR not to break the build ;-) Would you
please update this PR?
--
This is an automated message from the Apache Git Service.
ani5rudh opened a new pull request, #54:
URL: https://github.com/apache/commons-statistics/pull/54
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
garydgregory commented on PR #1105:
URL: https://github.com/apache/commons-lang/pull/1105#issuecomment-1713725280
Hello @sujin0529
>I think this error is closer to IllegalArgumentException than
NullPointerException.
I disagree: `NullPointerException` is more _precise_ than
ani5rudh commented on PR #54:
URL:
https://github.com/apache/commons-statistics/pull/54#issuecomment-1713791166
Hi @kinow,
Previously, the declaration of the abstract method `combine` in the `Mean`
class was flagged as a code smell by SonarCloud and was removed. For
uniformity, I've
haegar9766 commented on PR #182:
URL: https://github.com/apache/commons-net/pull/182#issuecomment-1714049423
@garydgregory
How could i provide a unit test for this? To test the code, the appropriate
environment is needed. In this case an MVS system with FTP server and user
datasets.
haegar9766 opened a new pull request, #182:
URL: https://github.com/apache/commons-net/pull/182
Current MVSFTPEntryParser code doesn't support all possible datasets because
some RECFM options (e.g. "FBA") are not listet in "static final String
FILE_LIST_REGEX" (see also Jira-Ticket
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1321548812
##
src/main/java/org/apache/commons/text/cases/CamelCase.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
garydgregory commented on PR #182:
URL: https://github.com/apache/commons-net/pull/182#issuecomment-1713932793
@haegar9766
Thank you for your PR. Please add unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1321548812
##
src/main/java/org/apache/commons/text/cases/CamelCase.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
aherbert commented on PR #54:
URL:
https://github.com/apache/commons-statistics/pull/54#issuecomment-1714059737
I think the changes are fine. The javadoc rendered locally are good.
You could go one step further and replace all `` with `{@code }`
elements. This is the preferred way
garydgregory merged PR #110:
URL: https://github.com/apache/commons-daemon/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #221:
URL: https://github.com/apache/commons-bcel/pull/221#discussion_r1327778949
##
src/main/java/org/apache/bcel/generic/Type.java:
##
@@ -180,7 +181,7 @@ public static String getSignature(final
java.lang.reflect.Method meth) {
garydgregory merged PR #221:
URL: https://github.com/apache/commons-bcel/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1325793444
##
src/main/java/org/apache/commons/text/cases/CamelCase.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
aherbert merged PR #54:
URL: https://github.com/apache/commons-statistics/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michaelkarnerfors commented on PR #458:
URL: https://github.com/apache/commons-text/pull/458#issuecomment-1721966419
> -1 as is:
>
> * This PR will break the build: Run `mvn` to run the default Maven goal
which in turn runs all build checks
> * Don't rewrite existing tests: It
StudentGu opened a new pull request, #418:
URL: https://github.com/apache/commons-collections/pull/418
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jkbkupczyk commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722268773
> @jkbkupczyk Would you please rebase on master?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
garydgregory commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722315752
TY @jkbkupczyk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory merged PR #173:
URL: https://github.com/apache/commons-net/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #459:
URL: https://github.com/apache/commons-text/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #169:
URL: https://github.com/apache/commons-email/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722254244
@jkbkupczyk
Would you please rebase on master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
beise commented on PR #421:
URL: https://github.com/apache/commons-vfs/pull/421#issuecomment-1722187336
@garydgregory
Thanks for the hints.
Regarding the missing TestCase:
Unfortunately I am unable to configure the started jackrabbit webdav-server
to use a content-length
jkbkupczyk commented on PR #168:
URL: https://github.com/apache/commons-net/pull/168#issuecomment-1722255070
> -1 as the PR stands today: The PR does not test anything new that isn't
already tested. Before and after this PR, the code coverage is the same at: 40%
instructions / 31%
garydgregory merged PR #423:
URL: https://github.com/apache/commons-vfs/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1722489012
@woonsan
Ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722511522
@jkbkupczyk
Still fails :
https://github.com/apache/commons-net/actions/runs/6213336399/job/16864291327
--
This is an automated message from the Apache Git Service.
To
garydgregory merged PR #424:
URL: https://github.com/apache/commons-vfs/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jkbkupczyk commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722456292
Thank you @garydgregory and @kinow for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
garydgregory merged PR #421:
URL: https://github.com/apache/commons-vfs/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722536905
> > @jkbkupczyk Still fails :
https://github.com/apache/commons-net/actions/runs/6213336399/job/16864291327
>
> Hm, I think it's because files have the same name, I will
jkbkupczyk opened a new pull request, #184:
URL: https://github.com/apache/commons-net/pull/184
This PR fixes the bug in TFTPServerPathTest introduced by #173.
More information
[here](https://github.com/apache/commons-net/pull/173#issuecomment-1722511522)
FYI @garydgregory
--
garydgregory commented on PR #184:
URL: https://github.com/apache/commons-net/pull/184#issuecomment-1722551479
Hi @jkbkupczyk
Thank you for the PR.
The failure is still there unfortunately
https://github.com/apache/commons-net/actions/runs/6215274929
--
This is an automated
jkbkupczyk commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722535528
> @jkbkupczyk Still fails :
https://github.com/apache/commons-net/actions/runs/6213336399/job/16864291327
Hm, I think it's because files have the same name, I will create a
jkbkupczyk commented on PR #173:
URL: https://github.com/apache/commons-net/pull/173#issuecomment-1722538953
> > > @jkbkupczyk Still fails :
https://github.com/apache/commons-net/actions/runs/6213336399/job/16864291327
> >
> >
> > Hm, I think it's because files have the same
garydgregory merged PR #184:
URL: https://github.com/apache/commons-net/pull/184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jkbkupczyk commented on PR #184:
URL: https://github.com/apache/commons-net/pull/184#issuecomment-1722541268
TY @garydgregory, hope this fixes the issue with builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gbidsilva opened a new pull request, #344:
URL: https://github.com/apache/commons-csv/pull/344
Adding one simple detail to make method 'setHeaderComments' doc comment much
cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
garydgregory commented on PR #344:
URL: https://github.com/apache/commons-csv/pull/344#issuecomment-1692091979
It seems to me that the get and set methods for this attribute should be
more in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message,
gwlucastrig commented on PR #311:
URL: https://github.com/apache/commons-imaging/pull/311#issuecomment-1691506762
I take it you're not going to accept this PR. So I want to give you a
"heads up". I am working on enabling Commons Imaging to read TIFF files that
contain JPEG-formatted
garydgregory commented on PR #311:
URL: https://github.com/apache/commons-imaging/pull/311#issuecomment-1691550254
@gwlucastrig
I assume you're talking to me about accepting THIS PR. I've reviewed it
again, so I can't say.
--
This is an automated message from the Apache Git Service.
gbidsilva commented on code in PR #347:
URL: https://github.com/apache/commons-csv/pull/347#discussion_r1311973714
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -438,6 +440,44 @@ public CSVParser(final Reader reader, final CSVFormat
format, final long charact
garydgregory commented on code in PR #347:
URL: https://github.com/apache/commons-csv/pull/347#discussion_r1311959935
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -765,7 +805,14 @@ CSVRecord nextRecord() throws IOException {
final long
garydgregory commented on code in PR #347:
URL: https://github.com/apache/commons-csv/pull/347#discussion_r1312125582
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -438,6 +440,44 @@ public CSVParser(final Reader reader, final CSVFormat
format, final long
xDaryamo opened a new pull request, #148:
URL: https://github.com/apache/commons-validator/pull/148
testing sonarcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xDaryamo closed pull request #148: Test
URL: https://github.com/apache/commons-validator/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #347:
URL: https://github.com/apache/commons-csv/pull/347#discussion_r1311964030
##
src/main/java/org/apache/commons/csv/CSVParser.java:
##
@@ -438,6 +440,44 @@ public CSVParser(final Reader reader, final CSVFormat
format, final long
garydgregory merged PR #409:
URL: https://github.com/apache/commons-compress/pull/409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #347:
URL: https://github.com/apache/commons-csv/pull/347#issuecomment-1699381640
I'm OK with adding the position but I am guessing someone will create a
security issue for data exfiltration.
--
This is an automated message from the Apache Git Service.
To
gbidsilva commented on PR #347:
URL: https://github.com/apache/commons-csv/pull/347#issuecomment-1699425939
@garydgregory :
That is a good point. But IMO, whenever someone log the exception, at that
point they should consider the security risks.
Isn't usually exception provide such
gbidsilva commented on PR #347:
URL: https://github.com/apache/commons-csv/pull/347#issuecomment-1702728548
@garydgregory : let us know if there is anymore change to be done in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
garydgregory merged PR #158:
URL: https://github.com/apache/commons-logging/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #301:
URL: https://github.com/apache/commons-parent/pull/301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #349:
URL: https://github.com/apache/commons-csv/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #106:
URL: https://github.com/apache/commons-daemon/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1 - 100 of 8135 matches
Mail list logo
