[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514817#comment-14514817 ] ASF GitHub Bot commented on LANG-1065: -- GitHub user jamessawle reopened a pull request: https://github.com/apache/commons-lang/pull/39 LANG-1065 Added new 'merge' method to DateUtils and three tests Added new 'merge' method as proposed in LANG-1065. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rightmove/commons-lang LANG-1065 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 111d1d9444614e55c63d389ca7d1162a707d8c7c Author: jamessawle jamessa...@hotmail.com Date: 2014-12-10T12:04:58Z LANG-1065 Added new 'merge' method to DateUtils and three tests Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Discussion Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514844#comment-14514844 ] ASF GitHub Bot commented on LANG-1065: -- Github user britter commented on the pull request: https://github.com/apache/commons-lang/pull/39#issuecomment-96796650 @jamessawle Commons Lang has been migrated from svn to git. Because of this the main branch has been renamed to 'master'. Can you please rebase your work against the master branch? Thank you! Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Discussion Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514745#comment-14514745 ] ASF GitHub Bot commented on LANG-1065: -- Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/39 Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Discussion Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485835#comment-14485835 ] Benedikt Ritter commented on LANG-1065: --- Hello [~jamessawle], it looks like you and [~pbenedict] both want this feature and [~dmjones500] and I are not convinced that it fit's into commons. How ever, you could start a discussion on the dev ML asking for more feedback about this. Maybe others thing differently then we do. If there is consensus about the usefulness of this features, I won't block adding this. Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482739#comment-14482739 ] James Sawle commented on LANG-1065: --- Hi, My answer to this is two fold: - yes I do enjoy submitting patches - however, this is something we have custom implemented in our code base and I have had to do in multiple code bases elsewhere. Whilst Java 8 and Joda Time are nice solutions to the problem, both would be to large a refactor (and my previous projects would not have been supported within the contract) I can not believe we are the only two users of the commons-lang framework who would find this useful, maybe just the only two on the Jira boards. This would aid a lot, as would split methods doing the inverse. Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328884#comment-14328884 ] Duncan Jones commented on LANG-1065: bq. We have a pull request with tests. Evidently, that means someone else wants this functionality too. Perhaps the patch submitter desperately needs this functionality himself, but perhaps he just enjoys creating patches and contributing to the community. Either way, two users interested in a feature is not proof of a general need amongst the Lang user base. We have to go with our gut on this sort of decision. Mine still says this is too specific and Lang would not benefit from its inclusion. But please feel free to present further arguments explaining why this code would be useful to more users. I think a real-life use-case would help us understand why you would use it. Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329097#comment-14329097 ] Paul Benedict commented on LANG-1065: - I don't know the average frequency of contributors on other tickets, but I think 2 people and a test is good community participation on a minor issue. Please do what you feel is best. Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259485#comment-14259485 ] Paul Benedict commented on LANG-1065: - We have a pull request with tests. Evidently, that means someone wants this functionality too. This isn't the first time I wanted this functionality and typically need this when all I have is Date objects. My vote is to include it. Until the world moves to Java 8, I prefer to stick with solutions that manipulate JDK objects. Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258800#comment-14258800 ] Benedikt Ritter commented on LANG-1065: --- To me this also feels very specific for a/your use case. The hole implementation would rely on conventions for the structure of the passed in date objects. Further more I don't think we should extend the functionality of the time package anymore. There are better alternatives (Java 8, yoda-time) for handling temporal values in Java. Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255012#comment-14255012 ] Paul Benedict commented on LANG-1065: - I do. Until Java 8 there is no time-only object so any storage is either crammed into a Date (with date fields bogus but the time fields usable) or you fallback to the JDBC types (which I don't). Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249593#comment-14249593 ] Duncan Jones commented on LANG-1065: [~pbenedict]: Do you think this use case is common enough to warrant inclusion in Lang? Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Review Patch Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LANG-1065) Merge date and time together
[ https://issues.apache.org/jira/browse/LANG-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240996#comment-14240996 ] ASF GitHub Bot commented on LANG-1065: -- GitHub user jamessawle opened a pull request: https://github.com/apache/commons-lang/pull/39 LANG-1065 Added new 'merge' method to DateUtils and three tests Added new 'merge' method as proposed in LANG-1065. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jamessawle/commons-lang LANG-1065 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 111d1d9444614e55c63d389ca7d1162a707d8c7c Author: jamessawle jamessa...@hotmail.com Date: 2014-12-10T12:04:58Z LANG-1065 Added new 'merge' method to DateUtils and three tests Merge date and time together Key: LANG-1065 URL: https://issues.apache.org/jira/browse/LANG-1065 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Reporter: Paul Benedict Priority: Minor Fix For: Patch Needed Original Estimate: 1h Remaining Estimate: 1h I have 2 java.util.Date objects -- one with the correct date and one with the correct time. This enhancement will create a new method to apply the respective fragments to a new java.util.Date instance. Possible signature: public static Date merge(Date date, Date time); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
