[jira] [Commented] (NET-630) NET-630 Add deprecated annotations to the original SubnetUtils

2017-03-22 Thread Makoto Sakaguchi (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937563#comment-15937563
 ] 

Makoto Sakaguchi commented on NET-630:
--

I will try to deal with IPv6 based on the existing SubnetUtils.

I made the getAddressCount method to return a string of the number of available 
IP addresses because IPv6 uses a 128-bit address.
But it confused others, so I will change the method name to 
getAddressCountString().

> NET-630 Add deprecated annotations to the original SubnetUtils 
> ---
>
> Key: NET-630
> URL: https://issues.apache.org/jira/browse/NET-630
> Project: Commons Net
>  Issue Type: Sub-task
>Reporter: Makoto Sakaguchi
>
> It can also be replaced with new SubnetUtils class in the subnet package.
> https://github.com/apache/commons-net/pull/23



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (NET-630) NET-630 Add deprecated annotations to the original SubnetUtils

2017-03-22 Thread Sebb (JIRA)

[ 
https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937511#comment-15937511
 ] 

Sebb commented on NET-630:
--

Is it necessary to deprecate the existing SubnetUtils?
This will force users to recode their applications.

In Commons we strive for compatibility whenever possible.

So for example getAddressCount() has been replaced by getAddressCountLong().
However users can still call the original method, which will give the correct 
result (unless it overflows).


> NET-630 Add deprecated annotations to the original SubnetUtils 
> ---
>
> Key: NET-630
> URL: https://issues.apache.org/jira/browse/NET-630
> Project: Commons Net
>  Issue Type: Sub-task
>Reporter: Makoto Sakaguchi
>
> It can also be replaced with new SubnetUtils class in the subnet package.
> https://github.com/apache/commons-net/pull/23



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)