[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067594#comment-16067594
]
ASF GitHub Bot commented on TEXT-93:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062402#comment-16062402
]
ASF GitHub Bot commented on TEXT-93:
Github user ameyjadiye commented on the issue:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062325#comment-16062325
]
Gilles commented on TEXT-93:
It's fine to delay the addition of the overloaded method to when someone has a
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062008#comment-16062008
]
ASF GitHub Bot commented on TEXT-93:
Github user ameyjadiye commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062006#comment-16062006
]
ASF GitHub Bot commented on TEXT-93:
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061893#comment-16061893
]
Bruno P. Kinoshita commented on TEXT-93:
>Well, Yes nowadays programmers prefer List over arrays
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061891#comment-16061891
]
ASF GitHub Bot commented on TEXT-93:
Github user kinow commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061880#comment-16061880
]
Amey Jadiye commented on TEXT-93:
-
Well, Yes nowadays programmers prefer List over arrays and it's convineant
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061867#comment-16061867
]
Gilles commented on TEXT-93:
It is not obvious to me that such a method is not useful (and even more so when
one
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061773#comment-16061773
]
Amey Jadiye commented on TEXT-93:
-
Hi Gilles,
That method is removed all together as per previous
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061745#comment-16061745
]
Gilles commented on TEXT-93:
Code
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061498#comment-16061498
]
Wilson MacGyver commented on TEXT-93:
-
thank you guys for such fast turn around and awesome response
>
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061412#comment-16061412
]
Amey Jadiye commented on TEXT-93:
-
Committed all the changes we discussed to PR.
> RandomStringGenerator
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061411#comment-16061411
]
ASF GitHub Bot commented on TEXT-93:
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061353#comment-16061353
]
Wilson MacGyver commented on TEXT-93:
-
the primary argument for selectFromList is
in
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061137#comment-16061137
]
Pascal Schumacher commented on TEXT-93:
---
You can pass a char array to a char... vararg method, so an
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060473#comment-16060473
]
Amey Jadiye commented on TEXT-93:
-
Agreed with name change.
For suggested varargs we should have one more
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060454#comment-16060454
]
Pascal Schumacher commented on TEXT-93:
---
I prefer selectFrom as method name (as suggested by
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060441#comment-16060441
]
ASF GitHub Bot commented on TEXT-93:
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060069#comment-16060069
]
Gilles commented on TEXT-93:
Amey,
Referring to the PR; this code
{code}
public Builder selectFromList(List
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060044#comment-16060044
]
ASF GitHub Bot commented on TEXT-93:
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060026#comment-16060026
]
ASF GitHub Bot commented on TEXT-93:
GitHub user ameyjadiye opened a pull request:
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059851#comment-16059851
]
Pascal Schumacher commented on TEXT-93:
---
I'm not opposed to adding a new method to make it easier.
I
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059748#comment-16059748
]
Amey Jadiye commented on TEXT-93:
-
Hi [~pascalschumacher]
Though your code is generating expected output
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059728#comment-16059728
]
Pascal Schumacher commented on TEXT-93:
---
Thanks for the suggestion.
There is a bit of overlap with
[
https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058503#comment-16058503
]
Gilles commented on TEXT-93:
We could have
* {{selectFromList(char[])}}
* {{selectFromList(List)}}
>
26 matches
Mail list logo
