theshoeshiner commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059819568
The provided implementations are fairly simple (even more so after relying
on StringTokenizer) and aim to impose as few restrictions as possible, relying
on the
speters33w commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059789205
@theshoeshiner
I got everything re-merged into the initial clone, and git likes it. It
finds differences in StringTokenizerTest, but that's it.
I think I must have
speters33w commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059348369
Yeah, I don't know what I did, but it works, now, including my new test.
```
Process finished with exit code 0
```
You might need to rebase your project and do a
theshoeshiner commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059208892
Yea that's something wrong with your build. The test can't be failing
because its not being run to begin with. That class wasn't changed as part of
this PR so I'm not sure what
speters33w commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059201962
It's not giving me a stack trace, it's giving a build failure. I used Zulu
21 then Temurin 21 under IntelliJ Idea Ultimate
Here is the method:
```
@Test
theshoeshiner commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059179513
That line of code runs fine for me. Can you send the stacktrace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
speters33w commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059169372
Well, at least this one fails, it's the first test I ran
The text is 푡ℎ푒_푞푢푖푐푘_푏푟표푤푛_푓표푥
```
assertFormatAndParse(SnakeCase.INSTANCE,
speters33w commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059106379
@theshoeshiner
Funny... I was just starting to play with my clone of your project, I want
to run some tests using:
픗픥픢 픮픲픦픠픨 픟픯픬픴픫 픣픬픵
핋학핖 핢핦핚핔한 핓핣할함핟 핗할합
퐓퐡퐞 퐪퐮퐢퐜퐤
theshoeshiner commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2059087840
@speters33w
That suffers from all the same problems of the original implementation. This
PR wasn't just to refactor the existing features, it was to enhance them. The
speters33w commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-2058211784
Honestly, I'm not sure I'm in favor of splitting CaseUtils into a bunch of
separate classes. Actually, I'm sure I'm not in favor of this.
This will be confusing to a user.
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1409225221
##
src/main/java/org/apache/commons/text/TokenFormatterFactory.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
theshoeshiner commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-1830915425
@elharo @garydgregory
I converted the cases API to use StringTokenizer as suggested by @elharo. In
general this works out fine and greatly simplifies those classes, but
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1377572434
##
src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1377572434
##
src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1377419333
##
src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1376568237
##
src/main/java/org/apache/commons/text/cases/CasesUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1376681235
##
src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1376568237
##
src/main/java/org/apache/commons/text/cases/CasesUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370291586
##
src/main/java/org/apache/commons/text/cases/KebabCase.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370181046
##
src/main/java/org/apache/commons/text/cases/UpperCaseDelimitedCase.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370181046
##
src/main/java/org/apache/commons/text/cases/UpperCaseDelimitedCase.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370155220
##
src/main/java/org/apache/commons/text/cases/UpperCaseDelimitedCase.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
garydgregory commented on PR #450:
URL: https://github.com/apache/commons-text/pull/450#issuecomment-1777088768
> 1. I like this proposal in general. I'd love to get some beta feedback
before we lock everything in though. Does Apache commons have any sort of beta
or incubation phase for
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370044779
##
src/test/java/org/apache/commons/text/cases/CasesTest.java:
##
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370038780
##
src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1370013073
##
src/main/java/org/apache/commons/text/cases/CharacterDelimitedCase.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
elharo commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1366862715
##
src/main/java/org/apache/commons/text/cases/CamelCase.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
theshoeshiner commented on code in PR #450:
URL: https://github.com/apache/commons-text/pull/450#discussion_r1366855930
##
src/main/java/org/apache/commons/text/cases/CamelCase.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
28 matches
Mail list logo
