Re: [Jfs-discussion] [PATCH] fs: convert a pile of fsync routines to errseq_t based reporting

2017-07-31 Thread Dave Kleikamp
hose filesystems this is a straightforward conversion from calling > filemap_write_and_wait_range in their fsync operation to calling > file_write_and_wait_range. > > Signed-off-by: Jeff Layton <jlay...@redhat.com> Acked-by: Dave Kleikamp <dave.kleik...@oracle.com>

[Jfs-discussion] [GIT PULL] jfs fixes for 4.13-rc2

2017-07-25 Thread Dave Kleikamp
The following changes since commit d966564fcdc19e13eb6ba1fbe6b8101070339c3d: Revert "x86/ioapic: Restore IO-APIC irq_chip retrigger callback" (2017-02-08 18:08:29 -0800) are available in the git repository at: git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.13 for you to fetch

Re: [Jfs-discussion] [PATCH 06/11] jfs: Don't clear SGID when inheriting ACLs

2017-07-18 Thread Dave Kleikamp
_acl(). That way the function will not be >> called when inheriting ACLs which is what we want as it prevents SGID >> bit clearing and the mode has been properly set by posix_acl_create() >> anyway. >> >> Fixes: 073931017b49d9458aa351605b43a7e34598caef >> CC

Re: [Jfs-discussion] [PATCH 4/5] jfs: preserve i_mode if __jfs_set_acl() fails

2017-07-13 Thread Dave Kleikamp
On 07/12/2017 04:55 AM, Ernesto A. Fernández wrote: > When changing a file's acl mask, __jfs_set_acl() will first set the group > bits of i_mode to the value of the mask, and only then set the actual > extended attribute representing the new acl. > > If the second part fails (due to lack of

Re: [Jfs-discussion] [PATCH 06/11 linux-next] jfs: use magic.h

2017-05-21 Thread Dave Kleikamp
On 05/21/2017 10:41 AM, Fabian Frederick wrote: > Filesystems generally use SUPER_MAGIC values from magic.h > instead of a local definition. > > Signed-off-by: Fabian Frederick <f...@skynet.be> Acked-by: Dave Kleikamp <dave.kleik...@oracle.com> > --- >

Re: [Jfs-discussion] [PATCH v2 01/17] mm: drop "wait" parameter from write_one_page

2017-04-12 Thread Dave Kleikamp
On 04/12/2017 09:27 AM, Matthew Wilcox wrote: > On Wed, Apr 12, 2017 at 08:05:58AM -0400, Jeff Layton wrote: >> The callers all set it to 1. Also, make it clear that this function will >> not set any sort of AS_* error, and that the caller must do so if >> necessary. No existing caller uses this

Re: [Jfs-discussion] [PATCH 1/1 linux-next] jfs: atomically read inode size

2017-01-24 Thread Dave Kleikamp
On 01/23/2017 01:52 PM, Fabian Frederick wrote: > > >> On 23 January 2017 at 19:43 Dave Kleikamp <dave.kleik...@oracle.com> wrote: >> >> >> On 01/23/2017 11:50 AM, Fabian Frederick wrote: >>> See i_size_read() comments in include/linux/fs.h >>

Re: [Jfs-discussion] jfs: mangled lockdep splat

2016-12-05 Thread Dave Kleikamp
On 11/22/2016 06:05 PM, Christian Kujau wrote: > For some time now, I always[0] receive a lockdep warning when there's some > disk I/O on the system. But recently the warning looks kinda mangled, > I suspect the recent printk change (4bcc595ccd80, "printk: reinstate > KERN_CONT for printing

Re: [Jfs-discussion] [RESEND PATCH] fs: jfs: Replace CURRENT_TIME_SEC by current_time()

2016-11-11 Thread Dave Kleikamp
e through the jfs tree. Thanks, Shaggy > > Signed-off-by: Deepa Dinamani <deepa.ker...@gmail.com> > Acked-by: Dave Kleikamp <dave.kleik...@oracle.com> > Reviewed-by: Arnd Bergmann <a...@arndb.de> > --- > fs/jfs/ioctl.c | 2 +- > 1 file changed, 1 insertion(+)

[Jfs-discussion] [GIT PULL] jfs for 4.9

2016-10-04 Thread Dave Kleikamp
The following changes since commit b8927721ae9d5ac0582d29d7b8c267d465ad5f00: Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2016-08-29 12:37:11 -0700) are available in the git repository at: git://github.com/kleikamp/linux-shaggy.git

Re: [Jfs-discussion] [PATCH] jfs: Simplify code

2016-09-06 Thread Dave Kleikamp
@ > expression y,z; > @@ > > - list_splice(y,z); > - INIT_LIST_HEAD(y); > + list_splice_init(y,z); > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Signed-off-by: Dave Kleikamp <dave.kleik...@oracle.com> > --- > fs/jfs/jfs_txnmgr.c | 3 +-- > 1 fi

[Jfs-discussion] [GIT PULL] jfs changes for 4.7

2016-05-16 Thread Dave Kleikamp
The following changes since commit 1993b176a8224e371e0732ffada7ab9eb3b0912b: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide (2016-03-28 15:17:02 -0500) are available in the git repository at: git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.7 for you to fetch changes

Re: [Jfs-discussion] [PATCH 1/2] jfs: Clean up xattr name mapping

2016-04-27 Thread Dave Kleikamp
On 04/27/2016 12:10 PM, Andreas Gruenbacher wrote: > On Wed, Apr 27, 2016 at 4:29 PM, Dave Kleikamp <dave.kleik...@oracle.com> > wrote: >> On 04/22/2016 07:43 AM, Andreas Gruenbacher wrote: >>> Instead of stripping "os2." prefixes in __jfs_setxattr, make call

Re: [Jfs-discussion] [PATCH 1/2] jfs: Clean up xattr name mapping

2016-04-27 Thread Dave Kleikamp
On 04/22/2016 07:43 AM, Andreas Gruenbacher wrote: > Instead of stripping "os2." prefixes in __jfs_setxattr, make callers > strip them, as __jfs_getxattr already does. With that change, use the > same name mapping function in jfs_{get,set,remove}xattr. > > Signed-off-by: Andreas Gruenbacher

Re: [Jfs-discussion] segfaults in jfs_fsck via fuzzing

2016-04-15 Thread Dave Kleikamp
On 04/15/2016 08:08 AM, Hanno Böck wrote: > Hi, > > I did some fuzzing on jfsutils. It uncovered two segfaults that look > like null pointer accesses. > > The first one (in function (ujfs_rw_diskblocks) seems to be fixed in CVS > already, but there hasn't been a release for years. The second one

Re: [Jfs-discussion] [PATCH 0/3] jfs: logging neatening

2016-03-30 Thread Dave Kleikamp
On 03/30/2016 11:22 AM, Joe Perches wrote: > On Wed, 2016-03-30 at 10:56 -0500, Dave Kleikamp wrote: >> On 03/30/2016 07:23 AM, Joe Perches wrote: >>> >>> There is a difference in use between jfs_error and the other >>> jfs_info, jfs_warn, and jfs_err logging

Re: [Jfs-discussion] [PATCH 0/3] jfs: logging neatening

2016-03-30 Thread Dave Kleikamp
On 03/30/2016 07:23 AM, Joe Perches wrote: > This patchset fixes the uses of jfs_info, jfs_warn and jfs_err that > have terminating newlines and a couple other trivialities to make > the logging a bit more consistent. These patches look good. I'm pushing them out to the -next build. > There is a

Re: [Jfs-discussion] Problem: overflow in fs/jfs/jfs_imap.c

2016-03-08 Thread Dave Kleikamp
On 03/07/2016 03:40 PM, sambessel...@planet.nl wrote: > Hi Dave, > > Moving from kernel 4.1.7 to 4.4.2 for me resulted in an overflow in > function diMount in fs/jfs/jfs_imap.c > > When mounting a JFS partition, PAX notes the following: > 'PAX: size overflow detected in function diMount

Re: [Jfs-discussion] File transfer speed slows 10x and more after reaching 1TB in size

2016-02-11 Thread Dave Kleikamp
On 02/11/2016 03:31 AM, alanb wrote: > Update: > > I reformatted one of the 4TB drives to XFS, and did another transfer of > the original 2TB image file from JFS to XFS. > > What is interesting, is when I copy the 2TB image file from the JFS > drive to the XFS drive, I still encountered the

Re: [Jfs-discussion] [PATCH 11/17] fs/jfs: remove unnecessary new_valid_dev check

2015-09-28 Thread Dave Kleikamp
On 09/28/2015 09:18 AM, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai <bywxiao...@163.com> Acked-by: Dave Kleikamp <dave.kleik...@oracle.com> > --- > fs/jfs/namei.c | 3 ---

Re: [Jfs-discussion] jfsutils: development status and license

2015-08-03 Thread Dave Kleikamp
On 08/03/2015 04:42 AM, Daniel Cegiełka wrote: Hi, It seems that jfsutils is not actively developed. The last version was published in 2011. Is this package will be further developed? Not really. I've made a few fixes in cvs since then, but never got around to creating a new release. I

[Jfs-discussion] [GIT PULL] jfs changes for 4.2-rc3

2015-07-16 Thread Dave Kleikamp
indentation on if statement Dave Kleikamp (1): jfs: clean up jfs_rename and fix out of order unlock Nan Jia (1): jfs: removed a prohibited space after opening parenthesis fs/jfs/file.c | 2 +- fs/jfs/inode.c | 4 ++-- fs/jfs/namei.c | 27 +-- 3 files changed, 16

[Jfs-discussion] [PATCH] dquot_initialize() can now return error. Handle it where possible

2015-07-15 Thread Dave Kleikamp
Slightly modified by Dave Kleikamp due to needed jfs_rename() error path fix. Signed-off-by: Jan Kara j...@suse.com Reviewed-by: Dave Kleikamp dave.kleik...@oracle.com --- fs/jfs/file.c | 7 +-- fs/jfs/jfs_inode.c | 4 +++- fs/jfs/namei.c | 54

[Jfs-discussion] [PATCH] jfs: clean up jfs_rename and fix out of order unlock

2015-07-15 Thread Dave Kleikamp
a future patch by Jan Kara doesn't need to deal with renumbering or confusing out-of-order labels. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com --- fs/jfs/namei.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/fs/jfs/namei.c b/fs/jfs

Re: [Jfs-discussion] [PATCH 5/6] jfs: Handle error from dquot_initialize()

2015-07-15 Thread Dave Kleikamp
On 07/15/2015 12:23 PM, Dave Kleikamp wrote: On 07/15/2015 07:42 AM, Jan Kara wrote: dquot_initialize() can now return error. Handle it where possible. Looks good to me. No, I take that back. Reviewing this I found an existing problem with the error paths in jfs_rename, and your patch adds

Re: [Jfs-discussion] [PATCH] jfs: fix indentation on if statement

2015-06-04 Thread Dave Kleikamp
On 06/04/2015 11:57 AM, Colin King wrote: From: Colin Ian King colin.k...@canonical.com The if statement and closing brace are indented by 1 extra space, so remove this extra spacing. Cosmetic change only. Thanks. Pushed to jfs-next. Signed-off-by: Colin Ian King

Re: [Jfs-discussion] [PATCH] fs: jfs: file: removed a prohibited space after opening parenthesis

2015-06-01 Thread Dave Kleikamp
On 05/31/2015 04:53 AM, Nan Jia wrote: Fixed a coding style issue. Thanks. Added to jfs-next. Signed-off-by: Nan Jia jiananm...@gmail.com --- fs/jfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jfs/file.c b/fs/jfs/file.c index e98d39d..b9dc23c 100644

Re: [Jfs-discussion] Strange dir inode

2015-04-24 Thread Dave Kleikamp
On 04/22/2015 06:09 AM, Felipe Monteiro de Carvalho wrote: Hello, I've been working hard to get jfs read support in my software, and I try as hard as possible to figure out myself without asking question, but there is a very strange point where I got stuck =( Its a dir inode, which has

Re: [Jfs-discussion] Cannot Find the Root Inode of a JFS Disk

2015-04-15 Thread Dave Kleikamp
On 04/15/2015 04:27 AM, Felipe Monteiro de Carvalho wrote: Hello, I am implementing a software to read JFS partitions in Windows/Mac OS X. Only reading, no writing involved. It works already for many partitions, but someone sent me a disk, and this is something wrong with my

[Jfs-discussion] [GIT PULL] jfs changes for v4.1

2015-04-14 Thread Dave Kleikamp
Not much this time. Just a one-liner. The following changes since commit 09d35919b06e8508b51ee8a643a67b56f7bea0dd: Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2015-03-12 09:50:45 -0700) are available in the git repository at:

Re: [Jfs-discussion] [PATCH][3.2.y][3.4.y][3.10.y] jfs: fix readdir regression

2015-04-08 Thread Dave Kleikamp
On 04/08/2015 08:14 PM, Zefan Li wrote: On 2015/3/24 5:06, Dave Kleikamp wrote: Upstream commit 44512449, jfs: fix readdir cookie incompatibility with NFSv4, was backported incorrectly into the stable trees which used the filldir callback (rather than dir_emit). The position is being

Re: [Jfs-discussion] [patch 1/4] fs, jfs: remove slab object constructor

2015-03-26 Thread Dave Kleikamp
On 03/26/2015 02:28 AM, Christoph Hellwig wrote: On Wed, Mar 25, 2015 at 07:37:40PM -0700, David Rientjes wrote: That would be true only for ptr = mempool_alloc(gfp, pool); mempool_free(ptr, pool); and nothing in between, and that's pretty pointless. Typically, callers allocate

[Jfs-discussion] [PATCH][3.2.y][3.4.y][3.10.y] jfs: fix readdir regression

2015-03-23 Thread Dave Kleikamp
that need to be fixed are 3.2.y, 3.4.y and 3.10.y. https://bugzilla.kernel.org/show_bug.cgi?id=94741 Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: jfs-discussion@lists.sourceforge.net Cc: sta...@vger.kernel.org --- fs/jfs/jfs_dtree.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [Jfs-discussion] JFS readdir() issues in stable 3.2

2015-03-21 Thread Dave Kleikamp
On 03/20/2015 06:33 PM, Richard Weinberger wrote: Hi! Mainline commit 44512449c0ab368889dd13ae0031fba74ee7e1d2 (jfs: fix readdir cookie incompatibility with NFSv4) does not work as expected on 3.2. Maybe on other stable kernels too. UML stumbled over it:

Re: [Jfs-discussion] [patch 1/2] mm, mempool: poison elements backed by slab allocator

2015-03-19 Thread Dave Kleikamp
On 03/19/2015 06:20 PM, David Rientjes wrote: On Mon, 16 Mar 2015, Rasmus Villemoes wrote: Mempools keep elements in a reserved pool for contexts in which allocation may not be possible. When an element is allocated from the reserved pool, its memory contents is the same as when it was

Re: [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse

2015-03-19 Thread Dave Kleikamp
. (The sysv.h one) I totally agree with this patch. (So many of them, bread crumbs of copy/paste for you ;0) I'm sure that was the case with jfs. Reviewed-by: Boaz Harrosh b...@plexistor.com Acked-by: Dave Kleikamp dave.kleik...@oracle.com

Re: [Jfs-discussion] Cannot find inode

2015-02-23 Thread Dave Kleikamp
On 02/21/2015 04:26 AM, Felipe Monteiro de Carvalho wrote: Hello, I am writing a software to read jfs partitions, and I can already read the root and many directories / files inside it. But some dirs / files have a high inode number (0x106 and 0x107), but my Fileset Inode Map has only 3

Re: [Jfs-discussion] Cannot find inode

2015-02-23 Thread Dave Kleikamp
On 02/23/2015 11:08 AM, Felipe Monteiro de Carvalho wrote: Hello, First thanks for the answer =) On Mon, Feb 23, 2015 at 12:44 PM, Dave Kleikamp dave.kleik...@oracle.com wrote: Are you familiar with the JFS layout document? http://jfs.sourceforge.net/project/pub/jfslayout.pdf Yes, I

[Jfs-discussion] [GIT PULL] jfs changes for v3.20

2015-02-12 Thread Dave Kleikamp
The following changes since commit 53262d12d1658669029ab39a63e3d314108abe66: Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux (2014-12-23 11:03:28 -0800) are available in the git repository at: git://github.com/kleikamp/linux-shaggy.git tags/jfs-3.20

Re: [Jfs-discussion] [PATCH] jfs: Deletion of an unnecessary check before the function call unload_nls

2015-02-02 Thread Dave Kleikamp
On 02/01/2015 10:15 AM, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 1 Feb 2015 17:00:24 +0100 The unload_nls() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was

Re: [Jfs-discussion] Remove TO DO in jfs_xtree.c

2014-12-29 Thread Dave Kleikamp
On 12/29/2014 09:48 PM, ty...@mit.edu wrote: On Mon, Dec 29, 2014 at 04:13:37PM -0600, Dave Kleikamp wrote: On 12/27/2014 06:58 PM, nick wrote: Greetings Dave, I am wondering why there is a TO DO above this code: * ToDo: tlocks should be on doubly-linked list, so we can

Re: [Jfs-discussion] [PATCH 11/12] jfs: Convert to private i_dquot field

2014-11-04 Thread Dave Kleikamp
On 11/04/2014 05:19 AM, Jan Kara wrote: CC: jfs-discussion@lists.sourceforge.net Signed-off-by: Jan Kara j...@suse.cz Acked-by: Dave Kleikamp dave.kleik...@oracle.com --- fs/jfs/jfs_incore.h | 3 +++ fs/jfs/super.c | 9 + 2 files changed, 12 insertions(+) diff --git a/fs

Re: [Jfs-discussion] [PATCH 01/12] quota: Allow each filesystem to specify which quota types it supports

2014-10-10 Thread Dave Kleikamp
On 10/10/2014 09:54 AM, Jan Kara wrote: Currently all filesystems supporting VFS quota support user and group quotas. With introduction of project quotas this is going to change so make sure filesystem isn't called for quota type it doesn't support by introduction of a bitmask determining

Re: [Jfs-discussion] [PATCH 11/12] jfs: Convert to private i_dquot field

2014-10-10 Thread Dave Kleikamp
On 10/10/2014 09:55 AM, Jan Kara wrote: CC: Dave Kleikamp sha...@kernel.org CC: jfs-discussion@lists.sourceforge.net Signed-off-by: Jan Kara j...@suse.cz --- fs/jfs/jfs_incore.h | 3 +++ fs/jfs/super.c | 13 + 2 files changed, 16 insertions(+) diff --git a/fs/jfs

Re: [Jfs-discussion] [PATCH 11/12] jfs: Convert to private i_dquot field

2014-10-10 Thread Dave Kleikamp
You can add my Acked-by: Dave Kleikamp dave.kleik...@oracle.com On 10/10/2014 10:40 AM, Jan Kara wrote: On Fri 10-10-14 10:33:02, Dave Kleikamp wrote: On 10/10/2014 09:55 AM, Jan Kara wrote: CC: Dave Kleikamp sha...@kernel.org CC: jfs-discussion@lists.sourceforge.net Signed-off-by: Jan Kara

Re: [Jfs-discussion] [PATCH V2] fs/jfs/jfs_inode.c: atomically set inode-i_flags

2014-04-14 Thread Dave Kleikamp
Looks good to me. I'll push it upstream. Thanks, Dave On 04/14/2014 02:39 AM, Fabian Frederick wrote: According to commit 5f16f3225b0624 ext4: atomically set inode-i_flags in ext4_set_inode_flags() Inspired-by: Theodore Ts'o ty...@mit.edu Cc: Dave Kleikamp sha...@kernel.org Cc: Theodore

[Jfs-discussion] [PATCH] jfs: set i_ctime when setting ACL

2014-02-13 Thread Dave Kleikamp
code doesn't bother storing the acl in that case, thus the ctime isn't getting set. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Reported-by: Michael L. Semon mlsemo...@gmail.com --- fs/jfs/acl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index

Re: [Jfs-discussion] Duplicate block references have been detected in Metadata

2013-10-25 Thread Dave Kleikamp
On 10/25/2013 03:47 AM, Daniel Vecerka wrote: Hi everyone, we have 24TB SW-RAID6 array with one large JFS partition. There was power failure (bad UPS) when jfs_fsck have been running and after this accident I'm not able to get JFS clean. There is jfs_fsck error which I get : **Phase

[Jfs-discussion] [GIT PULL] jfs fix for 3.12

2013-10-21 Thread Dave Kleikamp
to fix an oops in an error path. Dave Kleikamp (1): jfs: fix error path in ialloc fs/jfs/jfs_inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

Re: [Jfs-discussion] 146Gb in lost+found ?

2013-10-04 Thread Dave Kleikamp
On 10/04/2013 01:26 AM, Per Jessen wrote: Per Jessen wrote: Dave Kleikamp wrote: On 10/03/2013 01:12 PM, Per Jessen wrote: I'm in the process of moving some data from one server to another, and have come across 146Gb in lost+found date-wise, they span more than 6 years. They are all

Re: [Jfs-discussion] 146Gb in lost+found ?

2013-10-03 Thread Dave Kleikamp
On 10/03/2013 01:12 PM, Per Jessen wrote: I'm in the process of moving some data from one server to another, and have come across 146Gb in lost+found date-wise, they span more than 6 years. They are all called Inn.RCN. A directory was lost at some point. With no directory, file names

Re: [Jfs-discussion] Journal Corrupt, Logredo Failed.

2013-09-17 Thread Dave Kleikamp
On 09/17/2013 04:08 PM, Adam Crane wrote: hey, I'm not entirely sure if this is the correct place to ask for help, but I've been looking around and can't find anywhere else. I'm really at a loss and could use some help. The system crashed and upon reboot I can't get the drive to mount. The

[Jfs-discussion] [PATCH stable] fix readdir cookie incompatibility with NFSv4

2013-08-27 Thread Dave Kleikamp
method. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com [bwh: Backported to 3.2: - Adjust context - s/ctx-pos/filp-f_pos/] Signed-off-by: Ben Hutchings b...@decadent.org.uk --- fs/jfs/jfs_dtree.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff

[Jfs-discussion] [GIT PULL] jfs for 3.11-rc8

2013-08-26 Thread Dave Kleikamp
. Dave Kleikamp (1): jfs: fix readdir cookie incompatibility with NFSv4 fs/jfs/jfs_dtree.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions

[Jfs-discussion] [PATCH] jfs: fix readdir cookie incompatibility with NFSv4

2013-08-15 Thread Dave Kleikamp
entry. This incompatibility can result in the nfs client reporting a readdir loop. This patch doesn't change the value stored internally, but adds one to the value exposed to the iterate method. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com --- fs/jfs/jfs_dtree.c | 31

Re: [Jfs-discussion] [PATCH] jfs: fix readdir cookie incompatibility with NFSv4

2013-08-15 Thread Dave Kleikamp
On 08/15/2013 04:26 PM, Christian Kujau wrote: On Thu, 15 Aug 2013 at 15:48, Dave Kleikamp wrote: This patch replaces the one I posted yesterday. I like this better since it doesn't require fixing existing on-disk cookies or skipping a position in the in-inode index table. Thanks. Applied

[Jfs-discussion] [PATCH] jfs: avoid misuse of cookie value of 2

2013-08-14 Thread Dave Kleikamp
0, 1 and 2 for a rewind, and the . and .. entries. jfs was using 0 and 1 for . and .., but 2 for a regular entry. This patch makes jfs conform by using 1 and 2 for . and .. and fixes any regular entry using the value 2. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com diff --git a/fs/jfs

[Jfs-discussion] [GIT PULL] JFS updates for 3.11

2013-07-10 Thread Dave Kleikamp
up to eb8630d7d2fd13589e6a7a3ae2fe1f75f867fbed: jfs: Update jfs_error (2013-06-05 14:47:19 -0500) A couple cleanups to JFS for 3.11 Dave Kleikamp (1): jfs

Re: [Jfs-discussion] jfs_fsck stucks

2013-06-14 Thread Dave Kleikamp
On 06/14/2013 10:42 AM, Marek Skuczynski wrote: ... and missing callstack for jfs_fsck tool #0 bread (vol=0, pxd=..., buf=0x7fe17f08, update=0) at log_map.c:1873 #1 0x00433acc in rXtree (vol=0, dp=, first_leaf=0x7fe17f5c) at log_map.c:1693 #2 0x0043417c in bMapInit (vol=0, dip=0x4fdda0) at

Re: [Jfs-discussion] jfs_fsck stucks

2013-06-14 Thread Dave Kleikamp
On 06/14/2013 12:28 PM, Marek Skuczynski wrote: Values passed to bread are: vol: 0, pxd: len: 1, addr1: 0, addr2: 0 The p-header.flag is equal 0 after returning from bread(). Any idea how to handle this problem ? It looks like the function needs to do a better job of sanity checking.

Re: [Jfs-discussion] [PATCH 0/2] jfs: neatening

2013-06-05 Thread Dave Kleikamp
On 06/04/2013 06:39 PM, Joe Perches wrote: The second patch is speculative and maybe not necessary. Is a 3KB reduction in object size when embedded and !CONFIG_PRINTK worth it? I'm pushing the first patch to linux-next. I haven't made up my mind about the second. I don't really consider jfs

Re: [Jfs-discussion] [PATCH] jfs: Convert jfs_error to jfs_sb_err

2013-06-04 Thread Dave Kleikamp
I generally like this cleanup except for one thing. On 06/04/2013 12:22 AM, Joe Perches wrote: Use a more current logging style. Rename function jfs_error to jfs_sb_err. Why the rename? If you're going to rename it, the new name should be more descriptive, such as

Re: [Jfs-discussion] [PATCH] jfs: Convert jfs_error to jfs_sb_err

2013-06-04 Thread Dave Kleikamp
On 06/04/2013 11:28 AM, Joe Perches wrote: On Tue, 2013-06-04 at 11:00 -0500, Dave Kleikamp wrote: I generally like this cleanup except for one thing. On 06/04/2013 12:22 AM, Joe Perches wrote: Use a more current logging style. Rename function jfs_error to jfs_sb_err. Why the rename

[Jfs-discussion] [GIT PULL] jfs for 3.10-rc5

2013-06-03 Thread Dave Kleikamp
The following changes since commit 514e250f67d2b2a8ab08dc9c3650af19a411c926: Merge tag 'gpio-fixes-v3.10-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio (2013-05-23 18:24:10 -0700) are available in the git repository at: git://github.com/kleikamp/linux-shaggy.git

Re: [Jfs-discussion] [PATCH 3.9-stable] jfs: fix a couple races

2013-05-29 Thread Dave Kleikamp
On 05/29/2013 09:59 AM, Luis Henriques wrote: Dave Kleikamp dave.kleik...@oracle.com writes: Commit 73aaa22d5ffb2630456bac2f9a4ed9b81d0d7271 upstream This fixes a real-world hang reported against the 3.9.3 kernel. The races described in the commit seem to be present in all the other

Re: [Jfs-discussion] jfs resize

2013-05-28 Thread Dave Kleikamp
: Dave Kleikamp [mailto:dave.kleik...@oracle.com] Sent: Wednesday, May 22, 2013 12:33 PM To: Kiebzak, Jason M. Cc: 'jfs-discussion@lists.sourceforge.net' Subject: Re: [Jfs-discussion] jfs resize On 05/21/2013 08:08 AM, Kiebzak, Jason M. wrote: Hello everyone, I have a large JFS

[Jfs-discussion] [PATCH 3.9-stable] jfs: fix a couple races

2013-05-28 Thread Dave Kleikamp
Commit 73aaa22d5ffb2630456bac2f9a4ed9b81d0d7271 upstream This fixes a real-world hang reported against the 3.9.3 kernel. From: Dave Kleikamp dave.kleik...@oracle.com This patch fixes races uncovered by xfstests testcase 068. One race is the result of jfs_sync() trying to write a sync point

Re: [Jfs-discussion] [PATCH 1/2] jfs: Several bugs in jfs_freeze() and jfs_unfreeze()

2013-05-24 Thread Dave Kleikamp
On 05/24/2013 03:57 AM, Vahram Martirosyan wrote: The mentioned functions do not pay attention to the error codes returned by the functions updateSuper(), lmLogInit() and lmLogShutdown(). It brings to system crash later when writing to log. The patch adds corresponding code to check and

Re: [Jfs-discussion] [PATCH 2/2] jfs: Log shutdown error in jfs_freeze() function

2013-05-24 Thread Dave Kleikamp
On 05/24/2013 04:25 AM, Gu Zheng wrote: Hi Vahram, I saw the same issue in the bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=53331, and I sent out a patch this issue, but I've get any feedback. Sorry I missed that bug. I just realized that bugzilla.kernel.org has been sending my

Re: [Jfs-discussion] jfs resize

2013-05-22 Thread Dave Kleikamp
On 05/21/2013 08:08 AM, Kiebzak, Jason M. wrote: Hello everyone, I have a large JFS partition (100 TB – yes terabytes) hosted on an LVM partition. I proceeded to grow the LVM partition to 200TB. Then I started a resize in JFS. The resize has now been running 24 hours and it is still

[Jfs-discussion] [PATCH V7 -next 11/33] dio: Convert direct_IO to use iov_iter

2013-03-08 Thread Dave Kleikamp
Change the direct_IO aop to take an iov_iter argument rather than an iovec. This will get passed down through most filesystems so that only the __blockdev_direct_IO helper need be aware of whether user or kernel memory is being passed to the function. Signed-off-by: Dave Kleikamp dave.kleik

[Jfs-discussion] [PATCH V6 18/30] fs: add read_iter and write_iter to several file systems

2013-01-29 Thread Dave Kleikamp
, hpfs, jfs, jffs2, logfs, minix, nilfs2, omfs, ramfs, reiserfs, romfs, sysv, and ufs. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Acked-by: Boaz Harrosh bharr...@panasas.com Cc: Zach Brown z...@zabbo.net Cc: v9fs-develo...@lists.sourceforge.net Cc: Tigran A. Aivazian tig

[Jfs-discussion] [PATCH V6 09/30] dio: Convert direct_IO to use iov_iter

2013-01-29 Thread Dave Kleikamp
Change the direct_IO aop to take an iov_iter argument rather than an iovec. This will get passed down through most filesystems so that only the __blockdev_direct_IO helper need be aware of whether user or kernel memory is being passed to the function. Signed-off-by: Dave Kleikamp dave.kleik

Re: [Jfs-discussion] Negative value for inode???

2013-01-24 Thread Dave Kleikamp
On 01/24/2013 02:17 PM, Craig Huff wrote: Short form is that I used jfs_debugfs to query for inode info for block 135537084 using d 135537084 0 i and di_number was returned as a negative value. I got the same value for iagnum using the command d 135537084 0 I. What gives? Is this an

[Jfs-discussion] [PATCH V5 18/30] fs: add read_iter and write_iter to several file systems

2013-01-09 Thread Dave Kleikamp
, hpfs, jfs, jffs2, logfs, minix, nilfs2, omfs, ramfs, reiserfs, romfs, sysv, and ufs. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: v9fs-develo...@lists.sourceforge.net Cc: Tigran A. Aivazian tig...@aivazian.fsnet.co.uk Cc: Jan Kara j...@suse.cz Cc: Andrew

Re: [Jfs-discussion] [PATCH] jfs: avoid undefined behavior from left-shifting by 32 bits

2013-01-07 Thread Dave Kleikamp
On 01/05/2013 01:19 PM, Nickolai Zeldovich wrote: Shifting a 32-bit int by 32 bits is undefined behavior in C, and results in different behavior on different architectures (e.g., x86 and PowerPC). diAlloc() in fs/jfs/jfs_imap.c computes a mask using 0xu(32-bitno), which can left-shift

Re: [Jfs-discussion] Out of memory on 3.5 kernels

2012-11-21 Thread Dave Kleikamp
On 10/30/2012 05:35 AM, Nico Schottelius wrote: Good morning, update: this problem still exists on 3.6.2-1-ARCH and it got worse: I reformatted the external disk to use xfs, but as the my root filesystem is still jfs, it still appears: Active / Total Objects (% used): 642732 /

[Jfs-discussion] [PATCH v4 19/31] fs: add read_iter and write_iter to several file systems

2012-11-21 Thread Dave Kleikamp
, jfs, jffs2, logfs, minix, nilfs2, omfs, ramfs, reiserfs, romfs, sysv, and ufs. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: v9fs-develo...@lists.sourceforge.net Cc: Tigran A. Aivazian tig...@aivazian.fsnet.co.uk Cc: Jan Kara j...@suse.cz Cc: Andrew Morton

[Jfs-discussion] [GIT PULL] jfs bug fix for 3.7

2012-10-22 Thread Dave Kleikamp
The following changes since commit 8d2b6b3ae280dcf6f6c7a95623670a57cdf562ed: Merge tag 'sh-for-linus' of git://github.com/pmundt/linux-sh (2012-10-16 19:24:00 -0700) are available in the git repository at: git://github.com/kleikamp/linux-shaggy.git tags/jfs-3.7-2 for you to fetch changes

Re: [Jfs-discussion] finding inodes via block

2012-10-12 Thread Dave Kleikamp
On 10/12/2012 10:33 AM, Robert Henney wrote: I have a jfs partition on a linux 2.6.32 install on which 3 sectors recently became unreadable. I was able to write zeros to those sectors using dd and the disk appears to think they're fine and readable again; at least no sectors are marked

[Jfs-discussion] [GIT PULL] JFS updates for 3.7

2012-10-03 Thread Dave Kleikamp
and some minor fixes Dave Kleikamp (2): jfs: Remove obsolete email address jfs: Fix do_div precision in commit b40c2e66 Tino Reichardt (1): fs/jfs: TRIM support for JFS Filesystem Wei Yongjun (1): JFS: use

Re: [Jfs-discussion] fs/jfs: TRIM support for JFS Filesystem

2012-09-18 Thread Dave Kleikamp
On 09/18/2012 01:57 AM, Dan Carpenter wrote: Hello Tino Reichardt, The patch 0d59722ea777: fs/jfs: TRIM support for JFS Filesystem from Aug 29, 2012, leads to the following static checker warning: fs/jfs/jfs_dmap.c:1650 dbDiscardAG() warn: check 'range_cnt' for negative values

Re: [Jfs-discussion] fs/jfs: TRIM support for JFS Filesystem

2012-09-18 Thread Dave Kleikamp
to replace a 64-bit division with do_div, I unintentionally assigned the divisor to a 32-bit variable. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Tino Reichardt milky-ker...@mcmilk.de --- fs/jfs/jfs_dmap.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/jfs

Re: [Jfs-discussion] fs/jfs: TRIM support for JFS Filesystem

2012-09-18 Thread Dave Kleikamp
On 09/18/2012 02:34 PM, Tino Reichardt wrote: * Dan Carpenter dan.carpen...@oracle.com wrote: Hello Tino Reichardt, The patch 0d59722ea777: fs/jfs: TRIM support for JFS Filesystem from Aug 29, 2012, leads to the following static checker warning: fs/jfs/jfs_dmap.c:1650 dbDiscardAG()

Re: [Jfs-discussion] [PATCH] JFS: use list_move instead of list_del/list_add

2012-09-17 Thread Dave Kleikamp
Meant to reply earlier. I've sent this to linux-next and will target for the next mainline merge window. Thanks, Shaggy On 09/06/2012 02:33 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using list_move() instead of list_del() + list_add(). spatch with a semantic

Re: [Jfs-discussion] Oh noes! fsck stuck :-/

2012-09-11 Thread Dave Kleikamp
On 09/09/2012 02:34 PM, Will Sheldon wrote: Hello clever people :-) Once upon a time I had a 3 disk LVM (instructed to fill the disks sequentially). This LVM had a single LV formatted jfs and filled my life with sunshine and joy. Then I dropped a UPS on top of the server, one of the

Re: [Jfs-discussion] [PATCH] fs/jfs: TRIM support for JFS Filesystem

2012-07-31 Thread Dave Kleikamp
-up patch upstream. Signed-off-by: Tino Reichardt list-...@mcmilk.de Acked-by: Dave Kleikamp dave.kleik...@oracle.com -- regards, TR jfs-trim-2012-07-28.diff diff -X exclude -urpN linux-git/Documentation/filesystems/jfs.txt linux_jfs-trim/Documentation/filesystems/jfs.txt

Re: [Jfs-discussion] Repaired file system still marked dirty, exit code 4

2012-07-23 Thread Dave Kleikamp
On 07/23/2012 12:12 PM, Tim Nufire wrote: Dave, A quick update on this issue.. I've run jfs_fsck repairs several more times on this file system and each time one more file is deleted due to cross linked blocks. All the files in question were created on the same day and at least 2 of the

Re: [Jfs-discussion] Repaired file system still marked dirty, exit code 4

2012-07-19 Thread Dave Kleikamp
was modified. processing terminated: 7/19/2012 2:30:27 with return code: 0 exit code: 4. /sbin/jfs_fsck died with exit status 4 Thu Jul 19 02:30:54 2012 Thanks, Tim On Jul 18, 2012, at 4:11 PM, Dave Kleikamp dave.kleik...@oracle.com wrote: On 07/18/2012 05:43 PM, Tim

Re: [Jfs-discussion] Repaired file system still marked dirty, exit code 4

2012-07-18 Thread Dave Kleikamp
On 07/17/2012 09:20 PM, Tim Nufire wrote: Hello, I'm having trouble repairing one of my volumes running JFS... Each time I run jfs_fsck problems are found and repaired but yet the volume is still marked dirty and the exit code is 4 (File system errors left uncorrected). Here's the output

Re: [Jfs-discussion] Repaired file system still marked dirty, exit code 4

2012-07-18 Thread Dave Kleikamp
On 07/18/2012 05:43 PM, Tim Nufire wrote: Sorry, I sent the wrong jfs_fsck output in my last email.. That was for the READ-ONLY pass I did *before* trying to make repairs. The output from the read-only check is interesting because it shows the Disk Allocation Maps errors which don't get

Re: [Jfs-discussion] fsck.jfs: sending ioctl 1261 to a partition!

2012-05-07 Thread Dave Kleikamp
On 05/07/2012 11:38 AM, Per Jessen wrote: I've recently begun seeing this message, usually on boot-up - it doesn't seem to cause any real issue, but I though I'd mention it anyway. This is harmless. fsck.jfs is sending the BLKFLSBUF ioctl, which flushes the page cache. The ioctl is sent down

[Jfs-discussion] [RFC PATCH v2 21/21] fs: add read_iter and write_iter to more file systems

2012-03-30 Thread Dave Kleikamp
File systems that use generic_file_aio_read() and generic_file_aio_write() can trivially support generic_file_read_iter() and generic_file_write_iter(). This patch adds those file_operations for 9p, ext2, fat, hfs, hfsplus, jfs, nilfs2, and reiserfs. Signed-off-by: Dave Kleikamp dave.kleik

[Jfs-discussion] [RFC PATCH v2 09/21] dio: Convert direct_IO to use iov_iter

2012-03-30 Thread Dave Kleikamp
Change the direct_IO aop to take an iov_iter argument rather than an iovec. This will get passed down through most filesystems so that only the __blockdev_direct_IO helper need be aware of whether user or kernel memory is being passed to the function. Signed-off-by: Dave Kleikamp dave.kleik

Re: [Jfs-discussion] [PATCH v2] vfs: __read_cache_page should use gfp argument rather than GFP_KERNEL

2011-12-21 Thread Dave Kleikamp
On 12/21/2011 02:28 PM, Andrew Morton wrote: On Wed, 21 Dec 2011 11:05:48 -0600 Dave Kleikamp dave.kleik...@oracle.com wrote: [ updated to remove now-obsolete comment in read_cache_page_gfp()] lockdep reports a deadlock in jfs because a special inode's rw semaphore is taken recursively

Re: [Jfs-discussion] [PATCH 1/1] fix d_revalidate oopsen on NFS exports

2011-11-30 Thread Dave Kleikamp
On 11/30/2011 06:47 PM, Chris Dunlop wrote: On Wed, Nov 30, 2011 at 08:54:43AM +, David Howells wrote: ... Acked-by: David Howells dhowe...@redhat.com It's also worth printing a message - this *is* a kernel bug of some description if it happens. Like the below? This covers the

Re: [Jfs-discussion] [PATCH 1/1] fix d_revalidate oopsen on NFS exports

2011-11-30 Thread Dave Kleikamp
On 11/30/2011 09:33 PM, Chris Dunlop wrote: On Wed, Nov 30, 2011 at 08:22:39PM -0600, Dave Kleikamp wrote: On 11/30/2011 06:47 PM, Chris Dunlop wrote: It's also worth printing a message - this *is* a kernel bug of some description if it happens. Like the below? This covers

Re: [Jfs-discussion] unlinked dentries leaking space on jfs?

2011-11-22 Thread Dave Kleikamp
, Here is a pen, write out my name... (from: The Servant - Orchestra) On Tue, Nov 15, 2011 at 13:51, Dave Kleikamp dave.kleik...@oracle.com wrote: On 11/15/2011 03:49 PM, Alessandro Salvatori wrote: On Mon, Nov 14, 2011 at 16:07, Dave Kleikamp dave.kleik...@oracle.com wrote: Even without

Re: [Jfs-discussion] unlinked dentries leaking space on jfs?

2011-11-15 Thread Dave Kleikamp
On 11/15/2011 03:49 PM, Alessandro Salvatori wrote: On Mon, Nov 14, 2011 at 16:07, Dave Kleikamp dave.kleik...@oracle.com wrote: Even without NFS, a rm -rf may still fail to remove the whole directory in OS/2 compatibility mode. because of the case-insensitiveness or because of the lack

Re: [Jfs-discussion] unlinked dentries leaking space on jfs?

2011-11-14 Thread Dave Kleikamp
On 11/14/2011 04:50 PM, Alessandro Salvatori wrote: Hello, by creating and immediately deleting entries in a non-empty folder on a jfs filesystem, it seems like one can leak filesystem space, that will only be recovered when that folder becomes completely empty. To see this for

  1   2   3   >