Charles O Nutter wrote:
The fix was to also set self on the adopted thread's frame and evaluator. I
would LOVE to commit this fix right now, but SF CVS is still down. So here's
the changed code. With this fix, your test case runs successfully.
I built a custom jruby.jar with your new code,
I think I see what's going on. You get the ruby instance in one thread, and before you call anything in that thread you call against it in another thread. The issue here is that although that non-main thread gets adopted, it's missing one piece of the puzzle needed to execute: self. The main execut
Charles O Nutter wrote:
Yes, that AOOB was the one I saw breaking. I'll see if I can find a way to
reproduce your other issue.
OK, I created a simple test that reproduces the NPE. If you run this code,
you'll get an NPE when calling the defined "foo" method from a new
thread; it works if
The "different threads" thing may be the biggest issue. Before, all incoming threads were treated as the same "main" thread inside JRuby, and so it would look like the same thread was executing every call. However, that caused multiple external threads running concurrently to totally destroy each o
Yes, that AOOB was the one I saw breaking. I'll see if I can find a way to reproduce your other issue.On 3/29/06, Werner Schuster (murphee) <
[EMAIL PROTECTED]> wrote:Charles O Nutter wrote:>Can you send the actual script that's getting executed when evalScript is
>dying?>>The Ruby Code executed is
Charles O Nutter wrote:
Can you send the actual script that's getting executed when evalScript is
dying?
The Ruby Code executed is really just
require 'java'
BTW: I just found that your fix fixed a case I'd found yesterday:
with the released 0.8.3, this
def foo
"foo"
end
would cause a
Can you send the actual script that's getting executed when evalScript is dying?On 3/29/06, Werner Schuster (murphee) <
[EMAIL PROTECTED]> wrote:Charles O Nutter wrote:>I believe SF anon CVS is a bit behind the main line. The change was adding
>one line to ThreadContext.preAdoptThread:>push
Charles O Nutter wrote:
I believe SF anon CVS is a bit behind the main line. The change was adding
one line to ThreadContext.preAdoptThread:
pushCRef(runtime.getObject()); // this is new
}
OK, I got that, and I set a breakpoint at this added line
(pushCRef,...). It executed that li
I believe SF anon CVS is a bit behind the main line. The change was adding one line to ThreadContext.preAdoptThread: public void preAdoptThread() { pushIter(Iter.ITER_NOT); pushFrame();
getCurrentFrame().newScope(null); pushRubyClass(runtime.getObject()); push
Charles O Nutter wrote:
I just committed a fix (a one-liner) that allows that test case to run
successfully again. Please try EclipseShell again and let me know if it
works better now.
I got JRuby from the CVS and built the .jar, but the problem seems to be
here;
Could you tell me where you
We had a test case for testing multiple external Java threads calling into a single runtime, and at one time it worked. I ran it today, and BOOM, it blows up all over the place. We had not included it in regular test runs because we hoped the contributor could clean it up a bit...I guess we paid th
Thomas E Enebo wrote:
I will have to take a look later, but I would bet we added some
mandatory piece of state in Ruby that getDefaultInstance() is not
setting up. I can take a look this evening for a bit...Looking
at how BSF sets things up may glean something since that appears to
be working.
I will have to take a look later, but I would bet we added some
mandatory piece of state in Ruby that getDefaultInstance() is not
setting up. I can take a look this evening for a bit...Looking
at how BSF sets things up may glean something since that appears to
be working.
-Tom
On Tue, 28 Mar 2
Thomas E Enebo wrote:
JRuby 0.8.3 has been released. This version fixes a
huge number of problems and boasts the following notables:
Thanks for the new release!
But: I tested this with the EclipseShell JRuby support (ie. simply
replaced it's JRuby jar with 0.8.3 from 0.8.2),
and now I k
14 matches
Mail list logo
