Re: Relation addresses

2014-06-19 Thread William Reade
On Thu, Jun 19, 2014 at 12:16 AM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: On Wed, Jun 18, 2014 at 5:04 PM, William Reade william.re...@canonical.com wrote: We're not changing any semantics; apart from anything else, relation-broken does not depend on any remote unit. its

Re: Relation addresses

2014-06-19 Thread William Reade
On Thu, Jun 19, 2014 at 5:14 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: If that's the case, why do we not just require charms to implement an address-changed hook to update the relation setting then? That way we don't break existing proxy charms, but other charms won't be fixed

Re: Relation addresses

2014-06-19 Thread Andrew Wilkins
On Fri, Jun 20, 2014 at 6:44 AM, William Reade william.re...@canonical.com wrote: On Thu, Jun 19, 2014 at 5:14 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: If that's the case, why do we not just require charms to implement an address-changed hook to update the relation setting

Re: Relation addresses

2014-06-18 Thread Andrew Wilkins
On Tue, Jun 17, 2014 at 9:29 PM, John Meinel j...@arbash-meinel.com wrote: ... In a nutshell: - There will be a new hook, relation-address-changed, and a new tool called address-get. This seems less than ideal, we already have standards ways of getting this data and being notified of

Re: Relation addresses

2014-06-18 Thread Andrew Wilkins
On Wed, Jun 18, 2014 at 2:56 PM, Andrew Wilkins andrew.wilk...@canonical.com wrote: On Tue, Jun 17, 2014 at 9:29 PM, John Meinel j...@arbash-meinel.com wrote: ... In a nutshell: - There will be a new hook, relation-address-changed, and a new tool called address-get. This seems less

Re: Relation addresses

2014-06-18 Thread Kapil Thangavelu
addresses are just keys in a unit relation data bag. relation-get is the cli tool to retrieve either self or related units databag key/values (ie for self's address in the rel $ relation-get $JUJU_UNIT_NAME private-address). unit-get is used to retrieve the current iaas properties of a unit. my

Re: Relation addresses

2014-06-18 Thread William Reade
On Tue, Jun 17, 2014 at 5:35 PM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: or another unit level change hook (unit-address-changed), again the concerns are that we're changing the semantics of relation hooks to something fundamentally different for this one case (every other

Re: Relation addresses

2014-06-18 Thread William Reade
On Wed, Jun 18, 2014 at 7:05 PM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: addresses are just keys in a unit relation data bag. relation-get is the cli tool to retrieve either self or related units databag key/values (ie for self's address in the rel $ relation-get

Re: Relation addresses

2014-06-18 Thread Kapil Thangavelu
On Wed, Jun 18, 2014 at 5:21 PM, William Reade william.re...@canonical.com wrote: On Wed, Jun 18, 2014 at 7:05 PM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: addresses are just keys in a unit relation data bag. relation-get is the cli tool to retrieve either self or related

Re: Relation addresses

2014-06-18 Thread Andrew Wilkins
On Thu, Jun 19, 2014 at 7:59 AM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: On Wed, Jun 18, 2014 at 5:21 PM, William Reade william.re...@canonical.com wrote: On Wed, Jun 18, 2014 at 7:05 PM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: addresses are just keys

Re: Relation addresses

2014-06-18 Thread Andrew Wilkins
On Thu, Jun 19, 2014 at 5:21 AM, William Reade william.re...@canonical.com wrote: On Wed, Jun 18, 2014 at 7:05 PM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: addresses are just keys in a unit relation data bag. relation-get is the cli tool to retrieve either self or related

Re: Relation addresses

2014-06-17 Thread Andrew Wilkins
On Tue, Jun 17, 2014 at 3:42 PM, William Reade william.re...@canonical.com wrote: On Tue, Jun 17, 2014 at 6:39 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: Hi all, I've started looking into fixing https://bugs.launchpad.net/juju-core/+bug/1215579. The gist is, we currently set

Re: Relation addresses

2014-06-17 Thread Kapil Thangavelu
On Tue, Jun 17, 2014 at 12:39 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: Hi all, I've started looking into fixing https://bugs.launchpad.net/juju-core/+bug/1215579. The gist is, we currently set private-address in relation settings when a unit joins, but never update it. I've

Re: Relation addresses

2014-06-17 Thread John Meinel
... In a nutshell: - There will be a new hook, relation-address-changed, and a new tool called address-get. This seems less than ideal, we already have standards ways of getting this data and being notified of its change. introducing non-orthogonal ways of doing the same lacks value

Re: Relation addresses

2014-06-17 Thread Kapil Thangavelu
On Tue, Jun 17, 2014 at 9:29 AM, John Meinel j...@arbash-meinel.com wrote: ... In a nutshell: - There will be a new hook, relation-address-changed, and a new tool called address-get. This seems less than ideal, we already have standards ways of getting this data and being notified of

Re: Relation addresses

2014-06-17 Thread Andrew Wilkins
On Tue, Jun 17, 2014 at 11:35 PM, Kapil Thangavelu kapil.thangav...@canonical.com wrote: On Tue, Jun 17, 2014 at 9:29 AM, John Meinel j...@arbash-meinel.com wrote: ... In a nutshell: - There will be a new hook, relation-address-changed, and a new tool called address-get. This

Re: Relation addresses

2014-06-17 Thread John Meinel
Well, given it is unit-get shouldn't it be more relation-get private-address ? The issue is *that* is give me the private-address for the other side of this relation. Which is not quite what you want. And while I think it is true that many things won't be able to handle binding to more than one ip