Re: [kaffe] Bug with jijt and arm (with solution)
Salut Christophe,
Dalibor Topic wrote:
Salut Christophe,
I'm sorry for taking so long to get back to your patch. Have a happy new
year!
Christophe Dubach wrote:
I'm sorry for the previous message but there was an error :
What make's the bug to disapeer is the fact that I modify the
KAFFE_JNI_SETEXCEPTFP macro.
#define KAFFE_JNI_SETEXCEPTFP(ebufp) { \
vmExcept_setJNIFrame(ebufp,(uintp)__builtin_frame_address(0));\
}
If I change the FIRSTFRAME I've other problem...
I'm sorry, but I don't understand very well what happen, but I've not
enough time to invstigate this (if someone else could do this...).
Kero tried your patch and succeeded in buiding kaffe 1.1.3 for familiar
distribution on handhelds.org with jit enabled. So I'll give it a bit of
testing on other cpus-os platforms I can get hold of, and check it in.
Looks good to me, on i386.
Since this is your first patch, before I check it in, I have to ask if
you're tainted, i.e. have looked at Sun's sources, decompiled them, or
signed an NDA that would prevent you from contributing.
cheers,
dalibor topic
___
kaffe mailing list
[EMAIL PROTECTED]
http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
Re: [kaffe] Bug with jijt and arm (with solution)
Salut Christophe,
I'm sorry for taking so long to get back to your patch. Have a happy new
year!
Christophe Dubach wrote:
I'm sorry for the previous message but there was an error :
What make's the bug to disapeer is the fact that I modify the
KAFFE_JNI_SETEXCEPTFP macro.
#define KAFFE_JNI_SETEXCEPTFP(ebufp) { \
vmExcept_setJNIFrame(ebufp,(uintp)__builtin_frame_address(0));\
}
If I change the FIRSTFRAME I've other problem...
I'm sorry, but I don't understand very well what happen, but I've not
enough time to invstigate this (if someone else could do this...).
Kero tried your patch and succeeded in buiding kaffe 1.1.3 for familiar
distribution on handhelds.org with jit enabled. So I'll give it a bit of
testing on other cpus-os platforms I can get hold of, and check it in.
Thanks a lot!
cheers,
dalibor topic
___
kaffe mailing list
[EMAIL PROTECTED]
http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
[kaffe] Bug with jijt and arm (with solution)
Hello,
I've found a bug when we enable jit on arm platform. This bug was
introduce with the revision 1.6 of the file
kaffe/config/arm/linux/jit-md.h (you can see the log, the author tell us
about this...).
The bug is :
exception.h: 139: vmExcept_setJNIFrame: Assertion fp!=0 failed.
Here is the easy fix for it, just replace
#define FIRSTFRAME(f, o) (f) =
*(exceptionFrame*)((uintp)__builtin_frame_address(0) -
sizeof(exceptionFrame))
with
#define FIRSTFRAME(f, o) (f) =
*(exceptionFrame*)((uintp)__builtin_frame_address(0))
Because if I'm not wrong, builtin_frame_address return the address of
the frame, so why substract 12 (sizeof exceptionFrame)?
I think you could also remove the -sizeof(exceptionFrame) in jit.h for
the macro FIRSTFRAME.
But I we can also simply change the macro KAFFE_JNI_SETEXCEPTFP in
kaffe/kaffevm/jni.c with (why should we do all the stuff as declaring a
variable exceptionFrame ...?) :
#define KAFFE_JNI_SETEXCEPTFP(ebufp) { \
vmExcept_setJNIFrame(ebufp,(uintp)__builtin_frame_address(0));\
}
I hope someone will take a look at this and change it in the cvs...
It's the first time I propose a patch to bug, so if something is not
clear or if something is wrong, please tell me about that...
Christophe.
___
kaffe mailing list
[EMAIL PROTECTED]
http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
Re: [kaffe] Bug with jijt and arm (with solution)
I'm sorry for the previous message but there was an error :
What make's the bug to disapeer is the fact that I modify the
KAFFE_JNI_SETEXCEPTFP macro.
#define KAFFE_JNI_SETEXCEPTFP(ebufp) { \
vmExcept_setJNIFrame(ebufp,(uintp)__builtin_frame_address(0));\
}
If I change the FIRSTFRAME I've other problem...
I'm sorry, but I don't understand very well what happen, but I've not
enough time to invstigate this (if someone else could do this...).
___
kaffe mailing list
[EMAIL PROTECTED]
http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
