There appears to be an issue with select vs choice statements; see the
message below.

Essentially, it appears a default selection in a choice statement takes
precidence over an explicit select statement for one of the choice
options.

----- Forwarded message from [EMAIL PROTECTED] -----
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED], [EMAIL PROTECTED]
Bcc: [EMAIL PROTECTED]
Subject: RE: [BUG] 2.6.0: ARM won't build without CONFIG_CPU_FREQ_GOV_USERSPACE=y
Date: Fri, 26 Dec 2003 10:57:54 +0100

Because of "cpufreq_get()" being necessary for SA1100 it is already
special-handled for this architecture. 

A snippet from arch/arm/Kconfig:

# CPUfreq on SA11x0 is special -- it _needs_ the userspace governor

config CPU_FREQ_SA1100
        bool
        depends on CPU_FREQ && SA1100_LART
        default y
        select CPU_FREQ_DEFAULT_GOV_USERSPACE
        select CPU_FREQ_24_API if SYSCTL

config CPU_FREQ_SA1110
        bool
        depends on CPU_FREQ && (SA1100_ASSABET || SA1100_CERF |
SA1100_PT_SYSTEM3)
        default y
        select CPU_FREQ_DEFAULT_GOV_USERSPACE
        select CPU_FREQ_24_API if SYSCTL


IMO this should cause the default governor to be forced to "userspace",
and the deprecated 2.4. API [including cpufreq_get()] to be activated as
well. However, Kconfig thinks different: the default setting for
CPU_FREQ_DEFAULT_GOV (see drivers/cpufreq/Kconfig) is PERFORMANCE, and
this seems to take precedence over the "select". IMHO this is a Kconfig
bug -- can you notify the maintainer of this issue, please?

Else we'd have to change drivers/cpufreq/Kconfig from
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
to
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE if !CPU_FREQ_SA1100
default CPU_FREQ_DEFAULT_GOV_USERSPACE if !CPU_FREQ_SA1100
or disable the selection for CPU_FREQ_SA1100 completely.

    Dominik


----- End forwarded message -----

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel

Reply via email to