Re: [kbuild-devel] CONFIG_HOTPLUG_CPU: kconfig bug?
Hi,
On Wed, 29 Aug 2007, Sam Ravnborg wrote:
I've noticed an oddity with CONFIG_HOTPLUG_CPU in 2.6.23-rc:
make oldconfig seems to turn it on even when nothing wants it,
increasing kernel size by about 10k; but if you then edit the
line out of .config and make oldconfig again, it correctly
offers the choice and lets it be turned off after all.
I have tried to track down what is happening here.
The culprint is:
config SUSPEND_SMP
bool
depends on SUSPEND_SMP_POSSIBLE PM_SLEEP
select HOTPLUG_CPU
default y
It seems that due to the fact that SUSPEND_SMP is default y
then kconfig enforce the select HOTPLUG_CPU.
It's somewhat a side effect of using select and defaults, the order of the
config symbols becomes significant for oldconfig, if you look at the
output you'll find:
Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL) (HOTPLUG_CPU)
[Y/?] y
this sets it to 'y'. In this case one isn't asked about it, because there
is only one choice. The patch below avoids the setting of the value here.
bye, Roman
Avoid setting the value if the symbol doesn't need to be changed or can't
be changed. Later choices may change the dependencies and thus the
possible input range.
Signed-off-by: Roman Zippel [EMAIL PROTECTED]
---
scripts/kconfig/conf.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
Index: linux-2.6/scripts/kconfig/conf.c
===
--- linux-2.6.orig/scripts/kconfig/conf.c
+++ linux-2.6/scripts/kconfig/conf.c
@@ -72,7 +72,7 @@ static void check_stdin(void)
}
}
-static void conf_askvalue(struct symbol *sym, const char *def)
+static int conf_askvalue(struct symbol *sym, const char *def)
{
enum symbol_type type = sym_get_type(sym);
tristate val;
@@ -87,7 +87,7 @@ static void conf_askvalue(struct symbol
printf(%s\n, def);
line[0] = '\n';
line[1] = 0;
- return;
+ return 0;
}
switch (input_mode) {
@@ -97,23 +97,23 @@ static void conf_askvalue(struct symbol
case set_random:
if (sym_has_value(sym)) {
printf(%s\n, def);
- return;
+ return 0;
}
break;
case ask_new:
case ask_silent:
if (sym_has_value(sym)) {
printf(%s\n, def);
- return;
+ return 0;
}
check_stdin();
case ask_all:
fflush(stdout);
fgets(line, 128, stdin);
- return;
+ return 1;
case set_default:
printf(%s\n, def);
- return;
+ return 1;
default:
break;
}
@@ -123,7 +123,7 @@ static void conf_askvalue(struct symbol
case S_HEX:
case S_STRING:
printf(%s\n, def);
- return;
+ return 1;
default:
;
}
@@ -174,6 +174,7 @@ static void conf_askvalue(struct symbol
break;
}
printf(%s, line);
+ return 1;
}
int conf_string(struct menu *menu)
@@ -187,7 +188,8 @@ int conf_string(struct menu *menu)
def = sym_get_string_value(sym);
if (sym_get_string_value(sym))
printf([%s] , def);
- conf_askvalue(sym, def);
+ if (!conf_askvalue(sym, def))
+ return 0;
switch (line[0]) {
case '\n':
break;
@@ -240,7 +242,8 @@ static int conf_sym(struct menu *menu)
if (menu_has_help(menu))
printf(/?);
printf(] );
- conf_askvalue(sym, sym_get_string_value(sym));
+ if (!conf_askvalue(sym, sym_get_string_value(sym)))
+ return 0;
strip(line);
switch (line[0]) {
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now http://get.splunk.com/
___
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] CONFIG_HOTPLUG_CPU: kconfig bug?
It's somewhat a side effect of using select and defaults, the order of the
config symbols becomes significant for oldconfig,
And the patch have a side effect or just buggy `diff -p` output :)
[]
-static void conf_askvalue(struct symbol *sym, const char *def)
+static int conf_askvalue(struct symbol *sym, const char *def)
{
enum symbol_type type = sym_get_type(sym);
tristate val;
@@ -87,7 +87,7 @@ static void conf_askvalue(struct symbol
^ it's int already.
printf(%s\n, def);
line[0] = '\n';
line[1] = 0;
- return;
+ return 0;
}
switch (input_mode) {
@@ -97,23 +97,23 @@ static void conf_askvalue(struct symbol
Eeh, programmers...
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now http://get.splunk.com/
___
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] CONFIG_HOTPLUG_CPU: kconfig bug?
On Mon, Aug 27, 2007 at 03:54:49PM +0100, Hugh Dickins wrote: Hi Roman, I've noticed an oddity with CONFIG_HOTPLUG_CPU in 2.6.23-rc: make oldconfig seems to turn it on even when nothing wants it, increasing kernel size by about 10k; but if you then edit the line out of .config and make oldconfig again, it correctly offers the choice and lets it be turned off after all. (I've not actually tried make anything_else_config.) Attached is a 2.6.23-rc1 i386 SMP .config, CONFIG_HOTPLUG_CPU not set, with which it should be easy to reproduce the issue: just make oldconfig in an -rc2 or current kernel tree (being sure to choose N for SUSPEND and HIBERNATION: those rightly select it). I tried to reproduce this with no luck: $ mv hugh .config $ make scripts/kconfig/conf -s arch/i386/Kconfig * * Restart config... * * * Power management options (ACPI, APM) * Power Management support (PM) [Y/n/?] y Legacy Power Management API (DEPRECATED) (PM_LEGACY) [N/y/?] n Power Management Debug Support (PM_DEBUG) [N/y/?] n Suspend to RAM and standby (SUSPEND) [Y/n/?] (NEW) n = I selected 'n' Hibernation (aka 'suspend to disk') (HIBERNATION) [N/y/?] (NEW) n = I selected 'n' * * Fusion MPT device support * Fusion MPT ScsiHost drivers for SPI (FUSION_SPI) [Y/n/m/?] y Fusion MPT ScsiHost drivers for FC (FUSION_FC) [N/m/y/?] n Fusion MPT ScsiHost drivers for SAS (FUSION_SAS) [N/m/y/?] n Maximum number of scatter gather entries (16 - 128) (FUSION_MAX_SGE) [128] 128 Fusion MPT misc device (ioctl) driver (FUSION_CTL) [N/m/y/?] n Fusion MPT logging facility (FUSION_LOGGING) [N/y/?] (NEW) # # configuration written to .config # CHK include/linux/version.h CHK include/linux/utsrelease.h make: *** [_all] Interrupt $ grep HOTPLUG_CPU .config # CONFIG_HOTPLUG_CPU is not set If you let kbuild do a silentoldconfig then I expect it to be set due to SUSPEND being set. If you can still reproduce it could you then explan the exect stepts to do so. PS. I used latest -linus as of yesterday. Sam - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel
