[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 Stefano Pettini changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #31 from dtl135dtl...@gmail.com --- Yeah, the 0/8k thing is a mistake. Forgive me. Computer science classes were many years and many, many beers ago. Feel free to fix it, though I'm not sure why anyone would want AAC-LC files with such a low

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #30 from rdragonr...@gmail.com --- That's weird. I was not the one to write the original patch, so I am surprised to hear about that. I don't see a reason it should be 0bps, at least according to the code. Maybe 8k is too low? I have

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #28 from rdragonr...@gmail.com --- The primary patch is designed to still work with faac / libfaac (at least according to the person who wrote it), as far as I am aware. I am not certain, though, what encoder/decoder provides it, since all

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 Stefano Pettini changed: What|Removed |Added CC|

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #26 from rdragonr...@gmail.com --- I have followed the instructions in the two recent posts, the Github mock and the mySQL liblz4 ones. I attempted to use the Github google mock rather than the built-in one, but I still got this error set

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #25 from dtl135dtl...@gmail.com --- I also hit an error with MySQL and something about -llz4 flag. I installed liblz4-dev and liblz4-tool and one of those took care of it. -- You are receiving this mail because: You are watching all bug

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #24 from dtl135dtl...@gmail.com --- I would try to get rid of the Ubuntu repo packages (libgtest-dev and google-mock) and use the upstream googletest: cd git clone https://github.com/google/googletest.git cd googletest/ mkdir build cd

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #23 from rdragonr...@gmail.com --- I have submitted the patch the reviewboard.kde.org, but I don't know what to do further. I am not a developer there, and don't really know much application coding. (I can write simple C programs, but don't

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #22 from rdragonr...@gmail.com --- Thank you. I have already installed google-mock and libgtest-dev, at very least. Would you know what package might provide the missing service? It also lists them as present but in need of building? --

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #21 from Myriam Schweingruber --- Comment on attachment 107274 --> https://bugs.kde.org/attachment.cgi?id=107274 Cmake log when encountering build error "CMake Error at tests/CMakeLists.txt:143 (add_subdirectory):

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #20 from rdragonr...@gmail.com --- I can't figure out what the error might be. I think everything was installed, but I had to somewhat guess, since apt-get build-dep does not seem to have a complete listing. Can you tell what might be

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #19 from rdragonr...@gmail.com --- Created attachment 107274 --> https://bugs.kde.org/attachment.cgi?id=107274=edit Cmake log when encountering build error -- You are receiving this mail because: You are watching all bug changes.

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #18 from Christoph Feck --- Nepomuk is optional, and you do not need it. To understand the actual error, please review the complete cmake log file(s). -- You are receiving this mail because: You are watching all bug

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #17 from rdragonr...@gmail.com --- I am still working on this. I have recently gotten some spare time, so I am trying to run the tests for the submitted patch for regular AAC format encoding. (I do not understand this entirely, but I had

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #16 from rdragonr...@gmail.com --- He-AAC format is still not working, and I don't know how to fix that one. -- You are receiving this mail because: You are watching all bug changes.

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #15 from rdragonr...@gmail.com --- The patch is now in git format and works. DTL's patch seems to have been correct, but I had some issues testing it that are now resolved. -- You are receiving this mail because: You are watching all bug

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #14 from rdragonr...@gmail.com --- Created attachment 105718 --> https://bugs.kde.org/attachment.cgi?id=105718=edit Git patch working for Amarok AAC transcoding now I converted the patch to git, and after some reading on regex, got it

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #13 from rdragonr...@gmail.com --- I found the guide, but it would seem that the dot character is supposed to match any character. This makes my assumption about why the regex is failing incorrect, and I need to do some more research... --

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #12 from Christoph Feck --- QRegExp uses the standard syntax for regular expressions. The web is full of tutorials for those. -- You are receiving this mail because: You are watching all bug changes.

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #11 from rdragonr...@gmail.com --- Thanks. I managed to make a patch (and the patched program builds and runs!), unfortunately, it does not work. The problem is that the new patch for AAC searches this regex: return ffmpegOutput.contains(

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #10 from Myriam Schweingruber --- The command you are looking for is git diff :-) -- You are receiving this mail because: You are watching all bug changes.

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #9 from rdragonr...@gmail.com --- I was the discoverer of the problem, but the other poster, DTL135, was the person to create the fix. He did not want to convert the patch format, however. I am guessing the format is with the diff command,

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #8 from Myriam Schweingruber --- How did you make this patch if you do not use git? There are a huge load of HOWTOs available online, and there is also a quite comprehensive guide on our KDE wikis for this:

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #7 from rdragonr...@gmail.com --- Sorry to have taken so long. I got locked out of the KDE reviewboard for some reason (account creation issues), and have been quite busy with schoolwork. Unfortunately, I can't seem to submit the patch,

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #6 from Myriam Schweingruber --- As described in comment #2. You need an account on identity.kde.org, then submit the patch to reviewboard.kde.org and subscribe the Amarok group to it. The websites are pretty elf-explaining

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #5 from rdragonr...@gmail.com --- Okay, it seems that this is not getting resolved on its own. How might *I* submit that patch to the review board? How does that work? -- You are receiving this mail because: You are watching all bug

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 dtl135dtl...@gmail.com changed: What|Removed |Added Attachment #103405|initialpatch|aacfix description|

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #4 from dtl135dtl...@gmail.com --- Created attachment 103641 --> https://bugs.kde.org/attachment.cgi?id=103641=edit Poor Attempt at Initial HE-AAC Support -- You are receiving this mail because: You are watching all bug changes.

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #3 from dtl135dtl...@gmail.com --- (In reply to Myriam Schweingruber from comment #2) > Thank you for this patch, can you please submit it to reviewboard.kde.org, > and subscribe the Amarok group to it? I tried, but my patches are not in

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 --- Comment #2 from Myriam Schweingruber --- Thank you for this patch, can you please submit it to reviewboard.kde.org, and subscribe the Amarok group to it? -- You are receiving this mail because: You are watching all bug changes.

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 dtl135dtl...@gmail.com changed: What|Removed |Added CC||dtl135dtl...@gmail.com --- Comment #1

[amarok] [Bug 374670] AAC transcoding is broken due to deprecated libfaac

https://bugs.kde.org/show_bug.cgi?id=374670 rdragonr...@gmail.com changed: What|Removed |Added CC||rdragonr...@gmail.com -- You are