[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 swatilodh...@gmail.com changed: What|Removed |Added Latest Commit||http://commits.kde.org/digi

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #22 from swatilodh...@gmail.com --- Thanks a lot Maik for testing. I'll apply the patch and close this entry. -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #21 from Maik Qualmann --- Yes, the patch works. With this patch, an image is again visible in the album when the image information is missing. After rereading metadata from the image are the image information also

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #19 from caulier.gil...@gmail.com --- I cannot test for the moment as i'm not at home. Ask to Maik if he can test. Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #18 from swatilodh...@gmail.com --- (In reply to caulier.gilles from comment #17) > In your new patch xml file is untouched, only cpp files. It's wanted ? Yes, 'cause that cpp file decides the images to be displayed in the UI. So, JOIN must

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #17 from caulier.gil...@gmail.com --- In your new patch xml file is untouched, only cpp files. It's wanted ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #16 from caulier.gil...@gmail.com --- In your new patch xml file is untouched. It's the w -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #15 from swatilodh...@gmail.com --- Created attachment 100335 --> https://bugs.kde.org/attachment.cgi?id=100335=edit Updated patch Okay, I did realize after some testing that I made some unwanted changes in the XML schema file which

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 swatilodh...@gmail.com changed: What|Removed |Added Attachment #100320|0 |1 is obsolete|

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #14 from caulier.gil...@gmail.com --- Well, if the schema of tables are untouched no, and it sound the case. Only the way to handle data from table with SQL action are touched. But the revision of XML file need to be increased of course.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #13 from swatilodh...@gmail.com --- (In reply to caulier.gilles from comment #12) > By intrusive, i want mean it touch code in different place. > > As sqlite code in XML file is touched, the sqlite schema ID need to be > updated ? No schema

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #12 from caulier.gil...@gmail.com --- By intrusive, i want mean it touch code in different place. As sqlite code in XML file is touched, the sqlite schema ID need to be updated ? No schema updater need to be written ? Gilles Caulier --

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #11 from swatilodh...@gmail.com --- (In reply to caulier.gilles from comment #9) > Swati, > > In your patch, did you touch the sqlite schema or only mysql one ? I've changed the queries for both MySQL and SQLite in XML schema file, and of

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #10 from caulier.gil...@gmail.com --- Richard, This patch from Swati sound acceptable for you ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]

https://bugs.kde.org/show_bug.cgi?id=339607 caulier.gil...@gmail.com changed: What|Removed |Added Summary|MYSQL : Images not show if |MYSQL : Images not show if

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #8 from swatilodh...@gmail.com --- Created attachment 100320 --> https://bugs.kde.org/attachment.cgi?id=100320=edit Patch to fix this issue. I've changed INNER JOIN to LEFT JOIN at several places in the source code to ensure that images

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #7 from swatilodh...@gmail.com --- MySQL and SQLite return the same results. Both do not show images if the entry for that image id is removed from Image Information table. -- You are receiving this mail because: You are watching all bug

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #6 from Richard Mortimer --- Sorry. Had missed this one. I cannot see an obvious reason why there would be a difference between SQLite and MySQL. It should be easy to test the queries from the commandline in both

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #5 from caulier.gil...@gmail.com --- Richard, Do you see my previous comment ? Thanks in advance Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 caulier.gil...@gmail.com changed: What|Removed |Added CC||richm+...@oldelvet.org.uk ---

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #3 from swatilodh...@gmail.com --- Using "LEFT JOIN" instead of "INNER JOIN" in the SQL queries involving Images and ImageInformation tables, would be useful here? -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database

https://bugs.kde.org/show_bug.cgi?id=339607 caulier.gil...@gmail.com changed: What|Removed |Added Version|4.3.0 |5.0.0 -- You are receiving this