[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #15 from RJVB --- Let's just hope that it's the only fix required. As I said, it's not like I had systematic error messages about the dynamic_cast or even systematic failures, making this somewhat of a Heisenbug. I'll

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 Sven Brauch changed: What|Removed |Added Latest Commit|http://commits.kde.org/kdev |http://commits.kde.org/kdev

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #13 from Sven Brauch --- Yes, that looks like a solution to the problem. Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 Sven Brauch changed: What|Removed |Added Latest Commit||http://commits.kde.org/kdev

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #11 from RJVB --- Created attachment 101587 --> https://bugs.kde.org/attachment.cgi?id=101587=edit Give IProblem public visibility. -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #10 from RJVB --- For now the patch below seems to be a proper fix but I cannot vouch if it's a definite fix too. -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #9 from RJVB --- So, changing the "assert's" else clause to const auto ptr = diagnostic.data(); qWarning() << Q_FUNC_INFO << "dynamic cast to ClangProblem failed of" << ptr <<

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #8 from RJVB --- BTW, I see that ClangProblem already has a KDEVCLANGPRIVATE_EXPORT macro in its definition; its parents have KDEVPLATFORMLANGUAGE_EXPORT except for IProblem. Am I correct that this changes your

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #7 from RJVB --- Ok, let's not call it a fix then, but a sensible protection. It's still wrong to just let code fail somewhere down the line by allowing it to dereference a null pointer. And if the dynamic_cast isn't

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #6 from Sven Brauch --- The cast shouldn't fail. The code obviously excepts that only objects that can be cast into a ClangProblem are in the vector. The dynamic_cast is only there to make it easier to debug if it fails.

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #5 from RJVB --- What can possibly wrong about the fix? If a variable shouldn't be NULL and there are apparently reasons why it can happen outside of reasonable precautions, NOT checking is wrong. And clearly this is

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 Sven Brauch changed: What|Removed |Added CC||m...@svenbrauch.de ---

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #3 from RJVB --- scrap that about not seeing the warning: ClangFixits ClangProblem::allFixits() const dynamic cast to ClangProblem failed of 0x7fa2e1f475a8 ClangFixits ClangProblem::allFixits() const dynamic cast to

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 RJVB changed: What|Removed |Added CC||kf...@kde.org See Also|

[kdevelop] [Bug 370641] kdevelop (clang parser) crash when selecting a specific line

https://bugs.kde.org/show_bug.cgi?id=370641 --- Comment #1 from RJVB --- Another one: Is this output from KDevelop too? "error: abstractnavigationwidget.cpp.o DWARF DIE at 0x16b4 for class 'QWidget' has a base class 'QObject' that is a forward declaration, not a