[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-22 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376739 Elvis Angelaccio changed: What|Removed |Added Latest Commit|

[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-21 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376739 --- Comment #6 from Elvis Angelaccio --- Ok I figured out why kcmshell is not affected, it just resets the Apply button to false later... I'll try to come up with a patch, KCModule::changed(true) should not be emitted in the

[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-21 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=376739 --- Comment #5 from Jan Grulich --- With settingChanged() signal it's a bit tricky, because some connection types (e.g. wireless) asynchronously loads passwords and once those are received then we fill the UI with them which emits

[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-21 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376739 --- Comment #4 from Elvis Angelaccio --- Ok I this is what is going on here. Debug output when running kcmshell5 kcm_networkmanagement: Going to emit validityChanged( false ) from: void ConnectionEditorBase::initialize()

[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-21 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376739 --- Comment #3 from Elvis Angelaccio --- Yes. I just noticed that 'kcmshell5 kcm_networkmanagement' is not affected. I'll try to investigate what's going on... -- You are receiving this mail because: You are watching all bug

[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-20 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=376739 Jan Grulich changed: What|Removed |Added CC||jgrul...@redhat.com ---

[plasma-nm] [Bug 376739] KCM shows the Apply Settings dialog even if nothing changed

2017-02-20 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376739 --- Comment #1 from Elvis Angelaccio --- (In reply to Elvis Angelaccio from comment #0) > To reproduce: > > - Open the new Connection KCM > - Go back (click the All Settings button in System Settings) or just close System