https://bugs.kde.org/show_bug.cgi?id=385158
Bug ID: 385158
Summary: QDialogButtonBox::Discard is overridden to use
"edit-clear" icon; upstream setting ("edit-delete"
icon) is correct
Product: plasmashell
Version: master
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: k...@davidedmundson.co.uk
Reporter: pointedst...@zoho.com
CC: plasma-b...@kde.org
Target Milestone: 1.0
When you create a QDialogButtonBox with a Discard button via
QDialogButtonBox::Discard, it uses the edit-clear icon from the theme. An
example is Spectacle's main window.
This is incorrect: the Discard action is destructive, so it should use the
edit-delete icon. In fact, upstream Qt uses this icon by default:
https://github.com/qt/qtbase/blob/6d699d08200b1fe3a616dfbc275d46c98b77fcbd/src/widgets/styles/qcommonstyle.cpp#L5780
Somewhere we're overriding this, and we should probably stop, because
edit-delete is more correct.
--
You are receiving this mail because:
You are watching all bug changes.
