https://bugs.kde.org/show_bug.cgi?id=384584
Bug ID: 384584
Summary: list first callee saved registers for AMD64, X86, and
PPC architectures
Product: valgrind
Version: 3.14 SVN
Platform: Compiled Sources
OS:
https://bugs.kde.org/show_bug.cgi?id=384584
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|UNCONFIRMED |ASSIGNED
Summar
https://bugs.kde.org/show_bug.cgi?id=255603
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
https://bugs.kde.org/show_bug.cgi?id=255603
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||ma...@debian.org
--- Comm
https://bugs.kde.org/show_bug.cgi?id=332577
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Resolution|--- |DUPLICATE
https://bugs.kde.org/show_bug.cgi?id=208531
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comme
https://bugs.kde.org/show_bug.cgi?id=384526
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Resolution|--- |FIXED
Status|AS
https://bugs.kde.org/show_bug.cgi?id=384526
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
See Also||https://bugs.kde.org/
https://bugs.kde.org/show_bug.cgi?id=384337
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
See Also||https://bugs.kde.org/
https://bugs.kde.org/show_bug.cgi?id=384526
--- Comment #2 from Ivo Raisr <iv...@ivosh.net> ---
We can see the following performance improvement:
running Memcheck on perf/bz2:
baseline: 45,132 M instructions total; 161 M instructions
doRegisterAllocation_v3
patched: 45,107 M instructions
https://bugs.kde.org/show_bug.cgi?id=384526
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comm
https://bugs.kde.org/show_bug.cgi?id=384526
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|CONFIRMED |ASSIGNED
--
You are rec
https://bugs.kde.org/show_bug.cgi?id=384526
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Summary|reduce number of spill |reduce number of
https://bugs.kde.org/show_bug.cgi?id=384526
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Assigne
https://bugs.kde.org/show_bug.cgi?id=384526
Bug ID: 384526
Summary: reduce number of spill instructions in VEX register
allocator v3
Product: valgrind
Version: 3.14 SVN
Platform: Compiled Sources
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #13 from Ivo Raisr <iv...@ivosh.net> ---
Interestingly enough, VEX register allocator v2 also benefits from register
reordering:
For Memcheck on perf/bz2:
ra2-baseline: 45,214 M instructions total; 209 M doRegisterAllocation_
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #12 from Ivo Raisr <iv...@ivosh.net> ---
(In reply to Ivo Raisr from comment #10)
Included is also total cost of running doRegisterAllocation_v2/3:
Here are my findings for running Memcheck on perf/bz2:
v2 baseline: 45.214 G instru
https://bugs.kde.org/show_bug.cgi?id=384337
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Assignee|jsew...@acm.org |iv...@ivosh.net
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #9 from Ivo Raisr <iv...@ivosh.net> ---
Created attachment 107711
--> https://bugs.kde.org/attachment.cgi?id=107711=edit
Reorder allocatable registers for AMD64 and X86 archs
Reorder allocatable registers for AMD64 a
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #7 from Ivo Raisr <iv...@ivosh.net> ---
What I would like to do next is to compare how v2 and v3 allocate registers on
some hot paths in perf/bz2. However I have difficulty how to locate such SBs.
Although Callgrind shows add
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #6 from Ivo Raisr <iv...@ivosh.net> ---
Philippe, please could you measure these guys on your performance tests.
Although I was able to determine total instruction count on Memcheck+perf/bz2,
I was not able to measure rea
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #5 from Ivo Raisr <iv...@ivosh.net> ---
Created attachment 107678
--> https://bugs.kde.org/attachment.cgi?id=107678=edit
Small performance enhancement to v2. Also makes it the default for testing.
Small performance enhanceme
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #4 from Ivo Raisr <iv...@ivosh.net> ---
Created attachment 107677
--> https://bugs.kde.org/attachment.cgi?id=107677=edit
Different algorithm for find_vreg_to_spill() in v3.
Different algorithm for find_vreg_to_spill() in v3.
Also
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #3 from Ivo Raisr <iv...@ivosh.net> ---
Created attachment 107676
--> https://bugs.kde.org/attachment.cgi?id=107676=edit
Scan 10 instructions ahead instead of just 5
Scans 10 instructions ahead in function find_vreg_to_spill(
https://bugs.kde.org/show_bug.cgi?id=384337
--- Comment #2 from Ivo Raisr <iv...@ivosh.net> ---
Created attachment 107675
--> https://bugs.kde.org/attachment.cgi?id=107675=edit
Track vreg usage on per-instruction precision in v3
Tracks vreg usage on per-instruction basis, using bitse
https://bugs.kde.org/show_bug.cgi?id=384337
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comm
https://bugs.kde.org/show_bug.cgi?id=384337
Bug ID: 384337
Summary: performance improvements to VEX register allocator v2
and v3
Product: valgrind
Version: 3.14 SVN
Platform: Compiled Sources
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=384096
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Resolution|--- |FIXED
Status|AS
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #73 from Ivo Raisr <iv...@ivosh.net> ---
https://sourceware.org/git/?p=valgrind.git;a=commit;h=efa1e5ef8d257e3b20facf6f04350d29578ae9e4
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=384096
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #107555|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=384096
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Summary|HTML page for AddrCheck is |Mention Add
https://bugs.kde.org/show_bug.cgi?id=384096
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivo
https://bugs.kde.org/show_bug.cgi?id=384096
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Platform|Compiled Sources|unspecified
--
You are rec
https://bugs.kde.org/show_bug.cgi?id=384096
Bug ID: 384096
Summary: HTML page for AddrCheck is still present in
valgrind-www repository
Product: valgrind
Version: unspecified
Platform: Compiled Sources
OS:
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #71 from Ivo Raisr <iv...@ivosh.net> ---
I am going to integrate patch 014 next week unless I hear otherwise.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #107068|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381713
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Resolution|--- |WONTFIX
https://bugs.kde.org/show_bug.cgi?id=383602
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comm
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #68 from Ivo Raisr <iv...@ivosh.net> ---
(In reply to Petar Jovanovic from comment #67)
> This seems to be related to the way how MIPS port uses and handles
> DivModU128to64 and some other Iops.
> The issue comes from
https://bugs.kde.org/show_bug.cgi?id=381819
--- Comment #11 from Ivo Raisr <iv...@ivosh.net> ---
Awesome!
So the patch is able properly decode the following variants:
bextr 408,%eax,%edx
bextr 404,%eax,%edx
bextr 1D03,%rcx,%rcx
bextr 305,%eax,%eax
bextr A0C,%ebx,%edx
bextr 305,%eax,%eax
https://bugs.kde.org/show_bug.cgi?id=381819
--- Comment #9 from Ivo Raisr <iv...@ivosh.net> ---
Thank you for testing this.
So I can see two problems in the tests you conducted:
1. There are some new unrecognized instructions. You progressed further now
that bextr is supported and the
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #66 from Ivo Raisr <iv...@ivosh.net> ---
Pending no other problems arise, I would like to land new VEX register
allocator v3 after SVN->GIT migration is completed and the dust settles. That
is in 2-3 weeks from now.
The new v
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #65 from Ivo Raisr <iv...@ivosh.net> ---
(In reply to Petar Jovanovic from comment #63)
> The latest patch (lucky 13) seems to work fine on one MIPS variant I
> have tested. Thanks for the extra work.
> I will test other MIPS
https://bugs.kde.org/show_bug.cgi?id=381819
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
See Also||https://bugs.kde.org/
https://bugs.kde.org/show_bug.cgi?id=322586
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
See Also||https://bugs.kde.org/
https://bugs.kde.org/show_bug.cgi?id=381819
--- Comment #7 from Ivo Raisr <iv...@ivosh.net> ---
Weird, line 20564 pertains to decoding "pop" instruction.
There is a test case in Valgrind regression test suite:
none/tests/amd64/bmi.c which exercises bextr with the following oper
https://bugs.kde.org/show_bug.cgi?id=381819
--- Comment #5 from Ivo Raisr <iv...@ivosh.net> ---
So "bextr" should be supported by function dis_ESC_0F38__VEX(), file
VEX/priv/guest_amd64_toIR.c.
Either it is some uncommon variant or the decoder got confused somehow.
You can st
https://bugs.kde.org/show_bug.cgi?id=381819
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
S
https://bugs.kde.org/show_bug.cgi?id=381819
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comm
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #62 from Ivo Raisr <iv...@ivosh.net> ---
Patches 013 should fix the assertion hit on MIPS platform
when doing MOV coalescing and the destination vreg is becoming dead.
Petar, please could you test please?
Also I think that this sc
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #107036|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #107037|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #59 from Ivo Raisr <iv...@ivosh.net> ---
Thank you, Petar. I was able to download the file and decipher it. The root
cause is now known and I have to find an elegant way how to fix it.
--
You are receiving this mail becaus
https://bugs.kde.org/show_bug.cgi?id=382998
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Resolution|--- |FIXED
Status|AS
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #57 from Ivo Raisr <iv...@ivosh.net> ---
Petar, thank you again for testing patches 012!
Please could you set to 1 the following #define's at the beginning of
host_generic_reg_alloc3.c:
#define DEBUG_REGALLOC 1
#
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #55 from Ivo Raisr <iv...@ivosh.net> ---
Patches 012 should fix the assertion hit on MIPS platform in function
find_free_rreg().
Petar, please could you test please?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #107009|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #107008|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=382998
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Component|memcheck|general
Version|
https://bugs.kde.org/show_bug.cgi?id=382998
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivo
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #52 from Ivo Raisr <iv...@ivosh.net> ---
Petar, thank you for the detailed output. Now the root cause is clear and I
need to fix slightly the algorithm in find_free_rreg().
I'll prepare a new set of patches...
--
You are rec
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #50 from Ivo Raisr <iv...@ivosh.net> ---
Petar,
Thank you for the debugging output. Unfortunately it is not sufficient
to infer what went wrong.
Please could you set to 1 the following #define's at the beginning of
host_generic_reg_al
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #47 from Ivo Raisr <iv...@ivosh.net> ---
Patches 011 (re-)introduce command line option --vex-regalloc-version=2|3 which
allows to switch between register allocator implementations. Note that version
3 (new implementation) is now the d
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106877|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106876|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=79362
--- Comment #69 from Ivo Raisr <iv...@ivosh.net> ---
Just a quick note:
Once this functionality is integrated, remove the corresponding entry from www
page http://valgrind.org/help/projects.html:
---
Preserving debugging infor
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #43 from Ivo Raisr <iv...@ivosh.net> ---
(In reply to Petar Jovanovic from comment #41)
> With the changes (patch 010 Valgrind/VEX) applied, Memcheck is crashing on
> MIPS32/MIPS64.
Petar, thank you for testing the patches.
Plea
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #42 from Ivo Raisr <iv...@ivosh.net> ---
Created attachment 107004
--> https://bugs.kde.org/attachment.cgi?id=107004=edit
patch 010 - VEX part + some debugging for MIPS crashes
This patch adds some debugging statements in find_
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #39 from Ivo Raisr <iv...@ivosh.net> ---
Patches 010 implement the necessary changes for supporting the register
allocator v3 to all architectures supported by VEX.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106802|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106801|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #36 from Ivo Raisr <iv...@ivosh.net> ---
Some performance comparison...
Number of instructions executed either in function
doRegisterAllocation() [Valgrind baseline, v2] or
doRegisterAllocation_v3 [new VEX register allocat
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #35 from Ivo Raisr <iv...@ivosh.net> ---
The final set of patches implementing new VEX register allocator version 3
for AMD64 and X86 architectures.
All regression tests pass successfully, Firefox runs ok.
--
You are receiving thi
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106688|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106687|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=344547
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comm
https://bugs.kde.org/show_bug.cgi?id=382407
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Reso
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #32 from Ivo Raisr <iv...@ivosh.net> ---
Patches 008 implement direct reload optimization.
Now the only remaining TODO is the following one:
/* TODO-JIT: Contrary to what the algorithm overview
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106596|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106595|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=382256
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Reso
https://bugs.kde.org/show_bug.cgi?id=382256
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
https://bugs.kde.org/show_bug.cgi?id=382407
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comm
https://bugs.kde.org/show_bug.cgi?id=382407
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Assignee|jsew...@acm.org |iv...@ivo
https://bugs.kde.org/show_bug.cgi?id=382407
Bug ID: 382407
Summary: vg_perf needs "--terse" command line option
Product: valgrind
Version: 3.14 SVN
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity:
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #29 from Ivo Raisr <iv...@ivosh.net> ---
I tried to do performance comparison of reg_alloc v3 implementation as it
progresses in terms of patches. However the performance tests are not reliable
- I could not get consistent resul
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #28 from Ivo Raisr <iv...@ivosh.net> ---
The attached patches 007 implement groups of real registers in RRegUniverse.
They help to efficiently answer questions such as "Find me a free register of
the given class".
--
Y
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106549|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106550|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=332577
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever confi
https://bugs.kde.org/show_bug.cgi?id=332577
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Severity|normal |crash
--
You are rec
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #25 from Ivo Raisr <iv...@ivosh.net> ---
Right now the only remaining TODOs from patches 006 are:
/* TODO-JIT: To solve more efficiently questions such as "Find me a free
register of the given class" it would h
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106377|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106378|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #22 from Ivo Raisr <iv...@ivosh.net> ---
Memcheck "--stats=yes" results running on Firefox under amd64/Linux (Ubuntu):
v2:
716,447 (19,412,410 -> 331,710,658; ratio 17.1) [213,213 scs] avg tce size 462
v3 (patches 006):
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #21 from Ivo Raisr <iv...@ivosh.net> ---
I am currently on vacations so won't probably make any progress until the end
of July...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #17 from Ivo Raisr <iv...@ivosh.net> ---
Thank you for pointers where to focus next.
Indeed, that critical functionality is not implemented yet:
line 873 of host_generic_reg_alloc3.c:
/* Find a free rreg of the correct
https://bugs.kde.org/show_bug.cgi?id=381553
--- Comment #13 from Ivo Raisr <iv...@ivosh.net> ---
Patches 005 implement function find_vreg_to_spill().
With these patches, the register allocator v3 is able to produce correct
results for all tests in the Valgrind regression test suite.
The
https://bugs.kde.org/show_bug.cgi?id=381553
Ivo Raisr <iv...@ivosh.net> changed:
What|Removed |Added
Attachment #106324|0 |1
is ob
101 - 200 of 599 matches
Mail list logo
