[kdeconnect] [Bug 472697] Open with Open on Connected Device via KDE Connect appears for all files in Dolphin

2023-08-28 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=472697

--- Comment #3 from Chris Holland  ---
Uhg, can't find it. It's possible that the change is related to "mime
inheritance" instead of "application/octet-stream".

* KIO Search:
https://invent.kde.org/search?search=application%2Foctet-stream_source=navbar_id=2729_id=1552_code=true_ref=master
* (3 years ago) `KCoreDirLister::setMimeFilter`
https://invent.kde.org/frameworks/kio/-/blame/master/src/core/kcoredirlister.cpp?page=3#L2319
* (2 years ago) `KFileItemPrivate::determineMimeTypeHelper`
https://invent.kde.org/frameworks/kio/-/blame/master/src/core/kfileitem.cpp#L550
* (4 years ago) `KFileItem::currentMimeType`
https://invent.kde.org/frameworks/kio/-/blame/master/src/core/kfileitem.cpp?page=2#L1667
* (7 months ago) `KFileFilterCombo::setMimeFilter`
https://invent.kde.org/frameworks/kio/-/blame/master/src/filewidgets/kfilefiltercombo.cpp#L248
* (2 years ago) `KFileWidgetPrivate::updateAutoSelectExtension`
https://invent.kde.org/frameworks/kio/-/blame/master/src/filewidgets/kfilewidget.cpp?page=3#L2300
* (3 years ago) `HTTPProtocol::davParsePropstats`
https://invent.kde.org/frameworks/kio/-/blame/master/src/kioworkers/http/http.cpp#L932
* (7 years ago) `HTTPProtocol::fixupResponseMimetype`
https://invent.kde.org/frameworks/kio/-/blame/master/src/kioworkers/http/http.cpp?page=3#L2605
* (7 years ago) `http.json "defaultMimetype"`
https://invent.kde.org/frameworks/kio/-/blame/master/src/kioworkers/http/http.json#L7
* (1 year ago) `kfileitemactions.cpp mimeTypeListContains`
https://invent.kde.org/frameworks/kio/-/blame/master/src/widgets/kfileitemactions.cpp#L61
* (7 months ago) `KFileItemActionsPrivate::addPluginActionsTo`
https://invent.kde.org/frameworks/kio/-/blame/master/src/widgets/kfileitemactions.cpp#L533
* (1 year ago) `KFilePropsPlugin::slotEditFileType`
https://invent.kde.org/frameworks/kio/-/blame/master/src/widgets/kpropertiesdialog.cpp?page=2#L1234
* (1 year ago) `KFilePropsPlugin::updateDefaultHandler`
https://invent.kde.org/frameworks/kio/-/blame/master/src/widgets/kpropertiesdialog.cpp?page=2#L1595
* Dolphin Search (No Results):
https://invent.kde.org/search?repository_ref=master=application%2Foctet-stream_code=true=projects_id=1561_id=2775
* KService (kbuildsycoca5) (A few autotests):
https://invent.kde.org/search?repository_ref=master=application%2Foctet-stream_code=true=projects_id=1552_id=2379
* (3 years ago) Fix application preference ordering for mimetypes with multiple
inheritance.
https://invent.kde.org/frameworks/kservice/-/commit/d4c9cb9d0652c1ed7ba504335a50ea6bca7851e5

-

Operating System: openSUSE Tumbleweed 20230823
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.10
Kernel Version: 6.4.11-1-default (64-bit)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 472697] Open with Open on Connected Device via KDE Connect appears for all files in Dolphin

2023-08-28 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=472697

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #2 from Chris Holland  ---
*
https://discuss.kde.org/t/everything-downloaded-in-firefox-opens-in-kde-connect/4337
*
https://old.reddit.com/r/kde/comments/163jnhj/how_to_remove_kde_connects_url_handler_from/
*
https://invent.kde.org/network/kdeconnect-kde/-/blame/master/data/org.kde.kdeconnect_open.desktop#L132
*
https://invent.kde.org/network/kdeconnect-kde/-/commit/f1ce22124ce7dd630b8e909b4c50f90f035166d5

> https://discuss.kde.org/u/guss77 (2023-08-26):
>
> Weird that it only started happening recently - the relevant commit that 
> added KDE Connect open on application/octet-stream 1 was done 2 years ago.

So it's either a change in Dolphin, or KIO, or some other KDE Framework related
to MimeTypes?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 471136] kwin_x11 freezes xorg under certain conditions

2023-08-03 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=471136

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #9 from Chris Holland  ---
I was experiencing this or a similar bug on an AMD iGPU. The screen would
freeze but the mouse could be moved around. Music continued to play. After a
few seconds it un-freezes.

I was toying around with Disabling Desktop Effects:
* Morphing Popups
* Sliding Popups
* Squash (minimize effect)

And after clicking apply, the bug went away. I re-enabled those effects but I
could no longer reproduce.

--

I could previously easily reproduce the bug by:
* Spamming Meta key to open the app launcher (froze opening and closing).
* Gliding over the panel tasks in the taskmanager widget.
* Alt+Tabing.
* Opening/Closing Yakuake

Previously I killed kwin_x11 and the bug went away when opening/closing the app
menu with the mouse.

I tried disabling the compositor with the toggle key Alt+Shift+F12. I did not
disabled it from startup in System Settings > Compositor > Enable on Startup. I
still experienced the bug after disabling the compositor with the toggle key,
but maybe I did not actually disable it? I need to confirm this in a fresh KDE
install.

I previously installed Ubuntu (Gnome3 based) in another partition and did not
experience this bug so it's not the Kernel.

-

Operating System: openSUSE Tumbleweed 20230801
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.108.0
Qt Version: 5.15.10
Kernel Version: 6.4.6-1-default (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 5600G with Radeon Graphics (
https://www.amd.com/en/product/11176 )
Memory: 13.5 GiB of RAM (Corsair Vengence LPX 3600Ghz 2x8 GB sticks, with 2GB?
dedicated to VRAM)
Graphics Processor: AMD Radeon Graphics
Manufacturer: Micro-Star International Co., Ltd. (MSI Pro B550M-VC WIFI)
Product Name: MS-7C95
System Version: 3.0

-

- [YES] Entire desktop image is frozen
- [YES] Pointer still works
- [YES] Pointer still operates on desktop under frozen image (more on that
below)
- [TODO] killall -9 kwin_x11 and relaunching kwin_x11 recovers
  - If during the freeze, I tried to operate on any windows with pointer, they
now show up in updated positions/sizes, etc.
- [TODO] Does not happen if compositing is disabled
- [DID NOT CHECK] Does not happen on kernels older than 6.1.9
- [?] Does not happen with any other program
- [YES? TODO Was it Xorg or Wayland?] Does not happen on Gnome+Xorg
- [TODO] Does not happen on Plasma+Wayland (But too many other things don't
work for me)
- [TODO] Does not happen if compositing is toggled off then on after logging in
- [NO, kwin_x11 --replace still has the bug] Does not happen a 2nd time if kwin
is killed and restarted
- [TODO] Happens with a new user and user profile with default settings

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 464331] inconsistent scaling of taskbar icons

2023-01-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=464331

Chris Holland  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
Version|unspecified |5.26.5
   Assignee|zrenf...@gmail.com  |plasma-b...@kde.org
  Component|General |Task Manager and Icons-Only
   ||Task Manager
Product|Active Window Control   |plasmashell

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 463044] stuck on login screen when switch user after login

2022-12-20 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=463044

Chris Holland  changed:

   What|Removed |Added

  Component|General |general
 CC||zrenf...@gmail.com
Product|Active Window Control   |ksmserver
Version|unspecified |5.26.4
   Assignee|zrenf...@gmail.com  |k...@davidedmundson.co.uk

--- Comment #1 from Chris Holland  ---
You didn't install updates after login right?

This is reproduceable after restarting?

I think this is a KSMServer bug (software that displays the switch user
prompt), but it could be an SDDM bug (login screen).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeplasma-addons] [Bug 441241] When choosing Thumbnail Grid as your Task Switcher, tasks seem to be kept their position while you click the close button

2022-09-26 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=441241

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #7 from Chris Holland  ---
When Thumbnail Grid was written, this behavior was deliberate. It was so that
when you have 6 windows open, and you close 1 window, it doesn't resize the
window from 3x2 to 5x1. Also if you closed window #2 of 6, your mouse would be
hovering window #3 letting you easily close that window as well.

https://github.com/Zren/kwin-tabbox-thumbnail_grid/pull/2

The Alt+Tab popup currently goes from 5x2 => 3x3 => 4x2 right now...

Since I have it available: In Windows 11, the rows do not repopulate if a
window is closed after the Alt+Tab is show. In a 5x2, you can delete 4 windows
from the first row, and it'll still contain 1 window on the first row
(centered) and 5 windows on the bottom row. The windows in the top row do shift
to keep them centered though, and the window can resize if you delete windows
from both rows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 457466] Translated placeholder "Search..." text is not elided in SearchField

2022-08-04 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=457466

--- Comment #8 from Chris Holland  ---
After editing /usr/lib64/qt5/qml/org/kde/plasma/components.3/TextField.qml in
OpenSuse TW, I've noticed that `control.availableWidth` is `undefined`, which
means the width of the placeholder is undefined.

T.TextField {
id: control

Rectangle {
border.color: "yellow"
border.width: 1
color: "transparent"
x: control.leftPadding
y: control.topPadding
width: control.availableWidth
height: control.availableHeight
onWidthChanged: console.log('availableWidth',
control.availableWidth)
Component.onCompleted: console.log('availableWidth',
control.availableWidth)
}
...


I assume this is suppose to be `QQC2.Control.availableWidth` right?
* https://doc.qt.io/qt-6/qml-qtquick-controls2-control.html#availableWidth-prop

Except that `QQC2.TextField` does not inherit `QQC2.Control`.
* https://doc.qt.io/qt-6/qml-qtquick-controls2-textfield.html
* https://doc.qt.io/qt-6/qml-qtquick-textinput.html
* https://doc.qt.io/qt-6/qml-qtquick-item.html
*
https://github.com/qt/qtdeclarative/blob/dev/src/quicktemplates2/qquicktextfield_p.h
*
https://github.com/qt/qtdeclarative/blob/dev/src/quick/items/qquicktextinput_p.h

Seems there was a bug introduced in the commit that added
`control.availableWidth`. Git blame:
https://invent.kde.org/frameworks/plasma-framework/-/commit/52b9c9e94aec30ff8f0a05b0cf9a84e187f6bf61
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/213

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 457466] Translated placeholder "Search..." text is not elided in SearchField

2022-08-04 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=457466

--- Comment #6 from Chris Holland  ---
Searching 3175 files for "PlasmaExtras.SearchField":

kdeplasma-addons/applets/dict/package/contents/ui/main.qml
kwin/src/effects/windowview/qml/main.qml
plasma-desktop/applets/kicker/package/contents/ui/MenuRepresentation.qml
plasma-desktop/applets/kickoff/package/contents/ui/Header.qml
plasma-desktop/desktoppackage/contents/activitymanager/Heading.qml
plasma-desktop/desktoppackage/contents/explorer/WidgetExplorer.qml
plasma-framework/src/declarativeimports/plasmaextracomponents/qml/SearchField.qml
plasma-nm/applet/contents/ui/Toolbar.qml
plasma-workspace/applets/clipboard/contents/ui/ClipboardPage.qml
plasma-workspace/lookandfeel/contents/runcommand/RunCommand.qml

Adding `Item { Layout.minimumWidth: 300 }` to kickoff's Header.qml can also
duplicate this bug:
https://i.imgur.com/NklXX2t.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 457466] Translated placeholder "Search..." text is not elided in SearchField

2022-08-04 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=457466

Chris Holland  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #4 from Chris Holland  ---
I was able to confirm this bug in OpenSUSE TW as well:
https://i.imgur.com/wpxzFhG.png

1. Comment out all the `visible: __` stuff in plasma-nm's Toolbar.qml to show
all the extra fluff hidden on a non-wifi PC which shrinks the SearchField
width.
2. Resizing the plasmoid popup with Meta+RightClick+Drag to make the
SearchField even smaller.

The SearchField seems to use PC3.TextField at it's base. It has `elide:
Text.ElideRight` so I am not sure what's broken.

*
https://invent.kde.org/frameworks/plasma-framework/-/blob/master/src/declarativeimports/plasmaextracomponents/qml/SearchField.qml
*
https://invent.kde.org/frameworks/plasma-framework/-/blob/master/src/declarativeimports/plasmaextracomponents/qml/ActionTextField.qml
*
https://invent.kde.org/frameworks/plasma-framework/-/blame/master/src/declarativeimports/plasmacomponents3/TextField.qml#L122-138

Label {
id: placeholder
x: control.leftPadding
width: control.availableWidth
text: control.placeholderText
horizontalAlignment: control.horizontalAlignment
elide: Text.ElideRight
...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 457466] Translated placeholder "Search..." text is not elided in SearchField

2022-08-04 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=457466

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com
Summary|Bug with kde NetworkManager |Translated placeholder
   ||"Search..." text is not
   ||elided in SearchField

--- Comment #2 from Chris Holland  ---
Hmm, plasma-nm uses PlasmaExtras.SearchField for the search field.
https://invent.kde.org/plasma/plasma-nm/-/blob/master/applet/contents/ui/Toolbar.qml#L150

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spam] [Bug 457001] VISIT MY SITE

2022-07-21 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=457001

Chris Holland  changed:

   What|Removed |Added

Product|Active Window Control   |Spam
  Component|General |Spam
   Assignee|zrenf...@gmail.com  |n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 456736] Kate KCommandBar Ctrl+Alt+I Improvements

2022-07-15 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456736

--- Comment #4 from Chris Holland  ---
> You only care about dynamic word wrap but someone else might want static word 
> wrap instead. 

I was more concerned on how to turn word wrap off. I guess the user is suppose
to already know where it is in the menubar before they know about KCommandBar
Ctrl+Alt+I so they know what to select. I assumed it was radiobutton, but it
turns out it's 2 checkboxes. The heck is Static Wrap... oh it's the ruler.

Both Sublime and VSCode seem to call "Static Wrap" rulers.
https://stackoverflow.com/questions/25900954/80-characters-right-margin-line-in-sublime-text-3
https://stackoverflow.com/questions/29968499/vertical-rulers-in-visual-studio-code

Perhaps this:
View: Toggle Word Wrap
View: Toggle Wrap At Ruler
View: Toggle Ruler or Show/Hide Ruler

The main issues stem from KCommandBar not supporting a checked property /
checkbox. Since it doesn't seem to have separate text for the MenuBar Action
and KCommandBar. "Toggle Word Wrap" might look weird in the MenuBar.

Is it possible to automate adding a "Toggle " prefix or suffix to the action
name in KCommandBar if it has action.checkable=true?

> Convert an existing document with tabs to spaces? That would be just search 
> and replace. 

Yes that. A naive "" => "\t" replace would replace indents in comments, and
possible in code strings "BlahBlah". Since you're editing every since line,
it might not show up easily on a diff. To properly replace indentation you'd
need to use "^(\t|\s{4})*(\s{4})" => "\1\t" or something complicated like that.
In any case, it's one of those commands that's a nice to have that both ST and
VSCodium have by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 456736] Kate KCommandBar Ctrl+Alt+I Improvements

2022-07-15 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456736

--- Comment #2 from Chris Holland  ---
> Which git features did you not find? We have most of the common features. See 
> https://invent.kde.org/utilities/kate/-/issues/24

See: https://i.imgur.com/Bauese2.png
See:
https://old.reddit.com/r/kde/comments/vyuynb/which_ide_or_editor_do_kde_programmers_use_to/ig56mrj/?context=2

None of them appear in the KCommandBar except:

* Git: Gitk (gui app)
* Git: git blame (gui app)
* Kate Project Manager: Checkout Git Branch

SublimeText and VSCodium have:
https://gist.github.com/Zren/c0282057009270035ff42f0d9cfac9a0

> True, its confusing. The reason there are two is because one is Mode and the 
> other is Highlighting. They have slightly different roles.

Uhg, so syntax switches both the color/format+autocomplete+snippets, but
highlight only switches the color/format? They definitely need to be labeled in
KCommandBar. Actually, just hide the Highlight actions from KCommandBar,
because that feature is way too niche imo.

> Because all the three types of wraps you mention, fall under the "Word Wrap" 
> category and if you check the main menu, you will find these options listed 
> under View->Word Wrap -> 

Not every "setting" should be quickly accessed. Only the quick word wrap toggle
imo.

Sublime only exposes:
Wrap at ruler
Word Wrap: Toggle

VSCodium:
View: Toggle Word Wrap

However in sublime's menu is:
Edit > Wrap > Wrap Paragraph at Ruler
Edit > Wrap > Wrap Paragraph at 70 characters
Edit > Wrap > Wrap Paragraph at 72 characters
Edit > Wrap > Wrap Paragraph at 78 characters
Edit > Wrap > Wrap Paragraph at 80 characters
Edit > Wrap > Wrap Paragraph at 100 characters
Edit > Wrap > Wrap Paragraph at 120 characters
View > Word Wrap
View > Word Wrap Column > Automatic
View > Word Wrap Column > 70
View > Word Wrap Column > 72
View > Word Wrap Column > 78
View > Word Wrap Column > 80
View > Word Wrap Column > 100
View > Word Wrap Column > 120

And VSCodium has this in it's settings:
https://i.imgur.com/xNXuvh8.png

> Not sure what you mean by 3rd party plugin. You can change the indentation in 
> the statusbar (for the open document only). Kate has auto indent detection so 
> I don't bother with changing indent settings anymore.

I'd honestly forgotten it showed in the statusbar in ST and VSCodium. I've not
touched it since installing Sublime 3rd party plugin "Missing Commands" which
adds the "Tab Width 2/4" custom commands to Sublime. I sometimes adjust the
autodetect from Tab Width 2 > 4 which is nice to do from the keyboard. It
typically happens in markdown, where md lists are 2 spaces, but code tags are 4
spaces.

Kate doesn't seem to have Convert to Spaces/Tabs though which both Sublime and
VSCodium have by default. I'll need to lookup if there's a feature request for
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 456736] New: Kate KCommandBar Ctrl+Alt+I Improvements

2022-07-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456736

Bug ID: 456736
   Summary: Kate KCommandBar Ctrl+Alt+I Improvements
   Product: kate
   Version: 22.04.2
  Platform: Other
OS: Other
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: ---

Via:
https://old.reddit.com/r/kde/comments/vyuynb/which_ide_or_editor_do_kde_programmers_use_to/ig5gpvd/?context=3

Kate doesn't have a simple "Word Wrap: Toggle". There's:
"Kate Part: Apply Word Wrap" (nope)
"Kate Part: Static Word Wrap" (nope)
"Kate Part: Dynamic Word Wrap" (works as a toggle) but the naming is terrible.
There's no indication that it's a toggle in the name, nor a checkmark.

Ah, I forgot to test selecting Syntax. Hmm, seems that all "set syntax" options
are duplicated. There's two "3D: STL".
Also, "Configuration: INI" doesn't indicate that you are setting the syntax.

Git support hasn't been implemented yet, but I guess I'll mention to to look
into SublimeText's GitAddSelectedHunkCommand but that's way down the line.
https://github.com/kemayo/sublime-text-git/blob/master/git/add.py#L47

Ability to quickly set Indentation via KCommandBar is also a 3rd party plugin.
https://github.com/fjl/Sublime-Missing-Palette-Commands/blob/st3/Missing.sublime-commands#L166
There's also a few interesting commands in there like "Split Into Lines",
though Kate seems to already have VSCode's "Insert cursor at end of each line
selected" (Shift+Alt+I).
https://stackoverflow.com/questions/54130822/how-to-split-selection-into-lines

Not sure if this is Kate or KCommandBar, but the Command Palette seems to be
full of "Kate Part:" and "Kate Project Manager:" prefixes... but those labels
aren't searchable. The above labels aren't very useful either. Should be "Git:
Checkout Branch" instead of "Kate Project Manager: Checkout Git Branch" (though
I understand Git is a WIP).


Links: https://api.kde.org/frameworks/kconfigwidgets/html/classKCommandBar.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 456733] New: Multiple Cursor Behavior: Alt+DoubleClick, Alt+Click+Drag and SelectText + Alt+Click

2022-07-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456733

Bug ID: 456733
   Summary: Multiple Cursor Behavior: Alt+DoubleClick,
Alt+Click+Drag and SelectText + Alt+Click
   Product: kate
   Version: 22.04.2
  Platform: Other
OS: Other
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: ---

Via:
https://old.reddit.com/r/kde/comments/vyuynb/which_ide_or_editor_do_kde_programmers_use_to/ig6cdh6/?context=3

In sublime text, you can Ctrl+DoubleClick to create a new cursor select the
word underneath the mouse.
You can also Ctrl+Click+Drag to create a cursor and select characters.

This is more a niche wishlist feature, except it's possible for the user to
slightly drag when clicking. Currently when Alt+Click+Dragging, Kate will
delete all but the first cursor and create a selection from it to the mouse. It
should be editing the selection of the last cursor only when Alt is pressed
while keeping the other cursors.

Another bug related to multi-cursor selections is that all selections are reset
when you Alt+Click to create a new cursor. To test, select a word, then
Alt+Click.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 456504] When using the "double click to open files" setting, you need to click extremely fast on the deskop

2022-07-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456504

--- Comment #1 from Chris Holland  ---
If you have trouble finding out which product/category, this might help:
https://zren.github.io/kde/repos/#desktop-folder-view

The existing Folder View bugs are at:
https://bugs.kde.org/buglist.cgi?component=Folder_id=2110597=bug_id%20DESC=plasmashell_format=advanced

Possibly related bug?
https://bugs.kde.org/show_bug.cgi?id=428978 Double clicking desktop items does
not open selected items (Plasma 5.20.4)

You're using Debian 11 with Plasma 5.20. Unless debian is backporting fixes,
you're unlikely to get a bugfix since 5.20 isn't an LTS release. There is
debian 12 with Plasma 5.24.
https://repology.org/project/plasma-desktop/versions#debian_11

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 456504] When using the "double click to open files" setting, you need to click extremely fast on the deskop

2022-07-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456504

Chris Holland  changed:

   What|Removed |Added

   Assignee|zrenf...@gmail.com  |plasma-b...@kde.org
  Component|General |Folder
Product|Active Window Control   |plasmashell
Version|unspecified |5.18.8
 CC||h...@kde.org,
   ||zrenf...@gmail.com
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 456466] SystemTray App Strawberry Middle Click To PlayPause Is Ignored After Plasma 5.25 Update

2022-07-08 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456466

Chris Holland  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||b3943ee1a63c96e48f7a0706d82
   ||96b67aaf5ba1e
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Chris Holland  ---
Git commit b3943ee1a63c96e48f7a0706d8296b67aaf5ba1e by Chris Holland.
Committed on 08/07/2022 at 15:35.
Pushed by cholland into branch 'master'.

Fix StatusNotifierItem MidClick

Bug was introduced in !1798's 8031139a commit.

M  +1-1   
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b3943ee1a63c96e48f7a0706d8296b67aaf5ba1e

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 456466] SystemTray App Strawberry Middle Click To PlayPause Is Ignored After Plasma 5.25 Update

2022-07-07 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456466

--- Comment #1 from Chris Holland  ---
Well the "StatusNotifierItem.qml:74: TypeError: Property 'operationDescription'
of object NaN is not a function" warning made it obvious that I was blind when
skimming the code.

https://invent.kde.org/plasma/plasma-workspace/-/blame/master/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml#L69-70

Looks like this commit defined the service variable after the operation call
accidentally when moving stuff around.

var operation = service.operationDescription("SecondaryActivate");
let service = model.Service;

https://invent.kde.org/plasma/plasma-workspace/-/commit/8031139aeb7f412ff3f8b9d7b1bd1d2fa16e7a2b#a3d37774fcfbf0224e15156bfd485eb9438664c1_71_70

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 456466] New: SystemTray App Strawberry Middle Click To PlayPause Is Ignored After Plasma 5.25 Update

2022-07-07 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=456466

Bug ID: 456466
   Summary: SystemTray App Strawberry Middle Click To PlayPause Is
Ignored After Plasma 5.25 Update
   Product: plasmashell
   Version: 5.25.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: System Tray
  Assignee: plasma-b...@kde.org
  Reporter: zrenf...@gmail.com
CC: mate...@gmail.com
  Target Milestone: 1.0

At first, I thought it might be a Strawberry (Qt5 Clementine Fork) bug. After
testing the Plasma/5.24 plasmoid code, I noticed middle click was working in
plasmawindowed. So it's definitely a system tray regression.

My Test Script: https://gist.github.com/Zren/b605e15697745adcd52b0982ce05e527

Here's a diff of Plasma 5.24 => 5.25:
https://gist.github.com/Zren/a49a07f98b95c01a63f4ac12277bb7bd
git diff Plasma/5.24 Plasma/5.25 --
~/kde/src/plasma-workspace/applets/systemtray/

The bug is probably in one of these files:

*
https://invent.kde.org/plasma/plasma-workspace/-/blame/master/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
*
https://invent.kde.org/plasma/plasma-workspace/-/blame/master/applets/systemtray/package/contents/ui/items/AbstractItem.qml
*
https://invent.kde.org/plasma/plasma-workspace/-/commits/master/applets/systemtray

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 445058] kwin interactive console does not work

2022-05-18 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=445058

--- Comment #8 from Chris Holland  ---
The systemd logs printed in journalctl is just capturing the kwin_x11 output.
It's possible that your distro doesn't capture the terminal output, or kwin
restarted somehow. The journalctl workaround works fine for me OpenSUSE
Tumbleweed Plasma 5.24.5.

Another workaround is to open Konsole, and run the following to restart kwin
and log it's output to the Konsole window.
kstart5 -- kwin_x11 --replace

`kwin_x11 --replace` is the actual command, but `kstart5` will keep kwin
running after you close Konsole. The `--` tells kstart5 to treat everything
after it as a single argument (the command to run).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 434713] Nothing happens when I press the keyboard shortcut of Keyboard Layout applet by the first time

2022-04-19 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=434713

--- Comment #13 from Chris Holland  ---
Keep in mind that I recently had to refactor the hide keyboard shortcut code as
the AppletConfiguration is no longer the top root item in Plasma 5.24

*
https://github.com/Zren/plasma-applet-tiledmenu/blame/master/package/contents/ui/config/ConfigGeneral.qml#L21
*
https://github.com/Zren/plasma-applet-tiledmenu/commit/ea15d8a2f141f0676b9608815a20707f0070b503

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 451484] kde window list plugin sort the list to easy find it

2022-03-15 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=451484

Chris Holland  changed:

   What|Removed |Added

   Assignee|zrenf...@gmail.com  |plasma-b...@kde.org
 CC||zrenf...@gmail.com
  Component|General |Window List
Version|unspecified |5.24.3
   Target Milestone|--- |1.0
Product|Active Window Control   |plasmashell

--- Comment #1 from Chris Holland  ---
Which widget is that? "Icon's Only Task Manager" or "Task Manager"? Is that the
overflow menu? Or is that literally the "Window List" widget?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spam] [Bug 451305] Is The Cash App ++ Real To Use To Send Or Receive Money?

2022-03-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=451305

Chris Holland  changed:

   What|Removed |Added

   Assignee|zrenf...@gmail.com  |n...@kde.org
Product|Active Window Control   |Spam
  Component|General |Spam

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 451190] Crash after coming back from another plasma session after one night

2022-03-07 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=451190

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
I'm also experiencing this crash (kdeconnect-kde v21.12.2-1.1). I updated
tumbleweed and experienced it again the next morning (v21.12.3-1.1). The
android app version is v1.19.1 on Android 10.

Here's the segfault info from the 2nd crash:

Application: KDE Connect Daemon (kdeconnectd), signal: Segmentation
fault
Content of s_kcrashErrorMessage: std::unique_ptr = {get() =
}
[KCrash Handler]
#6  0x7f67f4a1c324 in (anonymous namespace)::constData (d=...) at
kernel/qvariant.cpp:361
#7  qVariantToHelper > (handlerManager=...,
d=...) at kernel/qvariant.cpp:2669
#8  QVariant::toMap (this=0x55851b56c5d8) at kernel/qvariant.cpp:2721
#9  0x7f67ec631378 in ConnectivityReportPlugin::receivePacket
(np=..., this=) at
/usr/src/debug/kdeconnect-kde-21.12.3-1.1.x86_64/plugins/connectivity-report/connectivity_reportplugin.cpp:44
#10 ConnectivityReportPlugin::receivePacket (this=,
np=...) at
/usr/src/debug/kdeconnect-kde-21.12.3-1.1.x86_64/plugins/connectivity-report/connectivity_reportplugin.cpp:40
#11 0x7f67f5f9ce01 in Device::privateReceivedPacket
(this=0x55851b469450, np=...) at
/usr/src/debug/kdeconnect-kde-21.12.3-1.1.x86_64/core/device.cpp:398
#12 0x7f67f4a05503 in QtPrivate::QSlotObjectBase::call
(a=0x7ffec7265f70, r=0x55851b469450, this=0x55851b6354b0) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#13 doActivate (sender=0x55851b778f70, signal_index=7,
argv=0x7ffec7265f70) at kernel/qobject.cpp:3886
#14 0x7f67f49fe9cf in QMetaObject::activate
(sender=sender@entry=0x55851b778f70, m=,
local_signal_index=local_signal_index@entry=4, argv=argv@entry=0x7ffec7265f70)
at kernel/qobject.cpp:3946
#15 0x7f67f5f8dbfd in DeviceLink::receivedPacket (_t1=...,
this=0x55851b778f70) at
/usr/src/debug/kdeconnect-kde-21.12.3-1.1.x86_64/build/core/kdeconnectcore_autogen/CSWKE6ESUK/moc_devicelink.cpp:225
#16 LanDeviceLink::dataReceived (this=0x55851b778f70) at
/usr/src/debug/kdeconnect-kde-21.12.3-1.1.x86_64/core/backends/lan/landevicelink.cpp:135
#17 0x7f67f4a05503 in QtPrivate::QSlotObjectBase::call
(a=0x7ffec7266050, r=0x55851b778f70, this=0x55851b709400) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#18 doActivate (sender=0x55851b629ff0, signal_index=3,
argv=0x7ffec7266050) at kernel/qobject.cpp:3886
#19 0x7f67f5f86114 in SocketLineReader::dataReceived
(this=0x55851b629ff0) at
/usr/src/debug/kdeconnect-kde-21.12.3-1.1.x86_64/core/backends/lan/socketlinereader.cpp:29
#20 0x7f67f4a05503 in QtPrivate::QSlotObjectBase::call
(a=0x7ffec7266160, r=0x55851b629ff0, this=0x55851b6cdb50) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#21 doActivate (sender=0x55851b7b9b10, signal_index=3,
argv=0x7ffec7266160) at kernel/qobject.cpp:3886
#22 0x7f67f49fe9cf in QMetaObject::activate
(sender=sender@entry=0x55851b7b9b10, m=m@entry=0x7f67f4ca1280
, local_signal_index=local_signal_index@entry=0,
argv=argv@entry=0x0) at kernel/qobject.cpp:3946
#23 0x7f67f48fd250 in QIODevice::readyRead
(this=this@entry=0x55851b7b9b10) at .moc/moc_qiodevice.cpp:190
#24 0x7f67f4126705 in QSslSocketBackendPrivate::transmit
(this=0x7f67e0048b60) at ssl/qsslsocket_openssl.cpp:1162
#25 0x7f67f4a05538 in doActivate (sender=0x55851b588440,
signal_index=3, argv=0x7ffec72672d0) at kernel/qobject.cpp:3898
#26 0x7f67f49fe9cf in QMetaObject::activate
(sender=sender@entry=0x55851b588440, m=m@entry=0x7f67f4ca1280
, local_signal_index=local_signal_index@entry=0,
argv=argv@entry=0x0) at kernel/qobject.cpp:3946
#27 0x7f67f48fd250 in QIODevice::readyRead
(this=this@entry=0x55851b588440) at .moc/moc_qiodevice.cpp:190
#28 0x7f67f40ddeef in QAbstractSocketPrivate::emitReadyRead
(channel=0, this=0x55851b3f0be0) at socket/qabstractsocket.cpp:1323
#29 QAbstractSocketPrivate::canReadNotification (this=0x55851b3f0be0)
at socket/qabstractsocket.cpp:748
#30 0x7f67f40f3ca1 in QReadNotifier::event (this=,
e=) at socket/qnativesocketengine.cpp:1274
#31 0x7f67f5613a7f in QApplicationPrivate::notify_helper
(this=, receiver=0x55851b562db0, e=0x7ffec7267410) at
kernel/qapplication.cpp:3632
#32 0x7f67f49cee3a in QCoreApplication::notifyInternal2
(receiver=0x55851b562db0, event=0x7ffec7267410) at
kernel/qcoreapplication.cpp:1064
#33 0x7f67f4a26f3d in socketNotifierSourceDispatch
(source=source@entry=0x55851b3c5550) at kernel/qeventdispatcher_glib.cpp:107
#34 0x7f67f2e74e22 in g_main_dispa

[plasmashell] [Bug 449115] New: 24h clock with 9:59 is larger font than 10:00 in vertical panel

2022-01-24 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=449115

Bug ID: 449115
   Summary: 24h clock with 9:59 is larger font than 10:00 in
vertical panel
   Product: plasmashell
   Version: 5.23.5
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Digital Clock
  Assignee: plasma-b...@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: 1.0

https://old.reddit.com/r/kde/comments/sbuz5x/change_taskbar_clock_time_format/
https://i.imgur.com/mLoDtwa.png
https://i.imgur.com/P8inO1h.png

This can happen with en_US if the user selects 24-hour in digitalclock's
config. It can also be experienced by default in the Singapore locale.

For easy testing (note this is testing floating? not vertical):

TZ="UTC-06:00" LC_TIME="en_SG.UTF-8" plasmawindowed
org.kde.plasma.digitalclock
TZ="UTC-00:00" LC_TIME="en_SG.UTF-8" plasmawindowed
org.kde.plasma.digitalclock
TZ="UTC+06:00" LC_TIME="en_SG.UTF-8" plasmawindowed
org.kde.plasma.digitalclock
TZ="UTC+12:00" LC_TIME="en_SG.UTF-8" plasmawindowed
org.kde.plasma.digitalclock

https://invent.kde.org/plasma/plasma-workspace/-/blame/master/applets/digital-clock/package/contents/ui/DigitalClock.qml#L261

Looks like the vertical panels don't have enough space for 23:59 at... 10pt * 3
= 30pt

> fontSizeMode: Text.HorizontalFit
> font.pixelSize: 3 * PlasmaCore.Theme.defaultFont.pixelSize

The TZ env var doesn't seem to work with plasmoidviewer for some reason.

TZ="UTC+05:00" LC_TIME="en_SG.UTF-8" plasmoidviewer -a
org.kde.plasma.digitalclock -l leftedge -f vertical

"12:59 PM" text needs a panel to be ~178px wide.
"23:59" text needs a panel to be ~96px wide.

A "Ubuntu Unity" vertical panel is usually around 64px wide.
A "Windows 10" vertical taskbar is 92px wide according to
https://www.youtube.com/watch?v=RA_szqXEJrU.

A horizontal panel defaults to what? 36px tall? There's probably 2px of padding
top/bottom.
https://invent.kde.org/plasma/plasma-desktop/-/blob/master/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js#L30

32px*0.71=22.7px Time
32px*0.56=17.9px Time (w/ Date)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 448985] In Digital Clock 3.0 - Custom date format shows incorrect month - M01 instead of Jan

2022-01-23 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=448985

--- Comment #5 from Chris Holland  ---
So the `locale` command shows LC_TIME="en_US.UTF-8"? And you're also in EST.
Good to know.

"M01" could be a legit "testing" locale for Jan. I've just never seen it
before.

OpenSUSE Tumbleweed right?
What Qt version?  I have Qt 5.15.2+kde268-2.1

Qt uses CLDR for their locale database.
https://github.com/qt/qtbase/tree/dev/util/locale_database
https://cldr.unicode.org/index/downloads
https://unicode-org.github.io/cldr-staging/charts/40/
https://unicode-org.github.io/cldr-staging/charts/40/delta/en.html
https://www.google.com/search?hl=en=site%3Ahttps%3A%2F%2Funicode%2Dorg.github.io%2Fcldr%2Dstaging%2Fcharts%2F40%2F%20%22M01%22

Looks like the Sardinian [sc] v40 Delta has M01. Not sure what "delta" is
though.
https://unicode-org.github.io/cldr-staging/charts/40/delta/sc.html

There's also Fulah [ff] which has M01.
https://unicode-org.github.io/cldr-staging/charts/40/summary/ff.html

Chinese locales tend to have numbers in the month names like: 1月, 2月 for Jan,
Feb.
https://unicode-org.github.io/cldr-staging/charts/latest/verify/dates/zh.html

> This can happen if "MMM" gets parsed as "M" followed by "MM", e.g. with an 
> invisible character in between.

Why would it output M=M instead of M=1? An invisible character would be
equivalent to "M MM" which would be "1 01". You would need apostrophes to
escape it like 'M'MM to get "M01".

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 448985] In Digital Clock 3.0 - Custom date format shows incorrect month - M01 instead of Jan

2022-01-22 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=448985

Chris Holland  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
  Component|General |Digital Clock
Version|unspecified |5.23.5
 CC||zrenf...@gmail.com
   Assignee|zrenf...@gmail.com  |plasma-b...@kde.org
Product|Active Window Control   |plasmashell

-- 
You are receiving this mail because:
You are watching all bug changes.

[Active Window Control] [Bug 448985] In Digital Clock 3.0 - Custom date format shows incorrect month - M01 instead of Jan

2022-01-22 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=448985

--- Comment #1 from Chris Holland  ---
 is Saturday not Sat
dd is 22
MMM is Jan
mmm is mmm since digitalclock uses Qt.formatDate() not Qt.formatDateTime()


Which locale?

❯ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
...
LC_ALL=
❯ date
Sat Jan 22 08:37:36 PM EST 2022

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 448960] No GIMP Icon in task-manager

2022-01-22 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=448960

Chris Holland  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
Version|unspecified |5.23.5
  Component|General |Task Manager and Icons-Only
   ||Task Manager
Product|Active Window Control   |plasmashell
   Assignee|zrenf...@gmail.com  |h...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 445058] kwin interactive console does not work

2022-01-16 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=445058

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #4 from Chris Holland  ---
I just noticed in OpenSUSE Tumbleweed (kwin 5.23.5) that the kwin print output
and errors are printed to the system journal. Use:
journalctl -b0 -f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdesrc-build] [Bug 447601] ./kdesrc-build --initial-setup does not install Perl YAML on openSUSE TW

2022-01-13 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=447601

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
Bit annoying that the password prompt is before the package list. Anyways, this
seems to be the list of packages.

`@@ pkg/opensuse/unknown` at:
https://invent.kde.org/sdk/kdesrc-build/-/blob/master/modules/ksb/FirstRun.pm#L471

It looks like it uses the same package list for OpenSUSE Leap and Tumbleweed?
That might be the reason why it doesn't work.

Here's my output. I've installed a few dev packages already, so it found a few
already.
https://gist.github.com/Zren/519e064c54a082881a216f11fb5c00e8

I went into yast and noticed:

libpng12-devel - Development tools for applications which will use libpng
Provides: pkgconfig(libpng12) = 1.2.59
libpng16-devel - Development tools for applications which will use libpng
Provides: pkgconfig(libpng16) = 1.6.37

Which is probably why we get errors like:
'pkgconfig(libpng)' not found in package names. Trying capabilities.

Very annoying that SUSE doesn't map "pkgconfig(libpng)" to libpng16-devel.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Plasma SDK] [Bug 447452] [plasma-interactiveconsole] Ctrl+E to Execute is an ambiguous shortcut

2021-12-23 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=447452

--- Comment #1 from Chris Holland  ---
Looks like Ctrl+B is bookmark, not breakpoint.

https://github.com/KDE/ktexteditor/blob/92cab6563e46db4260c89b7b12c87237369f857c/src/view/kateview.cpp#L518

a = ac->addAction(QStringLiteral("Previous Editing Line"));
a->setText(i18n("Go to previous editing line"));
ac->setDefaultShortcut(a, QKeySequence(Qt::CTRL + Qt::Key_E));

a = ac->addAction(QStringLiteral("Next Editing Line"));
a->setText(i18n("Go to next editing line"));
ac->setDefaultShortcut(a, QKeySequence(Qt::CTRL + Qt::SHIFT +
Qt::Key_E));

https://github.com/KDE/ktexteditor/blob/da6275179c896613272bc4d70e9dc41943c30f5b/src/utils/katebookmarks.cpp#L48

m_bookmarkToggle = new KToggleAction(i18n("Set "), this);
ac->addAction(QStringLiteral("bookmarks_toggle"), m_bookmarkToggle);
   
m_bookmarkToggle->setIcon(QIcon::fromTheme(QStringLiteral("bookmark-new")));
ac->setDefaultShortcut(m_bookmarkToggle, Qt::CTRL + Qt::Key_B);
m_bookmarkToggle->setWhatsThis(i18n("If a line has no bookmark then add
one, otherwise remove it."));
connect(m_bookmarkToggle, ::triggered, this,
::toggleBookmark);

https://github.com/KDE/ktexteditor/blob/92cab6563e46db4260c89b7b12c87237369f857c/src/view/kateview.cpp#L690

a = m_toggleBlockSelection = new KToggleAction(i18n("Bl Selection
Mode"), this);
ac->addAction(QStringLiteral("set_verticalSelect"), a);
ac->setDefaultShortcut(a, QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_B));
a->setWhatsThis(i18n("This command allows switching between the normal
(line based) selection mode and the block selection mode."));
connect(a, ::triggered, this,
::ViewPrivate::toggleBlockSelection);

-- 
You are receiving this mail because:
You are watching all bug changes.

[Plasma SDK] [Bug 447452] New: [plasma-interactiveconsole] Ctrl+E to Execute is an ambiguous shortcut

2021-12-23 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=447452

Bug ID: 447452
   Summary: [plasma-interactiveconsole] Ctrl+E to Execute is an
ambiguous shortcut
   Product: Plasma SDK
   Version: 5.23.4
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: General
  Assignee: plasma-b...@kde.org
  Reporter: zrenf...@gmail.com
CC: antonis.tsiapalio...@kde.org
  Target Milestone: ---

This is technically a bug for plasma-workspace, since that's where
plasma-interactiveconsole is.

*
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1293#note_363801
*
https://invent.kde.org/plasma/plasma-workspace/-/tree/master/interactiveconsole
*
https://invent.kde.org/plasma/plasma-workspace/-/blob/master/interactiveconsole/interactiveconsole.cpp#L188

Looks like it's bound to Ctrl+E, but pressing that shows that the shortcut is
Ambiguous. Looks like you need to not be focusing the code TextArea (select
text in the output TextArea) for Ctrl+E to work, which defeats the purpose of
the shortcut. Also, there is no settings menu (probably meant for Kate).

Ctrl+B seems to be bound to... Toggle Breakpoint or something? It turns the bg
blue on the line with the cursor.

We should probably keep `Alt+E` generated by the i18n text. So we should be
using something like:

auto shortcuts = QList() << m_executeAction->shortcut() <<
(Qt::CTRL | Qt::Key_E) << (Qt::CTRL | Qt::Key_B);
m_executeAction->setShortcuts(shortcuts);

We'll also need to figure out how to disable the default KTextEditor Ctrl+B /
Ctrl+E actions so they're not ambiguous.

* https://doc.qt.io/qt-5/qaction.html#shortcuts

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 386330] Ability for QML plasmoids to detect when a notification action is clicked

2021-12-22 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=386330

--- Comment #2 from Chris Holland  ---
Oh neat! It was added 2021 Oct, so since KF5 v5.88.0

* https://www.volkerkrause.eu/2021/09/18/kf5-notifications-in-qml.html
* https://github.com/KDE/knotifications/blob/master/docs/qml-notifications.md
*
https://github.com/KDE/knotifications/commit/16e92d643faff27d52f10b14aab68b73d11a4481

Hmm, looks like I'll have to wait for Ubuntu 22.04 at least to use it on the
KDE Store.

* https://repology.org/project/knotifications/versions

I've stopped using the notifications dataengine anyways since it had problems
in Latte-Dock.

* https://github.com/Zren/plasma-applet-eventcalendar/issues/60

I'm currently using the executable dataengine + python script. I'll see about
trying to use the new KNotification API in a QML Loader, then using the python
script as a fallback.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447103] Only the canvas function is executed together with the full screen, which is not good. krita5.0 began to appear

2021-12-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=447103

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com
  Component|General |General
Product|Active Window Control   |krita
   Assignee|zrenf...@gmail.com  |krita-bugs-n...@kde.org

--- Comment #1 from Chris Holland  ---
I'm guessing this belong under the product = krita. Can you elaborate on the
problem? Did you select Platform = Microsoft Windows when reporting the bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 446732] audio widget multiplies himself

2021-12-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=446732

Chris Holland  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
  Component|General |Task Manager and Icons-Only
   ||Task Manager
Version|unspecified |5.23.4
   Assignee|zrenf...@gmail.com  |h...@kde.org
Product|Active Window Control   |plasmashell

-- 
You are receiving this mail because:
You are watching all bug changes.

[Active Window Control] [Bug 446732] audio widget multiplies himself

2021-12-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=446732

--- Comment #1 from Chris Holland  ---
Sounds like bug https://bugs.kde.org/show_bug.cgi?id=438565

This belongs under Product=plasmashell under the Component="Task Manager and
..."

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 380836] Horizontal and Vertical maximized states are reversed in signal parameters

2021-11-06 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=380836

--- Comment #2 from Chris Holland  ---
Here's the latest (permanent) links that take into account the refactor of
`src/` and the removal of `geometry.cpp` for posterity.

*
https://github.com/KDE/kde-workspace/blame/257b997132217fd73a1b3be14db49735b64235e7/kwin/netinfo.cpp#L259
*
https://github.com/KDE/kwin/blame/84a5c7b314965853fb21cda8128809ebf4af795a/src/abstract_client.h#L515
*
https://github.com/KDE/kwin/blame/84a5c7b314965853fb21cda8128809ebf4af795a/src/abstract_client.cpp#L917
*
https://github.com/KDE/kwin/blame/84a5c7b314965853fb21cda8128809ebf4af795a/src/abstract_client.h#L939
*
https://github.com/KDE/kwin/blame/84a5c7b314965853fb21cda8128809ebf4af795a/src/scripting/workspace_wrapper.cpp#L304
*
https://github.com/KDE/kwin/blame/84a5c7b314965853fb21cda8128809ebf4af795a/src/scripting/workspace_wrapper.h#L92

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spam] [Bug 443703] Remove the issue of cash app account number by seeking expert’s help

2021-10-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=443703

Chris Holland  changed:

   What|Removed |Added

Product|Active Window Control   |Spam
  Component|General |Spam
   Assignee|zrenf...@gmail.com  |n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 241227] konqueror file manager: home directory should show regular folders first and then hidden folders

2021-08-05 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=241227

--- Comment #10 from Chris Holland  ---
Git commit 50149d6abb8a0a978db3c6afb5238bc42a4a89c8 by Zren (Chris Holland), on
behalf of Gaston Haro.
Committed on 05/08/2021 at 12:55.
Pushed by cholland into branch 'release/21.08'.

Configurable Show hidden files and folders last toggle

Revision: https://phabricator.kde.org/D29115

M  +22   -6src/kitemviews/kfileitemmodel.cpp
M  +7-0src/kitemviews/kfileitemmodel.h
M  +5-0src/settings/dolphin_directoryviewpropertysettings.kcfg
M  +14   -0src/settings/viewpropertiesdialog.cpp
M  +2-0src/settings/viewpropertiesdialog.h
M  +29   -0src/views/dolphinview.cpp
M  +15   -0src/views/dolphinview.h
M  +19   -0src/views/dolphinviewactionhandler.cpp
M  +10   -0src/views/dolphinviewactionhandler.h
M  +14   -0src/views/viewproperties.cpp
M  +3-0src/views/viewproperties.h

https://invent.kde.org/system/dolphin/commit/50149d6abb8a0a978db3c6afb5238bc42a4a89c8

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 439789] New: Reorder shown currencies

2021-07-12 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=439789

Bug ID: 439789
   Summary: Reorder shown currencies
   Product: krunner
   Version: unspecified
  Platform: Other
OS: Other
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: converter
  Assignee: alexander.loh...@gmx.de
  Reporter: zrenf...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: ---

https://old.reddit.com/r/kde/comments/oi7vkz/why_do_i_get_2_different_values_when_using/h4ua8q3/

The list is populated with KUnitConverter's `mostCommonUnits()` which is
populated with the hardcoded addCommonUnit() or addDefaultUnit().

*
https://github.com/KDE/kdeplasma-addons/blob/master/runners/converter/converterrunner.cpp#L186
* https://github.com/KDE/kunitconversion/blob/master/src/currency.cpp

It is then sorted by relevance, with the lowest value up top and the highest
(usually YEN) at the bottom.

*
https://github.com/KDE/kdeplasma-addons/blob/master/runners/converter/converterrunner.cpp#L108
* match.setRelevance(1.0 - std::abs(std::log10(outputValue.number())) / 50.0);

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 438675] Last horizontal disk size indicator is rendered on first entry of Places

2021-06-24 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=438675

--- Comment #4 from Chris Holland  ---
The solution is to follow kio's filepicker code properly. I wrote the dolphin
code simpler since I thought I'd squirreled out all the edge cases of it being
recycled. Seems like I can't do that though.

https://invent.kde.org/frameworks/kio/-/blob/master/src/filewidgets/kfileplacesview.cpp#L121
https://invent.kde.org/frameworks/kio/-/blob/master/src/filewidgets/kfileplacesview.cpp#L235
mutable QMap m_freeSpaceInfo;

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 435081] [scripting] panels() also returns the desktops() containments

2021-04-28 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=435081

Chris Holland  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-workspace/commit/
   ||9eb6e16009fc13041f4cd675f10
   ||3920155380c14

--- Comment #2 from Chris Holland  ---
Git commit 9eb6e16009fc13041f4cd675f103920155380c14 by Chris Holland.
Committed on 28/04/2021 at 18:45.
Pushed by cholland into branch 'master'.

[scripting] Make panels() not return the desktops() containments

It was filtering by isPanel() before port to QJSEngine:
https://invent.kde.org/plasma/plasma-workspace/-/commit/033ad5ca60b3d4250a4f354fa38fc60f7d97c78b#cbf01be30b27864a9b58f834c520a69d108a4888_443_442

M  +4-2shell/scripting/scriptengine_v1.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/9eb6e16009fc13041f4cd675f103920155380c14

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 425360] List entry for home folder is can be deleted, but always returns upon re-opening the KCM

2021-04-25 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=425360

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #3 from Chris Holland  ---
Possibly related:
https://www.reddit.com/r/ManjaroLinux/comments/my55oc/weird_file_indexing_glitch_in_manjarokde/

The user changed their home directory to "Not Indexed", selected another KCM,
then opened up "File Search" again to see:

/home/user "Indexed"
/home/user "Not Indexed"

He repeated it to get

/home/user "Indexed"
/home/user "Not Indexed"
/home/user "Not Indexed"

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 434769] Volume adjustment goes offset

2021-04-20 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=434769

Chris Holland  changed:

   What|Removed |Added

   Version Fixed In|5.21.4  |5.21.5
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-pa/commit/b0f7cfc |ma/plasma-pa/commit/dedcbcc
   |cf80d00d9e76efa05d02bc2fc94 |f753545795c0194fd98cca081e4
   |b4318d  |7baf70

--- Comment #8 from Chris Holland  ---
Git commit dedcbccf753545795c0194fd98cca081e47baf70 by Chris Holland.
Committed on 20/04/2021 at 02:56.
Pushed by ngraham into branch 'master'.

Increment volume by percent instead of a constant volumeStep

Jumping by a fixed volumeStep has issues as the value is rounded.
65536/100 = 655.36
65536/100*5 = 3276.8
volumeStep = round(3276.8) = 3277

The floor() patch has an easy to test bug when jumping from 100% to
94% instead of 95% since volumeStep is rounded up.
Eg: 65536 => 62259 (-3277) 100% => 94%  (-6%)

The original round() logic also has issues when volume is around:
f(x) = (65536/100) / 2 + (65536/100) * x

amixer sset Master 983 # f(1)=983.04
Eg: 983 => 4260 (+3277) 1% => 7%  (+6%)

This patch adds changeVolumeByPercent(volumeObject, deltaPercent) to
increment any sink or source by a %volume. It also moves the common
code in increaseVolume() and decreaseVolume() into a new function.
Related: bug 435522
FIXED-IN: 5.21.5

M  +33   -32   applet/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-pa/commit/dedcbccf753545795c0194fd98cca081e47baf70

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 435522] Widget tooltip shows wrong volume level

2021-04-20 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=435522

Chris Holland  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-pa/commit/dedcbcc
   ||f753545795c0194fd98cca081e4
   ||7baf70
   Version Fixed In||5.21.5
 Resolution|--- |FIXED

--- Comment #2 from Chris Holland  ---
Git commit dedcbccf753545795c0194fd98cca081e47baf70 by Chris Holland.
Committed on 20/04/2021 at 02:56.
Pushed by ngraham into branch 'master'.

Increment volume by percent instead of a constant volumeStep

Jumping by a fixed volumeStep has issues as the value is rounded.
65536/100 = 655.36
65536/100*5 = 3276.8
volumeStep = round(3276.8) = 3277

The floor() patch has an easy to test bug when jumping from 100% to
94% instead of 95% since volumeStep is rounded up.
Eg: 65536 => 62259 (-3277) 100% => 94%  (-6%)

The original round() logic also has issues when volume is around:
f(x) = (65536/100) / 2 + (65536/100) * x

amixer sset Master 983 # f(1)=983.04
Eg: 983 => 4260 (+3277) 1% => 7%  (+6%)

This patch adds changeVolumeByPercent(volumeObject, deltaPercent) to
increment any sink or source by a %volume. It also moves the common
code in increaseVolume() and decreaseVolume() into a new function.
Related: bug 434769
FIXED-IN: 5.21.5

M  +33   -32   applet/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-pa/commit/dedcbccf753545795c0194fd98cca081e47baf70

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 435081] New: [scripting] panels() also returns the desktops() containments

2021-03-28 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=435081

Bug ID: 435081
   Summary: [scripting] panels() also returns the desktops()
containments
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: zrenf...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

While fixing a plasma scripting example in the documentation, I noticed that my
desktop widget's config keys was being logged twice. I had added a digitalclock
widget to my desktop to test quickly.

My Code: https://gist.github.com/Zren/e1a1c1a851a3fa76216d056b8f95c144

Notice I iterate the widgets in desktops() first, then panels() after. The
output of the code is:

desktops()
org.kde.plasma.folder[35] com.github.zren.sysmongraphs[93]:
org.kde.plasma.folder[35] com.github.zren.commandoutput[95]:
org.kde.plasma.folder[35] org.kde.plasma.digitalclock[99]:
org.kde.plasma.digitalclock: 
Appearance: 
showDate: true
panels()
org.kde.panel[1] org.kde.plasma.pager[3]:
org.kde.panel[1] org.kde.plasma.systemtray[7]:
org.kde.panel[1] org.kde.plasma.win7showdesktop[46]:
org.kde.panel[1] org.kde.plasma.taskmanager[47]:
...
org.kde.plasma.folder[35] com.github.zren.sysmongraphs[93]:
org.kde.plasma.folder[35] com.github.zren.commandoutput[95]:
org.kde.plasma.folder[35] org.kde.plasma.digitalclock[99]:
org.kde.plasma.digitalclock: 
Appearance: 
showDate: true


After skimming my code, I moved onto the scriptengine_v1.cpp code and found
that while the desktops() function filters by !isPanel(), the panels() function
does not.

https://invent.kde.org/plasma/plasma-workspace/-/blame/master/shell/scripting/scriptengine_v1.cpp#L470

It was filtering by isPanel() before port to QJSEngine:

https://invent.kde.org/plasma/plasma-workspace/-/commit/033ad5ca60b3d4250a4f354fa38fc60f7d97c78b#cbf01be30b27864a9b58f834c520a69d108a4888_467_469

Since I've confirmed this bug is a regression, I'll try to send a MR soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 434837] A feature request for letter based navigating between apps

2021-03-24 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=434837

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #5 from Chris Holland  ---
Tiled Menu (and the Windows start menu) doesn't have a separate column for
Categories, which is why the headings have a Jump to Letter feature.

I assume you only want this for the "All Applications" view which lists all
apps alphabetically?

An alternative is to make the scrollbar better, like the Android scrollbar:

*
https://stackoverflow.com/questions/31261437/how-to-create-material-design-like-custom-scrollbar-with-numbers-and-alphabets-b/36550228

Or the full alphabet:

*
https://ux.stackexchange.com/questions/83857/is-the-small-alphabetical-index-on-mobile-phone-lists-usable

Or just the populated letters:

* https://i.redd.it/crqv2rh07y131.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeplasma-addons] [Bug 425770] Wrong icons displaying in weather widget based on time of day (time zone bug)

2021-03-23 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=425770

--- Comment #2 from Chris Holland  ---
This bug was encountered again by a redditor:
https://www.reddit.com/r/kde/comments/mbqdee/how_to_fix_weather_widget_wrong_icon_at_night/

So this issue is really the "time" dataengine's solar calculations as there's
reports of it affecting bbcomet, wettercom, and envcan.

We need to find out if the "weather" dataengine is entering the wrong solar
"time" dataengine "source" name, or if the bug is really in the "time"
dataengine's solar calculation code.

*
https://invent.kde.org/plasma/plasma-workspace/-/blame/master/dataengines/weather/ions/envcan/ion_envcan.cpp#L733
* https://invent.kde.org/plasma/plasma-workspace/-/tree/master/dataengines/time

Install `plasma-sdk` to get the Plasma Engine Explorer app.

* Run `grep source= ~/.config/plasma-org.kde.plasma.desktop-appletsrc` to find
out the weather "source name".
  * Eg: If grep says `source=envcan|weather|Toronto, ON` then your source name
is `envcan|weather|Toronto, ON`.
* Select the "weather" dataengine.
* Enter your "Source name", then click "Request Source". The data should appear
in the table at the bottom.
* Screenshot: https://i.imgur.com/yAyFdKi.png
* Copy the `Observation Timestamp`, `Latitude`, and `Longitude` values. You can
select the "Value" cell and press `Ctrl+C`.
* The London timezone in the `Observation Timestamp=Tue Mar 23 23:00:00 2021
GMT` is the `GMT` at the end. For Toronto it was `Tue Mar 23 19:00:00 2021
UTC-04:00`, so the timezone code was `UTC-04:00`.

-

Now we need to check the solar time data.

* Select the "time" dataengine.
* Enter something like this into the source name:
`America/Toronto|Solar|Latitude=50|Longitude=50|DateTime=2021-03-23T19:06:00`
* https://i.imgur.com/19I0c8f.png
* Toronto:
`UTC-04:00|Solar|Latitude=43.68|Longitude=79.63|DateTime=2021-03-23T19:00:00`
* https://i.imgur.com/uuLxib5.png
* Click "Request Source", then scroll down to the bottom to find the data.
* Jot down all that data.

Now we finally have all the data we need to solve the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kunitconversion] [Bug 425790] KRunner currency converter can't handle large values (32-bit signed int overflow)

2021-03-06 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=425790

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #2 from Chris Holland  ---
The bug is somewhere in KUnitConversion::Value::round(2).
Screenshot: https://i.imgur.com/feCDHK2.png

There's an int cast:
https://invent.kde.org/frameworks/kunitconversion/-/blob/master/src/value.cpp#L184

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 433621] No category name over "Appearance" on Manjaro, which looks weird

2021-03-05 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=433621

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #3 from Chris Holland  ---
$ grep "Name=Hardware Configuration" /usr/share/kservices5/*.desktop
/usr/share/kservices5/msm_mhwd.desktop:Name=Hardware Configuration

$ pacman -Qo /usr/share/kservices5/msm_mhwd.desktop
/usr/share/kservices5/msm_mhwd.desktop is owned by manjaro-settings-manager-kcm
0.5.6-11

* https://gitlab.manjaro.org/applications/manjaro-settings-manager
*
https://gitlab.manjaro.org/applications/manjaro-settings-manager/-/blob/master/src/manjaro-category.desktop#L6

$ pacman -Qo /usr/share/kservices5/settings-appearance.desktop
/usr/share/kservices5/settings-appearance.desktop is owned by systemsettings
5.21.0

settings-appearance.desktop has settings-root-category.desktop as a parent
category.

The only ugly way I can think of is for Manjaro to patch the systemsettings
package, however this bug probably affects all distros who put a kcm at the
top.
I think this is the commit that tells it to not display "Name=Root"? This looks
slightly more complicated than just replacing an empty string in a desktop
file.

https://invent.kde.org/plasma/systemsettings/-/commit/f8e5cc22f4e90778fa8943f867cec9015e5cd6c4#81309d4ed02920d5a144031db1af0c3b7a0bb337_109_112

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375951] locally integrated menus

2021-02-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=375951

--- Comment #41 from Chris Holland  ---
The "show more" hamburger icon when the titlebar doesn't have enough room for
the full menu has already been implemented in the Material Window Decoration.

https://github.com/Zren/material-decoration

I also recently added a reveal menu on hover toggle.
https://github.com/Zren/material-decoration/issues/16#issuecomment-776291194

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 430643] BBC weather location search returns no matches

2021-01-03 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430643

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
The website (https://www.bbc.com/weather) fetches:

https://locator-service.api.bbci.co.uk/locations?api_key=AGbFAKx58hyjQScCXIYrxuEwJh2W2cmv=aws=en=international=settlement,airport,district=importance=london=true=json

The API Key (AGbFAKx58hyjQScCXIYrxuEwJh2W2cmv) can be found in the attribute of
this element:

...

However we should probably see if there's a way to register our own key.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeplasma-addons] [Bug 425770] Wrong icons displaying in weather widget based on time of day (time zone bug)

2020-12-26 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=425770

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
Hmmm.

https://invent.kde.org/plasma/plasma-workspace/-/commits/master/dataengines/weather/ions/envcan/ion_envcan.cpp
https://invent.kde.org/plasma/plasma-workspace/-/blame/master/dataengines/weather/ions/envcan/ion_envcan.cpp#L937

https://dd.weather.gc.ca/citypage_weather/xml/siteList.xml
https://dd.weather.gc.ca/citypage_weather/xml/ON/s458_e.xml (Toronto, ON)

isNight
https://invent.kde.org/plasma/plasma-workspace/-/blame/master/dataengines/weather/ions/envcan/ion_envcan.cpp#L760
https://invent.kde.org/plasma/plasma-workspace/-/blame/master/dataengines/weather/ions/envcan/ion_envcan.cpp#L1653

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 430441] Dolphin 20.12.0 segmentation faults when trying to drag mounted partition in Places panel

2020-12-23 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430441

--- Comment #11 from Chris Holland  ---
The bug has been fixed and will be released in KDE Apps / Dolphin v20.12.1
which is scheduled to be released January 7, 2021. KDE Neon should package the
release for you to update to it shortly afterwards.

https://community.kde.org/Schedules/release_service/20.12_Release_Schedule#Thursday.2C_January_7.2C_2021:_release_service_20.12.1_release

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 430441] Dolphin 20.12.0 segmentation faults when trying to drag mounted partition in Places panel

2020-12-18 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430441

Chris Holland  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/syst
   ||em/dolphin/commit/ef0931540
   ||46f91a59bc7e0fe1f22b590f45a
   ||0b0b

--- Comment #9 from Chris Holland  ---
Git commit ef093154046f91a59bc7e0fe1f22b590f45a0b0b by Chris Holland.
Committed on 18/12/2020 at 00:10.
Pushed by ngraham into branch 'release/20.12'.

Fix crash when device with capacitybar is dragged

M  +2-1src/panels/places/placesitemlistwidget.cpp

https://invent.kde.org/system/dolphin/commit/ef093154046f91a59bc7e0fe1f22b590f45a0b0b

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 430441] Dolphin 20.12.0 segmentation faults when trying to drag mounted partition in Places panel

2020-12-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430441

Chris Holland  changed:

   What|Removed |Added

 CC||colin_sei...@pm.me

--- Comment #7 from Chris Holland  ---
*** Bug 430350 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 430350] Dolphin crashed while trying to drag items in Devices

2020-12-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430350

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Chris Holland  ---
Sorry, I never tested dragging devices (and I've been testing it over a year).
this is a duplicate bug however, more info in the other thread.

*** This bug has been marked as a duplicate of bug 430441 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 430441] Dolphin 20.12.0 segmentation faults when trying to drag mounted partition in Places panel

2020-12-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430441

--- Comment #5 from Chris Holland  ---
Was able to quickly reproduce in the release/20.12 branch.

[KCrash Handler]
#4  0x7f40709b9e70 in QRect::width (this=0x10) at
/usr/include/qt/QtCore/qrect.h:266
#5  0x7f40709d642f in PlacesItemListWidget::paint (this=0x55e69f8e1a90,
painter=0x7fffe660e4c0, option=0x0, widget=0x55e69f73be10) at
/home/chris/Code/kde/dolphin/src/panels/places/placesitemlistwidget.cpp:118
#6  0x7f4070836883 in KItemListWidget::createDragPixmap
(this=0x55e69f8e1a90, option=0x0, widget=0x55e69f73be10) at
/home/chris/Code/kde/dolphin/src/kitemviews/kitemlistwidget.cpp:370
#7  0x7f4070840112 in KStandardItemListWidget::createDragPixmap
(this=0x55e69f8e1a90, option=0x0, widget=0x55e69f73be10) at
/home/chris/Code/kde/dolphin/src/kitemviews/kstandarditemlistwidget.cpp:550
#8  0x7f407081e5e7 in KItemListView::createDragPixmap
(this=0x55e69f82e230, indexes=...) at
/home/chris/Code/kde/dolphin/src/kitemviews/kitemlistview.cpp:628
#9  0x7f4070813763 in KItemListController::startDragging
(this=0x55e69f801750) at
/home/chris/Code/kde/dolphin/src/kitemviews/kitemlistcontroller.cpp:1264
#10 0x7f4070810b22 in KItemListController::mouseMoveEvent
(this=0x55e69f801750, event=0x7fffe660ebf0, transform=...) at
/home/chris/Code/kde/dolphin/src/kitemviews/kitemlistcontroller.cpp:598
#11 0x7f4070812ae7 in KItemListController::processEvent
(this=0x55e69f801750, event=0x7fffe660ebf0, transform=...) at
/home/chris/Code/kde/dolphin/src/kitemviews/kitemlistcontroller.cpp:1104

Weird, option=0x0. So QStyleOptionGraphicsItem* option is null. So it's
breaking when I try to calculate the size of the capacitybar.

QRect capacityRect(
textInfo->pos.x(),
option->rect.top() + option->rect.height() - CAPACITYBAR_HEIGHT -
CAPACITYBAR_MARGIN,
qMin((qreal)option->rect.width(), selectionRect().width()) -
(textInfo->pos.x() - option->rect.left()),
CAPACITYBAR_HEIGHT
);

I wasn't aware that it could be null:
https://doc.qt.io/archives/qt-4.8/qgraphicswidget.html#paint
https://doc.qt.io/archives/qt-4.8/qgraphicsitem.html#paint

I can easily check if option is null with `if (m_drawCapacityBar && option)`,
it won't draw the capacitybar in the drag though.

// We check if option=nullptr since it is null when the place is dragged.
// https://bugs.kde.org/show_bug.cgi?id=430441
if (m_drawCapacityBar && option) {

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 430320] Scrolling past -50 in the calendar applet crashes Plasma

2020-12-12 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=430320

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 391903] Ability to set [kwinrc][WindowSwitcher] AlternativeLayoutName

2020-11-13 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=391903

--- Comment #3 from Chris Holland  ---
The KCM moved to plasma-workspace. It doesn't look like we can set
TabBoxAlternative though.

*
https://github.com/KDE/plasma-workspace/blob/master/kcms/lookandfeel/kcm.cpp#L217
*
https://github.com/KDE/plasma-workspace/blob/master/kcms/lookandfeel/kcm.cpp#L667

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 425865] editable combobox fairly broken

2020-10-13 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=425865

Chris Holland  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/qqc2-desktop-style/c
   ||ommit/2d8d877373e088f94675a
   ||0d1fc969bf6dd048a26
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Chris Holland  ---
Git commit 2d8d877373e088f94675a0d1fc969bf6dd048a26 by Chris Holland.
Committed on 13/10/2020 at 15:04.
Pushed by cholland into branch 'master'.

ComboBox.contentItem must be a QQuickTextInput to fix autocomplete

See QQuickComboBoxPrivate::updateEditText()
https://github.com/qt/qtquickcontrols2/blob/dev/src/quicktemplates2/qquickcombobox.cpp#L426

By removing the MouseArea previously in the contentItem, we lose the
ability to press+hold+drag to select a drop down item.

A MouseArea has been added to the background component to capture
wheel events in a similar pattern to PlasmaComponents3.ComboBox.

The ComboBox previously closed the popup when releasing the click to
open the dropdown when editable=true.

M  +56   -107  org.kde.desktop/ComboBox.qml
M  +7-0tests/testComboBox.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/2d8d877373e088f94675a0d1fc969bf6dd048a26

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 424076] PlasmaComponents3.ComboBox closes popup on click release when editable=true

2020-10-08 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=424076

Chris Holland  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/plasma-framework/com
   ||mit/086a710478592bc4c93b90c
   ||28d4ec88e8ae8b86f
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Chris Holland  ---
Git commit 086a710478592bc4c93b90c28d4ec88e8ae8b86f by Zren (Chris Holland), on
behalf of Chris Holland.
Committed on 08/10/2020 at 13:34.
Pushed by cholland into branch 'master'.

ComboBox3.contentItem must be a QQuickTextInput to fix autocomplete

See QQuickComboBoxPrivate::updateEditText()
https://github.com/qt/qtquickcontrols2/blob/dev/src/quicktemplates2/qquickcombobox.cpp#L426

By removing the MouseArea previously in the contentItem, we lose the
ability to press+hold+drag to select a drop down item.

The wheel events still work, as they are captured by the MouseArea in
the background component.

The combobox previously closed the popup when releasing the click to
open the dropdown when editable=true.

M  +45   -103  src/declarativeimports/plasmacomponents3/ComboBox.qml

https://invent.kde.org/frameworks/plasma-framework/commit/086a710478592bc4c93b90c28d4ec88e8ae8b86f

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 426074] Buttons of gtk3 CSD do not respect size setting

2020-09-20 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=426074

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 426670] Buttons to close, maximize and minimize windows are very small in gtk apps with CSDs

2020-09-19 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=426670

--- Comment #8 from Chris Holland  ---
Incorrect Mikhail. I was using a hardcoded 10x10 icon in material-decoration. I
managed to fix material-decoration to scale the icons. However I couldn't
easily test as whatever process that generates the svg assets still had the
older library loaded in memory.

/usr/lib/qt/plugins/org.kde.kdecoration2/materialdecoration.so

After rebooting, I was able to view my changes to material-decoration.

https://user-images.githubusercontent.com/416367/93687885-7f3a0e80-fa8f-11ea-9f0b-1b0801480aeb.png

It appears the kded5 process needs to be restarted to test changes to
materialdecoration.so.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 426670] Buttons to close, maximize and minimize windows are very small in gtk apps with CSDs

2020-09-19 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=426670

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #6 from Chris Holland  ---
Sorry, my material-decoration wasn't scaling the icons by the button geometry.
It probably wasn't scaling for HiDPI either.

I am running into an issue however. Is there a cache for the icons generated to
~/.config/gtk-3.0/assets/?

https://github.com/Zren/material-decoration/issues/22#issuecomment-695220800

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 333219] An option to group hidden files in the end

2020-08-26 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=333219

--- Comment #7 from Chris Holland  ---
Recent Discussion on Reddit:
https://www.reddit.com/r/kde/comments/ih4ro2/is_it_possible_to_sort_files_in_dolphin_so_that/

I did attempt to merge my patches but it since it could affect performance and
is only for a few users it wasn't merged.
https://phabricator.kde.org/D7498

The most recent version of my patch. I rebase my "zren" branch on dolphin
master periodically so it could be out of date to anyone reading in the future.
https://github.com/Zren/dolphin/commit/565e4be6b3aa5348a5db0a8d62702d9469163d22

Anyone wishing to try my patches, try my dolphin fork (you'll have to recompile
every once and a while). Instructions are in the ReadMe.
https://github.com/Zren/dolphin

-- 
You are receiving this mail because:
You are watching all bug changes.

[lattedock] [Bug 417817] Notification in latte stop working

2020-07-28 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=417817

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #9 from Chris Holland  ---
Figured I'd link this here:
https://github.com/Zren/plasma-applet-eventcalendar/issues/60

Oh, so I can't connect to the notification datasource in lattedock or Latte
will think I'm running a notification server/GUI. Even though I only use it to
send operation calls like the default Timer widget.

*
https://github.com/Zren/plasma-applet-eventcalendar/blob/master/package/contents/ui/NotificationManager.qml
*
https://github.com/KDE/kdeplasma-addons/blob/master/applets/timer/package/contents/ui/main.qml#L71

var service = notificationSource.serviceForSource("notification");
var operation = service.operationDescription("createNotification");
service.startOperationCall(operation);

I'd already noticed that Desktop Widgets (in plasmashell) couldn't send
notifications to the notification widget in latte-dock as I don't believe
DataEngines sync between processes. This behavior can be observed by running
the Timer widget in plasmoidviewer.

Anyways, my solution was first to use notify-send, but I've since written a
notification.py script to also support actions/buttons.

*
https://github.com/Zren/plasma-applet-eventcalendar/blob/master/package/contents/scripts/notification.py#L125

I'd been holding off using notification.py for Google Calendar events as I
didn't want to send unvetted text (event summary) to the commandline via the
executable DataEngine. I could create a whitelist of characters I guess... or
blacklist quotes?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 424228] The Search field has stopped displaying a frame when using a larger font size and display scaling

2020-07-19 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=424228

--- Comment #7 from Chris Holland  ---
If the height is the problem, why is it not showing the left/right frame
highlight?

* https://github.com/KDE/kirigami/blob/master/src/controls/SearchField.qml
* https://github.com/KDE/kirigami/blob/master/src/controls/ActionTextField.qml
* https://doc.qt.io/qt-5/qml-qtquick-controls2-textfield.html

Where's the Kirigami TextField "style"? Is it just using the QQC2.TextField
defaults?

Also, why does the Kirigami.SearchField in Plasma Style show a highlight frame?

*
https://github.com/KDE/plasma-desktop/blob/master/kcms/desktoptheme/package/contents/ui/main.qml#L64

$ locate CategoriesPage.qml
/usr/share/kpackage/genericqml/org.kde.systemsettings.sidebar/contents/ui/CategoriesPage.qml

Editing that file with:
Layout.maximumHeight: topPadding + contentHeight + bottomPadding // Shows frame
Layout.maximumHeight: topPadding + contentHeight + bottomPadding - 1 // Doesn't
show frame

So the bug is that CategoriesPage.qml assumes the `iconSizes.smallMedium` is
taller than the text of the SearchField, which isn't always the case.

Eg: https://i.imgur.com/5GPkrYl.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 424076] New: PlasmaComponents3.ComboBox closes popup on click release when editable=true

2020-07-10 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=424076

Bug ID: 424076
   Summary: PlasmaComponents3.ComboBox closes popup on click
release when editable=true
   Product: frameworks-plasma
   Version: 5.71.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: components
  Assignee: notm...@gmail.com
  Reporter: zrenf...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: ---

https://invent.kde.org/frameworks/plasma-framework/-/blame/master/src/declarativeimports/plasmacomponents3/ComboBox.qml

One solution is to make `contentItem: T.TextField {}` instead of `MouseArea`
wrapping the `TextField`. However this breaks press+drag+select.

Note that if you do press+drag, it spams this:
file:///usr/lib/qt/qml/org/kde/plasma/components.3/ComboBox.qml:112:
ReferenceError: controlRoot is not defined

IF we make contentItem: T.TextField, it would also fix another bug:
PlasmaComponents3.ComboBox autocomplete doesn't work.

See `QQuickComboBoxPrivate::updateEditText()` to where it casts `contentItem`
as `QQuickTextInput`.

https://github.com/qt/qtquickcontrols2/blob/dev/src/quicktemplates2/qquickcombobox.cpp#L426

I've personally patched the ComboBox with:
https://gist.github.com/Zren/99ea7a517ea1e1ca028662aa84543ce8

OS: Manjaro
KDE Plasma Version: 5.19.80 (plasma-git)
KDE Frameworks Version: 5.71 (kf5-git)
Qt Version: 5.15

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 424060] When you open PlasmaComponents.Combobox in a widget on your desktop, plasmoid goes into edit mode.

2020-07-10 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=424060

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #5 from Chris Holland  ---
Note this affects PlasmaComponents2 (QQC1) ComboBoxes only. Didn't happen with
QQC2 (PlasmaComponents3).

It happens with a click in QQC1, whereas QQC2 requires a pressandhold to
trigger edit mode.

This is probably because QQC1 creates a native window popup, while QQC2 creates
a... I think it's a fake window that only stays within the parent window. So I
assume QQC1 recognizes the press, creates a new window, but doesn't send a
press released event to the ComboBox, and the Plasma Widget wrapper that
detects a press and hold event.

I was personally testing by changing this to "PlasmaComponents.ComboBox":
https://github.com/Zren/plasma-applet-gitlabissues/blob/master/package/contents/ui/IssueListView.qml#L87

Note that when editable=true, clicking the TextField doesn't trigger edit mode,
but clicking the indicator to open the dropdown does trigger edit mode.
Note I'm also I'm using Manjaro's Stable plasma-git.

Eg: https://www.youtube.com/watch?v=NuoFbmxVM0o

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387775] KWin touch screen edge creates a 1 pixel dead zone on that edge that doesn't accept mouse clicks or scrolls outside of full-screen mode

2020-06-21 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=387775

--- Comment #36 from Chris Holland  ---
Ooops. I wasn't testing kwin's Plasma/5.19 branch properly. `m_cornerOffset` is
fixed in Plasma 5.19.2:

*
https://invent.kde.org/plasma/kwin/commit/bc2df9f84be7ff12ab7e67ee7931eae1f5aeacce
* https://bugs.kde.org/show_bug.cgi?id=422816

Now that I think of it, this bug is titled "1px dead zone", not "bottom-left
fitt's law is broken". The 1px dead zone still exists on the left-center edge
of the screen, so I guess that's why this bug is still open.

I was testing by running `./build/bin/kwin_x11`. However to properly test
`X11Output` and `X11StandalonePlatform` we need to install it to
`org.kde.kwin.platforms/KWinX11Platform.so`. Doing so will crash kwin, but it
should auto-restart.

cd /usr/lib/qt/plugins/org.kde.kwin.platforms
sudo cp ./KWinX11Platform.so ./KWinX11Platform.so.bak
sudo cp ~/Code/kde/kwin/build/org.kde.kwin.platforms/KWinX11Platform.so ./

When testing it shows:

kwin.test: X11StandalonePlatform::doUpdateOutputs()
kwin.test: new X11Output KWin::X11Output(0x562e35e96600)
kwin.test: outputInfo[ 0 ] KWin::X11Output(0x562e35e96600)
kwin.test: name "DVI-I-0"
kwin.test: mm_width 477
kwin.test: mm_height 268
kwin.test: physicalSize QSize(477, 268)

kwin.test: Screens::physicalDpiX size(screen) QSize(1920, 1080)

kwin.test: OutputScreens::physicalSize output
KWin::X11Output(0x562e35e96600)
kwin.test: OutputScreens::physicalSize return output->physicalSize()
QSize(477, 268)
kwin.test: X11Output::physicalSize QSize(477, 268)

kwin.test: ScreenEdges Screens::self()->physicalDpiX(0) 102
kwin.test: ScreenEdges Screens::self()->physicalDpiY(0) 102
kwin.test: ScreenEdges m_cornerOffset 34

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387775] KWin touch screen edge creates a 1 pixel dead zone on that edge that doesn't accept mouse clicks or scrolls outside of full-screen mode

2020-06-21 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=387775

--- Comment #35 from Chris Holland  ---
I tried using `xprop` and `xwininfo` then clicking the bottom left corner to
find out it's properties.

$ xprop
XdndAware(ATOM) = ATOM

$ xwininfo
xwininfo: Window id: 0xbfaa2f8 (has no name)
  Absolute upper-left X:  0
  Absolute upper-left Y:  -16255
  Relative upper-left X:  0
  Relative upper-left Y:  -16255
  Width: 1
  Height: 33590
  Depth: 0
  Visual: 0x21
  Visual Class: TrueColor
  Border width: 0
  Class: InputOnly
  Colormap: 0x0 (not installed)
  Bit Gravity State: ForgetGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: yes
  Corners:  +0+-16255  -1919+-16255  -1919--16255  +0--16255
  -geometry 1x33590+0+-16255

A 1x33590 window? Oh: 33590-16255-16255=1080

$ xwininfo -root -tree | grep 33590 -B10 -A10
 0x184 "Qt Selection Owner for xembedsniproxy": ()  3x3+0+0  +0+0
 0x1a4 "Qt Selection Owner for kaccess": ()  3x3+0+0  +0+0
 0xa4 "Qt Selection Owner for kwalletd5": ()  3x3+0+0  +0+0
 0x165 (has no name): ()  1x1+0+0  +0+0
 0x164 "Qt Selection Owner for ksmserver": ()  3x3+0+0  +0+0
 0x124 "Qt Selection Owner for kglobalaccel5": ()  3x3+0+0  +0+0
 0xe5 (has no name): ()  1x1+0+0  +0+0
 0xe4 "Qt Selection Owner for kactivitymanagerd": ()  3x3+0+0  +0+0
 0xc4 "Qt Selection Owner for kded5": ()  3x3+0+0  +0+0
 0xbe7 "KWin": ()  1x1+0+0  +0+0
 0xbfaa2f8 (has no name): ()  1x33590+0+-16255  +0+-16255
 0xbfaaf6e (has no name): ()  1920x525+0+0  +0+0
1 child:
0xbfaaf6f (has no name): ()  1920x525+0+0  +0+0
   1 child:
   0x267 "kwin : bash — Yakuake": ("yakuake" "yakuake") 
1920x525+0+0  +0+0
 0xbe00036 (has no name): ()  1920x30+0+1050  +0+1050
1 child:
0xbe00037 (has no name): ()  1920x30+0+0  +0+1050
   1 child:
   0x1e00034 "Plasma": ("plasmashell" "plasmashell")  1920x30+0+0 
+0+1050

Testing an old neon-testing-20200512-1045.iso (Plasma 5.18.5?), the bug doesn't
exist. The Bottom Left corner works. Also, by hiding the titlebar in breeze
deco, I confirmed that kwin isn't treating titlebars special, the dead zone
just doesn't cover the top corners.

Here's `xwininfo` from clicking the middle-left of the screen from the ISO:

$ xwininfo
xwininfo: Window id: 0x2600024 (has no name)
  Absolute upper-left X:  0
  Absolute upper-left Y:  32
  Relative upper-left X:  0
  Relative upper-left Y:  32
  Width: 1
  Height: 1016
  Depth: 0
  Visual: 0x21
  Visual Class: TrueColor
  Border width: 0
  Class: InputOnly
  Colormap: 0x0 (not installed)
  Bit Gravity State: ForgetGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: yes
  Corners:  +0+32  -1919+32  -1919-32  +0-32
  -geometry 1x1016+0+32

So calculating 1080-1016 = 64. 64/2 = 32.

$ xwininfo -root -tree | grep 0x2600024 -B10 -A10
 ...
 0x267 "KWin": ()  1x1+0+0  +0+0
 0x260002f (has no name): ()  1x1+0+0  +0+0
 0x2600030 (has no name): ()  32x32+0+0  +0+0
 0x2600024 (has no name): ()  1x1016+0+32  +0+32

The 1x1 is probably the "screen edge" click hotspot.

32x32+0+0 could be the default top-left "screen edge" hover effect, as it
disappears when disable screenedge in system settings. It only appears for the
"Toggle Window Switching" option. The 32x32 window isn't created for the "Show
Desktop" option, even though the hover/glow effect is still drawn. So it's
**not** the glow.

So lets git clone kwin, then checkout the `Plasma/5.19` branch.

* https://invent.kde.org/plasma/kwin/-/blob/master/screenedge.cpp
* https://invent.kde.org/plasma/kwin/-/blob/master/screens.cpp
* https://invent.kde.org/plasma/kwin/-/blob/master/outputscreens.cpp

Looking at the logic of `m_cornerOffset`, this is what is intended assuming dpi
is the default `96`:

ScreenEdges::ScreenEdges(...)
  m_cornerOffset = (Screens::self()->physicalDpiX(0) +
Screens::self()->physicalDpiX(0) + 5) / 6
  m_cornerOffset = (96 + 96 + 5) / 6
  m_cornerOffset = (int)32.83
  m_cornerOffset = 32

Adding some logging to `screenedge.cpp` and `screens.cpp` and
`outputscreens.cpp`, we get:

kwin.screens: size(screen) QSize(1920, 1080)
kwin.outputscreens: OutputScreens::physicalSize output
KWin::X11Outpu

[kwin] [Bug 421527] Thumbnail Grid may stay cause the desktop to be always focused

2020-05-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=421527

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
Direct link to OP's attachment:
https://drive.google.com/file/d/1136PK_QmDzPcICjOsX09eQo1hZb3jhlf/view

I was able to reproduce this bug after turning back on "Show selected window".

It has "showing desktop" selected, then the "show desktop" item is replaced
with "app" as we don't have "Include 'show desktop' icon" checked. The
currentIndex does not change.

Even if we check "Include 'show desktop' icon", when the app appears the window
is selected in the tabbox but the show desktop effect is still active. Because
currentIndex=0 still. If we hit tab twice to select 'show desktop' then select
the app then all is well. This is because currentIndex changed.

So we need to detect when the data at currentIndex is changed (eg: 'show
desktop' => 'app') and cause it to 

https://github.com/KDE/kdeplasma-addons/blob/master/windowswitchers/thumbnail_grid/contents/ui/main.qml

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 421487] New: Bottom-Left Applet (kickoff) doesn't obey fitt's law

2020-05-13 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=421487

Bug ID: 421487
   Summary: Bottom-Left Applet (kickoff) doesn't obey fitt's law
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Panel
  Assignee: plasma-b...@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: 1.0

Can anyone confirm this?

When you click the bottom of the screen, you open the kickoff widget. If you
click the bottom-left corner, or the left of the screen/panel, the widget does
not open.

* I noticed this when I switched to Manjaro's plasma-git, but wasn't sure it
might've been already fixed.
* So I just tested neon-unstable-20200510-1103.iso in a VM, and noticed the
same behavior when the VM was in fullscreen.
* I tested kubuntu-disco-desktop-amd64.iso as well, and noticed it obeyed
fitt's law as I could activate the widget by clicking the bottom-left of the
screen and the left edge of the panel.

I could not figure out what caused it.

*
https://github.com/KDE/plasma-desktop/commits/master/desktoppackage/contents/views/Panel.qml
* https://github.com/KDE/plasma-desktop/commits/master/containments/panel
*
https://github.com/KDE/plasma-framework/commits/master/src/desktoptheme/breeze/translucent/widgets/panel-background.svg

Older bugs which might be useful for figuring it out:
* https://bugs.kde.org/show_bug.cgi?id=394819
* https://bugs.kde.org/show_bug.cgi?id=389215

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 375951] locally integrated menus

2020-03-26 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=375951

--- Comment #27 from Chris Holland  ---
I've restarted interest in this feature after finding and modifying zzag's
material decoration. I've bundled psifidotos's AppMenuModel.cpp from his
appmenu widget. He bundled libdbusmenuqt so I've done the same as I couldn't
iron out how to link to it.

* https://i.imgur.com/R3qHgaN.png
* https://github.com/Zren/material-decoration/tree/lim
* https://github.com/psifidotos/applet-window-appmenu/tree/master/plugin
* https://github.com/KDE/breeze/blob/master/kdecoration/breezesizegrip.cpp

It's a work in progress. I'm not sure if I'll attempt to embed a Widget QMenu
somehow, or if I'll stick with using
KDecoration2::DecorationButtonType::Custom. While it'll be easier to theme
"Custom" buttons, QMenu comes with "hover"+Left/Right Arrows to change
submenues and other basic menu features.

I recommend using the following command to test the LIM branch. It filters out
the non-essential logging, and restarts KWin.

sudo make install && QT_LOGGING_RULES="*=false;kdecoration.material=true"
kstart5 -- kwin_x11 --replace

Tip: I also found that just opening the System Settings > Window Decorations
kcm was more convenient for testing the close/maximize/minimize buttons.

kcmshell5 kwindecoration

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 417454] Emoji Picker (Selector) extremely slow

2020-02-11 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=417454

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
I've tried to fix the layout slowness, and add some lazy loading for the
emojis.

https://phabricator.kde.org/D27337

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 416497] No shadows on GTK menus.

2020-01-20 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=416497

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #2 from Chris Holland  ---
For reference, this is the PR for Gtk shadows. It added support for the
_GTK_FRAME_EXTENTS window property.
https://phabricator.kde.org/D24660



* Running `xprop`, then clicking Firefox with the default KWin titlebar, it
*properly* does not have the _GTK_FRAME_EXTENTS property.
* After entering Customize in Firefox, and unchecking "title bar" to enable
CSD, the property exists:
  _GTK_FRAME_EXTENTS(CARDINAL) = 26, 26, 23, 29

I couldn't easily figure out the contextmenu properties using xprop though,
since a context menu grabs the mouse.

So I used `watch -n0.5 -- xwininfo -root -tree` and opened and closed the
firefox contextmenu.

Parent window id: 0x0 (none)
  69 children:
  0x3200035 "Firefox"": ("Firefox" "Firefox") 201x234+59+270  +59+270
1 child:
0x3200036 (has no name): () 1x1+-1+-1  +58+269
...

I noticed the window id remained even when the contextmenu was closed. So I
ran:
watch -- xprop -id 0x3200035

I did not see any _GTK_FRAME_EXTENTS property.

WM_TRANSIENT_FOR(WINDOW): window id # 0x32022c4
WM_HINTS(WM_HINTS):
Client accepts input or input focus: True
Initial state is Normal State.
window id # of group leader: 0x321
WM_WINDOW_ROLE(STRING) = "Popup"
XdndAware(ATOM) = BITMAP
_NET_WM_OPAQUE_REGION(CARDINAL) = 
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_POPUP_MENU
...

I also tested Gnome Chess, and noticed it's app icon menu did have:

_GTK_FRAME_EXTENTS(CARDINAL) = 6, 6, 5, 7
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_POPUP_MENU

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 405322] Negative "Relative Start Time" in Process Table after hibernation

2020-01-11 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=405322

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #1 from Chris Holland  ---
I observe this regularly after putting my PC to sleep. I don't hibernate it,
and I'm able to wake it with the spacebar.

Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.65.0
Qt Version: 5.14.0
Kernel Version: 5.4.6-2-MANJARO

-

Here's where the logic is calculated:

*
https://github.com/KDE/libksysguard/blob/master/processui/ProcessModel.cpp#L1410
*
https://github.com/KDE/libksysguard/blob/master/processui/ProcessModel.cpp#L1573

I think it's caused by TimeUtil::systemUptimeAbsolute(), as it takes the
current time, and subtracts TimeUtil::systemUptimeSeconds()

* https://github.com/KDE/libksysguard/blob/master/processui/timeutil.h#L65
* https://github.com/KDE/libksysguard/blob/master/processui/timeutil.h#L45
* https://doc.qt.io/qt-5/qdatetime.html#currentDateTime

We're using CLOCK_MONOTONIC

> https://linux.die.net/man/3/clock_gettime
> CLOCK_MONOTONIC
>Clock that cannot be set and represents monotonic time since some 
> unspecified starting point.


I assume that it's taking the seconds since waking up and subtracting the
seconds since the system's initial boot somewhere but I can't figure it out
without some debug logging.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 393630] System tray icons not clickable and collapsible when an entry's visibility is changed to hidden

2019-08-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=393630

--- Comment #42 from Chris Holland  ---
There seems to be a Plasma 5.12.9 release on Tue 2019-09-10 according to:
https://community.kde.org/Schedules/Plasma_5

It doesn't look like the https://phabricator.kde.org/D18805 patch to avoid
`plasmoid.rootItem` was backported to the Plasma 5.12 branch.

https://github.com/KDE/plasma-workspace/blob/Plasma/5.12/applets/systemtray/package/contents/ui/ConfigEntries.qml#L236

I'm not sure how long after Sept 10 it would take for Kubuntu 18.04.__ to get
the bugfix release. Would it land before Kubuntu 20.04?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 407118] Keyboard navigation broken

2019-06-03 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=407118

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385814] Some icons removed from the favorites list are back when plasma session is restarted

2019-03-18 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=385814

--- Comment #45 from Chris Holland  ---
This breakdown is for developers, regular users can skip this comment.

*
https://github.com/KDE/plasma-desktop/blame/master/applets/kicker/plugin/kastatsfavoritesmodel.cpp#L622
*
https://github.com/KDE/kactivities-stats/blame/master/src/resultwatcher.cpp#L368
*
https://github.com/KDE/kactivities-stats/blame/master/src/resultwatcher.cpp#L69
*
https://github.com/KDE/kactivities-stats/blob/248d6355aaabc389b4a4916afd63b7ef18b4c3b2/src/common/dbus/common.h#L50

To see the info of the DBus interface used run:
qdbus org.kde.ActivityManager /ActivityManager/Resources/Linking

To monitor the add/remove favorites code, double click the signal in
`qdbusviewer`, or run:
dbus-monitor
"type='signal',interface='org.kde.ActivityManager.ResourcesLinking',member='ResourceLinkedToActivity'"
"type='signal',interface='org.kde.ActivityManager.ResourcesLinking',member='ResourceUnlinkedFromActivity'"

Some sort of magic then stores the favourite list in an SQLite database. The
`kactivitymanagerd-statsrc` file is just for sorting the order of the
favorites.
~/.local/share/kactivitymanagerd/resources/database

Browse the ResourceLink table to see all the favourites using `sqlitebrowser`,
or run:
sqlite3 ~/.local/share/kactivitymanagerd/resources/database "SELECT * FROM
'ResourceLink';"

$ sqlite3 ~/.local/share/kactivitymanagerd/resources/database "SELECT *
FROM 'ResourceLink';"
:global|org.kde.plasma.favorites.applications|qupzilla.desktop
:global|org.kde.plasma.favorites.applications|org.kde.discover.desktop
:global|org.kde.plasma.favorites.applications|preferred://browser
:global|org.kde.plasma.favorites.applications|kontact.desktop
   
:global|org.kde.plasma.favorites.applications|applications:systemsettings.desktop
   
:global|org.kde.plasma.favorites.applications|applications:org.kde.dolphin.desktop
   
80cddcc9-cf02-4e23-af0b-dc569f24a2b4|org.kde.plasma.favorites.applications|applications:LEGO
The Hobbit.desktop
   
:global|org.kde.plasma.favorites.documents|/usr/share/plasma/wallpapers/org.kde.image/contents/ui/config.qml

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 385814] Some icons removed from the favorites list are back when plasma session is restarted

2019-03-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=385814

--- Comment #39 from Chris Holland  ---
Per activity favourites was added a month before this bug report was made (just
before Plasma 5.11.0).

*
https://github.com/KDE/plasma-desktop/blame/master/applets/kicker/plugin/kastatsfavoritesmodel.cpp
*
https://github.com/KDE/plasma-desktop/commit/4ba9b01e2d6acc361f4ac0c7e4c21066eb575146

It added the ability for sharing the favorites on all monitors / activities.

Since this only affects a few users (?) it sounds like there's a race condition
somewhere which is fairly difficult to test for and track down. Especially when
it might only happen when plasmashell is starting up when you first login which
means you have to relog every time you attempt to test.

Anyone still experiencing this, please upload your:

~/.config/kactivitymanagerdrc
~/.config/kactivitymanagerd-statsrc

If you can reproduce the bug repeatedly, please also upload what those files
look like after you edit the favorites before you reboot (before the bug is
triggered) and what they look like after.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 405098] Show a capacity bar indicating the free space left in partition similar to KIO's File Widget

2019-03-05 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=405098

--- Comment #2 from Chris Holland  ---
Yeah, I found https://bugs.kde.org/show_bug.cgi?id=399710 after I made this
bug, which links to https://phabricator.kde.org/T9795 discussing doing that.

Not sure if I should mark this as a duplicate of that bug, as the title
suggests it's for a "KIO url scheme"-like thing for viewing devices in the file
area.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 405098] New: Show a capacity bar indicating the free space left in partition similar to KIO's File Widget

2019-03-04 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=405098

Bug ID: 405098
   Summary: Show a capacity bar indicating the free space left in
partition similar to KIO's File Widget
   Product: dolphin
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: panels: places
  Assignee: dolphin-bugs-n...@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: ---

User Discussion:
https://www.reddit.com/r/kde/comments/axdwzg/dolphin_and_disk_space/

KDE's "File Save Dialog" shows a capacity bar when you hover a device in the
dialog's places panel.

* https://github.com/KDE/kio/tree/master/src/filewidgets
*
https://github.com/KDE/kio/blob/master/src/filewidgets/kfileplacesview.cpp#L218
* https://github.com/KDE/kio/blob/master/src/filewidgets/kfileplacesmodel.h#L50
*
https://github.com/KDE/kio/blob/master/src/filewidgets/kfileplacesitem.cpp#L270

* https://github.com/KDE/kwidgetsaddons/blob/master/src/kcapacitybar.h
* https://github.com/KDE/kwidgetsaddons/blob/master/src/kcapacitybar.cpp

Gotta figure out a way merge that feature into Dolphin's places panel, ideally
without the need to hover the PlaceItem to see the capacityBar.

* https://github.com/KDE/dolphin/blob/master/src/panels/places/

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404292] Digital clock settings option for toggling between 12 and 24 hour clock format is broken

2019-02-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=404292

Chris Holland  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.15.1
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/006c4f5f9ee8d
   ||fb3d95604a706d01b968c1e1c8a
 Status|REPORTED|RESOLVED

--- Comment #3 from Chris Holland  ---
Git commit 006c4f5f9ee8dfb3d95604a706d01b968c1e1c8a by Chris Holland.
Committed on 14/02/2019 at 23:48.
Pushed by cholland into branch 'Plasma/5.15'.

[Digital Clock] Fix 24h tri-state button broken in port to QQC2

In 12h system locales (eg: en_US), checked=1 is cast as
Qt::PartiallyChecked=1 which defaults to the system locale (12h).
Since it's no longer a tri-state button, the user can't select
Qt::Checked=2 which forces the 24h state.

FIXED-IN: 5.15.1

M  +2-1applets/digital-clock/package/contents/ui/configAppearance.qml

https://commits.kde.org/plasma-workspace/006c4f5f9ee8dfb3d95604a706d01b968c1e1c8a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404292] Digital clock settings option for toggling between 12 and 24 hour clock format is broken

2019-02-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=404292

--- Comment #2 from Chris Holland  ---
Ah, seems like the QQC1.CheckBox.checkedState property was renamed
QQC2.CheckBox.checkState

* https://doc.qt.io/qt-5.11/qml-qtquick-controls2-checkbox.html#checkState-prop

In any case, here's a patch: https://phabricator.kde.org/D19021

Martin, you can either wait a few days for Plasma 5.15.1, or you can manually
edit the file with the fix:
/usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/configAppearance.qml

Then relog to reload the widget.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 404292] Digital clock settings option for toggling between 12 and 24 hour clock format is broken

2019-02-14 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=404292

--- Comment #1 from Chris Holland  ---
Why the heck is this config property an unsigned int instead of a bool? Oh
right. It's a tri-state button that defaults to whatever the system locale
chooses.

// config/main.xml

  Force the clock to use 12/24 hour time, instead of following the
user locale.
  1



// ui/configAppearance.qml
QtControls.CheckBox {
id: use24hFormat
text: i18nc("Checkbox label; means 24h clock format, without am/pm",
"Use 24-hour Clock")
}

// ui/DigitalClock.qml
property int use24hFormat: plasmoid.configuration.use24hFormat


*
https://github.com/KDE/plasma-workspace/blame/master/applets/digital-clock/package/contents/ui/configAppearance.qml


It looks like during the QQC2/Kirigami migration, the tri-state button property
`checkedState` was changed to `checked`.

https://github.com/KDE/plasma-workspace/commit/39e812d57fd6a52e6c8596f823564a241d9ae696#diff-26b9a772d0004bc6a0622b47b3cbfd09L46

Since `bool checked` when cast to an integer is 0=off, and 1=on, it's basically
changing between Qt::Unchecked=0 and Qt::PartiallyChecked=1. So when the 24h
button is "checked=true", it's cast as Qt::PartiallyChecked=1 and ends up using
the system locale. Since in en_US defaults to 12h clock, it has no visible
effect.

If the dev who wrote the code migration developed in a 24h system locale, it'd
"work" during testing.

* https://doc.qt.io/qt-5/qml-qtquick-controls-checkbox.html#checkedState-prop
* https://doc.qt.io/archives/qt-5.10/qt.html#CheckState-enum

It's a bit odd that Qt::PartiallyChecked is 1, instead of 2. But I guess that
was intentional by the Qt devs.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404146] Tabbox kcm incorrectly falls back to informative on broken theme

2019-02-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=404146

--- Comment #2 from Chris Holland  ---
The main reason I made this bug is for when a downloaded QML skin from the KDE
Store is loaded but fails to load (eg: was written for KWin 4.x).

However, you do raise a good point, I completely forgot "informative" is part
of kdeplasma-addons.

So it seems the hardcoded default needs to be... "org.kde.breath.desktop" so
that it loads:
/usr/share/plasma/look-and-feel/org.kde.breath.desktop/contents/windowswitcher/WindowSwitcher.qml

However that still depends on the breeze package. KWin itself does not seem to
ship with any "QML" tabbox skins that I can see. So does this mean it needs to
somehow fallback to a C++ TabBox theme? Like the "kwin/effects/coverswitch"
desktop effect? I'm not quite sure how it loads the C++ effects to be honest...

Looking at the kcm code, it seems that the desktop effect itself has a "TabBox"
config property. I take it that it will then take over the "Alt+Tab" and
"Alt+Shift+Tab" shortcuts.

*
https://github.com/KDE/kwin/blob/cfecb1e0770ca6c8fa879124e11b03081342b9ed/kcmkwin/kwintabbox/main.cpp#L368
*
https://github.com/KDE/kwin/blob/master/effects/coverswitch/coverswitch.kcfg#L35
* 

Falling back to a "kwin effect" skin sounds like a fairly complicated fallback,
as you'd need to copy the kcm's save() code.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404146] New: When a QML tabbox skin fails to load, fall back to "Informative" like we do when the configured file does not exist

2019-02-09 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=404146

Bug ID: 404146
   Summary: When a QML tabbox skin fails to load, fall back to
"Informative" like we do when the configured file does
not exist
   Product: kwin
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: tabbox
  Assignee: kwin-bugs-n...@kde.org
  Reporter: zrenf...@gmail.com
  Target Milestone: ---

Issue was raised when discussing the workaround in
https://phabricator.kde.org/T10464

The relevant code is at:
*
https://github.com/KDE/kwin/blob/cfecb1e0770ca6c8fa879124e11b03081342b9ed/tabbox/tabboxhandler.cpp#L281

1. It first checks if a
"plasma/look-and-feel/%1/contents/windowswitcher/WindowSwitcher.qml" file
exists and uses that.
2. If not, it looks for a "kwin/tabbox/%1/contents/ui/main.qml"
3. Then it uses the hardcoded "informative" QML file
"kwin/tabbox/informative/contents/ui/main.qml" as a fallback (I always wondered
why it was using informative when I selected certain "look and feel" skins).

So it seems we need a new function perform the QML loading stuff which returns
a `QObject` or `nullptr`. Something like this:


QObject *TabBoxHandlerPrivate::loadSwitcherItem(QString file)
{
if (file.isNull()) {
m_qmlComponent->loadUrl(QUrl::fromLocalFile(file));
if (m_qmlComponent->isError()) {
m_qmlComponent.reset(...) // ???
return nullptr;
} else {
QObject *object =
m_qmlComponent->create(m_qmlContext.data());
return object
}
}
}

QObject *TabBoxHandlerPrivate::createSwitcherItem(bool desktopMode)
{
QString lookAndFeelFilepath = desktopMode ? ... : ...
QString file = lookAndFeelFilepath;
QObject *object = loadSwitcherItem(file);
if (object != nullptr) {
return object;
}

QString tabboxFilepath = ...
QString file = tabboxFilepath;
QObject *object = loadSwitcherItem(file);
if (object != nullptr) {
return object;
}

QString informativeTabboxFilepath = ...
QString file = informativeTabboxFilepath;
QObject *object = loadSwitcherItem(file);
if (object != nullptr) {
QStringList args;
args << QStringLiteral("The Window Switcher failed to
load, using Informative")
KProcess::startDetached(QStringLiteral("kdialog"),
args);

return object;
} else {
QStringList args;
args << QStringLiteral("The Window Switcher
installation is broken, resources are missing.\nContact your distribution about
this")
KProcess::startDetached(QStringLiteral("kdialog"),
args);

return nullptr;
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 395012] Skins can't be installed from KNS

2019-01-27 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=395012

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370185] On task switcher (Informative, Breeze, Compact,..) can not control switching with arrow keys

2019-01-18 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=370185

--- Comment #16 from Chris Holland  ---
Git commit 80bd32b12a01e29f3fe88f2a50c0a2a842872c19 by Chris Holland.
Committed on 18/01/2019 at 17:44.
Pushed by cholland into branch 'master'.

Consistent arrow key handling in the Informative Alt+Tab skin

Moved `Dialog.Keys.onPressed` to `Dialog.mainItem.Keys.onPressed` so
that all tabbox skins are consistent. This fixes up/down arrow key
navigation in this skin.

Differential Revision: https://phabricator.kde.org/D16093

M  +12   -11   windowswitchers/informative/contents/ui/main.qml

https://commits.kde.org/kdeplasma-addons/80bd32b12a01e29f3fe88f2a50c0a2a842872c19

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 403334] Can only change Desktop Layout / Wallpaper Plugin via MouseWheel

2019-01-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=403334

--- Comment #3 from Chris Holland  ---
https://github.com/KDE/qqc2-desktop-style/commit/581b140c8b81096f40ddebd84b8b2fbc327b616d

I can confirm that Neon's
/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls.2/org.kde.desktop/ComboBox.qml

is using `model` on line 72 + 210 instead of `delegateModel`.

After modifying the file and restarting plasmashell, the bug was fixed. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 403334] New: Can only change Desktop Layout / Wallpaper Plugin via MouseWheel

2019-01-17 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=403334

Bug ID: 403334
   Summary: Can only change Desktop Layout / Wallpaper Plugin via
MouseWheel
   Product: plasmashell
   Version: 5.14.90
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Desktop Containment
  Assignee: se...@kde.org
  Reporter: zrenf...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

There's a bug when changing Wallpaper Plugin. Left Clicking to open the
ComboBox's drop down menu, then left clicking a different plugin will not
switch the GUI. Scrolling over the ComboBox works though.

Eg: https://www.youtube.com/watch?v=5S3_OsyJkiw

There was a Kirigami.FormLayout + QtQuickControl2 patch that changed
QtControls1.ComboBox.onCurrentIndexChanged
*
https://github.com/KDE/plasma-desktop/commits/master/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
*
https://github.com/KDE/plasma-desktop/commit/c2640f83f1077365cd7f87ca2adbfbfb12cf4da7#diff-95d96a95e58373ce46189786eca598f8L144

to QtControls2.ComboBox.onActivated
*
https://github.com/KDE/plasma-desktop/commit/c2640f83f1077365cd7f87ca2adbfbfb12cf4da7#diff-95d96a95e58373ce46189786eca598f8R108

I also noticed the CombBox no longer updates when a wallpaper plugin is
installed which https://phabricator.kde.org/D15178 added.

The "Layout: Folder View" => "Layout: Desktop" ComboBox also displays this bug.

The Image wallpaper plugin's "Scaled and Cropped" ComboBox is still using
QtQuickControl1.onCurrentIndexChanged so it does not have this bug.
*
https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/imagepackage/contents/ui/config.qml#L91

Neon's gitunstable ISO has Qt 5.11.2

QtQuickControls2 ComboBox
* https://doc.qt.io/qt-5.11/qml-qtquick-controls2-combobox.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 340982] I cannot set my short date to YYYY-MM-DD, nor my time to HH:MM

2019-01-13 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=340982

--- Comment #155 from Chris Holland  ---
Git commit 235fa8107dabb757d88cd1876309c12cad990207 by Chris Holland.
Committed on 14/01/2019 at 01:53.
Pushed by cholland into branch 'master'.

[Digital Clock] Add ability to set a custom date format string

Adds a new customDateFormat config key which is used when the dateFormat
"StringEnum" is set to custom.
Shows a link to the Qt time formatting documentation next to the text field.
Qt doc link and text field are hidden when not set to custom date format.

Differential Revision: https://phabricator.kde.org/D18019

M  +5-1applets/digital-clock/package/contents/config/main.xml
M  +8-6applets/digital-clock/package/contents/ui/DigitalClock.qml
M  +26   -0applets/digital-clock/package/contents/ui/configAppearance.qml

https://commits.kde.org/plasma-workspace/235fa8107dabb757d88cd1876309c12cad990207

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390330] Calendar top column does not contain all the days. Only Sat, Sun

2019-01-03 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=390330

--- Comment #8 from Chris Holland  ---
Git commit e5949866bb8f019a416930e2eb58bea363ff0ebf by Chris Holland.
Committed on 03/01/2019 at 21:58.
Pushed by cholland into branch 'master'.

[Calendar] Expose firstDayOfWeek in MonthView

This allows for calendar widgets to override the Locale. Users may
want to start the week on a Sunday, Saturday, or Monday without
changing their locale's date formatting.

Differential Revision: https://phabricator.kde.org/D15321

M  +1-0src/declarativeimports/calendar/qml/MonthView.qml

https://commits.kde.org/plasma-framework/e5949866bb8f019a416930e2eb58bea363ff0ebf

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 401579] Folders in recent documents show unknown icon

2018-12-28 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=401579

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #3 from Chris Holland  ---
I can reproduce in Manjaro with Plasma 5.14.4, Frameworks 5.52, Qt 5.11.2. Note
I'm using the *Breath* icons, which I assume inherits the Breeze icons.

*
https://github.com/KDE/plasma-desktop/blame/master/applets/taskmanager/package/contents/ui/ContextMenu.qml#L101
*
https://github.com/KDE/plasma-desktop/blame/master/applets/taskmanager/plugin/backend.cpp#L286

Here's the KFileItem::iconName() code path:
* https://github.com/KDE/kio/blame/master/src/core/kfileitem.cpp#L893
* https://github.com/KDE/kio/blame/master/src/core/kfileitem.cpp#L1492


-
If I add a few `qDebug()` statements, it seems all the "Recent Doc" icons are
"application-octet-stream".

qDebug() << "url:" << url;
qDebug() << "   scheme:" << url.scheme();
qDebug() << "   isLocal:" << url.isLocalFile();
qDebug() << "   isDir:" << fileItem.isDir();
qDebug() << "   icon:" << fileItem.iconName();

url: QUrl("/home/chris/Pictures/Screenshots")
   scheme: ""
   isLocal: false
   isDir: false
   icon: "application-octet-stream"

I tried setting the scheme to "file" when it's empty. Which fixed
`url.isLocalFile()` but did not fix `KFileItem::isDir()`.

if (url.scheme() == QStringLiteral("")) {
url.setScheme("file");
}

url: QUrl("file:///home/chris/Pictures/Screenshots")
   scheme: "file"
   isLocal: true
   isDir: false
   icon: "application-octet-stream"

-- 
You are receiving this mail because:
You are watching all bug changes.

[xdg-desktop-portal-kde] [Bug 402077] SaveFile does not set the current_name

2018-12-12 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=402077

--- Comment #1 from Chris Holland  ---
I was wrong, setLabelText is *suppose* to set the label next to the filename
TextField but it seems the the KDE KDialog ignores it.
https://github.com/qt/qtbase/blob/5.11/src/widgets/dialogs/qfiledialog.cpp#L605

Looking at the selectFile logic...
https://github.com/qt/qtbase/blob/5.11/src/widgets/dialogs/qfiledialog.cpp#L1047

It seems that it will set the lineEdit text even if the filename does not
exist, and even if it's a relative path.

So I suggest we move the selectFile(currentName) after we navigate to the
correct directory.

if (!currentFolder.isEmpty()) {
fileDialog->setDirectoryUrl(QUrl(currentFolder));
}

if (!currentFile.isEmpty()) {
fileDialog->selectFile(currentFile);
}

if (!currentName.isEmpty()) {
fileDialog->selectFile(currentName);
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[xdg-desktop-portal-kde] [Bug 402077] New: SaveFile does not set the current_name

2018-12-12 Thread Chris Holland
https://bugs.kde.org/show_bug.cgi?id=402077

Bug ID: 402077
   Summary: SaveFile does not set the current_name
   Product: xdg-desktop-portal-kde
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: jgrul...@redhat.com
  Reporter: zrenf...@gmail.com
  Target Milestone: ---

As discussed in:
https://www.reddit.com/r/kde/comments/a5cxwk/firefox_v64_can_now_use_the_kde_file_selection/ebneet7/

OS: Manjaro Linux
xdg-desktop-portal: v1.0.3-1
xdg-desktop-portal-kde: v5.14.4-1


Here's where the GTK portal sets "current_name"
https://github.com/flatpak/xdg-desktop-portal-gtk/blob/master/src/filechooser.c#L479-L482

The KDE portal parses "current_name", but it seems that since there wasn't a
dedicated "setFilename" function, the fella moved on to implementing the rest.
https://github.com/KDE/xdg-desktop-portal-kde/blob/master/src/filechooser.cpp#L252

// TODO: Looks Qt doesn't have API for this
// if (!currentName.isEmpty()) {
//fileDialog->selectFile(currentName);
// }


I'm not 100% sure if this is correct, but I found that QFileDialog can set the
"filename" label widget:
http://doc.qt.io/qt-5/qfiledialog.html#DialogLabel-enum
http://doc.qt.io/qt-5/qfiledialog.html#setLabelText

if (!currentName.isEmpty()) {
   fileDialog->setLabelText(QFileDialog::FileName, currentName);
}

I'll see about learning how to compile this once I've tested if setLabelText is
the correct method.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   >