[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375993

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=392289

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=375993

Martin Flöser  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||n/113be5fac81a4b546e2a1b272
   ||451f50e777bdcb5
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.10.4

--- Comment #8 from Martin Flöser  ---
Git commit 113be5fac81a4b546e2a1b272451f50e777bdcb5 by Martin Flöser.
Committed on 01/07/2017 at 06:20.
Pushed by graesslin into branch 'Plasma/5.10'.

Restore active client after ending showing desktop

Summary:
Showing desktop requests focus on the desktop window. This means the
active window is reset. When ending showing desktop the state was not
restored.

This change addresses this problem by requesting focus to the best
window.
FIXED-IN: 5.10.4

Test Plan: New autotest and manual testing

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6420

M  +1-0autotests/integration/CMakeLists.txt
A  +128  -0autotests/integration/showing_desktop_test.cpp [License: GPL
(v2)]
M  +7-1workspace.cpp

https://commits.kde.org/kwin/113be5fac81a4b546e2a1b272451f50e777bdcb5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=375993

Martin Flöser  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D6420

--- Comment #7 from Martin Flöser  ---
Possible patch at: https://phabricator.kde.org/D6420

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=375993

Martin Flöser  changed:

   What|Removed |Added

  Flags|Wayland?|Wayland+

--- Comment #6 from Martin Flöser  ---
Some investigation results: the problem only exists if there is a desktop
window. If there is no desktop window, show desktop properly restores focus.
This behavior matches the code which requests focus on the desktop, but does
not try to restore.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=375993

--- Comment #5 from Martin Flöser  ---
Given the code in question the problem must exist at least since 5.3 maybe
longer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=375993

Martin Flöser  changed:

   What|Removed |Added

   Keywords||reproducible
  Flags||Wayland?, X11+
  Component|general |core

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=375993

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375993

Nate Graham  changed:

   What|Removed |Added

 CC||martin.ruess...@mailbox.org

--- Comment #4 from Nate Graham  ---
*** Bug 374954 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=375993

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Bastian Beischer]

https://bugs.kde.org/show_bug.cgi?id=375993

--- Comment #3 from Bastian Beischer  ---
I can also confirm this. Also bug 374954 is a duplicate, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Bastian Beischer]

https://bugs.kde.org/show_bug.cgi?id=375993

Bastian Beischer  changed:

   What|Removed |Added

 CC||bastian.beischer@rwth-aache
   ||n.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=375993

--- Comment #2 from Kai Uwe Broulik  ---
I can reproduce this on git master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Tony]

https://bugs.kde.org/show_bug.cgi?id=375993

Tony  changed:

   What|Removed |Added

 CC||jodr...@live.com

--- Comment #1 from Tony  ---
I have the same setup as you, cn't reproduce on neon unstable. Maybe is already
fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375993] The 'Show Desktop' action doesn't restore focus

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=375993

Kai Uwe Broulik  changed:

   What|Removed |Added

   Target Milestone|1.0 |---
  Component|general |general
 Ever confirmed|0   |1
   Assignee|k...@davidedmundson.co.uk|kwin-bugs-n...@kde.org
 CC||k...@privat.broulik.de
Product|plasmashell |kwin
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.