[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Robby Stephenson]

https://bugs.kde.org/show_bug.cgi?id=378477

Robby Stephenson  changed:

   What|Removed |Added

 CC||bugs-kde.akk...@xoxy.net

--- Comment #16 from Robby Stephenson  ---
*** Bug 384528 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Robby Stephenson]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #15 from Robby Stephenson  ---
If I understand you correctly, I think I'm following the spirit of what you're
saying. For icons which could be expected to be in the icon theme, I use
QIcon::fromTheme() with the method call that falls back to a resource icon. For
example, QIcon::fromTheme("checkmark", QIcon(":/icons/checkmark")).

For icons which I specifically don't want to be themed, then I just use the
resource call. An example there would be wine.png which represents a wine
bottle in Tellico. Many themes could reasonably be expected to have an
application icon for WINE instead so I wouldn't want to use the theme icon in
that case.

For whatever reason, the two users who reported the bug did not see the icons
as installed. I could not reproduce the problem since they showed up just fine
for me. I don't know if it is a Debian/Ubuntu issue or something else. If
indeed this fixes the problem for those users, seems like a win/win to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #14 from Christoph Feck  ---
You are of course free to use hardcoded icons from QRC resources, but users of
KDE applications usually expect that these follow the locale icon theme
configuration.

For more information about "qt5ct", please see
https://wiki.archlinux.org/index.php/qt#Configuration_of_Qt5_apps_under_environments_other_than_KDE_Plasma
and https://sourceforge.net/projects/qt5ct/

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #13 from Christoph Feck  ---
Instead of adding code to all applications, we rely on platform tools to set
correct paths for icon themes.

For Plasma, this is part of the plasma-integration and frameworks-integration
plugins.

If you use KDE applications outside of the Plasma environment, please use
"qt5ct". This comes with both a platform plugin, as well as a configuration
tool to change Qt5 fonts, icons, and other UI settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[goupilcom]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #12 from goupil...@gmail.com  ---
(In reply to Robby Stephenson from comment #11)
> Git commit 94376ac3c82942a26c2cf748a5072278c57e6405 by Robby Stephenson.
> Committed on 22/06/2017 at 02:16.
> Pushed by rstephenson into branch 'master'.
> 
> Add a QRC file for the internal icons
> 
> Use the internal resources icons when appropriate. Otherwise, check for
> icons from the theme and fall back to internal ones when needed.
> 
> I can't verify this, but I expect it to fix Bug 378477.
> 
> Also scrub icons from several data sources.
> FIXED-IN: 3.1
> 
> A  +51   -0icons/icons.qrc
> M  +4-0src/CMakeLists.txt
> M  +2-1src/borrowerdialog.cpp
> M  +1-1src/configdialog.cpp
> M  +2-2src/entryeditdialog.cpp
> M  +1-1src/fetch/amazonfetcher.cpp
> M  +1-1src/fetch/bibliosharefetcher.cpp
> M  +1-1src/fetch/bibsonomyfetcher.cpp
> M  +1-1src/fetch/boardgamegeekfetcher.cpp
> M  +1-1src/fetch/hathitrustfetcher.cpp
> M  +1-1src/fetch/ibsfetcher.cpp
> M  +1-1src/fetch/imdbfetcher.cpp
> M  +1-1src/fetch/moviemeterfetcher.cpp
> M  +1-1src/fetch/musicbrainzfetcher.cpp
> M  +1-1src/fetch/openlibraryfetcher.cpp
> M  +1-1src/fetch/videogamegeekfetcher.cpp
> M  +1-1src/fetch/z3950fetcher.cpp
> M  +4-3src/fetchdialog.cpp
> M  +4-4src/groupview.cpp
> M  +2-2src/gui/collectiontypecombo.cpp
> M  +2-2src/gui/ratingwidget.cpp
> M  +1-1src/gui/starrating.cpp
> M  +3-1src/loandialog.cpp
> M  +3-1src/main.cpp
> M  +34   -22   src/mainwindow.cpp
> M  +1-1src/models/borrowermodel.cpp
> M  +2-2src/models/entrygroupmodel.cpp
> M  +3-3src/models/entrymodel.cpp
> M  +1-1src/models/filtermodel.cpp
> M  +2-2src/utils/tellico_utils.cpp
> 
> https://commits.kde.org/tellico/94376ac3c82942a26c2cf748a5072278c57e6405

Thank you for your great job. I will test this new version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Robby Stephenson]

https://bugs.kde.org/show_bug.cgi?id=378477

Robby Stephenson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||3.1
  Latest Commit||https://commits.kde.org/tel
   ||lico/94376ac3c82942a26c2cf7
   ||48a5072278c57e6405

--- Comment #11 from Robby Stephenson  ---
Git commit 94376ac3c82942a26c2cf748a5072278c57e6405 by Robby Stephenson.
Committed on 22/06/2017 at 02:16.
Pushed by rstephenson into branch 'master'.

Add a QRC file for the internal icons

Use the internal resources icons when appropriate. Otherwise, check for
icons from the theme and fall back to internal ones when needed.

I can't verify this, but I expect it to fix Bug 378477.

Also scrub icons from several data sources.
FIXED-IN: 3.1

A  +51   -0icons/icons.qrc
M  +4-0src/CMakeLists.txt
M  +2-1src/borrowerdialog.cpp
M  +1-1src/configdialog.cpp
M  +2-2src/entryeditdialog.cpp
M  +1-1src/fetch/amazonfetcher.cpp
M  +1-1src/fetch/bibliosharefetcher.cpp
M  +1-1src/fetch/bibsonomyfetcher.cpp
M  +1-1src/fetch/boardgamegeekfetcher.cpp
M  +1-1src/fetch/hathitrustfetcher.cpp
M  +1-1src/fetch/ibsfetcher.cpp
M  +1-1src/fetch/imdbfetcher.cpp
M  +1-1src/fetch/moviemeterfetcher.cpp
M  +1-1src/fetch/musicbrainzfetcher.cpp
M  +1-1src/fetch/openlibraryfetcher.cpp
M  +1-1src/fetch/videogamegeekfetcher.cpp
M  +1-1src/fetch/z3950fetcher.cpp
M  +4-3src/fetchdialog.cpp
M  +4-4src/groupview.cpp
M  +2-2src/gui/collectiontypecombo.cpp
M  +2-2src/gui/ratingwidget.cpp
M  +1-1src/gui/starrating.cpp
M  +3-1src/loandialog.cpp
M  +3-1src/main.cpp
M  +34   -22   src/mainwindow.cpp
M  +1-1src/models/borrowermodel.cpp
M  +2-2src/models/entrygroupmodel.cpp
M  +3-3src/models/entrymodel.cpp
M  +1-1src/models/filtermodel.cpp
M  +2-2src/utils/tellico_utils.cpp

https://commits.kde.org/tellico/94376ac3c82942a26c2cf748a5072278c57e6405

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[goupilcom]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #10 from goupil...@gmail.com  ---
(In reply to Robby Stephenson from comment #7)
> Thanks for the screenshots. Looking at them, there are other missing icons
> in the UI., too, it appears. The Filters tab should have an icon, the
> Nouveau button should have one, etc...checkmark icons probably don't shown
> in the column view, either, right?
> 
> That symptom gives me a few pointers to go check...

Thanks for you attention. I confirm your observations (see the screenshots
above) : checkmark icons don't shown in the column view.

To avoid a possible packaging problem, i compile Tellico 3.0.2 myself and
install it (# make install). I have the same problem : no icons on its
interface, the icons are present on /usr/share/tellico/pics, and Tellico crash
when i save the database.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[goupilcom]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #9 from goupil...@gmail.com  ---
Created attachment 106136
  --> https://bugs.kde.org/attachment.cgi?id=106136=edit
Checkmark icon not present in the column view

Checkmark icon not present in the column view : See the "Daedalus - No Escape"
entry ("Commercial" is checked, and the "Check" icon isn't displayed in the
column view above.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[goupilcom]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #8 from goupil...@gmail.com  ---
Created attachment 106134
  --> https://bugs.kde.org/attachment.cgi?id=106134=edit
A screenshot of the same database with Tellico downgraded to 2.3.9

A screenshot of the same database (under the same MATE window manager) with
Tellico downgraded to 2.3.9.
I only change the pixmap by others i had found on internet (for the stars &
checkmark.png, in /usr/share/kde4/apps/tellico/pics), and in the appearance of
the windows manager for the scroll bars.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Robby Stephenson]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #7 from Robby Stephenson  ---
Thanks for the screenshots. Looking at them, there are other missing icons in
the UI., too, it appears. The Filters tab should have an icon, the Nouveau
button should have one, etc...checkmark icons probably don't shown in the
column view, either, right?

That symptom gives me a few pointers to go check...

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[goupilcom]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #6 from goupil...@gmail.com  ---
Created attachment 105915
  --> https://bugs.kde.org/attachment.cgi?id=105915=edit
A sreenshot of the interface. See the stars on the xml preview AND NOT on the
interface

On the xml preview you can see "Quality (record)" and "Quality (game)" with 5
stars, and on the interface in the same entry field no star is displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[goupilcom]

https://bugs.kde.org/show_bug.cgi?id=378477

goupil...@gmail.com  changed:

   What|Removed |Added

 CC||goupil...@gmail.com

--- Comment #5 from goupil...@gmail.com  ---
(In reply to Robby Stephenson from comment #2)
> I can't confirm at the moment - everything shows up properly for me. I
> wonder if there's a problem with the Ubuntu packaging possibly? I'm not sure
> where the default installation on Ubuntu is. Can you check to see if there's
> a /usr/share/tellico/pics/star_on.png file, for example?
> 
> If you run from the command line, is there any output that might seem to be
> relevant?

I'm on Debian Sid. I have had the same problem with Tellico v.3.0.2, and the
graphics files (star_on.png, stars1.png, ...) were present in
/usr/share/tellico/pics/. The stars appears in the XML file rendering but not
on the interface. Finaly i downgrade to Tellico 2.3.9 because Tellico v.3.0.2
can't write without crashing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #4 from fcremone...@gmail.com ---
Sorry if I reply this late, by the way yeah, the star_on.png file is present,
and i noticed later that is present even in the entry view. About the packages
I don't know honestly, I remember that I tried twice to repair them and nothing
changed,then, regarding what you wrote about run it from the command line, at
the moment I'm using the 2.3.9 version to adjust some of the record I made,
when i finish that I'll upgrade to 3.0.1 and I'll try that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #3 from Christoph Feck  ---
If you can provide the information requested in comment #2, please add it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[Robby Stephenson]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #2 from Robby Stephenson  ---
I can't confirm at the moment - everything shows up properly for me. I wonder
if there's a problem with the Ubuntu packaging possibly? I'm not sure where the
default installation on Ubuntu is. Can you check to see if there's a
/usr/share/tellico/pics/star_on.png file, for example?

If you run from the command line, is there any output that might seem to be
relevant?

-- 
You are receiving this mail because:
You are watching all bug changes.

[tellico] [Bug 378477] Can't see the star icon in the column view and in the entry editor

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378477

--- Comment #1 from fcremone...@gmail.com ---
i've see that the current of the screen is italian, sorry. Anyway i think that
you can guess that "rating" is translated in "valutazione personale"

-- 
You are receiving this mail because:
You are watching all bug changes.