https://bugs.kde.org/show_bug.cgi?id=254779
Rolf Eike Beer changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #7 from David Zaslavsky ---
OK, it's uploaded as review 128701.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #6 from Rolf Eike Beer ---
Put a merged patch (i.e. changes of both patches) into RB, but later commit
the separated ones.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #5 from David Zaslavsky ---
I've completed the new patches (subject to coding style cleanup or design
changes), incorporating the feedback from above. I wound up not changing the
code design of the model, but I did add
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #4 from Rolf Eike Beer ---
> I didn't change the storage model (the part that fails the "wtf test")
> because
> I thought it best to limit my changes to those actually necessary to
> add the
> feature. But since
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #3 from David Zaslavsky ---
OK, I'll make those changes and try to submit the patch to Reviewboard once I'm
done.
I didn't change the storage model (the part that fails the "wtf test") because
I thought it best to
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #2 from Rolf Eike Beer ---
The patch looks good in principle, however I have some nitpicks:
Optional:
-if you have a KDE account I would welcome if you could put the patch into
Reviewboard instead, referencing
https://bugs.kde.org/show_bug.cgi?id=254779
--- Comment #1 from David Zaslavsky ---
Created attachment 100193
--> https://bugs.kde.org/attachment.cgi?id=100193=edit
Patch that adds a checkbox to filter out invalid keys
I've made some progress on a patch for this issue.
https://bugs.kde.org/show_bug.cgi?id=254779
David Zaslavsky changed:
What|Removed |Added
CC||diaz...@ellipsix.net